better_errors 0.1.0 → 0.1.1

data/lib/better_errors/error_page.rb

@@ -50,6 +50,14 @@ module BetterErrors
     end
     
   private
+    def exception_message
+      if exception.is_a?(SyntaxError) && exception.message =~ /\A.*:\d*: (.*)$/
+        $1
+      else
+        exception.message
+      end
+    end
+
     def real_exception(exception)
       if exception.respond_to? :original_exception
         exception.original_exception

data/lib/better_errors/repl.rb

@@ -1,16 +1,18 @@
 module BetterErrors
   module REPL
     PROVIDERS = [
-        { impl:   "better_errors/repl/pry",
-          const:  :Pry },
         { impl:   "better_errors/repl/basic",
           const:  :Basic },
       ]
-    
+
     def self.provider
       @provider ||= const_get detect[:const]
     end
     
+    def self.provider=(prov)
+      @provider = prov
+    end
+    
     def self.detect
       PROVIDERS.find do |prov|
         test_provider prov

data/lib/better_errors/stack_frame.rb

@@ -2,7 +2,7 @@ module BetterErrors
   class StackFrame
     def self.from_exception(exception)
       idx_offset = 0
-      exception.backtrace.each_with_index.map { |frame, idx|
+      list = exception.backtrace.each_with_index.map do |frame, idx|
         frame_binding = exception.__better_errors_bindings_stack[idx - idx_offset]
         md = /\A(?<file>.*):(?<line>\d*):in `(?<name>.*)'\z/.match(frame)
 
@@ -13,7 +13,13 @@ module BetterErrors
         end
 
         StackFrame.new(md[:file], md[:line].to_i, md[:name], frame_binding)
-      }.compact
+      end
+
+      if exception.is_a?(SyntaxError) && exception.to_s =~ /\A(.*):(\d*):/
+        list.unshift StackFrame.new($1, $2.to_i, "")
+      end
+
+      list
     end
     
     attr_reader :filename, :line, :name, :frame_binding

data/lib/better_errors/templates/main.erb

@@ -204,7 +204,7 @@
         <table>
             <tr>
                 <th>Message</th>
-                <td><%= exception.message %></td>
+                <td><%= exception_message %></td>
             </tr>
             <% if backtrace_frames.any? %>
                 <tr>
@@ -245,15 +245,17 @@
                 <%== highlighted_code_block frame %>
                 
                 <% if BetterErrors.binding_of_caller_available? %>
-                    <div class="repl">
-                        <h3>REPL</h3>
-                        <div class="console">
-                            <pre></pre>
-                            <div class="prompt"><span>&gt;&gt;</span> <input/></div>
+                    <% if frame.frame_binding %>
+                        <div class="repl">
+                            <h3>REPL</h3>
+                            <div class="console">
+                                <pre></pre>
+                                <div class="prompt"><span>&gt;&gt;</span> <input/></div>
+                            </div>
                         </div>
-                    </div>
-
-                    <div class="variable_info"></div>
+                        
+                        <div class="variable_info"></div>
+                    <% end %>
                 <% else %>
                     <h3>Advanced features unavailable</h3>
                     <p class="error">

data/lib/better_errors/version.rb

@@ -1,3 +1,3 @@
 module BetterErrors
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/better_errors/stack_frame_spec.rb

@@ -57,5 +57,14 @@ module BetterErrors
         frame.gem_path.should == "(gem) whatever-1.2.3/lib/whatever.rb"
       end
     end
+
+    it "should special case SyntaxErrors" do
+      syntax_error = SyntaxError.new "my_file.rb:123: you wrote bad ruby!"
+      syntax_error.stub!(:backtrace).and_return([])
+      frames = StackFrame.from_exception(syntax_error)
+      frames.count.should == 1
+      frames.first.filename.should == "my_file.rb"
+      frames.first.line.should == 123
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: better_errors
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors: