better_errors 0.0.7 → 0.0.8

data/README.md

@@ -21,7 +21,7 @@ group :development do
 end
 ```
 
-If you would like to use Better Errors' **advanced features**, you need to add the [`binding_of_caller`](https://github.com/banister/binding_of_caller) gem to your Gemfile:
+If you would like to use Better Errors' **advanced features** (REPL, local/instance variable inspection, pretty stack frame names), you need to add the [`binding_of_caller`](https://github.com/banister/binding_of_caller) gem to your Gemfile:
 
 ```ruby
 gem "binding_of_caller"

data/lib/better_errors.rb

@@ -8,7 +8,7 @@ require "better_errors/error_frame"
 require "better_errors/middleware"
 
 class << BetterErrors
-  attr_accessor :application_root, :binding_of_caller_available
+  attr_accessor :application_root, :binding_of_caller_available, :logger
   
   alias_method :binding_of_caller_available?, :binding_of_caller_available
 end

data/lib/better_errors/error_frame.rb

@@ -76,11 +76,15 @@ module BetterErrors
       Hash[frame_binding.eval("instance_variables").map { |x| [x, frame_binding.eval(x.to_s)] }]
     end
     
+    def to_s
+      "#{pretty_path}:#{line}:in `#{name}'"
+    end
+    
   private
     def set_pretty_method_name
       name =~ /\A(block (\([^)]+\) )?in )?/
       recv = frame_binding.eval("self")
-      method = frame_binding.eval("__method__")
+      return unless method = frame_binding.eval("__method__")
       @name = if recv.is_a? Module
                 "#{$1}#{recv}.#{method}"
               else

data/lib/better_errors/error_page.rb

@@ -40,6 +40,10 @@ module BetterErrors
                   end
       response.merge(highlighted_input: CodeRay.scan(opts["source"], :ruby).div(wrap: nil))
     end
+
+    def backtrace_frames
+      @backtrace_frames ||= ErrorFrame.from_exception(exception)
+    end
     
   private
     def real_exception(exception)
@@ -53,10 +57,6 @@ module BetterErrors
     def request_path
       env["REQUEST_PATH"]
     end
-  
-    def backtrace_frames
-      @backtrace_frames ||= ErrorFrame.from_exception(exception)
-    end
     
     def coderay_scanner_for_ext(ext)
       case ext
@@ -64,6 +64,7 @@ module BetterErrors
       when "html";  :html
       when "erb";   :erb
       when "haml";  :haml
+      else          :text
       end
     end
     
@@ -75,6 +76,7 @@ module BetterErrors
       lines = File.readlines(frame.filename)
       min_line = [1, frame.line - lines_of_context].max - 1
       max_line = [frame.line + lines_of_context, lines.count + 1].min - 1
+      raise Errno::EINVAL if min_line > lines.length
       [min_line, max_line, lines[min_line..max_line].join]
     end
     
@@ -95,7 +97,7 @@ module BetterErrors
         end
         html << "</div>"
       end
-    rescue Errno::ENOENT
+    rescue Errno::ENOENT, Errno::EINVAL
       "<p>Source unavailable</p>"
     end
   end

data/lib/better_errors/middleware.rb

@@ -20,9 +20,21 @@ module BetterErrors
       @app.call env
     rescue Exception => ex
       @error_page = @handler.new ex, env
+      log_exception
       [500, { "Content-Type" => "text/html; charset=utf-8" }, [@error_page.render]]
     end
   
+    def log_exception
+      return unless BetterErrors.logger
+      
+      message = "\n#{@error_page.exception.class} - #{@error_page.exception.message}:\n"
+      @error_page.backtrace_frames.each do |frame|
+        message << "  #{frame}\n"
+      end
+      
+      BetterErrors.logger.fatal message
+    end
+  
     def internal_call(env, opts)
       if opts[:oid].to_i != @error_page.object_id
         return [200, { "Content-Type" => "text/plain; charset=utf-8" }, [JSON.dump(error: "Session expired")]]

data/lib/better_errors/rails.rb

@@ -3,6 +3,7 @@ module BetterErrors
     initializer "better_errors.configure_rails_initialization" do
       unless Rails.env.production?
         Rails.application.middleware.use BetterErrors::Middleware
+        BetterErrors.logger = Rails.logger
         BetterErrors.application_root = Rails.root.to_s
       end
     end

data/lib/better_errors/templates/main.erb

@@ -352,8 +352,6 @@
         })(i, frames[i], frameInfos[i]);
     }
     
-    document.querySelector(".frames li:first-child").click();
-    
     var applicationFrames = document.getElementById("application_frames");
     var allFrames = document.getElementById("all_frames");
     
@@ -380,6 +378,13 @@
     };
     
     applicationFrames.click();
+    
+    for(var i = 0; i < frames.length; i++) {
+        if(frames[i].attributes["data-context"].value == "application") {
+            frames[i].click();
+            break;
+        }
+    }
 })();
 </script>
 </html>

data/lib/better_errors/version.rb

@@ -1,3 +1,3 @@
 module BetterErrors
-  VERSION = "0.0.7"
+  VERSION = "0.0.8"
 end

data/spec/better_errors/error_page_spec.rb

@@ -7,6 +7,16 @@ module BetterErrors
     let(:error_page) { ErrorPage.new exception, { "REQUEST_PATH" => "/some/path" } }
     
     let(:response) { error_page.render }
+    
+    let(:empty_binding) {
+      local_a = :value_for_local_a
+      local_b = :value_for_local_b
+      
+      @inst_c = :value_for_inst_c
+      @inst_d = :value_for_inst_d
+      
+      binding
+    }
   
     it "should include the error message" do
       response.should include("you divided by zero you silly goose!")
@@ -42,6 +52,26 @@ module BetterErrors
       end
     end
     
+    context "variable inspection" do
+      let(:exception) { empty_binding.eval("raise") rescue $! }
+      
+      it "should show local variables" do
+        html = error_page.do_variables("index" => 0)[:html]
+        html.should include("local_a")
+        html.should include(":value_for_local_a")
+        html.should include("local_b")
+        html.should include(":value_for_local_b")
+      end
+      
+      it "should show instance variables" do
+        html = error_page.do_variables("index" => 0)[:html]
+        html.should include("inst_c")
+        html.should include(":value_for_inst_c")
+        html.should include("inst_d")
+        html.should include(":value_for_inst_d")
+      end
+    end
+    
     it "should not die if the source file is not a real filename" do
       exception.stub!(:backtrace).and_return([
         "<internal:prelude>:10:in `spawn_rack_application'"

data/spec/better_errors/middleware_spec.rb

@@ -21,6 +21,14 @@ module BetterErrors
         
         headers["Content-Type"].should == "text/html; charset=utf-8"
       end
+      
+      it "should log the exception" do
+        logger = Object.new
+        logger.should_receive :fatal
+        BetterErrors.stub!(:logger).and_return(logger)
+        
+        app.call({})
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: better_errors
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-09 00:00:00.000000000 Z
+date: 2012-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -119,4 +119,3 @@ test_files:
 - spec/better_errors/middleware_spec.rb
 - spec/better_errors/support/my_source.rb
 - spec/spec_helper.rb
-has_rdoc: