betfair_api_ng_rails 0.0.8 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cf7f63ee0737110869e21a922b12a4aa99850019
-  data.tar.gz: bed144ea5a16997275538b8fd88b1566413e6b64
+  metadata.gz: c20bda2211a6be34fbfffba46eb548faf580d3a3
+  data.tar.gz: 81c228df7a738da9bc5156485567ea34ab566820
 SHA512:
-  metadata.gz: 86b7d9ab358b32912b1fe5e4a1bf2b56a8cd731f976a1e82268c0ca843dc03bda4aa94ec2da6e65edd34382b39c62ac60c8bb073bfd0b96ebde826f63c0a64d4
-  data.tar.gz: b437d15bea1d28fc5cbce55c6ad5bb8b1274249382d4f3b8a0ab38e0db0140534c14c2bae652497c98ec40c0f17deb163891736c7e2843382a0b5209bb373d9f
+  metadata.gz: a08183228cab41b7d28a52cc86328cdba3fcedc80a5aec045cf752810aa825ea8b1fc66c35a92dd71f2f008169592596e53bb295d8342232aa53ab74fdd451d4
+  data.tar.gz: 20693a5383bb7bcceb79d35977090acda984cd3327498c47160528dcadc2a98c438ba91fe8645bebc795f7b9a16fd143b8de5afe658e3df6eb855902ef9db9a3

data/README.md

@@ -6,7 +6,7 @@ API-NG is Betfair's next generation API for developers looking to create automat
 
 Add this line to your application's Gemfile:
 
-    gem 'betfair_api_ng_rails'
+    gem 'betfair_api_ng_rails', '1.0.0'
 
 And then execute:
 
@@ -35,26 +35,13 @@ In this files you must specify credentials to API-NG. Also you should notice tha
 
 ## Usage
 
-Sample code for fetching all competitions:
+Please check [wiki pages](https://github.com/alterego-labs/betfair_api_ng_rails/wiki). It will be available soon...
 
-```ruby
-result = BetfairApiNgRails::Competition.all
-```
-
-For all available methods see [there](https://api.developer.betfair.com/services/webapps/docs/display/1smk3cen4v3lu3yomq5qye0ni/Betting+Operations).
-
-Also you may passing filtering params:
-
-```ruby
-filter = BetfairApiNgRails::MarketFilter.new text_query: 'World*'
-result = BetfairApiNgRails::Competition.where filter: filter
-```
-
-Or fetching competition by identifier:
+## CHANGES IN 1.0.0
 
-```ruby
-result = BetfairApiNgRails::Competition.find 1
-```
+1. Replaced ActiveRecord style querying by more similar structure to API-NG
+2. Starting to testing
+3. Refactoring
 
 ## CHANGES IN 0.0.8
 
@@ -64,15 +51,6 @@ result = BetfairApiNgRails::Competition.find 1
 4. Added shortcuts for models
 5. Refactoring
 
-## CHANGES IN 0.0.7!!!
-
-Now gem used Object model for doing requests and it's results that is based on [betfair's type definitions](https://api.developer.betfair.com/services/webapps/docs/display/1smk3cen4v3lu3yomq5qye0ni/Betting+Type+Definitions#BettingTypeDefinitions-UpdateInstruction).
-
-## WARNING!!!
-
-__Last version of gem supports only listCompetitions, listEventTypes and listEvents requests.__ I will provide more powerful functional soon.
-
-
 ## Contributing
 
 1. Fork it

data/Rakefile

@@ -1 +1,10 @@
-require "bundler/gem_tasks"
+require "rubygems"
+require 'rspec/core/rake_task'
+require 'rubygems/specification'
+
+task default: :spec
+desc "Run specs"
+RSpec::Core::RakeTask.new do |t|
+  t.pattern = FileList['spec/**/*_spec.rb']
+  t.rspec_opts = %w(--color)
+end

data/betfair_api_ng_rails.gemspec

@@ -21,4 +21,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "activesupport", ">= 3.1.0"
+  spec.add_development_dependency "rspec", "~> 3.0.0.beta"
+  spec.add_development_dependency "rspec-its"
+  spec.add_development_dependency "pry-nav"
 end

data/lib/betfair_api_ng_rails.rb

@@ -1,4 +1,7 @@
 require "betfair_api_ng_rails/version"
+require "betfair_api_ng_rails/errors"
+require "betfair_api_ng_rails/api/request_methods"
+require "betfair_api_ng_rails/railtie" if defined?(Rails)
 
 module BetfairApiNgRails
 
@@ -8,108 +11,124 @@ module BetfairApiNgRails
     autoload :BaseRequester,    'betfair_api_ng_rails/api/base_requester'
     autoload :FormatterFactory, 'betfair_api_ng_rails/api/formatter_factory'
 
-    module BF
+    autoload :Config,         'betfair_api_ng_rails/api/config'
+    autoload :Constants,      'betfair_api_ng_rails/api/constants'
+    autoload :Provider,       'betfair_api_ng_rails/api/provider'
+    autoload :SessionManager, 'betfair_api_ng_rails/api/session_manager'
 
-      autoload :Config,         'betfair_api_ng_rails/api/bf/config'
-      autoload :Constants,      'betfair_api_ng_rails/api/bf/constants'
-      autoload :Provider,       'betfair_api_ng_rails/api/bf/provider'
-      autoload :SessionManager, 'betfair_api_ng_rails/api/bf/session_manager'
+    autoload :Connection,         'betfair_api_ng_rails/api/connection'
+    autoload :Hashalator,         'betfair_api_ng_rails/api/hashalator'
 
-      module Formatters
+    module Formatters
 
-        autoload :JsTreeFormatter, 'betfair_api_ng_rails/api/bf/formatters/js_tree_formatter'
+      autoload :JsTreeFormatter, 'betfair_api_ng_rails/api/formatters/js_tree_formatter'
 
-      end
-
-      module Data
+    end
 
-        autoload :Base,               'betfair_api_ng_rails/api/bf/data/base'
-        autoload :Attributes,         'betfair_api_ng_rails/api/bf/data/attributes'
-        autoload :Constants,          'betfair_api_ng_rails/api/bf/data/constants'
-        autoload :Competition,        'betfair_api_ng_rails/api/bf/data/competition'
-        autoload :CompetitionResult,  'betfair_api_ng_rails/api/bf/data/competition_result'
-        autoload :MarketFilter,       'betfair_api_ng_rails/api/bf/data/market_filter'
-        autoload :TimeRange,          'betfair_api_ng_rails/api/bf/data/time_range'
-        autoload :TimeRangeResult,    'betfair_api_ng_rails/api/bf/data/time_range_result'
-        autoload :EventType,          'betfair_api_ng_rails/api/bf/data/event_type'
-        autoload :EventTypeResult,    'betfair_api_ng_rails/api/bf/data/event_type_result'
-        autoload :Event,              'betfair_api_ng_rails/api/bf/data/event'
-        autoload :EventResult,        'betfair_api_ng_rails/api/bf/data/event_result'
+    module Data
 
-        module Concerns
+      autoload :Base,               'betfair_api_ng_rails/api/data/base'
+      autoload :Attributes,         'betfair_api_ng_rails/api/data/attributes'
+      autoload :Constants,          'betfair_api_ng_rails/api/data/constants'
+      autoload :Competition,        'betfair_api_ng_rails/api/data/competition'
+      autoload :CompetitionResult,  'betfair_api_ng_rails/api/data/competition_result'
+      autoload :MarketFilter,       'betfair_api_ng_rails/api/data/market_filter'
+      autoload :TimeRange,          'betfair_api_ng_rails/api/data/time_range'
+      autoload :TimeRangeResult,    'betfair_api_ng_rails/api/data/time_range_result'
+      autoload :EventType,          'betfair_api_ng_rails/api/data/event_type'
+      autoload :EventTypeResult,    'betfair_api_ng_rails/api/data/event_type_result'
+      autoload :Event,              'betfair_api_ng_rails/api/data/event'
+      autoload :EventResult,        'betfair_api_ng_rails/api/data/event_result'
+      autoload :CountryCodeResult,  'betfair_api_ng_rails/api/data/country_code_result'
+      autoload :VenueResult,        'betfair_api_ng_rails/api/data/venue_result'
+      autoload :MarketTypeResult,   'betfair_api_ng_rails/api/data/market_type_result'
 
-          autoload :Hashable,           'betfair_api_ng_rails/api/bf/data/concerns/hashable'
-          autoload :Querable,           'betfair_api_ng_rails/api/bf/data/concerns/querable'
+      module Concerns
 
-        end
+        autoload :Hashable,           'betfair_api_ng_rails/api/data/concerns/hashable'
 
       end
 
-      module Enums
-
-        autoload :MarketProjection,           'betfair_api_ng_rails/api/bf/enums/market_projection'
-        autoload :PriceData,                  'betfair_api_ng_rails/api/bf/enums/price_data'
-        autoload :MatchProjection,            'betfair_api_ng_rails/api/bf/enums/match_projection'
-        autoload :OrderProjection,            'betfair_api_ng_rails/api/bf/enums/order_projection'
-        autoload :MarketStatus,               'betfair_api_ng_rails/api/bf/enums/market_status'
-        autoload :RunnerStatus,               'betfair_api_ng_rails/api/bf/enums/runner_status'
-        autoload :TimeGranularity,            'betfair_api_ng_rails/api/bf/enums/time_granularity'
-        autoload :Side,                       'betfair_api_ng_rails/api/bf/enums/side'
-        autoload :OrderStatus,                'betfair_api_ng_rails/api/bf/enums/order_status'
-        autoload :OrderBy,                    'betfair_api_ng_rails/api/bf/enums/order_by'
-        autoload :SortDir,                    'betfair_api_ng_rails/api/bf/enums/sort_dir'
-        autoload :OrderType,                  'betfair_api_ng_rails/api/bf/enums/order_type'
-        autoload :MarketSort,                 'betfair_api_ng_rails/api/bf/enums/market_sort'
-        autoload :MarketBettingType,          'betfair_api_ng_rails/api/bf/enums/market_betting_type'
-        autoload :ExecutionReportStatus,      'betfair_api_ng_rails/api/bf/enums/execution_report_status'
-        autoload :ExecutionReportErrorCode,   'betfair_api_ng_rails/api/bf/enums/execution_report_error_code'
-        autoload :PersistenceType,            'betfair_api_ng_rails/api/bf/enums/perisstence_type'
-        autoload :InstrictionReportStatus,    'betfair_api_ng_rails/api/bf/enums/instruction_report_status'
-        autoload :InstructionReportErrorCode, 'betfair_api_ng_rails/api/bf/enums/instruction_report_error_code'
-        autoload :RollupModel,                'betfair_api_ng_rails/api/bf/enums/rollup_model'
-        autoload :GroupBy,                    'betfair_api_ng_rails/api/bf/enums/group_by'
-        autoload :BetStatus,                  'betfair_api_ng_rails/api/bf/enums/bet_status'
-
-        module Concerns
-
-          autoload :Enumable, 'betfair_api_ng_rails/api/bf/enums/concerns/enumable'
-
-        end
+    end
+
+    module Enums
+
+      autoload :MarketProjection,           'betfair_api_ng_rails/api/enums/market_projection'
+      autoload :PriceData,                  'betfair_api_ng_rails/api/enums/price_data'
+      autoload :MatchProjection,            'betfair_api_ng_rails/api/enums/match_projection'
+      autoload :OrderProjection,            'betfair_api_ng_rails/api/enums/order_projection'
+      autoload :MarketStatus,               'betfair_api_ng_rails/api/enums/market_status'
+      autoload :RunnerStatus,               'betfair_api_ng_rails/api/enums/runner_status'
+      autoload :TimeGranularity,            'betfair_api_ng_rails/api/enums/time_granularity'
+      autoload :Side,                       'betfair_api_ng_rails/api/enums/side'
+      autoload :OrderStatus,                'betfair_api_ng_rails/api/enums/order_status'
+      autoload :OrderBy,                    'betfair_api_ng_rails/api/enums/order_by'
+      autoload :SortDir,                    'betfair_api_ng_rails/api/enums/sort_dir'
+      autoload :OrderType,                  'betfair_api_ng_rails/api/enums/order_type'
+      autoload :MarketSort,                 'betfair_api_ng_rails/api/enums/market_sort'
+      autoload :MarketBettingType,          'betfair_api_ng_rails/api/enums/market_betting_type'
+      autoload :ExecutionReportStatus,      'betfair_api_ng_rails/api/enums/execution_report_status'
+      autoload :ExecutionReportErrorCode,   'betfair_api_ng_rails/api/enums/execution_report_error_code'
+      autoload :PersistenceType,            'betfair_api_ng_rails/api/enums/perisstence_type'
+      autoload :InstrictionReportStatus,    'betfair_api_ng_rails/api/enums/instruction_report_status'
+      autoload :InstructionReportErrorCode, 'betfair_api_ng_rails/api/enums/instruction_report_error_code'
+      autoload :RollupModel,                'betfair_api_ng_rails/api/enums/rollup_model'
+      autoload :GroupBy,                    'betfair_api_ng_rails/api/enums/group_by'
+      autoload :BetStatus,                  'betfair_api_ng_rails/api/enums/bet_status'
+
+      module Concerns
+
+        autoload :Enumable, 'betfair_api_ng_rails/api/enums/concerns/enumable'
 
       end
 
-      module Http
-
-        autoload :Requester,  'betfair_api_ng_rails/api/bf/http/requester'
-        autoload :Responser,  'betfair_api_ng_rails/api/bf/http/responser'
-        autoload :Factory,    'betfair_api_ng_rails/api/bf/http/factory'
+    end
 
-      end
+    module Http
 
-      module ORM
+      autoload :Requester,  'betfair_api_ng_rails/api/http/requester'
+      autoload :Responser,  'betfair_api_ng_rails/api/http/responser'
+      autoload :Factory,    'betfair_api_ng_rails/api/http/factory'
 
-        autoload :Requester, 'betfair_api_ng_rails/api/bf/orm/requester'
+    end
 
-        module Parsers
+    module Parsers
 
-          autoload :Base,             'betfair_api_ng_rails/api/bf/orm/parsers/base'
-          autoload :ListCompetitions, 'betfair_api_ng_rails/api/bf/orm/parsers/list_competitions'
-          autoload :ListEventTypes,   'betfair_api_ng_rails/api/bf/orm/parsers/list_event_types'
-          autoload :ListEvents,       'betfair_api_ng_rails/api/bf/orm/parsers/list_events'
+      autoload :Base,             'betfair_api_ng_rails/api/parsers/base'
+      autoload :ListCompetitions, 'betfair_api_ng_rails/api/parsers/list_competitions'
+      autoload :ListEventTypes,   'betfair_api_ng_rails/api/parsers/list_event_types'
+      autoload :ListEvents,       'betfair_api_ng_rails/api/parsers/list_events'
+      autoload :ListTimeRanges,   'betfair_api_ng_rails/api/parsers/list_time_ranges'
+      autoload :ListCountries,    'betfair_api_ng_rails/api/parsers/list_countries'
+      autoload :ListVenues,       'betfair_api_ng_rails/api/parsers/list_venues'
+      autoload :ListMarketTypes,  'betfair_api_ng_rails/api/parsers/list_market_types'
 
-        end
+    end
 
-      end
+    module ConnectionExt
+      
+      autoload :Parsing,    'betfair_api_ng_rails/api/connection_ext/parsing'
+      autoload :Formatting, 'betfair_api_ng_rails/api/connection_ext/formatting'
 
     end
 
   end
 
-  include Api::BF::Data
+  include Api::Data
+  extend  Api::RequestMethods
 
   def self.config(&block)
-    @_config ||= BetfairApiNgRails::Api::BF::Config
+    @_config ||= BetfairApiNgRails::Api::Config
     block_given? ? yield(@_config) : @_config
   end
 
+  def self.connection
+    raise BetfairApiNgRails::NoConnectionError unless @connection
+    @connection
+  end
+
+  def self.connection=(value)
+    @connection = value
+  end
+
 end

data/lib/betfair_api_ng_rails/api/concerns/errorable.rb

@@ -0,0 +1,19 @@
+require 'active_support/core_ext/object'
+
+module BetfairApiNgRails
+  module Api
+    module Concerns
+      module Errorable
+
+        def has_errors?
+          !error_info.nil?
+        end
+
+        def error_info
+          @http_responser.try(:error_info?)
+        end
+
+      end
+    end
+  end
+end

data/lib/betfair_api_ng_rails/api/config.rb

@@ -0,0 +1,27 @@
+module BetfairApiNgRails
+  module Api
+    class Config
+
+      class << self
+
+        attr_accessor :application_key,
+                      :ssl_key_filepath,
+                      :ssl_crt_filepath,
+                      :login_url,
+                      :api_url,
+                      :username,
+                      :password,
+                      :locale,
+                      :formatter,
+                      :keep_alive_session,
+                      :keep_alive_url
+
+        def formatter=(value)
+          @formatter = BetfairApiNgRails::Api::FormatterFactory.initialize_formatter value
+        end
+
+      end
+
+    end
+  end
+end

data/lib/betfair_api_ng_rails/api/connection.rb

@@ -0,0 +1,34 @@
+module BetfairApiNgRails
+  module Api
+    class Connection
+      
+      attr_reader :ssoid
+
+      def initialize
+        request_ssoid
+      end
+
+      def request(method, params = {})
+        provider.fetch method: method, params: hashing(params)
+      end
+
+      include Api::ConnectionExt::Parsing
+      include Api::ConnectionExt::Formatting
+
+    protected
+
+      def provider
+        @_provider ||= BetfairApiNgRails::Api::Provider.new ssoid
+      end
+
+      def request_ssoid
+        @ssoid = BetfairApiNgRails::Api::SessionManager.new_ssoid
+      end
+
+      def hashing(params)
+        BetfairApiNgRails::Api::Hashalator.new(params).to_hash
+      end
+
+    end
+  end
+end

data/lib/betfair_api_ng_rails/api/connection_ext/formatting.rb

@@ -0,0 +1,34 @@
+require 'active_support/inflector'
+require 'pry-nav'
+
+module BetfairApiNgRails
+  module Api
+    module ConnectionExt
+      module Formatting
+        include BetfairApiNgRails::Api::Constants
+
+        def self.included(base)
+          base.send :class_eval,  <<-CODE
+            def request_with_formatting(method, params = {})
+              res = request_without_formatting(method, params)
+              need_formatting_for?(method) ? formatting(method, res) : res
+            end
+            alias_method :request_without_formatting, :request
+            alias_method :request, :request_with_formatting
+          CODE
+        end
+
+      private
+
+        def formatting(method, result)
+          BetfairApiNgRails.config.formatter.process result, as: method
+        end
+
+        def need_formatting_for?(method)
+          ALLOWED_FORMATTING.include?(method) && BetfairApiNgRails.config.formatter
+        end
+
+      end
+    end
+  end
+end

data/lib/betfair_api_ng_rails/api/connection_ext/parsing.rb

@@ -0,0 +1,29 @@
+require 'active_support/inflector'
+require 'pry-nav'
+
+module BetfairApiNgRails
+  module Api
+    module ConnectionExt
+      module Parsing
+
+        def self.included(base)
+          base.send :class_eval,  <<-CODE
+            def request_with_parsing(method, params = {})
+              res = request_without_parsing(method, params)
+              init_parser(method, res).process
+            end
+            alias_method :request_without_parsing, :request
+            alias_method :request, :request_with_parsing
+          CODE
+        end
+
+      private
+
+        def init_parser(method, responser)
+          "BetfairApiNgRails::Api::Parsers::#{method.camelize}".constantize.new responser
+        end
+
+      end
+    end
+  end
+end

data/lib/betfair_api_ng_rails/api/constants.rb

@@ -0,0 +1,51 @@
+module BetfairApiNgRails
+  module Api
+    module Constants
+
+      SUCCESS_LOGIN = "SUCCESS"
+
+      PROVIDER_NAME = "BF"
+
+      SESSION_REQUEST_HEADERS = {
+        "Content-Type" => "application/x-www-form-urlencoded"
+      }
+
+      API_REQUEST_HEADERS = {
+        "Content-Type" => "application/json",
+        "Accept"       => "application/json"
+      }
+
+      ALLOWED_RESOURCES = [
+        "listEventTypes",
+        "listCompetitions",
+        "listTimeRanges",
+        "listEvents",
+        "listMarketTypes",
+        "listCountries",
+        "listVenues",
+        "listMarketCatalogue",
+        "listMarketBook",
+        "listCurrentOrders",
+        "listClearedOrders",
+        "listMarketProfitAndLoss"
+      ]
+
+      ALLOWED_FORMATTING = [
+        "listEventTypes",
+        "listCompetitions",
+        "listEvents"
+      ]
+
+      SIMPLE_LISTING_FILTERED = [
+        "listEventTypes",
+        "listCompetitions",
+        "listTimeRanges",
+        "listEvents",
+        "listMarketTypes",
+        "listCountries",
+        "listVenues"
+      ]
+
+    end
+  end
+end