betfair 0.0.14 → 0.0.16

data/.gitignore

@@ -4,3 +4,5 @@ Gemfile.lock
 pkg/*
 .rvmrc
 examples/bar.rb
+examples/doh.rb
+examples/doh.log

data/lib/betfair/api.rb

@@ -2,7 +2,6 @@ module Betfair
 
   class API
 
-
     ## Some handy constants...
 
     EXCHANGE_IDS = {
@@ -19,10 +18,10 @@ module Betfair
     ## API METHODS
     #
 
-    def place_bet(session_token, exchange_id, market_id, runner_id, bet_type, price, size)		
+    def place_bet(session_token, exchange_id, market_id, selection_id, bet_type, price, size)		
       bf_bet = { 
         :marketId           => market_id, 
-        :selectionId        => runner_id, 
+        :selectionId        => selection_id, 
         :betType            => bet_type, 
         :price              => price, 
         :size               => size, 
@@ -41,7 +40,33 @@ module Betfair
       return response.maybe_result( :bet_results, :place_bets_result )
     end
 
+    
+   def place_multiple_bets(session_token, exchange_id, bets)		
+      bf_bet = []
+      bets.each do |bet|
+        bf_bet << { 
+          :marketId           => bet[:market_id], 
+          :selectionId        => bet[:runner_id], 
+          :betType            => bet[:bet_type], 
+          :price              => bet[:price], 
+          :size               => bet[:size], 
+          :asianLineId        => bet[:asian_line_id], 
+          :betCategoryType    => bet[:bet_category_type], 
+          :betPersistenceType => bet[:bet_peristence_type], 
+          :bspLiability       => bet[:bsp_liability] 
+        }
+      end
 
+      response = exchange(exchange_id).
+        session_request( session_token,
+                         :placeBets, 
+                         :place_bets_response,
+                         :bets => { 'PlaceBets' => bf_bet } )
+
+      return response.maybe_result( :bet_results, :place_bets_result )
+    end
+      
+    
     def cancel_bet(session_token, exchange_id, bet_id)
       bf_bet = { :betId => bet_id }
 
@@ -53,7 +78,21 @@ module Betfair
       
       return response.maybe_result( :bet_results, :cancel_bets_result )
     end
+    
+    
+    def cancel_multiple_bets(session_token, exchange_id, bets)
+      bf_bet = []
+      bets.each { |bet_id| bf_bet << { :betId => bet_id } }
 
+      response = exchange(exchange_id).
+        session_request( session_token,
+                         :cancelBets, 
+                         :cancel_bets_response,
+                         :bets => { 'CancelBets' => bf_bet } ) # "CancelBets" has to be a string, not a symbol!
+      
+      return response.maybe_result( :bet_results, :cancel_bets_result )
+    end
+    
 
     def get_market(session_token, exchange_id, market_id, locale = nil) 
       response = exchange(exchange_id).
@@ -113,6 +152,26 @@ module Betfair
 
       return response.maybe_result
     end
+    
+
+    def get_mu_bets( session_token, exchange_id, market_id = 0, bet_status = 'MU', start_record = 0, record_count = 200, sort_order = 'ASC', order_by =  'PLACED_DATE') #, bet_ids = nil, , exclude_last_second = nil, matched_since = nil
+      response = exchange( exchange_id ).
+        session_request( session_token, 
+                         :getMUBets, 
+                         :get_mu_bets_response,
+                         #:betIds => bet_ids,
+                         :betStatus => bet_status,
+                         #:excludeLastSecond => exclude_last_second,
+                         :marketId => market_id,
+                         #:matchedSince => matched_since,
+                         :orderBy => order_by,
+                         :recordCount => record_count,
+                         :sortOrder => sort_order,
+                         :startRecord => start_record
+                         )
+
+      return response.maybe_result( :bets, :mu_bet )
+    end
 
 
     def login(username, password, product_id, vendor_software_id, location_id, ip_address)
@@ -424,4 +483,4 @@ module Betfair
 
   end
 
-end
+end

data/lib/betfair/version.rb

@@ -1,3 +1,3 @@
 module Betfair
-  VERSION = "0.0.14"
+  VERSION = "0.0.16"
 end

data/spec/betfair/api_spec.rb

@@ -1,7 +1,6 @@
 require 'tempfile'
 require 'spec_helper'
 
-
 module Betfair
 
   describe "Helper methods for mashing the data from the API" do 
@@ -78,7 +77,29 @@ module Betfair
       end
     end
     
-    describe "cancel bet success"  do
+    describe "place multiple bets success"do
+      it "should place mutliple bets on the exchange via the api" do
+        savon.expects(:place_bets).returns(:success)
+        bets = []
+        bets <<  { market_id: 104184109, runner_id: 58805, bet_type: 'B', price: 2.0, size: 2.0, asian_line_id: 0, 
+                  bet_category_type: 'E', bet_peristence_type: 'NONE', bsp_liability: 0 }
+        bets = @bf.place_multiple_bets(@session_token, 1, bets)       
+        bets.should_not be_nil
+      end
+    end
+    
+    describe "place multiple bets fail"  do
+      it "should return an error message" do
+        savon.expects(:place_bets).returns(:fail)
+        bets = []
+        bets <<  { market_id: 104184109, runner_id: 58805, bet_type: 'B', price: 2.0, size: 2.0, asian_line_id: 0, 
+                  bet_category_type: 'E', bet_peristence_type: 'NONE', bsp_liability: 0 }                  
+        error_code = @bf.place_multiple_bets(@session_token, 1, bets)      
+        error_code[:result_code].should eq('INVALID_SIZE')
+      end
+    end
+      
+    describe "cancel bet success" do
       it "should cancel a bet on the exchange via the api" do
         savon.expects(:cancel_bets).returns(:success)
         bet = @bf.cancel_bet(@session_token, 3, 16939689578)       
@@ -94,6 +115,22 @@ module Betfair
       end
     end
     
+    describe "cancel multiple bets success" do
+      it "should cancel a bet on the exchange via the api" do
+        savon.expects(:cancel_bets).returns(:success)
+        bets = @bf.cancel_multiple_bets(@session_token, 3, [16939689578, 16939689579, 169396895710])       
+        bets.should_not be_nil
+      end
+    end
+    
+    describe "cancel bet fail"  do
+      it "should fail to cancel mulitple bets on the exchange via the api" do
+        savon.expects(:cancel_bets).returns(:fail)
+        error_code = @bf.cancel_multiple_bets(@session_token, 3, [16939689578, 16939689579, 169396895710])        
+        error_code.should eq('API_ERROR - NO_SESSION')
+      end
+    end
+    
   end
 
   
@@ -175,6 +212,24 @@ module Betfair
         events.should_not be_nil
       end    
     end
+    
+    describe "get matched/unmatched bets success" do
+      it "should return all of our unmatched and matched bets on an exchange, can take a market_id as the third arguement, plus many more" do 
+        savon.expects(:getMUBets).returns(:success)
+        bets = @bf.get_mu_bets(@session_token, 1)        
+        #bets.length.should eq(2)
+        bets[0][:selection_id].should eq("5986909")
+        bets[1][:selection_id].should eq("6230544")
+      end
+    end
+    
+    describe "get matched/unmatched bets"  do
+      it "should return an error message given the exchange id and and array of market type ids and no session id" do
+        savon.expects(:getMUBets).returns(:fail)
+        error_code = @bf.get_mu_bets(@session_token, 1)        
+        error_code.should eq('API_ERROR - NO_SESSION')        
+      end
+    end
 
   end
      

data/spec/fixtures/get_account_funds/success.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
-	       xmlns:n2="http://www.betfair.com/publicapi/types/exchange/v5/" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
+<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:n2="http://www.betfair.com/publicapi/types/exchange/v5/" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
   <soap:Body>
     <n:getAccountFundsResponse xmlns:n="http://www.betfair.com/publicapi/v5/BFExchangeService/">
       <n:Result xsi:type="n2:GetAccountFundsResp">

data/spec/fixtures/get_mu_bets/fail.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:n2="http://www.betfair.com/publicapi/types/exchange/v5/" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
+  <soap:Body>
+    <n:getMUBetsResponse xmlns:n="http://www.betfair.com/publicapi/v5/BFExchangeService/">
+      <n:Result xsi:type="n2:GetMUBetsResp">
+        <header xsi:type="n2:APIResponseHeader">
+          <errorCode xsi:type="n2:APIErrorEnum">NO_SESSION</errorCode>
+          <minorErrorCode xsi:nil="1"></minorErrorCode>
+          <sessionToken xsi:nil="1"></sessionToken>
+          <timestamp xsi:type="xsd:dateTime">2012-03-11T05:33:20.615Z</timestamp>
+        </header>
+        <bets xsi:nil="1"></bets>
+        <errorCode xsi:type="n2:GetMUBetsErrorEnum">API_ERROR</errorCode>
+        <minorErrorCode xsi:nil="1"></minorErrorCode>
+        <totalRecordCount xsi:type="xsd:int">0</totalRecordCount>
+      </n:Result>
+    </n:getMUBetsResponse>
+  </soap:Body>
+</soap:Envelope>

data/spec/fixtures/get_mu_bets/success.xml

@@ -0,0 +1,54 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:n2="http://www.betfair.com/publicapi/types/exchange/v5/" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
+  <soap:Body>
+    <n:getMUBetsResponse xmlns:n="http://www.betfair.com/publicapi/v5/BFExchangeService/">
+      <n:Result xsi:type="n2:GetMUBetsResp">
+        <header xsi:type="n2:APIResponseHeader">
+          <errorCode xsi:type="n2:APIErrorEnum">OK</errorCode>
+          <minorErrorCode xsi:nil="1"></minorErrorCode>
+          <sessionToken xsi:type="xsd:string">tK5bi3RcJxzC7mtX6dIjCaaIe/DOvKzcX4GK8RQ7RGo=</sessionToken>
+          <timestamp xsi:type="xsd:dateTime">2012-03-11T05:35:21.219Z</timestamp>
+        </header>
+        <bets xsi:type="n2:ArrayOfMUBet">
+          <n2:MUBet xsi:type="n2:MUBet">
+            <asianLineId xsi:type="xsd:int">0</asianLineId>
+            <betId xsi:type="xsd:long">1828957078</betId>
+            <transactionId xsi:type="xsd:long">2433120449</transactionId>
+            <betStatus xsi:type="n2:BetStatusEnum">U</betStatus>
+            <betType xsi:type="n2:BetTypeEnum">L</betType>
+            <betCategoryType xsi:type="n2:BetCategoryTypeEnum">E</betCategoryType>
+            <betPersistenceType xsi:type="n2:BetPersistenceTypeEnum">NONE</betPersistenceType>
+            <marketId xsi:type="xsd:int">100470197</marketId>
+            <matchedDate xsi:type="xsd:dateTime">0001-01-01T00:00:00.000Z</matchedDate>
+            <size xsi:type="xsd:double">5.0</size>
+            <bspLiability xsi:type="xsd:double">0.0</bspLiability>
+            <placedDate xsi:type="xsd:dateTime">2012-03-11T05:28:37.000Z</placedDate>
+            <price xsi:type="xsd:double">1.89</price>
+            <selectionId xsi:type="xsd:int">5986909</selectionId>
+            <handicap xsi:type="xsd:double">0.0</handicap>
+          </n2:MUBet>
+          <n2:MUBet xsi:type="n2:MUBet">
+            <asianLineId xsi:type="xsd:int">0</asianLineId>
+            <betId xsi:type="xsd:long">1828957079</betId>
+            <transactionId xsi:type="xsd:long">2433120450</transactionId>
+            <betStatus xsi:type="n2:BetStatusEnum">U</betStatus>
+            <betType xsi:type="n2:BetTypeEnum">L</betType>
+            <betCategoryType xsi:type="n2:BetCategoryTypeEnum">E</betCategoryType>
+            <betPersistenceType xsi:type="n2:BetPersistenceTypeEnum">NONE</betPersistenceType>
+            <marketId xsi:type="xsd:int">100470197</marketId>
+            <matchedDate xsi:type="xsd:dateTime">0001-01-01T00:00:00.000Z</matchedDate>
+            <size xsi:type="xsd:double">5.0</size>
+            <bspLiability xsi:type="xsd:double">0.0</bspLiability>
+            <placedDate xsi:type="xsd:dateTime">2012-03-11T05:28:37.000Z</placedDate>
+            <price xsi:type="xsd:double">1.48</price>
+            <selectionId xsi:type="xsd:int">6230544</selectionId>
+            <handicap xsi:type="xsd:double">0.0</handicap>
+          </n2:MUBet>
+        </bets>
+        <errorCode xsi:type="n2:GetMUBetsErrorEnum">OK</errorCode>
+        <minorErrorCode xsi:nil="1"></minorErrorCode>
+        <totalRecordCount xsi:type="xsd:int">2</totalRecordCount>
+      </n:Result>
+    </n:getMUBetsResponse>
+  </soap:Body>
+</soap:Envelope>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: betfair
 version: !ruby/object:Gem::Version
-  version: 0.0.14
+  version: 0.0.16
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-29 00:00:00.000000000Z
+date: 2012-03-13 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
-  requirement: &70236502261180 !ruby/object:Gem::Requirement
+  requirement: &70157897063020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70236502261180
+  version_requirements: *70157897063020
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70236502258180 !ruby/object:Gem::Requirement
+  requirement: &70157897062340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70236502258180
+  version_requirements: *70157897062340
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70236502252040 !ruby/object:Gem::Requirement
+  requirement: &70157897061740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70236502252040
+  version_requirements: *70157897061740
 - !ruby/object:Gem::Dependency
   name: savon_spec
-  requirement: &70236502249320 !ruby/object:Gem::Requirement
+  requirement: &70157897061180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70236502249320
+  version_requirements: *70157897061180
 description: Gem for accessing the Betfair API.
 email:
 - lukeb@lukebyrne.com
@@ -68,6 +68,7 @@ files:
 - README
 - Rakefile
 - betfair.gemspec
+- examples/doh.log
 - examples/foo.rb
 - lib/betfair.rb
 - lib/betfair/api.rb
@@ -83,6 +84,8 @@ files:
 - spec/fixtures/get_market/success.xml
 - spec/fixtures/get_market_prices_compressed/fail.xml
 - spec/fixtures/get_market_prices_compressed/success.xml
+- spec/fixtures/get_mu_bets/fail.xml
+- spec/fixtures/get_mu_bets/success.xml
 - spec/fixtures/login/fail.xml
 - spec/fixtures/login/success.xml
 - spec/fixtures/place_bets/fail.xml
@@ -102,7 +105,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2051552141254141461
+      hash: 1829796573211684180
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -111,7 +114,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2051552141254141461
+      hash: 1829796573211684180
 requirements: []
 rubyforge_project: betfair
 rubygems_version: 1.8.10
@@ -130,6 +133,8 @@ test_files:
 - spec/fixtures/get_market/success.xml
 - spec/fixtures/get_market_prices_compressed/fail.xml
 - spec/fixtures/get_market_prices_compressed/success.xml
+- spec/fixtures/get_mu_bets/fail.xml
+- spec/fixtures/get_mu_bets/success.xml
 - spec/fixtures/login/fail.xml
 - spec/fixtures/login/success.xml
 - spec/fixtures/place_bets/fail.xml