best_in_place 3.1.1 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: f42b596132f7b09be9241f0d8b0c51af70ddfc08
-  data.tar.gz: de11ecdc29b0213492b844b18f20325eecdd931a
+SHA256:
+  metadata.gz: bbdae997fd9415d9a651576e8793d828c11ce6dd0cc65aaa2430dde3e43b61d2
+  data.tar.gz: 51a853b0123110bfd6bf5808f6f3317bc319e4740726843874b30933b91e09db
 SHA512:
-  metadata.gz: 39a699e70e97bd086678ff33d4831116258de870b3666292de2b1dd3d95a672f4239fcac73521a525faa5d1ae897b6174efee1ea7c990cac6c0d794d52de8d34
-  data.tar.gz: 76e249d89a3376deb3d6a8ad4caeb9c387016ea28fa89d933459c741725ce1b5ecf6f4aebf22fce915a71809bca5e652736da633cc4bf53f52d8af97b1c7da4b
+  metadata.gz: 265f777bfee7c4148e2cd51021d6d7900abccff976c764980f90e9817262ba00360f3bd85749b16ca1a2664e05c3eaa62ae25f722c0148caf2dc9c2127c10909
+  data.tar.gz: 1b1bc9e112f87d80ba388636ba2138b06bf49de87cb9923bceaae654c8f2f4bf8a0409b2b14980d17e41d820a8244b22e81d0ca16a1a9442efad7b9fbabf5977

data/.github/workflows/rspec.yml

@@ -0,0 +1,50 @@
+name: Ruby CI
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+permissions:
+  contents: read
+
+jobs:
+  test:
+    name: Ruby ${{ matrix.ruby }} - ${{ matrix.rails }}
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        ruby: [3.1, 3.2, 3.3]
+        rails:
+          - rails_7.0
+          - rails_7.1
+          - rails_7.2
+          - rails_edge
+    env:
+      RAILS_ENV: test
+      DISPLAY: ":99.0"
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.rails }}.gemfile
+
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true
+
+    - name: Set up PhantomJS
+      run: |
+        mkdir -p travis-phantomjs
+        wget https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-2.1.1-linux-x86_64.tar.bz2 -O travis-phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
+        tar -xvf travis-phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2 -C travis-phantomjs
+        echo "$PWD/travis-phantomjs/phantomjs-2.1.1-linux-x86_64/bin" >> $GITHUB_PATH
+
+    - name: Run tests
+      run: bundle exec rspec
+      env:
+       BUNDLE_GEMFILE: gemfiles/${{ matrix.rails }}.gemfile

data/.gitignore

@@ -8,7 +8,9 @@ spec/internal/.bundle
 spec/internal/db/*.sqlite3
 spec/internal/log/*.log
 spec/internal/tmp/**/*
+spec/internal/local
 
 .rvmrc
 coverage
-tmp
+tmp
+failifier.txt

data/Appraisals

@@ -1,31 +1,19 @@
-appraise "rails-3.2" do
-  gem 'rails', github: "rails/rails", branch: '3-2-stable'
-  gem 'strong_parameters'
-  gem 'test-unit'
+appraise "rails-7.0" do
+  gem 'sqlite3', '~> 1.4'
+  gem "rails", github: "rails/rails", branch: '7-0-stable'
 end
 
-appraise "rails-4.0" do
-  gem "rails", github: "rails/rails", branch: '4-0-stable'
-  gem 'test-unit'
+appraise "rails-7.1" do
+  gem 'sqlite3', '~> 1.4'
+  gem "rails", '7.1.0' # issue with 7-1-stable
 end
 
-appraise "rails-4.1" do
-  gem "rails", github: "rails/rails", branch: '4-1-stable'
-end
-
-appraise "rails-4.2" do
-  gem "rails", github: "rails/rails", branch: '4-2-stable'
-end
-
-appraise "rails-5.0" do
-  gem "rails", github: "rails/rails", branch: '5-0-stable'
-end
-
-appraise "rails-5.1" do
-  gem "rails", github: "rails/rails", branch: '5-1-stable'
+appraise "rails-7.2" do
+  gem 'sqlite3', '~> 1.4'
+  gem "rails", github: "rails/rails", branch: '7-2-stable'
 end
 
 appraise "rails-edge" do
-  gem "rails", github: "rails/rails"
-  gem 'arel', github: 'rails/arel'
+  gem 'sqlite3', '~> 1.4'
+  gem "rails", github: "rails/rails", branch: 'main'
 end

data/CHANGELOG.md

@@ -1,5 +1,6 @@
 #Changelog
-- unreleased
+- v.6.1.0
+- Version set to the version of rails it matches to (given that is the usecase)
 
 - v.3.1.1
   - Chore/improve readme

data/Gemfile

@@ -1,12 +1,11 @@
 source 'https://rubygems.org'
-source 'https://rails-assets.org'
 
 # Specify your gem's dependencies in best_in_place.gemspec
 gemspec
-
-gem 'activerecord'
-gem 'rails-assets-jquery', '1.11.1'
-gem 'rails-assets-jquery-ui', '1.10.4'
+source 'https://rails-assets.org' do
+  gem 'rails-assets-jquery', '1.11.1'
+  gem 'rails-assets-jquery-ui', '1.10.4'
+end
 gem 'rdiscount'
 gem 'rspec-rails'
 gem 'nokogiri'
@@ -18,6 +17,9 @@ gem 'sqlite3'
 gem 'appraisal'
 gem 'launchy'
 
+gem 'puma'
+gem 'phantomjs', :require => 'phantomjs/poltergeist'
+
 platforms :mri_21 do
   gem 'byebug'
 end

data/README.md

@@ -2,7 +2,6 @@
 [![Build Status](https://secure.travis-ci.org/bernat/best_in_place.png)](http://travis-ci.org/bernat/best_in_place)
 **The Unobtrusive in Place editing solution**
 
-
 ## Description
 
 **Best in Place** is a jQuery based AJAX Inplace-Editor that takes profit of RESTful server-side controllers to allow users to edit stuff with
@@ -20,27 +19,31 @@ The editor works by PUTting the updated value to the server and GETting the upda
 Installing *best_in_place* is very easy and straight-forward.
 Just begin including the gem in your Gemfile:
 
-    gem 'best_in_place', '~> 3.0.1'
+    gem 'best_in_place', '~> 4.0'
 
 After that, specify the use of the jquery and best in place
 javascripts in your application.js, and optionally specify jquery-ui if
 you want to use jQuery UI datepickers:
 
-    //= require jquery
-    //= require best_in_place
+```javascript
+//= require jquery
+//= require best_in_place
 
-    //= require jquery-ui
-    //= require best_in_place.jquery-ui
+//= require jquery-ui
+//= require best_in_place.jquery-ui
+```
 
 If you want to use jQuery UI datepickers, you should also install and
 load your preferred jquery-ui CSS file and associated assets.
 
 Then, just add a binding to prepare all best in place fields when the document is ready:
 
-    $(document).ready(function() {
-      /* Activating Best In Place */
-      jQuery(".best_in_place").best_in_place();
-    });
+```javascript
+$(document).ready(function() {
+  /* Activating Best In Place */
+  jQuery(".best_in_place").best_in_place();
+});
+```
 
 You are done!
 
@@ -104,7 +107,9 @@ If you provide an option that is not explicitly a best_in_place option it will b
 
 So, for instance, if you want to add an HTML tab index to the best_in_place span just add it to your method call:
 
-    <%= best_in_place @user, :name, tabindex: "1" %>
+```erb
+<%= best_in_place @user, :name, tabindex: "1" %>
+```
 
 ### best_in_place_if
 **best_in_place_if condition, object, field, OPTIONS**
@@ -118,15 +123,21 @@ condition, is satisfied. Specifically:
 
 Say we have something like
 
-    <%= best_in_place_if condition, @user, :name, :as => :input %>
+```erb
+<%= best_in_place_if condition, @user, :name, :as => :input %>
+```
 
 In case *condition* is satisfied, the outcome will be just the same as:
 
-    <%= best_in_place @user, :name, :as => :input %>
+```erb
+<%= best_in_place @user, :name, :as => :input %>
+```
 
 Otherwise, we will have the same outcome as:
 
-    <%= @user.name %>
+```erb
+<%= @user.name %>
+```
 
 It is a very useful feature to use with, for example, [Ryan Bates](https://github.com/ryanb)' [CanCan](https://github.com/ryanb/cancan), so we only allow BIP edition if the current user has permission to do it.
 
@@ -138,41 +149,53 @@ Examples (code in the views):
 
 ### Input
 
-    <%= best_in_place @user, :name, :as => :input %>
+```erb
+<%= best_in_place @user, :name, :as => :input %>
 
-    <%= best_in_place @user, :name, :as => :input, :place_holder => "Click me to add content!" %>
+<%= best_in_place @user, :name, :as => :input, :place_holder => "Click me to add content!" %>
+```
 
 ### Textarea
 
-    <%= best_in_place @user, :description, :as => :textarea %>
+```erb
+<%= best_in_place @user, :description, :as => :textarea %>
 
-    <%= best_in_place @user, :favorite_books, :as => :textarea, :ok_button => 'Save', :cancel_button => 'Cancel' %>
+<%= best_in_place @user, :favorite_books, :as => :textarea, :ok_button => 'Save', :cancel_button => 'Cancel' %>
+```
 
 ### Select
 
-    <%= best_in_place @user, :country, :as => :select, :collection => {"1" => "Spain", "2" => "Italy", "3" => "Germany", "4" => "France"} %>
-    <%= best_in_place @user, :country, :as => :select, :collection => { es: 'Spain', it: 'Italy', de: 'Germany', fr: 'France' } %>
-    <%= best_in_place @user, :country, :as => :select, :collection => %w(Spain Italy Germany France) %>
-    <%= best_in_place @user, :country, :as => :select, :collection => [[1, 'Spain'], [3, 'Germany'], [2, 'Italy'], [4, 'France']] %>
+```erb
+<%= best_in_place @user, :country, :as => :select, :collection => {"1" => "Spain", "2" => "Italy", "3" => "Germany", "4" => "France"} %>
+<%= best_in_place @user, :country, :as => :select, :collection => { es: 'Spain', it: 'Italy', de: 'Germany', fr: 'France' } %>
+<%= best_in_place @user, :country, :as => :select, :collection => %w(Spain Italy Germany France) %>
+<%= best_in_place @user, :country, :as => :select, :collection => [[1, 'Spain'], [3, 'Germany'], [2, 'Italy'], [4, 'France']] %>
+```
 
 Of course it can take an instance or global variable for the collection, just remember the structure is a hash.
 The value will always be converted to a string for display.
 
 ### Checkbox
 
-    <%= best_in_place @user, :receive_emails, as: :checkbox, collection: ["No, thanks", "Yes, of course!"] %>
-    <%= best_in_place @user, :receive_emails, as: :checkbox, collection: {false: "Nope", true: "Yep"} %>
+```erb
+<%= best_in_place @user, :receive_emails, as: :checkbox, collection: ["No, thanks", "Yes, of course!"] %>
+<%= best_in_place @user, :receive_emails, as: :checkbox, collection: {false: "Nope", true: "Yep"} %>
+```
 
 If you use array as a collection, the first value is always the negative boolean value and the second the positive. Structure: `["false value", "true value"]`.
 If not defined, it will default to *Yes* and *No* options.
 Default true and false values are stored in locales
 
-    t(:'best_in_place.yes', default: 'Yes')
-    t(:'best_in_place.no', default: 'No')
+```ruby
+t(:'best_in_place.yes', default: 'Yes')
+t(:'best_in_place.no', default: 'No')
+```
 
 ### Date
 
-    <%= best_in_place @user, :birth_date, :as => :date %>
+```erb
+<%= best_in_place @user, :birth_date, :as => :date %>
+```
 
 With the :date type the input field will be initialized as a datepicker input.
 In order to provide custom options to the datepicker initialization you must
@@ -187,20 +210,21 @@ Best in place provides a utility method you should use in your controller in
 order to provide the response that is expected by the javascript side, using
 the :json format. This is a simple example showing an update action using it:
 
-    def update
-      @user = User.find params[:id]
-
-      respond_to do |format|
-        if @user.update_attributes(params[:user])
-          format.html { redirect_to(@user, :notice => 'User was successfully updated.') }
-          format.json { respond_with_bip(@user) }
-        else
-          format.html { render :action => "edit" }
-          format.json { respond_with_bip(@user) }
-        end
-      end
+```ruby
+def update
+  @user = User.find params[:id]
+
+  respond_to do |format|
+    if @user.update_attributes(params[:user])
+      format.html { redirect_to(@user, :notice => 'User was successfully updated.') }
+      format.json { respond_with_bip(@user) }
+    else
+      format.html { render :action => "edit" }
+      format.json { respond_with_bip(@user) }
     end
-
+  end
+end
+```
 
 ## Custom display methods
 
@@ -209,7 +233,9 @@ the :json format. This is a simple example showing an update action using it:
 As of best in place 1.0.3 you can use custom methods in your model in order to
 decide how a certain field has to be displayed. You can write something like:
 
-    = best_in_place @user, :description, :as => :textarea, :display_as => :mk_description
+```
+= best_in_place @user, :description, :as => :textarea, :display_as => :mk_description
+```
 
 Then instead of using `@user.description` to show the actual value, best in
 place will call `@user.mk_description`. This can be used for any kind of
@@ -222,16 +248,22 @@ helper to render the attribute, like `number_to_currency` or `simple_format`.
 As of version 1.0.4 best in place provides this feature using the
 `display_with` option. You can use it like this:
 
-    = best_in_place @user, :money, :display_with => :number_to_currency
+```
+= best_in_place @user, :money, :display_with => :number_to_currency
+```
 
 If you want to pass further arguments to the helper you can do it providing an
 additional `helper_options` hash:
 
-    = best_in_place @user, :money, :display_with => :number_to_currency, :helper_options => {:unit => "€"}
+```
+= best_in_place @user, :money, :display_with => :number_to_currency, :helper_options => {:unit => "€"}
+```
 
 You can also pass in a proc or lambda like this:
 
-    = best_in_place @post, :body, :display_with => lambda { |v| textilize(v).html_safe }
+```
+= best_in_place @post, :body, :display_with => lambda { |v| textilize(v).html_safe }
+```
 
 ## Ajax success callback
 
@@ -239,26 +271,35 @@ You can also pass in a proc or lambda like this:
 
 The 'ajax:success' event is triggered upon success. Use bind:
 
-    $('.best_in_place').bind("ajax:success", function () {$(this).closest('tr').effect('highlight'); });
+```javascript
+$('.best_in_place').bind("ajax:success", function () {$(this).closest('tr').effect('highlight'); });
+```
 
 To bind a callback that is specific to a particular field, use the 'classes' option in the helper method and
 then bind to that class.
 
-    <%= best_in_place @user, :name, :classes => 'highlight_on_success' %>
-    <%= best_in_place @user, :mail, :classes => 'bounce_on_success' %>
-
-    $('.highlight_on_success').bind("ajax:success", function(){$(this).closest('tr').effect('highlight');});
-    $('.bounce_on_success').bind("ajax:success", function(){$(this).closest('tr').effect('bounce');});
+```erb
+<%= best_in_place @user, :name, :classes => 'highlight_on_success' %>
+<%= best_in_place @user, :mail, :classes => 'bounce_on_success' %>
+```
+```javascript
+$('.highlight_on_success').bind("ajax:success", function(){$(this).closest('tr').effect('highlight');});
+$('.bounce_on_success').bind("ajax:success", function(){$(this).closest('tr').effect('bounce');});
+```
 
 ### Providing data to the callback
 
 Use the :data option to add HTML5 data attributes to the best_in_place span. For example, in your view:
 
-    <%= best_in_place @user, :name, :data => {:user_name => @user.name} %>
+```erb
+<%= best_in_place @user, :name, :data => {:user_name => @user.name} %>
+```
 
 And in your javascript:
 
-    $('.best_in_place').bind("ajax:success", function(){ alert('Name updated for '+$(this).data('userName')); });
+```javascript
+$('.best_in_place').bind("ajax:success", function(){ alert('Name updated for '+$(this).data('userName')); });
+```
 
 ## Non Active Record environments
 We are not planning to support other ORMs apart from Active Record, at least for now. So, you can perfectly consider the following workaround as *the right way* until a specific implementation is done for your ORM.
@@ -267,68 +308,75 @@ Best In Place automatically assumes that Active Record is the ORM you are using.
 
 Let's setup an example so we can illustrate how to use Best In Place too in a non-ORM case. Imagine you have an awesome ice cream shop, and you have a model representing a single type of ice cream. The IceCream model has a name, a description, a... nevermind. The thing is that it also has a stock, which is a combination of flavour and size. A big chocolate ice cream (yummy!), a small paella ice cream (...really?), and so on. Shall we see some code?
 
-    class IceCream < ActiveRecord::Base
-      serialize :stock, Hash
+```ruby
+class IceCream < ActiveRecord::Base
+  serialize :stock, Hash
 
-      # consider the get_stock and set_stock methods are already defined
-    end
+  # consider the get_stock and set_stock methods are already defined
+end
+```
 
 Imagine we want to have a grid showing all the combinations of flavour and size and, for each combination, an editable stock. Since the stock for a flavour and a size is not a single and complete model attribute, we cannot use Best In Place *directly*. But we can set it up with an easy workaround.
 
 In the view, we'd do:
 
-    // @ice_cream is already available
-    - flavours = ... // get them somewhere
-    - sizes = ... // get them somewhere
-    table
-      tr
-        - flavours.each do |flavour|
-          th= flavour
-      - sizes.each do |size|
-        tr
-          th= size
-          - flavours.each do |flavour|
-            - v = @ice_cream.get_stock(flavour: flavour, size: size)
-            td= best_in_place v, :to_i, as: :input, url: set_stock_ice_cream_path(flavour: flavour, size: size)
+```slim
+// @ice_cream is already available
+- flavours = ... // get them somewhere
+- sizes = ... // get them somewhere
+table
+  tr
+    - flavours.each do |flavour|
+      th= flavour
+  - sizes.each do |size|
+    tr
+      th= size
+      - flavours.each do |flavour|
+        - v = @ice_cream.get_stock(flavour: flavour, size: size)
+        td= best_in_place v, :to_i, as: :input, url: set_stock_ice_cream_path(flavour: flavour, size: size)
+```
 
 Now we need a route to which send the stock updates:
 
-    TheAwesomeIceCreamShop::Application.routes.draw do
-      ...
-
-      resources :ice_creams, :only => :none do
-        member do
-          put :set_stock
-        end
-      end
+```ruby
+TheAwesomeIceCreamShop::Application.routes.draw do
+  ...
 
-      ...
+  resources :ice_creams, :only => :none do
+    member do
+      put :set_stock
     end
+  end
 
-And finally we need a controller:
+  ...
+end
+```
 
+And finally we need a controller:
 
-    class IceCreamsController < ApplicationController::Base
-      respond_to :html, :json
+```ruby
+class IceCreamsController < ApplicationController::Base
+  respond_to :html, :json
 
-      ...
+  ...
 
-      def set_stock
-        flavour = params[:flavour]
-        size = params[:size]
-        new_stock = (params["fixnum"] || {})["to_i"]
+  def set_stock
+    flavour = params[:flavour]
+    size = params[:size]
+    new_stock = (params["fixnum"] || {})["to_i"]
 
-        @ice_cream.set_stock(new_stock, { :flavour => flavour, :size => size })
-        if @ice_cream.save
-          head :ok
-        else
-          render :json => @ice_cream.errors.full_messages, :status => :unprocessable_entity
-        end
-      end
+    @ice_cream.set_stock(new_stock, { :flavour => flavour, :size => size })
+    if @ice_cream.save
+      head :ok
+    else
+      render :json => @ice_cream.errors.full_messages, :status => :unprocessable_entity
+    end
+  end
 
-      ...
+  ...
 
-    end
+end
+```
 
 And this is how it is done!
 
@@ -336,11 +384,12 @@ And this is how it is done!
 
 You can configure some global options for best_in_place. Currently these options are available:
 
-    BestInPlace.configure do |config|
-      config.container = :div
-      config.skip_blur = true
-    end
-
+```ruby
+BestInPlace.configure do |config|
+  config.container = :div
+  config.skip_blur = true
+end
+```
 
 ## Notification
 
@@ -348,8 +397,10 @@ Sometimes your in-place updates will fail due to validation or for some other re
 
 To opt into the jquery.purr error notification, just add best_in_place.purr to your javascripts, as described below.
 
-    //= require jquery.purr
-    //= require best_in_place.purr
+```javascript
+//= require jquery.purr
+//= require best_in_place.purr
+```
 
 If you'd like to develop your own custom form of error notification, you can use best_in_place.purr as an example to guide you.
 
@@ -357,8 +408,10 @@ If you'd like to develop your own custom form of error notification, you can use
 
 If the script is used with the Rails Gem no html tags will be allowed unless the sanitize option is set to true, in that case only the tags [*b i u s a strong em p h1 h2 h3 h4 h5 ul li ol hr pre span img*] will be allowed. If the script is used without the gem and with frameworks other than Rails, then you should make sure you are providing the csrf authenticity params as meta tags and you should always escape undesired html tags such as script, object and so forth.
 
-    <meta name="csrf-param" content="authenticity_token"/>
-    <meta name="csrf-token" content="YOUR UNIQUE TOKEN HERE"/>
+```html
+<meta name="csrf-param" content="authenticity_token"/>
+<meta name="csrf-token" content="YOUR UNIQUE TOKEN HERE"/>
+```
 
 ---
 

data/best_in_place.gemspec

@@ -1,6 +1,4 @@
-# -*- encoding: utf-8 -*-
-$:.push File.expand_path("../lib", __FILE__)
-require 'best_in_place/version'
+require_relative 'lib/best_in_place/version'
 
 Gem::Specification.new do |s|
   s.name        = "best_in_place"
@@ -8,7 +6,7 @@ Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Bernat Farrero"]
   s.email       = ["bernat@itnig.net"]
-  s.homepage    = "http://github.com/bernat/best_in_place"
+  s.homepage    = "https://github.com/bernat/best_in_place"
   s.summary     = <<SUM
   It makes any field in place editable by clicking on it, it works for inputs,
   textareas, select dropdowns and checkboxes
@@ -24,7 +22,8 @@ DESC
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  s.add_runtime_dependency 'actionpack', '>= 3.2'
-  s.add_runtime_dependency 'railties', '>= 3.2'
+  s.required_ruby_version = '>= 3.1.0'
 
+  s.add_runtime_dependency 'actionpack', '>= 7.0'
+  s.add_runtime_dependency 'railties', '>= 7.0'
 end

data/gemfiles/{rails_3.2.gemfile → rails_6.1.gemfile}

@@ -16,12 +16,15 @@ gem "poltergeist"
 gem "sqlite3"
 gem "appraisal"
 gem "launchy"
-gem "rails", github: "rails/rails", branch: "3-2-stable"
-gem "strong_parameters"
-gem "test-unit"
+gem "rails", github: "rails/rails", branch: "6-1-stable"
 
 platforms :mri_21 do
   gem "byebug"
 end
 
+
+gem 'puma'
+gem 'phantomjs', :require => 'phantomjs/poltergeist'
+
+
 gemspec path: "../"

data/gemfiles/{rails_4.0.gemfile → rails_7.0.gemfile}

@@ -3,7 +3,6 @@
 source "https://rubygems.org"
 source "https://rails-assets.org"
 
-gem "activerecord"
 gem "rails-assets-jquery", "1.11.1"
 gem "rails-assets-jquery-ui", "1.10.4"
 gem "rdiscount"
@@ -13,11 +12,12 @@ gem "combustion"
 gem "sprockets-rails"
 gem "capybara"
 gem "poltergeist"
-gem "sqlite3"
+gem "sqlite3", "~> 1.4"
 gem "appraisal"
 gem "launchy"
-gem "rails", github: "rails/rails", branch: "4-0-stable"
-gem "test-unit"
+gem "puma"
+gem "phantomjs", require: "phantomjs/poltergeist"
+gem "rails", github: "rails/rails", branch: "7-0-stable"
 
 platforms :mri_21 do
   gem "byebug"

data/gemfiles/{rails_4.2.gemfile → rails_7.1.gemfile}

@@ -3,7 +3,6 @@
 source "https://rubygems.org"
 source "https://rails-assets.org"
 
-gem "activerecord"
 gem "rails-assets-jquery", "1.11.1"
 gem "rails-assets-jquery-ui", "1.10.4"
 gem "rdiscount"
@@ -13,10 +12,12 @@ gem "combustion"
 gem "sprockets-rails"
 gem "capybara"
 gem "poltergeist"
-gem "sqlite3"
+gem "sqlite3", "~> 1.4"
 gem "appraisal"
 gem "launchy"
-gem "rails", github: "rails/rails", branch: "4-2-stable"
+gem "puma"
+gem "phantomjs", require: "phantomjs/poltergeist"
+gem "rails", "7.1.0"
 
 platforms :mri_21 do
   gem "byebug"

data/gemfiles/{rails_4.1.gemfile → rails_7.2.gemfile}

@@ -3,7 +3,6 @@
 source "https://rubygems.org"
 source "https://rails-assets.org"
 
-gem "activerecord"
 gem "rails-assets-jquery", "1.11.1"
 gem "rails-assets-jquery-ui", "1.10.4"
 gem "rdiscount"
@@ -13,10 +12,12 @@ gem "combustion"
 gem "sprockets-rails"
 gem "capybara"
 gem "poltergeist"
-gem "sqlite3"
+gem "sqlite3", "~> 1.4"
 gem "appraisal"
 gem "launchy"
-gem "rails", github: "rails/rails", branch: "4-1-stable"
+gem "puma"
+gem "phantomjs", require: "phantomjs/poltergeist"
+gem "rails", github: "rails/rails", branch: "7-2-stable"
 
 platforms :mri_21 do
   gem "byebug"

data/gemfiles/rails_edge.gemfile

@@ -3,7 +3,6 @@
 source "https://rubygems.org"
 source "https://rails-assets.org"
 
-gem "activerecord"
 gem "rails-assets-jquery", "1.11.1"
 gem "rails-assets-jquery-ui", "1.10.4"
 gem "rdiscount"
@@ -13,11 +12,12 @@ gem "combustion"
 gem "sprockets-rails"
 gem "capybara"
 gem "poltergeist"
-gem "sqlite3"
+gem "sqlite3", "~> 1.4"
 gem "appraisal"
 gem "launchy"
-gem "rails", github: "rails/rails"
-gem "arel", github: "rails/arel"
+gem "puma"
+gem "phantomjs", require: "phantomjs/poltergeist"
+gem "rails", github: "rails/rails", branch: "main"
 
 platforms :mri_21 do
   gem "byebug"

data/lib/best_in_place/display_methods.rb

@@ -30,15 +30,15 @@ module BestInPlace
     end
 
     def add_model_method(klass, attr, display_as)
-      model_attributes(klass)[attr.to_s] = Renderer.new method: display_as.to_sym, type: :model
+      model_attributes(klass)[attr.to_s] = Renderer.new({ method: display_as.to_sym, type: :model })
     end
 
     def add_helper_method(klass, attr, helper_method, helper_options = nil)
-      model_attributes(klass)[attr.to_s] = Renderer.new method: helper_method.to_sym, type: :helper, attr: attr, helper_options: helper_options
+      model_attributes(klass)[attr.to_s] = Renderer.new({ method: helper_method.to_sym, type: :helper, attr: attr, helper_options: helper_options })
     end
 
     def add_helper_proc(klass, attr, helper_proc)
-      model_attributes(klass)[attr.to_s] = Renderer.new type: :proc, attr: attr, proc: helper_proc
+      model_attributes(klass)[attr.to_s] = Renderer.new({ type: :proc, attr: attr, proc: helper_proc })
     end
 
     def model_attributes(klass)

data/lib/best_in_place/engine.rb

@@ -1,8 +1,8 @@
 module BestInPlace
   class Engine < Rails::Engine
     initializer 'best_in_place' do
-      ActionView::Base.send(:include, BestInPlace::Helper)
-      ActionController::Base.send(:include, BestInPlace::ControllerExtensions)
+      ActiveSupport.on_load(:action_view) { include BestInPlace::Helper }
+      ActiveSupport.on_load(:action_controller_base) { include BestInPlace::ControllerExtensions }
     end
   end
 end

data/lib/best_in_place/helper.rb

@@ -149,10 +149,11 @@ module BestInPlace
           {from: :sanitize, to: :raw}
       ]
 
+      deprecator = ActiveSupport::Deprecation.new
       deprecations.each do |deprecation|
         if deprecated_option = opts.delete(deprecation[:from])
           opts[deprecation[:from]] = deprecated_option
-          ActiveSupport::Deprecation.warn("[Best_in_place] :#{deprecation[:from]} is deprecated in favor of :#{deprecation[:to]} ")
+          deprecator.warn("[Best_in_place] :#{deprecation[:from]} is deprecated in favor of :#{deprecation[:to]} ")
         end
       end
     end

data/lib/best_in_place/railtie.rb

@@ -4,7 +4,7 @@ require 'action_view/base'
 module BestInPlace
   class Railtie < ::Rails::Railtie #:nodoc:
     config.after_initialize do
-      BestInPlace::ViewHelpers = ActionView::Base.new
+      BestInPlace::ViewHelpers = ActionView::Base.empty
     end
   end
 end

data/lib/best_in_place/test_helpers.rb

@@ -4,7 +4,7 @@ module BestInPlace
 
     def bip_area(model, attr, new_value)
       id = BestInPlace::Utils.build_best_in_place_id model, attr
-      find("##{id}").trigger('click')
+      page.find("##{id}").click
       execute_script <<-JS
         $("##{id} form textarea").val('#{escape_javascript new_value.to_s}');
         $("##{id} form textarea").blur();
@@ -24,13 +24,13 @@ module BestInPlace
 
     def bip_bool(model, attr)
       id = BestInPlace::Utils.build_best_in_place_id model, attr
-      find("##{id}").trigger('click')
+      find("##{id}").click
       wait_for_ajax
     end
 
     def bip_select(model, attr, name)
       id = BestInPlace::Utils.build_best_in_place_id model, attr
-      find("##{id}").trigger('click')
+      find("##{id}").click
       find("##{id}").select(name)
       wait_for_ajax
     end

data/lib/best_in_place/version.rb

@@ -1,3 +1,3 @@
 module BestInPlace
-  VERSION = '3.1.1'
+  VERSION = '4.0.0'
 end

data/spec/helper_spec.rb

@@ -3,7 +3,6 @@
 describe BestInPlace::Helper, type: :helper do
   describe "#best_in_place" do
     before do
-
       @user = User.new :name => "Lucia",
         :last_name => "Napoli",
         :email => "lucianapoli@gmail.com",
@@ -32,7 +31,7 @@ describe BestInPlace::Helper, type: :helper do
     end
 
     it "should show deprecation warning" do
-      expect(ActiveSupport::Deprecation).to receive(:warn).with("[Best_in_place] :path is deprecated in favor of :url ")
+      expect_any_instance_of(ActiveSupport::Deprecation).to receive(:warn).with("[Best_in_place] :path is deprecated in favor of :url ")
 
       helper.best_in_place @user, :name, path: "http://example.com"
     end
@@ -94,7 +93,6 @@ describe BestInPlace::Helper, type: :helper do
         expect(@span.attribute("data-bip-inner-class")).to be_nil
       end
 
-
       it "should have be sanitized by default" do
         expect(@span.attribute("data-bip-raw")).to be_nil
       end
@@ -336,7 +334,7 @@ describe BestInPlace::Helper, type: :helper do
       end
 
       it "should render the date as text" do
-        expect(@span.text).to eq(@user.birth_date.to_date.to_s)
+        expect(@span.text).to eq(@user.birth_date.utc.to_s)
       end
 
       it "should have a date data-bip-type" do

data/spec/integration/text_area_spec.rb

@@ -16,13 +16,12 @@ describe "JS behaviour", :js => true do
   it "should be able to use bip_text to update a text area" do
     @user.save!
     visit user_path(@user)
-    expect(find('#description')).to have_content('User description')
+    expect(page.find('#description')).to have_content('User description')
 
     bip_area @user, :description, "A new description"
 
     visit user_path(@user)
-
-    expect(find('#description')).to have_content('A new description')
+    expect(page.find('#description')).to have_content('A new description')
   end
 
   it "should be able to use a bip_text with :display_with option" do

data/spec/internal/app/assets/config/manifest.js

@@ -0,0 +1,3 @@
+//= link_tree ../images
+//= link_directory ../stylesheets .css
+//= link_directory ../javascripts .js

data/spec/internal/app/controllers/admin/test_results_controller.rb

@@ -8,7 +8,7 @@ class Admin::TestResultsController < ApplicationController
 
   def update
     @test_result = TestResult.find(params[:id])
-    @test_result.update_attributes(test_result_params)
+    @test_result.update(test_result_params)
     respond_to do |format|
       format.json { respond_with_bip(@test_result) }
     end

data/spec/internal/app/controllers/admin/users_controller.rb

@@ -6,7 +6,7 @@ class Admin::UsersController < ApplicationController
   def update
     @user = User.find(params[:id])
     respond_to do |format|
-      @user.update_attributes(user_params)
+      @user.update(user_params)
       format.json { respond_with_bip(@user, param: :admin) }
     end
   end

data/spec/internal/app/controllers/cuca/cars_controller.rb

@@ -8,7 +8,7 @@ module Cuca
       @car = Car.find params[:id]
 
       respond_to do |format|
-        @car.update_attributes params[:cuca_car]
+        @car.update params[:cuca_car]
         format.json { respond_with_bip(@car) }
       end
     end

data/spec/internal/app/controllers/users_controller.rb

@@ -46,9 +46,10 @@ class UsersController < ApplicationController
   # PUT /users/1.xml
   def update
     @user = User.find(params[:id])
+    # puts "RUNNING UPDATE: #{user_params.inspect}"
 
     respond_to do |format|
-      if @user.update_attributes(user_params)
+      if @user.update(user_params)
         format.html { redirect_to(@user, :notice => 'User was successfully updated.') }
         format.json { respond_with_bip(@user) }
       else

data/spec/internal/app/views/users/show.html.erb

@@ -96,13 +96,13 @@
     <tr>
       <td>User description</td>
       <td id="description">
-        <%= best_in_place @user, :description, :display_as => :markdown_desc, as: :textarea, :raw => true %>
+        <%= best_in_place @user, :description, as: :textarea, raw: true %>
       </td>
     </tr>
     <tr>
       <td>Simple-formatted user description</td>
       <td id="dw_description">
-        <%= best_in_place @user, :description_simple, :display_with => :simple_format, as: :textarea %>
+        <%= best_in_place @user, :description_simple, display_with: :simple_format, as: :textarea %>
       </td>
     </tr>
     <tr>

data/spec/internal/config/initializers/development.rb

@@ -1,8 +1,9 @@
 if ENV['dev']
   Rails.application.configure do
+    config.assets.enabled = true
     config.cache_classes = false
     config.eager_load = false
-    config.assets.debug = true
+    config.assets.debug = false
   end
 end
-I18n.enforce_available_locales = true
+I18n.enforce_available_locales = true

data/spec/rails_helper.rb

@@ -1,9 +1,7 @@
-ENV['RAILS_ENV'] ||= 'test'
-
 require 'combustion'
 require 'capybara/rspec'
-
 require 'capybara/poltergeist'
+
 require_relative 'support/screenshot'
 Capybara.register_driver :poltergeist do |app|
   Capybara::Poltergeist::Driver.new(app, {js_errors: false, inspector: true})
@@ -25,11 +23,11 @@ require 'capybara/rails'
 require 'best_in_place/test_helpers'
 require_relative 'support/retry_on_timeout'
 
-
 RSpec.configure do |config|
   config.include BestInPlace::TestHelpers
   config.use_transactional_fixtures = false
   config.raise_errors_for_deprecations!
+  config.example_status_persistence_file_path = "failifier.txt"
 
   config.filter_run focus: true
   config.run_all_when_everything_filtered = true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: best_in_place
 version: !ruby/object:Gem::Version
-  version: 3.1.1
+  version: 4.0.0
 platform: ruby
 authors:
 - Bernat Farrero
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-05-18 00:00:00.000000000 Z
+date: 2024-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '7.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '7.0'
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '7.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '7.0'
 description: |2
     BestInPlace is a jQuery script and a Rails helper that provide the method best_in_place to display
     any object field easily editable for the user by just clicking on it. It supports input data,
@@ -48,9 +48,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/rspec.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - Appraisals
 - CHANGELOG.md
 - Gemfile
@@ -58,12 +58,10 @@ files:
 - Rakefile
 - best_in_place.gemspec
 - config.ru
-- gemfiles/rails_3.2.gemfile
-- gemfiles/rails_4.0.gemfile
-- gemfiles/rails_4.1.gemfile
-- gemfiles/rails_4.2.gemfile
-- gemfiles/rails_5.0.gemfile
-- gemfiles/rails_5.1.gemfile
+- gemfiles/rails_6.1.gemfile
+- gemfiles/rails_7.0.gemfile
+- gemfiles/rails_7.1.gemfile
+- gemfiles/rails_7.2.gemfile
 - gemfiles/rails_edge.gemfile
 - lib/assets/javascripts/best_in_place.jquery-ui.js
 - lib/assets/javascripts/best_in_place.js
@@ -84,6 +82,7 @@ files:
 - spec/integration/new_record_spec.rb
 - spec/integration/placeholder_spec.rb
 - spec/integration/text_area_spec.rb
+- spec/internal/app/assets/config/manifest.js
 - spec/internal/app/assets/images/info.png
 - spec/internal/app/assets/images/no.png
 - spec/internal/app/assets/images/purrBottom.png
@@ -145,10 +144,10 @@ files:
 - spec/utils_spec.rb
 - vendor/assets/javascripts/jquery.autosize.js
 - vendor/assets/javascripts/jquery.purr.js
-homepage: http://github.com/bernat/best_in_place
+homepage: https://github.com/bernat/best_in_place
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -156,16 +155,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 3.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.8
-signing_key: 
+rubygems_version: 3.5.11
+signing_key:
 specification_version: 4
 summary: It makes any field in place editable by clicking on it, it works for inputs,
   textareas, select dropdowns and checkboxes

data/.travis.yml

@@ -1,34 +0,0 @@
-language: ruby
-sudo: false
-cache: bundler
-rvm:
-  - 2.4.1
-  - 2.3.3
-  - 2.2.7
-
-env: "RAILS_ENV=test DISPLAY=:99.0"
-gemfile:
-  - gemfiles/rails_3.2.gemfile
-  - gemfiles/rails_4.0.gemfile
-  - gemfiles/rails_4.1.gemfile
-  - gemfiles/rails_4.2.gemfile
-  - gemfiles/rails_5.0.gemfile
-  - gemfiles/rails_5.1.gemfile
-  - gemfiles/rails_edge.gemfile
-
-matrix:
-  allow_failures:
-    - gemfile: gemfiles/rails_edge.gemfile
-  exclude:
-    - rvm: 2.4.1
-      gemfile: gemfiles/rails_3.2.gemfile
-    - rvm: 2.4.1
-      gemfile: gemfiles/rails_4.0.gemfile
-    - rvm: 2.4.1
-      gemfile: gemfiles/rails_4.1.gemfile
-
-before_install:
-  - mkdir travis-phantomjs
-  - wget https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-2.1.1-linux-x86_64.tar.bz2 -O $PWD/travis-phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
-  - tar -xvf $PWD/travis-phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2 -C $PWD/travis-phantomjs
-  - export PATH=$PWD/travis-phantomjs/phantomjs-2.1.1-linux-x86_64/bin:$PATH

data/gemfiles/rails_5.0.gemfile

@@ -1,25 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-source "https://rails-assets.org"
-
-gem "activerecord"
-gem "rails-assets-jquery", "1.11.1"
-gem "rails-assets-jquery-ui", "1.10.4"
-gem "rdiscount"
-gem "rspec-rails"
-gem "nokogiri"
-gem "combustion"
-gem "sprockets-rails"
-gem "capybara"
-gem "poltergeist"
-gem "sqlite3"
-gem "appraisal"
-gem "launchy"
-gem "rails", github: "rails/rails", branch: "5-0-stable"
-
-platforms :mri_21 do
-  gem "byebug"
-end
-
-gemspec path: "../"

data/gemfiles/rails_5.1.gemfile

@@ -1,25 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-source "https://rails-assets.org"
-
-gem "activerecord"
-gem "rails-assets-jquery", "1.11.1"
-gem "rails-assets-jquery-ui", "1.10.4"
-gem "rdiscount"
-gem "rspec-rails"
-gem "nokogiri"
-gem "combustion"
-gem "sprockets-rails"
-gem "capybara"
-gem "poltergeist"
-gem "sqlite3"
-gem "appraisal"
-gem "launchy"
-gem "rails", github: "rails/rails", branch: "5-1-stable"
-
-platforms :mri_21 do
-  gem "byebug"
-end
-
-gemspec path: "../"