berkshelf 3.1.3 → 3.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2f602bc76f25aadd31542d00b644abe495c9a0ae
-  data.tar.gz: ab05691e2bd055675d57e3940337770571124fb5
+  metadata.gz: 1c2cbd226c97f7eb03ba011273102912c1ab35c3
+  data.tar.gz: 41a2609f4d1ea587b37be2e78f9a965408f801c2
 SHA512:
-  metadata.gz: cf4fd42a2f32ea879fcefc8389323cbbd293f382b884f7b65fc17aaee93e5bc27b6a4594d07c3be84346da03a50197563f3ad1f6addaae50096d8f359ee68d35
-  data.tar.gz: 51824f49578a4ce7417797e158413afe3951f65d243b48de48905af27924a0561f2c5b8aaaf533a7f0758ca3b5c67fbf002e694c07c2f3dff04240f4f4b3ffc0
+  metadata.gz: f1fb76696aa23da536edce710c03a1da9abe896470ccbed29713c97681f713d5213229804841566b5e5e908c3fc7f2f2465ccf871b36c8f2ced7bdaabd71678e
+  data.tar.gz: 907002c134b4c2294895dc3889fa32e52d71bb762c0c4298df6b4632e352836e645e5ed4746c8740f47ef9efcfa24be9a7a2a09905737ae4c83e47304d880318

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 > This is a high level digest of changes. For the complete CHANGELOG diff two tags in the project's [commit history](https://github.com/berkshelf/berkshelf/commits/master).
 
+# 3.1.4
+
+* Improvements
+  * Update the default vagrant box from the generators to Ubuntu 14.04 (formerly 12.04 EOL)
+
+* Bug fixes
+  * Handle the case where a remote source had been removed but still existed in the lockfile
+  * Follow redirects (HTTP -> HTTPS) in all requests
+
 # 3.1.3
 
 * Enhancements

data/Gemfile

@@ -31,5 +31,5 @@ group :guard do
 end
 
 group :test do
-  gem "berkshelf-api", github: "berkshelf/berkshelf-api"
+  gem "berkshelf-api", "~> 1.4"
 end

data/features/berksfile.feature

@@ -2,7 +2,7 @@ Feature: Evaluating a Berksfile
   Scenario: Containing pure Ruby
     Given I write to "Berksfile" with:
       """
-      source 'https://api.berkshelf.com'
+      source 'https://supermarket.getchef.com'
 
       if ENV['BACON']
         puts "If you don't got bacon..."

data/features/commands/install.feature

@@ -242,15 +242,15 @@ Feature: berks install
   Scenario: installing a Berksfile that contains a Git location
     Given I have a Berksfile pointing at the local Berkshelf API with:
       """
-      cookbook 'berkshelf-cookbook-fixture', 
-        git: 'git://github.com/RiotGames/berkshelf-cookbook-fixture.git', 
+      cookbook 'berkshelf-cookbook-fixture',
+        git: 'git://github.com/RiotGames/berkshelf-cookbook-fixture.git',
         tag: 'v0.2.0'
       """
     When I successfully run `berks install`
     Then the cookbook store should have the git cookbooks:
       | berkshelf-cookbook-fixture | 0.2.0 | 70a527e17d91f01f031204562460ad1c17f972ee |
     And the git cookbook "berkshelf-cookbook-fixture-70a527e17d91f01f031204562460ad1c17f972ee" should not have the following directories:
-      | .git | 
+      | .git |
 
   Scenario: installing a Berksfile that contains a Git location with a tag
     Given I have a Berksfile pointing at the local Berkshelf API with:
@@ -364,13 +364,11 @@ Feature: berks install
       """
     And I write to "Berksfile.lock" with:
       """
-      {
-        "dependencies": {
-          "bacon": {
-            "locked_version": "0.2.0"
-          }
-        }
-      }
+      DEPENDENCIES
+        bacon (~> 0.1)
+
+      GRAPH
+        bacon (0.2.0)
       """
     When I successfully run `berks install`
     Then the output should contain:
@@ -399,6 +397,48 @@ Feature: berks install
       """
     And the exit status should be "NoSolutionError"
 
+  Scenario: running install when the Cookbook from Berksfile.lock is not found in the sources
+    Given I have a Berksfile pointing at the local Berkshelf API with:
+      """
+      cookbook 'foo'
+      """
+    And I write to "Berksfile.lock" with:
+      """
+      DEPENDENCIES
+        foo
+
+      GRAPH
+        foo (0.1.0)
+      """
+    When I run `berks install`
+    Then the output should contain:
+      """
+      Cookbook 'foo' (0.1.0) not found in any of the sources! This can happen if the remote cookbook has been deleted or if the sources inside the Berksfile have changed. Please run `berks update foo` to resolve to a valid version.
+      """
+
+  Scenario: running install when the version from Berksfile.lock is not found in the sources
+    Given the Chef Server has cookbooks:
+      | foo | 0.3.0 |
+      | foo | 0.2.0 |
+    And the Berkshelf API server's cache is up to date
+    And I have a Berksfile pointing at the local Berkshelf API with:
+      """
+      cookbook 'foo'
+      """
+    And I write to "Berksfile.lock" with:
+      """
+      DEPENDENCIES
+        foo
+
+      GRAPH
+        foo (0.1.0)
+      """
+    When I run `berks install`
+    Then the output should contain:
+      """
+      Cookbook 'foo' (0.1.0) not found in any of the sources! This can happen if the remote cookbook has been deleted or if the sources inside the Berksfile have changed. Please run `berks update foo` to resolve to a valid version.
+      """
+
   Scenario: installing when there are sources with duplicate names defined in the same group
     Given I have a Berksfile pointing at the local Berkshelf API with:
       """

data/features/commands/search.feature

@@ -11,5 +11,6 @@ Feature: berks search
     * the output should contain:
       """
       berkshelf-api (1.0.0)
+      berkshelf-api-server (1.4.0)
       berkshelf-cookbook-fixture (1.0.0)
       """

data/features/commands/upload.feature

@@ -407,7 +407,7 @@ Feature: berks upload
       """
     And the cookbook "fake" has the file "Berksfile" with:
       """
-      source 'https://api.berkshelf.com'
+      source 'https://supermarket.getchef.com'
       metadata
       """
     And the cookbook "fake" has the file "Berksfile.lock" with:

data/features/config.feature

@@ -3,8 +3,8 @@ Feature: Reading a Berkshelf configuration file
     When I successfully run `berks cookbook sparkle_motion`
     Then the resulting "sparkle_motion" Vagrantfile should contain:
       | config.omnibus.chef_version = :latest |
-      | config.vm.box = "opscode_ubuntu-12.04_provisionerless" |
-      | config.vm.box_url = "https://opscode-vm-bento.s3.amazonaws.com/vagrant/opscode_ubuntu-12.04_provisionerless.box" |
+      | config.vm.box = "chef/ubuntu-14.04" |
+      | config.vm.box_url = "https://vagrantcloud.com/chef/ubuntu-14.04/version/1/provider/virtualbox.box" |
 
   Scenario: Using a Berkshelf configuration file that disables the vagrant-omnibus plugin
     Given I have a Berkshelf config file containing:

data/generator_files/Berksfile.erb

@@ -1,4 +1,4 @@
-source "https://api.berkshelf.com"
+source "https://supermarket.getchef.com"
 <% if options[:chef_minitest] -%>
 
 group :integration do

data/generator_files/Vagrantfile.erb

@@ -25,11 +25,14 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
 <% end -%>
 
   # Every Vagrant virtual environment requires a box to build off of.
+  # If this value is a shorthand to a box in Vagrant Cloud then 
+  # config.vm.box_url doesn't need to be specified.
   config.vm.box = "<%= berkshelf_config.vagrant.vm.box %>"
 
   # The url from where the 'config.vm.box' box will be fetched if it
-  # doesn't already exist on the user's system.
-  config.vm.box_url = "<%= berkshelf_config.vagrant.vm.box_url %>"
+  # is not a Vagrant Cloud box and if it doesn't already exist on the 
+  # user's system.
+  # config.vm.box_url = "<%= berkshelf_config.vagrant.vm.box_url %>"
 
   # Assign this VM to a host-only network IP, allowing you to access it
   # via the IP. Host-only networks can talk to the host machine as well as

data/lib/berkshelf/berksfile.rb

@@ -27,7 +27,7 @@ module Berkshelf
       end
     end
 
-    DEFAULT_API_URL = "https://api.berkshelf.com".freeze
+    DEFAULT_API_URL = "https://supermarket.getchef.com".freeze
 
     include Mixin::Logging
     include Mixin::DSLEval
@@ -172,7 +172,7 @@ module Berkshelf
     # in a second source would not be used.
     #
     # @example
-    #   source "https://api.berkshelf.com"
+    #   source "https://supermarket.getchef.com"
     #   source "https://berks-api.riotgames.com"
     #
     # @param [String] api_url
@@ -207,7 +207,7 @@ module Berkshelf
       if args.first == :opscode
         Berkshelf.formatter.deprecation "Your Berksfile contains a site location pointing to the Opscode Community " +
           "Site (site :opscode). Site locations have been replaced by the source location. Change this to: " +
-          "'source \"https://api.berkshelf.com\"' to remove this warning. For more information visit " +
+          "'source \"https://supermarket.getchef.com\"' to remove this warning. For more information visit " +
           "https://github.com/berkshelf/berkshelf/wiki/deprecated-locations"
         source(DEFAULT_API_URL)
         return
@@ -445,7 +445,7 @@ module Berkshelf
     #     "nginx" => {
     #       "local" => #<Version 1.8.0>,
     #       "remote" => {
-    #         #<Source uri: "https://api.berkshelf.com"> #=> #<Version 2.6.2>
+    #         #<Source uri: "https://supermarket.getchef.com"> #=> #<Version 2.6.2>
     #       }
     #     }
     #   }

data/lib/berkshelf/community_rest.rb

@@ -75,6 +75,7 @@ module Berkshelf
       options[:builder] ||= Faraday::RackBuilder.new do |b|
         b.response :parse_json
         b.response :gzip
+        b.response :follow_redirects
         b.request :retry,
           max: @retries,
           interval: @retry_interval,

data/lib/berkshelf/config.rb

@@ -95,11 +95,11 @@ module Berkshelf
       default: false
     attribute 'vagrant.vm.box',
       type: String,
-      default: 'opscode_ubuntu-12.04_provisionerless',
+      default: 'chef/ubuntu-14.04',
       required: true
     attribute 'vagrant.vm.box_url',
       type: String,
-      default: 'https://opscode-vm-bento.s3.amazonaws.com/vagrant/opscode_ubuntu-12.04_provisionerless.box',
+      default: 'https://vagrantcloud.com/chef/ubuntu-14.04/version/1/provider/virtualbox.box',
       required: true
     attribute 'vagrant.vm.forward_port',
       type: Hash,

data/lib/berkshelf/errors.rb

@@ -2,7 +2,7 @@ module Berkshelf
   class BerkshelfError < StandardError
     class << self
       # @param [Integer] code
-      def status_code(code)
+      def set_status_code(code)
         define_method(:status_code) { code }
         define_singleton_method(:status_code) { code }
       end
@@ -11,13 +11,13 @@ module Berkshelf
     alias_method :message, :to_s
   end
 
-  class DeprecatedError < BerkshelfError; status_code(10); end
-  class InternalError < BerkshelfError; status_code(99); end
+  class DeprecatedError < BerkshelfError; set_status_code(10); end
+  class InternalError < BerkshelfError; set_status_code(99); end
   class ArgumentError < InternalError; end
   class AbstractFunction < InternalError; end
 
   class BerksfileNotFound < BerkshelfError
-    status_code(100)
+    set_status_code(100)
 
     # @param [#to_s] filepath
     #   the path where a Berksfile was not found
@@ -31,7 +31,7 @@ module Berkshelf
   end
 
   class CookbookNotFound < BerkshelfError
-    status_code(103)
+    set_status_code(103)
 
     def initialize(name, version, location)
       @name     = name
@@ -49,7 +49,7 @@ module Berkshelf
   end
 
   class DuplicateDependencyDefined < BerkshelfError
-    status_code(105)
+    set_status_code(105)
 
     def initialize(name)
       @name = name
@@ -64,7 +64,7 @@ module Berkshelf
   end
 
   class NoSolutionError < BerkshelfError
-    status_code(106)
+    set_status_code(106)
 
     attr_reader :demands
 
@@ -80,12 +80,12 @@ module Berkshelf
     end
   end
 
-  class CookbookSyntaxError < BerkshelfError; status_code(107); end
-  class ConstraintNotSatisfied < BerkshelfError; status_code(111); end
+  class CookbookSyntaxError < BerkshelfError; set_status_code(107); end
+  class ConstraintNotSatisfied < BerkshelfError; set_status_code(111); end
   class BerksfileReadError < BerkshelfError
-    status_code(113)
+    set_status_code(113)
 
-    # @param [#status_code] original_error
+    # @param [#set_status_code] original_error
     def initialize(original_error)
       @original_error  = original_error
       @error_message   = original_error.to_s
@@ -111,7 +111,7 @@ module Berkshelf
   end
 
   class MismatchedCookbookName < BerkshelfError
-    status_code(114)
+    set_status_code(114)
 
     # @param [Dependency] dependency
     #   the dependency with the expected name
@@ -139,7 +139,7 @@ module Berkshelf
   end
 
   class InvalidConfiguration < BerkshelfError
-    status_code(115)
+    set_status_code(115)
 
     def initialize(errors)
       @errors = errors
@@ -158,7 +158,7 @@ module Berkshelf
   end
 
   class InsufficientPrivledges < BerkshelfError
-    status_code(119)
+    set_status_code(119)
 
     def initialize(path)
       @path = path
@@ -172,7 +172,7 @@ module Berkshelf
   end
 
   class DependencyNotFound < BerkshelfError
-    status_code(120)
+    set_status_code(120)
 
     # @param [String, Array<String>] names
     #   the list of cookbook names that were not defined
@@ -200,7 +200,7 @@ module Berkshelf
   end
 
   class CommunitySiteError < BerkshelfError
-    status_code(123)
+    set_status_code(123)
 
     def initialize(uri, message)
       @uri     = uri
@@ -214,7 +214,7 @@ module Berkshelf
   end
 
   class CookbookValidationFailure < BerkshelfError
-    status_code(124)
+    set_status_code(124)
 
     # @param [Location] location
     #   the location (or any subclass) raising this validation error
@@ -232,7 +232,7 @@ module Berkshelf
 
   class UploadFailure < BerkshelfError; end
   class FrozenCookbook < UploadFailure
-    status_code(126)
+    set_status_code(126)
 
     # @param [CachedCookbook] cookbook
     def initialize(cookbook)
@@ -247,7 +247,7 @@ module Berkshelf
   end
 
   class OutdatedDependency < BerkshelfError
-    status_code(128)
+    set_status_code(128)
 
     # @param [Dependency] locked_dependency
     #   the locked dependency
@@ -270,7 +270,7 @@ module Berkshelf
   end
 
   class EnvironmentNotFound < BerkshelfError
-    status_code(129)
+    set_status_code(129)
 
     def initialize(environment_name)
       @environment_name = environment_name
@@ -282,7 +282,7 @@ module Berkshelf
   end
 
   class ChefConnectionError < BerkshelfError
-    status_code(130)
+    set_status_code(130)
 
     def to_s
       'There was an error connecting to the Chef Server'
@@ -290,7 +290,7 @@ module Berkshelf
   end
 
   class UnknownCompressionType < BerkshelfError
-    status_code(131)
+    set_status_code(131)
 
     def initialize(destination)
       @destination = destination
@@ -309,7 +309,7 @@ module Berkshelf
   # @param [Array<#to_s>] files
   #   the list of files that were not valid
   class InvalidCookbookFiles < BerkshelfError
-    status_code(132)
+    set_status_code(132)
 
     def initialize(cookbook, files)
       @cookbook = cookbook
@@ -328,7 +328,7 @@ module Berkshelf
   end
 
   class LicenseNotFound < BerkshelfError
-    status_code(134)
+    set_status_code(134)
 
     attr_reader :license
 
@@ -345,7 +345,7 @@ module Berkshelf
   # Raised when a cookbook or its recipes contain a space or invalid
   # character in the path.
   class ConfigNotFound < BerkshelfError
-    status_code(135)
+    set_status_code(135)
 
     # @param [String] type
     #   the type of config that was not found (Berkshelf, Chef, etc)
@@ -362,7 +362,7 @@ module Berkshelf
   end
 
   class LockfileParserError < BerkshelfError
-    status_code(136)
+    set_status_code(136)
 
     # @param [String] lockfile
     #   the path to the Lockfile
@@ -379,7 +379,7 @@ module Berkshelf
   end
 
   class InvalidSourceURI < BerkshelfError
-    status_code(137)
+    set_status_code(137)
 
     def initialize(url, reason = nil)
       @url    = url
@@ -393,10 +393,10 @@ module Berkshelf
     end
   end
 
-  class DuplicateDemand < BerkshelfError; status_code(138); end
-  class VendorError < BerkshelfError; status_code(139); end
+  class DuplicateDemand < BerkshelfError; set_status_code(138); end
+  class VendorError < BerkshelfError; set_status_code(139); end
   class LockfileNotFound < BerkshelfError
-    status_code(140)
+    set_status_code(140)
 
     def to_s
       'Lockfile not found! Run `berks install` to create the lockfile.'
@@ -404,7 +404,7 @@ module Berkshelf
   end
 
   class NotACookbook < BerkshelfError
-    status_code(141)
+    set_status_code(141)
 
     # @param [String] path
     #   the path to the thing that is not a cookbook
@@ -418,10 +418,10 @@ module Berkshelf
     end
   end
 
-  class PackageError < BerkshelfError; status_code(143); end
+  class PackageError < BerkshelfError; set_status_code(143); end
 
   class LockfileOutOfSync < BerkshelfError
-    status_code(144)
+    set_status_code(144)
 
     def to_s
       'The lockfile is out of sync! Run `berks install` to sync the lockfile.'
@@ -429,7 +429,7 @@ module Berkshelf
   end
 
   class DependencyNotInstalled < BerkshelfError
-    status_code(145)
+    set_status_code(145)
 
     def initialize(dependency)
       @name    = dependency.name
@@ -443,7 +443,7 @@ module Berkshelf
   end
 
   class NoAPISourcesDefined < BerkshelfError
-    status_code(146)
+    set_status_code(146)
 
     def to_s
       "Your Berksfile does not define any API sources! You must define " \
@@ -451,12 +451,12 @@ module Berkshelf
       "default Berkshelf API server, add the following code to the top of " \
       "your Berksfile:" \
       "\n\n" \
-      "    source 'https://api.berkshelf.com'"
+      "    source 'https://supermarket.getchef.com'"
     end
   end
 
   class GraphvizNotInstalled < BerkshelfError
-    status_code(147)
+    set_status_code(147)
 
     def to_s
       "Graphviz is not installed! In order to generate a dependency graph, " \
@@ -467,7 +467,7 @@ module Berkshelf
   end
 
   class GraphvizCommandFailed < BerkshelfError
-    status_code(148)
+    set_status_code(148)
 
     def initialize(command, output)
       @command = command
@@ -480,9 +480,20 @@ module Berkshelf
     end
   end
 
+  class MissingLockfileCookbookVersion < CookbookNotFound
+    set_status_code(149)
+
+    def to_s
+      super + " " \
+      "This can happen if the remote cookbook has been deleted or if the sources inside the Berksfile have changed. " \
+      "Please run `berks update #{@name}` to resolve to a valid version."
+    end
+  end
+
+
   # Git errors
   # ------------------------------
-  class GitError < BerkshelfError; status_code(400); end
+  class GitError < BerkshelfError; set_status_code(400); end
 
   class GitNotInstalled < GitError
     def initialize

data/lib/berkshelf/formatters/human.rb

@@ -57,7 +57,7 @@ module Berkshelf
     #
     # @param [Hash] hash
     #   the list of outdated cookbooks in the format
-    #   { 'cookbook' => { 'api.berkshelf.com' => #<Cookbook> } }
+    #   { 'cookbook' => { 'supermarket.getchef.com' => #<Cookbook> } }
     def outdated(hash)
       if hash.empty?
         Berkshelf.ui.info('All cookbooks up to date!')

data/lib/berkshelf/formatters/json.rb

@@ -89,7 +89,7 @@ module Berkshelf
     #
     # @param [Hash] hash
     #   the list of outdated cookbooks in the format
-    #   { 'cookbook' => { 'api.berkshelf.com' => #<Cookbook> } }
+    #   { 'cookbook' => { 'supermarket.getchef.com' => #<Cookbook> } }
     def outdated(hash)
       hash.each do |name, info|
         info['remote'].each do |remote_source, remote_version|

data/lib/berkshelf/installer.rb

@@ -90,6 +90,10 @@ module Berkshelf
             name, version = dependency.name, dependency.locked_version.to_s
             source = berksfile.source_for(name, version)
 
+            # Raise error if our Berksfile.lock has cookbook versions that
+            # can't be found in sources
+            raise MissingLockfileCookbookVersion.new(name, version, 'in any of the sources') unless source
+
             Berkshelf.log.debug "  Downloading #{dependency.name} (#{dependency.locked_version}) from #{source}"
 
             cookbook = source.cookbook(name, version)

data/lib/berkshelf/version.rb

@@ -1,3 +1,3 @@
 module Berkshelf
-  VERSION = "3.1.3"
+  VERSION = "3.1.4"
 end

data/spec/unit/berkshelf/community_rest_spec.rb

@@ -64,6 +64,14 @@ describe Berkshelf::CommunityREST do
   let(:api_uri) { Berkshelf::CommunityREST::V1_API }
   subject { Berkshelf::CommunityREST.new(api_uri) }
 
+  describe '#initialize' do
+    context 'Faraday handlers' do
+      it 'includes follow_redirects to prevent 301 from community, stopping some cookbooks installing' do
+        expect(subject.builder.handlers).to include(Ridley::Middleware::FollowRedirects)
+      end
+    end
+  end
+
   describe '#download' do
     let(:archive) { double('archive', path: '/foo/bar', unlink: true) }
 

data/spec/unit/berkshelf/cookbook_generator_spec.rb

@@ -58,7 +58,7 @@ describe Berkshelf::CookbookGenerator do
           contains "description      'Installs/Configures sparkle_motion'"
         end
         file 'Berksfile' do
-          contains 'source "https://api.berkshelf.com"'
+          contains 'source "https://supermarket.getchef.com"'
           contains 'metadata'
         end
         file 'Gemfile'

data/spec/unit/berkshelf/init_generator_spec.rb

@@ -30,8 +30,8 @@ describe Berkshelf::InitGenerator do
         file 'Vagrantfile' do
           contains 'recipe[some_cookbook::default]'
           contains ' config.omnibus.chef_version = :latest'
-          contains 'config.vm.box = "opscode_ubuntu-12.04_provisionerless"'
-          contains 'config.vm.box_url = "https://opscode-vm-bento.s3.amazonaws.com/vagrant/opscode_ubuntu-12.04_provisionerless.box"'
+          contains 'config.vm.box = "chef/ubuntu-14.04"'
+          contains 'config.vm.box_url = "https://vagrantcloud.com/chef/ubuntu-14.04/version/1/provider/virtualbox.box"'
         end
         file 'chefignore'
       }

data/spec/unit/berkshelf/installer_spec.rb

@@ -6,7 +6,7 @@ describe Berkshelf::Installer do
   subject { described_class.new(berksfile) }
 
   describe "#build_universe" do
-    let(:source_one) { double('one', uri: 'https://api.berkshelf.com') }
+    let(:source_one) { double('one', uri: 'https://supermarket.getchef.com') }
     let(:source_two) { double('two', uri: 'https://api.chef.org') }
     let(:sources) { [ source_one, source_two ] }
 

data/spec/unit/berkshelf/source_spec.rb

@@ -29,7 +29,7 @@ module Berkshelf
       end
 
       it 'returns true when the scheme is different' do
-        instance = described_class.new('http://api.berkshelf.com')
+        instance = described_class.new('http://supermarket.getchef.com')
         expect(instance).to be_default
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: berkshelf
 version: !ruby/object:Gem::Version
-  version: 3.1.3
+  version: 3.1.4
 platform: ruby
 authors:
 - Jamie Winsor
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-03 00:00:00.000000000 Z
+date: 2014-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable