berkeley_library-marc 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 79af51b1f4eafdf2e0513feba8d3770d17f4deedbf06338d53546227946220e5
-  data.tar.gz: 8e75143bfa04241f2ef4cfcf5c7a3ec8e966d56d7e53acf1c699f02ae8cb4fc9
+  metadata.gz: e65fb996c3685c2a6df95cce8aad97cb5d691feb628145c3282030a25cbc614f
+  data.tar.gz: 7514006d6baf02613db35cd6ecd28c2d96df13e130c26a7dfc5615c28e6ce57c
 SHA512:
-  metadata.gz: 75edae26fe5286775dd5913138a7ce67af8148d05c775c2c419aeda457a83e0cdd7f951297b0567af735b5b7c863b1d28c1348cad73e4b3761c2fcc6b8df55ac
-  data.tar.gz: b2f038b42bd85e7804d6163c1db865327f7f924542336e92326965319b2066bc5689649e4f3c1b527ec112b85e38e75c897811bdebf6d1fdbcf929baff11831a
+  metadata.gz: 4553db7137cc4bbd44658e8826ac5e01382233a129c62a72e0adcafd1425e70fc1d3fc9c5ee0619eedaa3debd2127f606a650c5b58e5b4840d00dcb9b23d36bd
+  data.tar.gz: 210df0e0c6f3afb9f1d99259444ceb09c8a011af50e5d8924b7767576d3419a1f6ef25c31623231aa9971928c2dead31205e2b5e066833e1d219e37e0e9ac6ab

data/.github/workflows/build.yml

@@ -1,18 +1,30 @@
 name: Build
-on: [ push, pull_request ]
+on: [ push, pull_request, workflow_dispatch ]
 jobs:
   test:
     strategy:
       fail-fast: false
       matrix:
         os: [ ubuntu-latest, macos-latest ]
-        ruby: [ '2.7', '3.0' ]
+        ruby: [ '3.3', '3.4' ]
     runs-on: ${{ matrix.os }}
 
     steps:
-      - uses: actions/checkout@v2
-      - uses: ruby/setup-ruby@v1
+      - name: Check out repository
+        uses: actions/checkout@v3
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true # runs 'bundle install' and caches installed gems automatically
-      - run: bundle exec rake
+
+      - name: Run checks
+        run: bundle exec rake
+
+      - name: Upload artifacts
+        if: ${{ always() }}
+        uses: actions/upload-artifact@v4
+        with:
+          name: artifacts-${{ matrix.ruby }}-${{ matrix.os }}
+          path: artifacts/**

data/.github/workflows/gem-push.yml

@@ -0,0 +1,33 @@
+name: Ruby Gem
+
+on:
+  release:
+    types: [published]
+
+jobs:
+  build:
+    name: Build + Publish
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      packages: write
+
+    steps:
+    - uses: actions/checkout@v3
+    
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: '3.3'
+        bundler-cache: true
+
+    - name: Publish to RubyGems
+      run: |
+        mkdir -p $HOME/.gem
+        touch $HOME/.gem/credentials
+        chmod 0600 $HOME/.gem/credentials
+        printf -- "---\n:rubygems_api_key: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
+        gem build *.gemspec
+        gem push *.gem
+      env:
+        GEM_HOST_API_KEY: "${{secrets.RUBYGEMS_AUTH_TOKEN}}"

data/.rubocop.yml

@@ -328,7 +328,228 @@ Style/SwapValues: # (new in 1.1)
 ############################################################
 # Added in RuboCop 1.10
 
-Gemspec/DateAssignment: # (new in 1.10)
+Gemspec/DeprecatedAttributeAssignment: # (new in 1.10)
   Enabled: true
 Style/HashConversion: # (new in 1.10)
   Enabled: true
+
+Gemspec/AddRuntimeDependency: # new in 1.65
+  Enabled: true
+Gemspec/AttributeAssignment: # new in 1.77
+  Enabled: true
+Gemspec/DevelopmentDependencies: # new in 1.44
+  Enabled: false
+Gemspec/RequireMFA: # new in 1.23
+  Enabled: true
+Layout/LineContinuationLeadingSpace: # new in 1.31
+  Enabled: true
+Layout/LineContinuationSpacing: # new in 1.31
+  Enabled: true
+Layout/LineEndStringConcatenationIndentation: # new in 1.18
+  Enabled: true
+Lint/AmbiguousOperatorPrecedence: # new in 1.21
+  Enabled: true
+Lint/AmbiguousRange: # new in 1.19
+  Enabled: true
+Lint/ArrayLiteralInRegexp: # new in 1.71
+  Enabled: true
+Lint/ConstantOverwrittenInRescue: # new in 1.31
+  Enabled: true
+Lint/ConstantReassignment: # new in 1.70
+  Enabled: true
+Lint/CopDirectiveSyntax: # new in 1.72
+  Enabled: true
+Lint/DuplicateMagicComment: # new in 1.37
+  Enabled: true
+Lint/DuplicateMatchPattern: # new in 1.50
+  Enabled: true
+Lint/DuplicateSetElement: # new in 1.67
+  Enabled: true
+Lint/EmptyInPattern: # new in 1.16
+  Enabled: true
+Lint/HashNewWithKeywordArgumentsAsDefault: # new in 1.69
+  Enabled: true
+Lint/IncompatibleIoSelectWithFiberScheduler: # new in 1.21
+  Enabled: true
+Lint/ItWithoutArgumentsInBlock: # new in 1.59
+  Enabled: true
+Lint/LiteralAssignmentInCondition: # new in 1.58
+  Enabled: true
+Lint/MixedCaseRange: # new in 1.53
+  Enabled: true
+Lint/NonAtomicFileOperation: # new in 1.31
+  Enabled: true
+Lint/NumericOperationWithConstantResult: # new in 1.69
+  Enabled: true
+Lint/RedundantRegexpQuantifiers: # new in 1.53
+  Enabled: true
+Lint/RedundantTypeConversion: # new in 1.72
+  Enabled: true
+Lint/RefinementImportMethods: # new in 1.27
+  Enabled: true
+Lint/RequireRangeParentheses: # new in 1.32
+  Enabled: true
+Lint/RequireRelativeSelfPath: # new in 1.22
+  Enabled: true
+Lint/SharedMutableDefault: # new in 1.70
+  Enabled: true
+Lint/SuppressedExceptionInNumberConversion: # new in 1.72
+  Enabled: true
+Lint/UnescapedBracketInRegexp: # new in 1.68
+  Enabled: true
+Lint/UselessConstantScoping: # new in 1.72
+  Enabled: true
+Lint/UselessDefaultValueArgument: # new in 1.76
+  Enabled: true
+Lint/UselessDefined: # new in 1.69
+  Enabled: true
+Lint/UselessNumericOperation: # new in 1.66
+  Enabled: true
+Lint/UselessOr: # new in 1.76
+  Enabled: true
+Lint/UselessRescue: # new in 1.43
+  Enabled: true
+Lint/UselessRuby2Keywords: # new in 1.23
+  Enabled: true
+Metrics/CollectionLiteralLength: # new in 1.47
+  Enabled: true
+Naming/BlockForwarding: # new in 1.24
+  Enabled: true
+Naming/PredicateMethod: # new in 1.76
+  Enabled: true
+Security/CompoundHash: # new in 1.28
+  Enabled: true
+Security/IoMethods: # new in 1.22
+  Enabled: true
+Style/AmbiguousEndlessMethodDefinition: # new in 1.68
+  Enabled: true
+Style/ArrayIntersect: # new in 1.40
+  Enabled: true
+Style/BitwisePredicate: # new in 1.68
+  Enabled: true
+Style/CollectionQuerying: # new in 1.77
+  Enabled: true
+Style/CombinableDefined: # new in 1.68
+  Enabled: true
+Style/ComparableBetween: # new in 1.74
+  Enabled: true
+Style/ComparableClamp: # new in 1.44
+  Enabled: true
+Style/ConcatArrayLiterals: # new in 1.41
+  Enabled: true
+Style/DataInheritance: # new in 1.49
+  Enabled: true
+Style/DigChain: # new in 1.69
+  Enabled: true
+Style/DirEmpty: # new in 1.48
+  Enabled: true
+Style/EmptyHeredoc: # new in 1.32
+  Enabled: true
+Style/EmptyStringInsideInterpolation: # new in 1.76
+  Enabled: true
+Style/EnvHome: # new in 1.29
+  Enabled: true
+Style/ExactRegexpMatch: # new in 1.51
+  Enabled: true
+Style/FetchEnvVar: # new in 1.28
+  Enabled: true
+Style/FileEmpty: # new in 1.48
+  Enabled: true
+Style/FileNull: # new in 1.69
+  Enabled: true
+Style/FileRead: # new in 1.24
+  Enabled: true
+Style/FileTouch: # new in 1.69
+  Enabled: true
+Style/FileWrite: # new in 1.24
+  Enabled: true
+Style/HashFetchChain: # new in 1.75
+  Enabled: true
+Style/HashSlice: # new in 1.71
+  Enabled: true
+Style/InPatternThen: # new in 1.16
+  Enabled: true
+Style/ItAssignment: # new in 1.70
+  Enabled: true
+Style/ItBlockParameter: # new in 1.75
+  Enabled: true
+Style/KeywordArgumentsMerging: # new in 1.68
+  Enabled: true
+Style/MagicCommentFormat: # new in 1.35
+  Enabled: true
+Style/MapCompactWithConditionalBlock: # new in 1.30
+  Enabled: true
+Style/MapIntoArray: # new in 1.63
+  Enabled: true
+Style/MapToHash: # new in 1.24
+  Enabled: true
+Style/MapToSet: # new in 1.42
+  Enabled: true
+Style/MinMaxComparison: # new in 1.42
+  Enabled: true
+Style/MultilineInPatternThen: # new in 1.16
+  Enabled: true
+Style/NestedFileDirname: # new in 1.26
+  Enabled: true
+Style/NumberedParameters: # new in 1.22
+  Enabled: true
+Style/NumberedParametersLimit: # new in 1.22
+  Enabled: true
+Style/ObjectThen: # new in 1.28
+  Enabled: true
+Style/OpenStructUse: # new in 1.23
+  Enabled: true
+Style/OperatorMethodCall: # new in 1.37
+  Enabled: true
+Style/QuotedSymbols: # new in 1.16
+  Enabled: true
+Style/RedundantArrayConstructor: # new in 1.52
+  Enabled: true
+Style/RedundantArrayFlatten: # new in 1.76
+  Enabled: true
+Style/RedundantConstantBase: # new in 1.40
+  Enabled: true
+Style/RedundantCurrentDirectoryInPath: # new in 1.53
+  Enabled: true
+Style/RedundantDoubleSplatHashBraces: # new in 1.41
+  Enabled: true
+Style/RedundantEach: # new in 1.38
+  Enabled: true
+Style/RedundantFilterChain: # new in 1.52
+  Enabled: true
+Style/RedundantFormat: # new in 1.72
+  Enabled: true
+Style/RedundantHeredocDelimiterQuotes: # new in 1.45
+  Enabled: true
+Style/RedundantInitialize: # new in 1.27
+  Enabled: true
+Style/RedundantInterpolationUnfreeze: # new in 1.66
+  Enabled: true
+Style/RedundantLineContinuation: # new in 1.49
+  Enabled: true
+Style/RedundantRegexpArgument: # new in 1.53
+  Enabled: true
+Style/RedundantRegexpConstructor: # new in 1.52
+  Enabled: true
+Style/RedundantSelfAssignmentBranch: # new in 1.19
+  Enabled: true
+Style/RedundantStringEscape: # new in 1.37
+  Enabled: true
+Style/ReturnNilInPredicateMethodDefinition: # new in 1.53
+  Enabled: true
+Style/SafeNavigationChainLength: # new in 1.68
+  Enabled: true
+Style/SelectByRegexp: # new in 1.22
+  Enabled: true
+Style/SendWithLiteralMethodName: # new in 1.64
+  Enabled: true
+Style/SingleLineDoEndBlock: # new in 1.57
+  Enabled: true
+Style/StringChars: # new in 1.12
+  Enabled: true
+Style/SuperArguments: # new in 1.64
+  Enabled: true
+Style/SuperWithArgsParentheses: # new in 1.58
+  Enabled: true
+Style/YAMLFileRead: # new in 1.53
+  Enabled: true

data/CHANGES.md

@@ -1,3 +1,8 @@
+# 0.3.2 (2025-07-23)
+
+- Update to support Ruby 3.3+.
+- Update Rubocop & style changes.
+
 # 0.3.1 (2022-01-26)
 
 - Fixes issue where `MARC::XMLReader#new` and `MARC::XMLReader#read` would

data/Dockerfile

@@ -1,7 +1,7 @@
 # =============================================================================
 # Target: base
 
-FROM ruby:2.7-alpine AS base
+FROM ruby:3.3-alpine AS base
 
 RUN apk --no-cache --update upgrade && \
     apk --no-cache add \
@@ -12,6 +12,7 @@ RUN apk --no-cache --update upgrade && \
         openssl \
         tzdata \
         xz-libs \
+        yaml-dev \
     && rm -rf /var/cache/apk/*
 
 WORKDIR /opt/app
@@ -29,8 +30,8 @@ RUN apk --update --no-cache add \
         git \
     && rm -rf /var/cache/apk/*
 
-# The base image ships bundler 1.17.2, but we want something more recent
-RUN gem install bundler -v 2.1.4
+# The base image ships an older bundler, so we want something more recent
+RUN gem install bundler -v 2.5.22
 
 # Copy codebase to WORKDIR. Unlike application projects, for a gem project
 # we need to do this before running `bundle install`, in order for the gem
@@ -54,4 +55,4 @@ COPY --from=development /usr/local/bundle /usr/local/bundle
 RUN bundle config set deployment 'true'
 RUN bundle install --local --path=/usr/local/bundle
 
-CMD ['bundle', 'exec', 'rake']
+CMD ["bundle", "exec", "rake"]

data/README.md

@@ -1,7 +1,21 @@
 # BerkeleyLibrary::Marc
 
 [![Build Status](https://github.com/BerkeleyLibrary/marc/actions/workflows/build.yml/badge.svg?branch=main)](https://github.com/BerkeleyLibrary/marc/actions/workflows/build.yml)
-[![Gem Version](https://img.shields.io/gem/v/berkeley_library-marc.svg)](https://github.com/BerkeleyLibrary/marc/releases)
+[![Gem Version](https://img.shields.io/gem/v/berkeley_library-marc.svg)](https://rubygems.org/gems/berkeley_library-marc)
 
 MARC-related utility code and opinionated extensions to [ruby-marc](https://github.com/ruby-marc/ruby-marc)
 for the UC Berkeley Library.
+
+## Installation
+
+In your Gemfile:
+
+```ruby
+gem 'berkeley_library-marc'
+```
+
+In your code:
+
+```ruby
+require 'berkeley_library/marc'
+```

data/berkeley_library-marc.gemspec

@@ -2,14 +2,14 @@ File.expand_path('lib', __dir__).tap do |lib|
   $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 end
 
-ruby_version = '>= 2.7'
+ruby_version = '~> 3.3'
 
 require 'berkeley_library/marc/module_info'
 
 Gem::Specification.new do |spec|
   spec.name = BerkeleyLibrary::Marc::ModuleInfo::NAME
-  spec.author = BerkeleyLibrary::Marc::ModuleInfo::AUTHOR
-  spec.email = BerkeleyLibrary::Marc::ModuleInfo::AUTHOR_EMAIL
+  spec.author = BerkeleyLibrary::Marc::ModuleInfo::AUTHORS
+  spec.email = BerkeleyLibrary::Marc::ModuleInfo::AUTHOR_EMAILS
   spec.summary = BerkeleyLibrary::Marc::ModuleInfo::SUMMARY
   spec.description = BerkeleyLibrary::Marc::ModuleInfo::DESCRIPTION
   spec.license = BerkeleyLibrary::Marc::ModuleInfo::LICENSE
@@ -17,7 +17,6 @@ Gem::Specification.new do |spec|
   spec.homepage = BerkeleyLibrary::Marc::ModuleInfo::HOMEPAGE
 
   spec.files = `git ls-files -z`.split("\x0")
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
   spec.required_ruby_version = ruby_version
@@ -30,15 +29,16 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'ci_reporter_rspec', '~> 1.0'
   spec.add_development_dependency 'colorize', '~> 0.8'
   spec.add_development_dependency 'dotenv', '~> 2.7'
-  spec.add_development_dependency 'listen', '>= 3.0.5', '< 3.2'
+  spec.add_development_dependency 'listen', '~> 3.2'
   spec.add_development_dependency 'nokogiri', '~> 1.13'
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '~> 3.10'
-  spec.add_development_dependency 'rubocop', '= 1.11'
-  spec.add_development_dependency 'rubocop-rake', '~> 0.5'
-  spec.add_development_dependency 'rubocop-rspec', '~> 2.2'
-  spec.add_development_dependency 'ruby-prof', '~> 0.17.0'
+  spec.add_development_dependency 'rubocop', '~> 1.78.0'
+  spec.add_development_dependency 'rubocop-rake', '~> 0.7.0'
+  spec.add_development_dependency 'rubocop-rspec', '~> 3.6.0'
+  spec.add_development_dependency 'ruby-prof'
   spec.add_development_dependency 'simplecov', '~> 0.21'
   spec.add_development_dependency 'simplecov-rcov', '~> 0.2'
   spec.add_development_dependency 'yard', '~> 0.9.27'
+  spec.metadata['rubygems_mfa_required'] = 'true'
 end

data/lib/berkeley_library/marc/field_info/var_fields/obsolescible.rb

@@ -12,7 +12,7 @@ module BerkeleyLibrary
           # it as obsolete, false otherwise
           # @return [Boolean] true if obsolete, false otherwise
           def obsolete?
-            return unless respond_to?(:desc)
+            return false unless respond_to?(:desc)
 
             desc&.include?(OBSOLETE)
           end

data/lib/berkeley_library/marc/field_info/var_fields/subfield_def.rb

@@ -43,7 +43,7 @@ module BerkeleyLibrary
           # see Object#to_s
           def to_s
             lines = ["$#{code_str} - #{desc}"]
-            values.each { |v| lines << INDENT + v.to_s }
+            values.each { |v| lines << (INDENT + v.to_s) }
             lines.join("\n")
           end
 

data/lib/berkeley_library/marc/field_info/var_fields/var_field_def.rb

@@ -51,10 +51,10 @@ module BerkeleyLibrary
           def concat_indented(blocks, values, header)
             return if values.empty?
 
-            blocks << INDENT + header
+            blocks << (INDENT + header)
             values.each do |v|
               lines = v.to_s.lines(chomp: true)
-              lines.each { |line| blocks << INDENT + INDENT + line }
+              lines.each { |line| blocks << (INDENT + INDENT + line) }
             end
           end
 

data/lib/berkeley_library/marc/module_info.rb

@@ -9,10 +9,10 @@ module BerkeleyLibrary
       NAME = 'berkeley_library-marc'.freeze
 
       # The author
-      AUTHOR = 'David Moles'.freeze
+      AUTHORS = ['David Moles', 'maría a. matienzo'].freeze
 
       # Author contact email
-      AUTHOR_EMAIL = 'dmoles@berkeley.edu'.freeze
+      AUTHOR_EMAILS = ['dmoles@berkeley.edu', 'matienzo@berkeley.edu'].freeze
 
       # Gem summary
       SUMMARY = 'MARC utilities for the UC Berkeley Library'.freeze
@@ -24,7 +24,7 @@ module BerkeleyLibrary
       LICENSE = 'MIT'.freeze
 
       # Gem version
-      VERSION = '0.3.1'.freeze
+      VERSION = '0.3.2'.freeze
 
       # Gem homepage
       HOMEPAGE = 'https://github.com/BerkeleyLibrary/marc'.freeze

data/lib/marc_extensions/field_map.rb

@@ -44,10 +44,10 @@ module MARCExtensions
 
     def indices_for(tags)
       sorted_tag_array(tags || tag_list)
-        .lazy                                      # prevent unnecessary allocations
-        .map { |t| @tags[t] }                      # get indices for each tag
-        .reject(&:nil?)                            # ignoring any tags we don't have fields for
-        .flat_map { |x| x }                        # flatten list of indices -- equiv. Array#flatten
+        .lazy                 # prevent unnecessary allocations
+        .map { |t| @tags[t] } # get indices for each tag
+        .compact              # ignoring any tags we don't have fields for
+        .flat_map { |x| x }   # flatten list of indices -- equiv. Array#flatten
     end
 
     def sorted_tag_array(tags)

data/lib/marc_extensions/record.rb

@@ -88,14 +88,14 @@ module MARCExtensions
     # Whether this record, its fields, and leader are all frozen.
     # @return [Boolean] true if the fields and leader are frozen
     def frozen?
-      (fields.frozen? && leader.frozen?) && super
+      fields.frozen? && leader.frozen? && super
     end
 
     # Returns the canonical ID from the 001 control field.
     # @return [String, nil] the 001 control field value, or nil if not present
     def record_id
       cf_001 = self['001']
-      return cf_001.value if cf_001
+      cf_001.value if cf_001
     end
 
     # Apply the provided [MARCSpec](http://marcspec.github.io/MARCspec/marc-spec.html)

data/rakelib/.rubocop.yml

@@ -0,0 +1,5 @@
+inherit_from: ../.rubocop.yml
+
+plugins:
+  - rubocop-rake
+  

data/spec/.rubocop.yml

@@ -1,5 +1,8 @@
 inherit_from: ../.rubocop.yml
 
+plugins:
+  - rubocop-rspec
+
 AllCops:
   # Exclude generated files
   Exclude:
@@ -29,6 +32,24 @@ Metrics/ModuleLength:
 Metrics/MethodLength:
   Enabled: false
 
+RSpec/ExampleLength:
+  Exclude:
+    - 'berkeley_library/marc/field_info/**/*.rb'
+    - 'marc_extensions/*.rb'
+
+RSpec/RepeatedExampleGroupDescription:
+  Exclude:
+    - 'berkeley_library/marc/field_info/**/*.rb'
+
+RSpec/MultipleExpectations:
+  Exclude:
+    - 'berkeley_library/marc/field_info/**/*.rb'
+    - 'marc_extensions/*.rb'
+
+RSpec/SpecFilePathFormat:
+  Exclude:
+    - 'marc_extensions/*.rb'
+
 ############################################################
 # Added in Rubocop 0.89
 

data/spec/berkeley_library/marc/field_info/var_fields/var_field_def_spec.rb

@@ -6,7 +6,7 @@ module BerkeleyLibrary
       module VarFields
         describe VarFieldDef do
           describe 'to_s' do
-            let(:fields) { %w[046 048].map { |t| [t, VarFields.standard.find { |vf| vf.tag == t }] }.to_h }
+            let(:fields) { %w[046 048].to_h { |t| [t, VarFields.standard.find { |vf| vf.tag == t }] } }
 
             it 'returns something like an EBCDList' do
               aggregate_failures('to_s') do

data/spec/berkeley_library/marc/field_info/var_fields/var_field_parser_spec.rb

@@ -8,10 +8,10 @@ module BerkeleyLibrary
     module FieldInfo
       module VarFields
         describe VarFieldParser do
-          let(:parser) { VarFieldParser.new }
+          let(:parser) { described_class.new }
           let(:printable_chars) { [0x21..0x3f, 0x5b..0x7b, 0x7d..0x7e].map(&:to_a).flatten.map { |cp| cp.chr(Encoding::UTF_8) } }
 
-          describe(:blank) do
+          describe '#blank' do
             it 'matches space' do
               expect(parser.blank).to parse(' ', trace: true)
             end
@@ -21,7 +21,7 @@ module BerkeleyLibrary
             end
           end
 
-          describe(:printable) do
+          describe '#printable' do
             it 'matches space' do
               expect(parser.printable).to parse(' ', trace: true)
             end
@@ -42,7 +42,7 @@ module BerkeleyLibrary
             end
           end
 
-          describe(:text) do
+          describe '#text' do
             it 'matches text' do
               expect(parser.text).to parse('Undefined', trace: true)
             end
@@ -61,7 +61,7 @@ module BerkeleyLibrary
             end
           end
 
-          describe(:ln_br) do
+          describe '#ln_br' do
             it 'matches a Windows line break' do
               expect(parser.ln_br).to parse("\r\n", trace: true)
             end
@@ -74,7 +74,7 @@ module BerkeleyLibrary
             end
           end
 
-          describe(:eol) do
+          describe '#eol' do
             it 'matches a newline' do
               expect(parser.eol).to parse("\n", trace: true)
             end
@@ -84,13 +84,13 @@ module BerkeleyLibrary
             end
           end
 
-          describe(:text) do
+          describe '#text' do
             it 'matches an ASCII printable sequence' do
               expect(parser.text).to parse(printable_chars.join, trace: true)
             end
           end
 
-          describe(:comment) do
+          describe '#comment' do
             it 'matches a comment' do
               expect(parser.comment).to parse('// this is a comment', trace: true)
             end
@@ -100,7 +100,7 @@ module BerkeleyLibrary
             end
           end
 
-          describe(:nc) do
+          describe '#nc' do
             it 'matches a comment' do
               expect(parser.nc).to parse('// this is a comment', trace: true)
             end
@@ -138,7 +138,7 @@ module BerkeleyLibrary
             end
           end
 
-          describe(:ind_def) do
+          describe '#ind_def' do
             it 'parses an indicator definition' do
               ind_def = '0 - No added entry'
               expect(parser.ind_def).to parse(ind_def, trace: true)
@@ -155,7 +155,7 @@ module BerkeleyLibrary
             end
           end
 
-          describe(:indicators) do
+          describe '#indicators' do
             it 'matches an empty indicator definition' do
               ind_def = <<~TXT.strip
                 Indicators
@@ -240,7 +240,7 @@ module BerkeleyLibrary
             end
           end
 
-          describe(:subfield_value) do
+          describe '#subfield_value' do
             it 'parses a single-character value' do
               expect(parser.subfield_value).to parse('1 - Form of name', trace: true)
             end
@@ -250,7 +250,7 @@ module BerkeleyLibrary
             end
           end
 
-          describe(:subfield_def) do
+          describe '#subfield_def' do
             it 'parses a subfield code definition without values' do
               subfield_def = '$4 - Relationship (R)'
               expect(parser.subfield_def).to parse(subfield_def, trace: true)
@@ -276,7 +276,7 @@ module BerkeleyLibrary
             end
           end
 
-          describe(:subfield_codes) do
+          describe '#subfield_codes' do
             it 'parses a typical set of subfield codes' do
               subfield_codes = <<~TXT.strip
                 Subfield Codes
@@ -315,7 +315,7 @@ module BerkeleyLibrary
             end
           end
 
-          describe(:ivc_def) do
+          describe '#ivc_def' do
             it 'parses instrument or voices codes' do
               ivc_def = <<~TXT.strip
                 Instrument or Voices Codes
@@ -328,7 +328,7 @@ module BerkeleyLibrary
             end
           end
 
-          describe(:vf) do
+          describe '#vf' do
             it 'parses a typical field' do
               vf = <<~TXT.strip
                 886 - FOREIGN MARC INFORMATION FIELD (R)
@@ -396,13 +396,13 @@ module BerkeleyLibrary
             end
           end
 
-          describe(:section_header) do
+          describe '#section_header' do
             it 'matches a section header' do
               expect(parser.section_header).to parse('--Number and Code Fields (01X-04X)--', trace: true)
             end
           end
 
-          describe(:section) do
+          describe '#section' do
             it 'matches a section with header' do
               section = <<~TXT.strip
                 --Number and Code Fields (01X-04X)--
@@ -460,7 +460,7 @@ module BerkeleyLibrary
             end
           end
 
-          describe(:list) do
+          describe '#list' do
             it 'parses multiple sections' do
               sections = <<~TXT.strip
                 --Number and Code Fields (01X-04X)--
@@ -510,7 +510,7 @@ module BerkeleyLibrary
 
           end
 
-          describe(:parse) do
+          describe '#parse' do
             it 'parses the standard list' do
               list = File.read(VarFields::PATH_STANDARD)
               expect(parser).to parse(list, trace: true)

data/spec/berkeley_library/marc/field_info/var_fields/var_field_transform_spec.rb

@@ -127,7 +127,7 @@ module BerkeleyLibrary
               ]
             }
           end
-          let(:xform) { VarFieldTransform.new }
+          let(:xform) { described_class.new }
 
           it 'transforms a comment' do
             comment = { comment: 'A doc comment' }

data/spec/berkeley_library/marc/field_info/var_fields_spec.rb

@@ -6,8 +6,8 @@ module BerkeleyLibrary
     module FieldInfo
       describe VarFields do
 
-        describe :standard do
-          let(:standard) { VarFields.standard }
+        describe '#standard' do
+          let(:standard) { described_class.standard }
 
           it 'loads all standard fields' do
             expect(standard).to be_a(VarFields::VarFieldList)
@@ -59,7 +59,7 @@ module BerkeleyLibrary
           end
 
           it 'returns obsolete fields with a flag' do
-            lines_actual = VarFields.standard(obsolete: true).to_s.lines(chomp: true).map(&:strip)
+            lines_actual = described_class.standard(obsolete: true).to_s.lines(chomp: true).map(&:strip)
 
             var_fields_standard_txt = File.read('lib/berkeley_library/marc/field_info/var_fields/data/var_fields_standard.txt')
             lines_expected = var_fields_standard_txt
@@ -70,7 +70,7 @@ module BerkeleyLibrary
             expect(lines_actual.size).to eq(lines_expected.size)
             lines_expected.each_with_index do |l_ex, i|
               # typo in standard.txt definition of 880 subfields
-              l_ex = l_ex.sub('Same', '- Same') if i >= 5052 && i <= 5056
+              l_ex = l_ex.sub('Same', '- Same') if i.between?(5052, 5056)
               expect(lines_actual[i]).to eq(l_ex), "Wrong value at line #{i}:\n\texpected: #{l_ex}, actual: #{lines_actual[i]}"
             end
           end
@@ -78,7 +78,7 @@ module BerkeleyLibrary
       end
 
       describe 'custom fields' do
-        describe :berkeley_9xx do
+        describe '#berkeley_9xx' do
           let(:berkeley_9xx) { VarFields.berkeley_9xx }
 
           it 'loads all berkeley_9xx fields' do
@@ -88,7 +88,8 @@ module BerkeleyLibrary
         end
 
         # TODO: get these working
-        xdescribe :tind_reserved do
+        # rubocop:disable RSpec/PendingWithoutReason
+        xdescribe '#tind_reserved' do
           let(:tind_reserved) { VarFields.tind_reserved }
 
           it 'loads all tind_reserved fields' do
@@ -97,7 +98,7 @@ module BerkeleyLibrary
           end
         end
 
-        xdescribe :berkeley_tind do
+        xdescribe '#berkeley_tind' do
           let(:berkeley_tind) { VarFields.berkeley_tind }
 
           it 'loads all berkeley_tind fields' do
@@ -105,6 +106,7 @@ module BerkeleyLibrary
             expect(berkeley_tind.size).to eq(9) # TODO: more assertions
           end
         end
+        # rubocop:enable RSpec/PendingWithoutReason
 
       end
     end

data/spec/marc_extensions/data_field_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe MARC::DataField do
   let(:marc_record) { MARC::XMLReader.read('spec/data/record-187888.xml').first }
 
-  describe :subfield_codes do
+  describe '#subfield_codes' do
     it 'returns the subfield codes in order' do
       expected_codes = %w[y 9 s u]
 

data/spec/marc_extensions/record_spec.rb

@@ -3,13 +3,13 @@ require 'spec_helper'
 describe MARC::Record do
   let(:marc_record) { MARC::XMLReader.read('spec/data/record-187888.xml').first }
 
-  describe :record_id do
+  describe '#record_id' do
     it 'returns the 001 control field value, if present' do
       expect(marc_record.record_id).to eq('187888')
     end
   end
 
-  describe :freeze do
+  describe '#freeze' do
     it 'freezes the fields' do
       expect(marc_record.fields).not_to be_frozen # just to be sure
       marc_record.freeze
@@ -22,11 +22,9 @@ describe MARC::Record do
       expect(marc_record.leader).to be_frozen
     end
 
-    it 'freezes the fields' do
+    it 'freezes each field' do
       marc_record.freeze
-      marc_record.fields.each do |df|
-        expect(df).to be_frozen
-      end
+      expect(marc_record.fields).to all(be_frozen)
     end
 
     it 'does not clobber the data' do
@@ -36,7 +34,7 @@ describe MARC::Record do
     end
   end
 
-  describe :data_fields do
+  describe '#data_fields' do
     it 'returns only the data fields' do
       expected_tags = %w[024 035 245 336 505 505 505 505 505 505 540 852 856 856 901 902 902 980 982 991]
       dff = marc_record.data_fields
@@ -73,7 +71,7 @@ describe MARC::Record do
     end
   end
 
-  describe :each_data_field do
+  describe '#each_data_field' do
     it 'returns only the data fields, in order' do
       each_data_field = marc_record.each_data_field
       expect(each_data_field.to_a).to eq(marc_record.data_fields)
@@ -103,7 +101,7 @@ describe MARC::Record do
     end
   end
 
-  describe :each_sorted_by_tag do
+  describe '#each_sorted_by_tag' do
     let(:tags) do
       %w[856 852] # NOTE: not sorted
     end
@@ -144,7 +142,7 @@ describe MARC::Record do
     end
   end
 
-  describe :data_fields_by_tag do
+  describe '#data_fields_by_tag' do
     it 'groups fields by tag' do
       fields = marc_record.fields
 
@@ -172,7 +170,7 @@ describe MARC::Record do
       end
     end
 
-    describe :each_sorted_by_tag do
+    describe '#each_sorted_by_tag' do
       it 'returns all tags if not passed a tag list' do
         fields = marc_record.fields
 
@@ -186,7 +184,7 @@ describe MARC::Record do
     end
   end
 
-  describe :each_control_field do
+  describe '#each_control_field' do
     it 'returns only the control fields' do
       expected_tags = %w[001 005]
       cff = marc_record.each_control_field.to_a
@@ -205,7 +203,7 @@ describe MARC::Record do
     end
   end
 
-  describe :spec do
+  describe '#spec' do
     it 'returns the results of a MARCSpec query' do
       query_str = '856$u{$y~\2}'
 

data/spec/marc_extensions/xml_reader_spec.rb

@@ -1,50 +1,46 @@
 require 'spec_helper'
 
 module MARC
+  # rubocop:disable RSpec/RepeatedExample,RSpec/MultipleExpectations
   describe XMLReader do
     let(:infile_path) { 'spec/data/record-187888.xml' }
-    describe :new do
+
+    describe '#new' do
       # not our first choice, but it's the ruby-marc default behavior
       it 'returns a REXMLParser by default' do
-        reader = XMLReader.new(infile_path)
+        reader = described_class.new(infile_path)
         expect(reader).to be_a(REXMLReader)
       end
 
       it 'works with Nokogiri' do
-        reader = XMLReader.new(infile_path, { parser: 'nokogiri' })
+        reader = described_class.new(infile_path, { parser: 'nokogiri' })
         expect(reader).to be_a(NokogiriReader)
       end
 
       it 'accepts a hash of options' do
-        reader = XMLReader.new(infile_path, { parser: 'nokogiri', freeze: true })
+        reader = described_class.new(infile_path, { parser: 'nokogiri', freeze: true })
         expect(reader).to be_a(NokogiriReader)
-        expect(reader.instance_variable_get(:@freeze)).to eq(true)
+        expect(reader.instance_variable_get(:@freeze)).to be(true)
       end
 
       it 'accepts keyword arguments' do
-        reader = XMLReader.new(infile_path, parser: 'nokogiri', freeze: true)
-        expect(reader).to be_a(NokogiriReader)
-        expect(reader.instance_variable_get(:@freeze)).to eq(true)
-      end
-
-      it 'accepts a hash of options' do
-        reader = XMLReader.new(infile_path, { parser: 'nokogiri', freeze: true })
+        reader = described_class.new(infile_path, parser: 'nokogiri', freeze: true)
         expect(reader).to be_a(NokogiriReader)
-        expect(reader.instance_variable_get(:@freeze)).to eq(true)
+        expect(reader.instance_variable_get(:@freeze)).to be(true)
       end
     end
 
-    describe :read do
+    describe '#read' do
       it 'reads a file' do
-        reader = XMLReader.read(infile_path)
-        expect(reader).to be_a(MARC::XMLReader)
+        reader = described_class.read(infile_path)
+        expect(reader).to be_a(described_class)
         record = reader.first
         expect(record).to be_a(MARC::Record)
       end
 
       describe 'freeze: true' do
         it 'works with REXML' do
-          reader = XMLReader.read(infile_path, { parser: 'rexml', freeze: true })
+          reader = described_class.read(infile_path, { parser: 'rexml', freeze: true })
           expect(reader).to be_a(MARC::REXMLReader)
           record = reader.first
           expect(record).to be_a(MARC::Record)
@@ -52,7 +48,7 @@ module MARC
         end
 
         it 'works with Nokogiri' do
-          reader = XMLReader.read(infile_path, { parser: 'nokogiri', freeze: true })
+          reader = described_class.read(infile_path, { parser: 'nokogiri', freeze: true })
           expect(reader).to be_a(MARC::NokogiriReader)
           record = reader.first
           expect(record).to be_a(MARC::Record)
@@ -62,4 +58,5 @@ module MARC
 
     end
   end
+  # rubocop:enable RSpec/RepeatedExample,RSpec/MultipleExpectations
 end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: berkeley_library-marc
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - David Moles
+- maría a. matienzo
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-01-26 00:00:00.000000000 Z
+date: 2025-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: marc
@@ -112,20 +113,14 @@ dependencies:
   name: listen
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.0.5
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.0.5
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
 - !ruby/object:Gem::Dependency
@@ -174,58 +169,58 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: 1.78.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: 1.78.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: 0.7.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: 0.7.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: 3.6.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: 3.6.0
 - !ruby/object:Gem::Dependency
   name: ruby-prof
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.17.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.17.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -270,12 +265,15 @@ dependencies:
         version: 0.9.27
 description: A gem providing MARC-related utility code and extensions to ruby-marc
   for the UC Berkeley Library
-email: dmoles@berkeley.edu
+email:
+- dmoles@berkeley.edu
+- matienzo@berkeley.edu
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".github/workflows/build.yml"
+- ".github/workflows/gem-push.yml"
 - ".gitignore"
 - ".idea/inspectionProfiles/Project_Default.xml"
 - ".idea/marc.iml"
@@ -329,6 +327,7 @@ files:
 - lib/marc_extensions/record.rb
 - lib/marc_extensions/subfield.rb
 - lib/marc_extensions/xml_reader.rb
+- rakelib/.rubocop.yml
 - rakelib/bundle.rake
 - rakelib/coverage.rake
 - rakelib/gem.rake
@@ -349,36 +348,25 @@ files:
 homepage: https://github.com/BerkeleyLibrary/marc
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: MARC utilities for the UC Berkeley Library
-test_files:
-- spec/.rubocop.yml
-- spec/berkeley_library/marc/field_info/var_fields/var_field_def_spec.rb
-- spec/berkeley_library/marc/field_info/var_fields/var_field_parser_spec.rb
-- spec/berkeley_library/marc/field_info/var_fields/var_field_transform_spec.rb
-- spec/berkeley_library/marc/field_info/var_fields_spec.rb
-- spec/data/field_info/vf_046.txt
-- spec/data/field_info/vf_048.txt
-- spec/data/record-187888.xml
-- spec/marc_extensions/data_field_spec.rb
-- spec/marc_extensions/record_spec.rb
-- spec/marc_extensions/xml_reader_spec.rb
-- spec/spec_helper.rb
+test_files: []