berkeley_library-alma 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 581717a54a7d13196acbf99d46db7c2e24931038a144994b9a262097efa3aae1
-  data.tar.gz: 3d9aad321ac4dcb7ee392c2ffb509a53c143936ae8256c758de0689a40c5be60
+  metadata.gz: 16a46868b570b1ebae5581407ffa071c63ea95a2d1c31d0a422fa89f2dd359df
+  data.tar.gz: 5e1106e53a671ffa3ae695cdb8ebff1b61c5f965642fbc66d8e95fd0affaabd3
 SHA512:
-  metadata.gz: fd8d67af487bac3d335a672d538fe72289a08e9abe470f560c3af5157a5724acd2619937b3e35dc802811a33e7181719516eece6a9c894ecfb1e38899ff6fe0f
-  data.tar.gz: 7f3d90e3777dd0b129931a7a919366afbb0db0fbb6ca4d5aa331c4be42c925f8ffc0d9b31f3b05bfcf4957c61afd343f3d496697ff10a979fb3b75c2c8f6db50
+  metadata.gz: 801e395bcffaa40afa629c8449b0d9e2c3d2ee31751b6f09698e3531eb96db9b5c45cdb5794ea74aee1665e67c6713190161b0a6f064f20eceec5c0275ab1756
+  data.tar.gz: 1636e32d6c5cff6ecf7c5d4ac923463905190fb2a221a7c37b8a05da9c294d31a0790ee0d955e0b956f32ff37ba1594bf80a5f172db80d62a76baadc8d24f474

data/.idea/alma.iml

@@ -23,7 +23,7 @@
     <orderEntry type="library" scope="PROVIDED" name="berkeley_library-util (v0.1.1, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="builder (v3.2.4, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="bundle-audit (v0.1.0, RVM: ruby-2.7.5) [gem]" level="application" />
-    <orderEntry type="library" scope="PROVIDED" name="bundler (v2.2.31, RVM: ruby-2.7.5) [gem]" level="application" />
+    <orderEntry type="library" scope="PROVIDED" name="bundler (v2.1.4, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="bundler-audit (v0.9.0.1, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="ci_reporter (v2.0.0, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="ci_reporter_rspec (v1.0.0, RVM: ruby-2.7.5) [gem]" level="application" />
@@ -38,7 +38,7 @@
     <orderEntry type="library" scope="PROVIDED" name="hashdiff (v1.0.1, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="http-accept (v1.7.0, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="http-cookie (v1.0.4, RVM: ruby-2.7.5) [gem]" level="application" />
-    <orderEntry type="library" scope="PROVIDED" name="i18n (v1.9.0, RVM: ruby-2.7.5) [gem]" level="application" />
+    <orderEntry type="library" scope="PROVIDED" name="i18n (v1.9.1, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="lograge (v0.11.2, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="loofah (v2.13.0, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="marc (v1.1.1, RVM: ruby-2.7.5) [gem]" level="application" />
@@ -66,16 +66,16 @@
     <orderEntry type="library" scope="PROVIDED" name="request_store (v1.5.1, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="rest-client (v2.1.0, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="rexml (v3.2.5, RVM: ruby-2.7.5) [gem]" level="application" />
-    <orderEntry type="library" scope="PROVIDED" name="rspec (v3.10.0, RVM: ruby-2.7.5) [gem]" level="application" />
-    <orderEntry type="library" scope="PROVIDED" name="rspec-core (v3.10.1, RVM: ruby-2.7.5) [gem]" level="application" />
-    <orderEntry type="library" scope="PROVIDED" name="rspec-expectations (v3.10.2, RVM: ruby-2.7.5) [gem]" level="application" />
-    <orderEntry type="library" scope="PROVIDED" name="rspec-mocks (v3.10.2, RVM: ruby-2.7.5) [gem]" level="application" />
-    <orderEntry type="library" scope="PROVIDED" name="rspec-support (v3.10.3, RVM: ruby-2.7.5) [gem]" level="application" />
+    <orderEntry type="library" scope="PROVIDED" name="rspec (v3.11.0, RVM: ruby-2.7.5) [gem]" level="application" />
+    <orderEntry type="library" scope="PROVIDED" name="rspec-core (v3.11.0, RVM: ruby-2.7.5) [gem]" level="application" />
+    <orderEntry type="library" scope="PROVIDED" name="rspec-expectations (v3.11.0, RVM: ruby-2.7.5) [gem]" level="application" />
+    <orderEntry type="library" scope="PROVIDED" name="rspec-mocks (v3.11.0, RVM: ruby-2.7.5) [gem]" level="application" />
+    <orderEntry type="library" scope="PROVIDED" name="rspec-support (v3.11.0, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="rubocop (v1.11.0, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="rubocop-ast (v1.15.1, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="rubocop-rake (v0.6.0, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="rubocop-rspec (v2.4.0, RVM: ruby-2.7.5) [gem]" level="application" />
-    <orderEntry type="library" scope="PROVIDED" name="ruby-marc-spec (v0.1.1, RVM: ruby-2.7.5) [gem]" level="application" />
+    <orderEntry type="library" scope="PROVIDED" name="ruby-marc-spec (v0.1.3, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="ruby-progressbar (v1.11.0, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="scrub_rb (v1.0.1, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="simplecov (v0.21.2, RVM: ruby-2.7.5) [gem]" level="application" />
@@ -91,7 +91,7 @@
     <orderEntry type="library" scope="PROVIDED" name="webmock (v3.14.0, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="webrick (v1.7.0, RVM: ruby-2.7.5) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="yard (v0.9.27, RVM: ruby-2.7.5) [gem]" level="application" />
-    <orderEntry type="library" scope="PROVIDED" name="zeitwerk (v2.5.3, RVM: ruby-2.7.5) [gem]" level="application" />
+    <orderEntry type="library" scope="PROVIDED" name="zeitwerk (v2.5.4, RVM: ruby-2.7.5) [gem]" level="application" />
   </component>
   <component name="RModuleSettingsStorage">
     <LOAD_PATH number="2" string0="$MODULE_DIR$/lib" string1="$MODULE_DIR$/spec" />
@@ -108,7 +108,7 @@
           </RakeTaskImpl>
           <RakeTaskImpl description="Run all specs in spec directory, with coverage" fullCommand="coverage" id="coverage" />
           <RakeTaskImpl description="Run tests, check test coverage, check code style, check for vulnerabilities, build gem" fullCommand="default" id="default" />
-          <RakeTaskImpl description="Build berkeley_library-alma.gemspec as berkeley_library-alma-0.0.2.gem" fullCommand="gem" id="gem" />
+          <RakeTaskImpl description="Build berkeley_library-alma.gemspec as berkeley_library-alma-0.0.3.gem" fullCommand="gem" id="gem" />
           <RakeTaskImpl description="Run RuboCop with auto-correct, and output results to console" fullCommand="ra" id="ra" />
           <RakeTaskImpl description="Run rubocop with HTML output" fullCommand="rubocop" id="rubocop" />
           <RakeTaskImpl id="rubocop">

data/CHANGES.md

@@ -1,3 +1,10 @@
+# 0.0.4 (15 February 2022)
+
+- adds `BarCode` subclass of `RecordId`, to look up bibliographic records by
+  item barcode. Note that since barcodes have no consistent format, `BarCode`
+  objects need to be constructed deliberately with `BarCode#new`, not with
+  `RecordId#parse`.
+
 # 0.0.3 (3 February 2022)
 
 - use `local_field_996` instead of `other_system_number` when making SRU queries

data/bin/alma-mms-lookup

@@ -25,9 +25,7 @@ require 'berkeley_library/alma'
 # Configuration
 
 # Configure Alma URLs etc.
-BerkeleyLibrary::Alma.configure do
-  Config.default!
-end
+BerkeleyLibrary::Alma::Config.default!
 
 # Set log level
 BerkeleyLibrary::Logging.logger.level = Logger::Severity::WARN

data/lib/berkeley_library/alma/barcode.rb

@@ -0,0 +1,33 @@
+require 'berkeley_library/alma/record_id'
+
+module BerkeleyLibrary
+  module Alma
+    # {RecordId} subclass representing an item barcode.
+    class BarCode
+      include RecordId
+
+      attr_reader :barcode
+
+      # Initialize a barcode. Since we purchase barcodes of varied formats and accept vendor
+      # barcodes as well we are only validating whether it's a string or not.
+      def initialize(barcode)
+        string?(barcode)
+        @barcode = barcode
+      end
+
+      # Returns the SRU query value for this Barcode.
+      #
+      # @return [String] the Barcode query value
+      def sru_query_value
+        "alma.barcode=#{@barcode}"
+      end
+
+      private
+
+      def string?(barcode)
+        raise ArgumentError, "Barcode must be a string: #{barcode.inspect}" unless barcode.is_a?(String)
+      end
+
+    end
+  end
+end

data/lib/berkeley_library/alma/module_info.rb

@@ -7,7 +7,7 @@ module BerkeleyLibrary
       SUMMARY = 'Alma/Primo utilities for the UC Berkeley Library'.freeze
       DESCRIPTION = 'A gem providing Alma/Primo-related utility code for the UC Berkeley Library'.freeze
       LICENSE = 'MIT'.freeze
-      VERSION = '0.0.3'.freeze
+      VERSION = '0.0.4'.freeze
       HOMEPAGE = 'https://github.com/BerkeleyLibrary/alma'.freeze
     end
   end

data/lib/berkeley_library/alma/record_id.rb

@@ -22,6 +22,9 @@ module BerkeleyLibrary
         # also accepts a {RecordId} and simply returns it, so it can be used in
         # situations where it may not be clear whether the ID has already been parsed.
         #
+        # **Note:** Use the {BarCode} class for barcodes, which don't have a consistent
+        # format and hence can't be auto-detected.
+        #
         # @param id [String, RecordId] the ID to parse
         # @return [RecordId, nil] an {MMSID} or {BibNumber}, depending on the type of ID,
         #         or `nil` if the specified `id` is neither an MMS ID nor a bib number

data/spec/data/C084093187-sru.xml

@@ -0,0 +1,299 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?><searchRetrieveResponse xmlns="http://www.loc.gov/zing/srw/">
+  <version>1.2</version>
+  <numberOfRecords>1</numberOfRecords>
+  <records>
+    <record>
+      <recordSchema>marcxml</recordSchema>
+      <recordPacking>xml</recordPacking>
+      <recordData>
+        <record xmlns="http://www.loc.gov/MARC21/slim">
+          <leader>03480cgm a2200781Mi 4500</leader>
+          <controlfield tag="001">991039354509706532</controlfield>
+          <controlfield tag="005">20210615124013.0</controlfield>
+          <controlfield tag="007">vd cvaizs</controlfield>
+          <controlfield tag="008">050601p19971996quc135            vleng d</controlfield>
+          <datafield ind1="1" ind2=" " tag="024">
+            <subfield code="a">774212007033</subfield>
+          </datafield>
+          <datafield ind1="4" ind2="2" tag="028">
+            <subfield code="a">20070</subfield>
+            <subfield code="b">Seville Pictures</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="035">
+            <subfield code="a">(OCoLC)613118288</subfield>
+            <subfield code="z">(OCoLC)800045975</subfield>
+            <subfield code="z">(OCoLC)811619021</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="035">
+            <subfield code="a">(CLU)8266514-ucladb-Voyager</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="035">
+            <subfield code="a">(EXLNZ-01UCS_NETWORK)9912724001006531</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="040">
+            <subfield code="a">W2U</subfield>
+            <subfield code="b">eng</subfield>
+            <subfield code="c">W2U</subfield>
+            <subfield code="d">OCLCF</subfield>
+            <subfield code="d">OCLCO</subfield>
+            <subfield code="d">TOH</subfield>
+            <subfield code="d">GK8</subfield>
+            <subfield code="d">OCL</subfield>
+            <subfield code="d">OCLCQ</subfield>
+            <subfield code="d">OCLCO</subfield>
+            <subfield code="e">rda</subfield>
+            <subfield code="d">CDS</subfield>
+            <subfield code="d">OCLCA</subfield>
+          </datafield>
+          <datafield ind1="1" ind2=" " tag="041">
+            <subfield code="a">eng</subfield>
+            <subfield code="a">fre</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="043">
+            <subfield code="a">n-us---</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="044">
+            <subfield code="a">quc</subfield>
+            <subfield code="a">xxu</subfield>
+            <subfield code="a">fr</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="046">
+            <subfield code="k">1996</subfield>
+          </datafield>
+          <datafield ind1="1" ind2="4" tag="050">
+            <subfield code="a">PN1997</subfield>
+            <subfield code="b">.L735 1997</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="090">
+            <subfield code="b">DVD 3916</subfield>
+            <subfield code="9">LOCAL</subfield>
+          </datafield>
+          <datafield ind1="0" ind2="0" tag="245">
+            <subfield code="a">Lost highway /</subfield>
+            <subfield code="c">October Films presents a CIBY 2000/Asymmetrical production ; a David Lynch film ; produced by Deepak Nayar, Tom Sternberg, Mahy Sweeney ; written by David Lynch &amp; Barry Gifford ; directed by David Lynch.</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="257">
+            <subfield code="a">United States</subfield>
+            <subfield code="a">France</subfield>
+            <subfield code="2">naf</subfield>
+          </datafield>
+          <datafield ind1=" " ind2="1" tag="264">
+            <subfield code="a">[Montreal] :</subfield>
+            <subfield code="b">Seville Pictures,</subfield>
+            <subfield code="c">1997.</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="300">
+            <subfield code="a">1 videodisc (135 min.) :</subfield>
+            <subfield code="b">sound, color ;</subfield>
+            <subfield code="c">4 3/4 in.</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="336">
+            <subfield code="a">two-dimensional moving image</subfield>
+            <subfield code="b">tdi</subfield>
+            <subfield code="2">rdacontent</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="337">
+            <subfield code="a">video</subfield>
+            <subfield code="b">v</subfield>
+            <subfield code="2">rdamedia</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="338">
+            <subfield code="a">videodisc</subfield>
+            <subfield code="b">vd</subfield>
+            <subfield code="2">rdacarrier</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="344">
+            <subfield code="a">digital</subfield>
+            <subfield code="b">optical</subfield>
+            <subfield code="g">stereo</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="346">
+            <subfield code="b">NTSC</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="347">
+            <subfield code="a">video file</subfield>
+            <subfield code="b">DVD video</subfield>
+            <subfield code="e">Region 1</subfield>
+            <subfield code="2">rda</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="380">
+            <subfield code="a">Motion picture</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="500">
+            <subfield code="a">Pan and scan version.</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="500">
+            <subfield code="a">Special features include: theatrical trailer; interactive menus; scene selection.</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="500">
+            <subfield code="a">Originally released as a motion picture in 1996.</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="508">
+            <subfield code="a">Music, Angelo Badalamenti ; editor, Mary Sweeney ; director of photography, Peter Deming.</subfield>
+          </datafield>
+          <datafield ind1="1" ind2=" " tag="511">
+            <subfield code="a">Bill Pullman, Patricia Arquette, Balthazar Getty, Robert Blake, Natasha Gregson Wagner, Gary Busey, Robert Loggia.</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="520">
+            <subfield code="a">A successful jazz musician whose marriage is on the rocks, a man in black who threatens to expose him, a young mechanic with links to a mobster, and the mobster's moll are all riders on the lost highway, trapped in their worlds of desire, destiny and unknown destination where the truth is always a short way further down the road.</subfield>
+          </datafield>
+          <datafield ind1="8" ind2=" " tag="521">
+            <subfield code="a">Canadian home video rating: R.</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="538">
+            <subfield code="a">DVD, Dolby stereo; Region 1; NTSC.</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="546">
+            <subfield code="a">In English or dubbed French.</subfield>
+          </datafield>
+          <datafield ind1=" " ind2="0" tag="650">
+            <subfield code="a">Jazz musicians</subfield>
+            <subfield code="z">United States</subfield>
+            <subfield code="v">Drama.</subfield>
+          </datafield>
+          <datafield ind1=" " ind2="7" tag="650">
+            <subfield code="a">Jazz musicians.</subfield>
+            <subfield code="2">fast</subfield>
+            <subfield code="0">(OCoLC)fst00982205</subfield>
+          </datafield>
+          <datafield ind1=" " ind2="7" tag="651">
+            <subfield code="a">United States.</subfield>
+            <subfield code="2">fast</subfield>
+            <subfield code="0">(OCoLC)fst01204155</subfield>
+          </datafield>
+          <datafield ind1=" " ind2="7" tag="655">
+            <subfield code="a">Drama.</subfield>
+            <subfield code="2">fast</subfield>
+            <subfield code="0">(OCoLC)fst01423879</subfield>
+          </datafield>
+          <datafield ind1=" " ind2="7" tag="655">
+            <subfield code="a">Feature films.</subfield>
+            <subfield code="2">fast</subfield>
+            <subfield code="0">(OCoLC)fst01710384</subfield>
+          </datafield>
+          <datafield ind1=" " ind2="7" tag="655">
+            <subfield code="a">Fiction films.</subfield>
+            <subfield code="2">fast</subfield>
+            <subfield code="0">(OCoLC)fst01710264</subfield>
+          </datafield>
+          <datafield ind1=" " ind2="7" tag="655">
+            <subfield code="a">Feature films.</subfield>
+            <subfield code="2">lcgft</subfield>
+          </datafield>
+          <datafield ind1=" " ind2="7" tag="655">
+            <subfield code="a">Fiction films.</subfield>
+            <subfield code="2">lcgft</subfield>
+          </datafield>
+          <datafield ind1="1" ind2=" " tag="700">
+            <subfield code="a">Pullman, Bill,</subfield>
+            <subfield code="e">actor.</subfield>
+          </datafield>
+          <datafield ind1="1" ind2=" " tag="700">
+            <subfield code="a">Arquette, Patricia,</subfield>
+            <subfield code="d">1968-</subfield>
+            <subfield code="e">actor.</subfield>
+          </datafield>
+          <datafield ind1="1" ind2=" " tag="700">
+            <subfield code="a">Getty, Balthazar,</subfield>
+            <subfield code="e">actor.</subfield>
+          </datafield>
+          <datafield ind1="1" ind2=" " tag="700">
+            <subfield code="a">Blake, Robert,</subfield>
+            <subfield code="d">1933-</subfield>
+            <subfield code="e">actor.</subfield>
+          </datafield>
+          <datafield ind1="1" ind2=" " tag="700">
+            <subfield code="a">Wagner, Natasha Gregson,</subfield>
+            <subfield code="d">1970-</subfield>
+            <subfield code="e">actor.</subfield>
+          </datafield>
+          <datafield ind1="1" ind2=" " tag="700">
+            <subfield code="a">Busey, Gary,</subfield>
+            <subfield code="e">actor.</subfield>
+          </datafield>
+          <datafield ind1="1" ind2=" " tag="700">
+            <subfield code="a">Loggia, Robert,</subfield>
+            <subfield code="e">actor.</subfield>
+          </datafield>
+          <datafield ind1="1" ind2=" " tag="700">
+            <subfield code="a">Nayar, Deepak.</subfield>
+            <subfield code="e">film producer.</subfield>
+          </datafield>
+          <datafield ind1="1" ind2=" " tag="700">
+            <subfield code="a">Sternberg, Tom.</subfield>
+            <subfield code="e">film producer.</subfield>
+          </datafield>
+          <datafield ind1="1" ind2=" " tag="700">
+            <subfield code="a">Sweeney, Mahy.</subfield>
+            <subfield code="e">film produer</subfield>
+          </datafield>
+          <datafield ind1="1" ind2=" " tag="700">
+            <subfield code="a">Lynch, David,</subfield>
+            <subfield code="d">1946-</subfield>
+            <subfield code="e">screenwriter,</subfield>
+            <subfield code="e">director.</subfield>
+          </datafield>
+          <datafield ind1="1" ind2=" " tag="700">
+            <subfield code="a">Gifford, Barry,</subfield>
+            <subfield code="d">1946-</subfield>
+            <subfield code="e">screenwriter.</subfield>
+          </datafield>
+          <datafield ind1="2" ind2=" " tag="710">
+            <subfield code="a">Séville Pictures.</subfield>
+          </datafield>
+          <datafield ind1="2" ind2=" " tag="710">
+            <subfield code="a">Asymmetrical (Firm)</subfield>
+          </datafield>
+          <datafield ind1="2" ind2=" " tag="710">
+            <subfield code="a">CIBY 2000 (Firm)</subfield>
+          </datafield>
+          <datafield ind1="2" ind2=" " tag="710">
+            <subfield code="a">October Films.</subfield>
+          </datafield>
+          <datafield ind1="4" ind2="2" tag="956">
+            <subfield code="z">Credits from Internet Movie Database</subfield>
+            <subfield code="u">http://www.imdb.com/title/tt0116922/</subfield>
+            <subfield code="9">LOCAL</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="968">
+            <subfield code="a">Reclvl: f Addate: 050601 Addid: SMI Moddate: 090214 Modid: MRC</subfield>
+            <subfield code="9">LOCAL</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="996">
+            <subfield code="e">GLADN151847889</subfield>
+            <subfield code="9">LOCAL</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="996">
+            <subfield code="a">b111084751</subfield>
+            <subfield code="b">Updated: 06-14-21</subfield>
+            <subfield code="c">Created: 03-17-09</subfield>
+            <subfield code="d">CatDate: 06-01-05</subfield>
+            <subfield code="9">LOCAL</subfield>
+          </datafield>
+          <datafield ind1=" " ind2=" " tag="AVA">
+            <subfield code="0">991039354509706532</subfield>
+            <subfield code="8">22725145850006532</subfield>
+            <subfield code="a">01UCS_BER</subfield>
+            <subfield code="b">MRC</subfield>
+            <subfield code="c">Media Resources Center</subfield>
+            <subfield code="d">DVD 3916</subfield>
+            <subfield code="e">available</subfield>
+            <subfield code="f">1</subfield>
+            <subfield code="g">0</subfield>
+            <subfield code="i">UCB_Campus</subfield>
+            <subfield code="j">mc</subfield>
+            <subfield code="k">8</subfield>
+            <subfield code="p">1</subfield>
+            <subfield code="q">Media Resources Center</subfield>
+          </datafield>
+        </record>
+      </recordData>
+      <recordIdentifier>991039354509706532</recordIdentifier>
+      <recordPosition>1</recordPosition>
+    </record>
+  </records>
+  <extraResponseData xmlns:xb="http://www.exlibris.com/repository/search/xmlbeans/">
+    <xb:exact>true</xb:exact>
+    <xb:responseDate>2022-02-10T12:40:32-0800</xb:responseDate>
+  </extraResponseData>
+</searchRetrieveResponse>

data/spec/lib/berkeley_library/alma/barcode_spec.rb

@@ -0,0 +1,67 @@
+require 'spec_helper'
+
+module BerkeleyLibrary
+  module Alma
+    describe BarCode do
+      before(:each) do
+        BerkeleyLibrary::Alma.configure do
+          Config.alma_sru_host = 'berkeley.alma.exlibrisgroup.com'
+          Config.alma_institution_code = '01UCS_BER'
+          Config.alma_primo_host = 'search.library.berkeley.edu'
+          Config.alma_permalink_key = 'iqob43'
+        end
+      end
+
+      after(:each) do
+        BerkeleyLibrary::Alma::Config.send(:clear!)
+      end
+
+      describe :new do
+        bad_barcode = 1234
+        it "raises an error for input that's not an string" do
+          expect { BarCode.new(bad_barcode) }.to raise_error(ArgumentError), "#{bad_barcode}: No error raised for #{bad_barcode}"
+        end
+      end
+
+      describe :marc_record do
+        it 'returns the MARC record' do
+          barcode_id = 'C084093187'
+          stub_sru_request('alma.barcode', barcode_id)
+
+          barcode = BerkeleyLibrary::Alma::BarCode.new(barcode_id)
+          marc_record = barcode.get_marc_record
+          expect(marc_record).not_to be_nil
+        end
+
+        it 'returns nil for an empty response' do
+          empty_sru_response = <<~XML.strip
+            <?xml version="1.0" encoding="UTF-8"?>
+            <searchRetrieveResponse>
+              <version>1.2</version>
+              <numberOfRecords>0</numberOfRecords>
+              <records/>
+            </searchRetrieveResponse>
+          XML
+
+          barcode_id = '991054360089706532doesntexist'
+          sru_url = sru_url_for('alma.barcode', barcode_id)
+          stub_request(:get, sru_url).to_return(status: 200, body: empty_sru_response)
+
+          barcode = BarCode.new(barcode_id)
+          marc_record = barcode.get_marc_record
+          expect(marc_record).to be_nil
+        end
+
+        it 'returns nil for an HTTP error response' do
+          barcode_id = '991054360089706532934j3h'
+          sru_url = sru_url_for('alma.barcode', barcode_id)
+          stub_request(:get, sru_url).to_return(status: 404)
+
+          barcode = BarCode.new(barcode_id)
+          marc_record = barcode.get_marc_record
+          expect(marc_record).to be_nil
+        end
+      end
+    end
+  end
+end

data/spec/lib/berkeley_library/alma/bib_number_spec.rb

@@ -90,7 +90,8 @@ module BerkeleyLibrary
       describe :marc_record do
         it 'returns the MARC record' do
           raw_bib_number = 'b11082434'
-          stub_sru_request(raw_bib_number)
+          full_bib_number = 'b110824349'
+          stub_sru_request('alma.local_field_996', full_bib_number)
 
           bib_number = BibNumber.new(raw_bib_number)
           marc_record = bib_number.get_marc_record

data/spec/lib/berkeley_library/alma/mms_id_spec.rb

@@ -58,7 +58,7 @@ module BerkeleyLibrary
       describe :marc_record do
         it 'returns the MARC record' do
           raw_mms_id = '991054360089706532'
-          stub_sru_request(raw_mms_id)
+          stub_sru_request('alma.mms_id', raw_mms_id)
 
           mms_id = MMSID.new(raw_mms_id)
           marc_record = mms_id.get_marc_record
@@ -77,7 +77,7 @@ module BerkeleyLibrary
           XML
 
           raw_mms_id = '991054360089706532'
-          sru_url = sru_url_for(raw_mms_id)
+          sru_url = sru_url_for('alma.mms_id', raw_mms_id)
           stub_request(:get, sru_url).to_return(status: 200, body: empty_sru_response)
 
           mms_id = MMSID.new(raw_mms_id)
@@ -87,7 +87,7 @@ module BerkeleyLibrary
 
         it 'returns nil for an HTTP error response' do
           raw_mms_id = '991054360089706532'
-          sru_url = sru_url_for(raw_mms_id)
+          sru_url = sru_url_for('alma.mms_id', raw_mms_id)
           stub_request(:get, sru_url).to_return(status: 404)
 
           mms_id = MMSID.new(raw_mms_id)

data/spec/spec_helper.rb

@@ -31,26 +31,17 @@ require 'berkeley_library/alma'
 # ------------------------------------------------------------
 # Utility methods
 
-def sru_url_for(record_id)
-  sru_url_base = 'https://berkeley.alma.exlibrisgroup.com/view/sru/01UCS_BER?version=1.2&operation=searchRetrieve&query='
-
-  if BerkeleyLibrary::Alma::Constants::ALMA_RECORD_RE =~ record_id
-    "#{sru_url_base}alma.mms_id%3D#{record_id}"
-  elsif BerkeleyLibrary::Alma::Constants::MILLENNIUM_RECORD_RE =~ record_id
-    full_bib_number = BerkeleyLibrary::Alma::BibNumber.new(record_id).to_s
-    "#{sru_url_base}alma.local_field_996%3D#{full_bib_number}"
-  else
-    raise ArgumentError, "Unknown record ID type: #{record_id}"
-  end
+def sru_url_for(index, value)
+  "https://berkeley.alma.exlibrisgroup.com/view/sru/01UCS_BER?version=1.2&operation=searchRetrieve&query=#{index}%3D#{value}"
 end
 
 def sru_data_path_for(record_id)
   "spec/data/#{record_id}-sru.xml"
 end
 
-def stub_sru_request(record_id)
-  sru_url = sru_url_for(record_id)
-  marc_xml_path = sru_data_path_for(record_id)
+def stub_sru_request(index, value)
+  sru_url_ = sru_url_for(index, value)
+  marc_xml_path = sru_data_path_for(value)
 
-  stub_request(:get, sru_url).to_return(status: 200, body: File.read(marc_xml_path))
+  stub_request(:get, sru_url_).to_return(status: 200, body: File.read(marc_xml_path))
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: berkeley_library-alma
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - David Moles
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-03 00:00:00.000000000 Z
+date: 2022-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: berkeley_library-logging
@@ -269,6 +269,7 @@ files:
 - bin/alma-mms-lookup
 - docker-compose.yml
 - lib/berkeley_library/alma.rb
+- lib/berkeley_library/alma/barcode.rb
 - lib/berkeley_library/alma/bib_number.rb
 - lib/berkeley_library/alma/config.rb
 - lib/berkeley_library/alma/constants.rb
@@ -282,8 +283,10 @@ files:
 - rakelib/spec.rake
 - spec/.rubocop.yml
 - spec/data/991054360089706532-sru.xml
-- spec/data/b11082434-sru.xml
+- spec/data/C084093187-sru.xml
+- spec/data/b110824349-sru.xml
 - spec/data/bibs_with_check_digits.txt
+- spec/lib/berkeley_library/alma/barcode_spec.rb
 - spec/lib/berkeley_library/alma/bib_number_spec.rb
 - spec/lib/berkeley_library/alma/config_spec.rb
 - spec/lib/berkeley_library/alma/mms_id_spec.rb
@@ -315,8 +318,10 @@ summary: Alma/Primo utilities for the UC Berkeley Library
 test_files:
 - spec/.rubocop.yml
 - spec/data/991054360089706532-sru.xml
-- spec/data/b11082434-sru.xml
+- spec/data/C084093187-sru.xml
+- spec/data/b110824349-sru.xml
 - spec/data/bibs_with_check_digits.txt
+- spec/lib/berkeley_library/alma/barcode_spec.rb
 - spec/lib/berkeley_library/alma/bib_number_spec.rb
 - spec/lib/berkeley_library/alma/config_spec.rb
 - spec/lib/berkeley_library/alma/mms_id_spec.rb