benchmark_driver 0.10.2 → 0.10.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 10ccc5d34405f81e882bed9f77adfc6e787dbaeb7d2a5ceed043724b826faeb1
-  data.tar.gz: 8a953719f6ff01c591153bde8aae1f59194c4447357d240596713a95f35c2fee
+  metadata.gz: a01e7df6105386d49b39a54c519f88b35026ed82d58ff9b116a4fdc5efb321e5
+  data.tar.gz: 34dd0f4a146931a01cf0a3f16506a3d077a62a8ae7000f600a6db8a0af507c74
 SHA512:
-  metadata.gz: 42f10df5f1c2e7f4088e8cc9e8558342ecd401e2535e97f29c7a27b7c167db59607ced9adaa6984d287f18536ab2ba90ffd7ef2507a71946155ac21479369774
-  data.tar.gz: c3f168d36de1803de0241cc38da15071d88e6aed39c07b458adffa47a79b401c584e87d147e69df6fa23b2ddf1f36268b484553f94e3672292839b94186e75bb
+  metadata.gz: 01c6b2070e29d77c444d5556aef4412938421fad38e0f54eacd5ad5ec7719bf7d89c697caafc306141694a500f639e1848d279fd585caad1ed5b06e8e0ffa695
+  data.tar.gz: 44e9353d54b7f14532dfd992bb1cf33bf33d8452eb69f90b73e0aaf6d5526402b5369eb2793aa523bf6b23137985052f5a3754ab16d28e31e457ac8c955a8e3b

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# v0.10.3
+
+- Allow specifying name in `--rbenv`
+- Don't print stderr in "command\_stdout" runner
+
 # v0.10.2
 
 - Optionalize `working_directory` of "command\_stdout" runner

data/exe/benchmark-driver

@@ -23,17 +23,20 @@ config = BenchmarkDriver::Config.new.tap do |c|
       abort '--executable must take argument but not given' if e.nil?
       e.split(';').each do |name_path|
         name, path = name_path.split('::', 2)
-        command = (path || name).split(',') # if `::` is not given, regard whole string as path
+        path ||= name # if `::` is not given, regard whole string as path
+        command = path.split(',')
         command[0] = File.expand_path(command[0])
         executables << BenchmarkDriver::Config::Executable.new(name: name, command: command)
       end
     end
     o.on('--rbenv [VERSIONS]', 'Ruby executables in rbenv (x.x.x,arg1,...;y.y.y,arg2,...;...)') do |r|
       abort '--rbenv must take argument but not given' if r.nil?
-      r.split(';').each do |spec|
+      r.split(';').each do |full_spec|
+        name, spec = full_spec.split('::', 2)
+        spec ||= name # if `::` is not given, regard whole string as spec
         version, *args = spec.split(',')
         executables << BenchmarkDriver::Config::Executable.new(
-          name: spec,
+          name: name,
           command: [BenchmarkDriver::Rbenv.ruby_path(version), *args],
         )
       end

data/lib/benchmark_driver/runner/command_stdout.rb

@@ -2,6 +2,7 @@ require 'benchmark_driver/struct'
 require 'benchmark_driver/metrics'
 require 'tempfile'
 require 'shellwords'
+require 'open3'
 
 # Run only once, for testing
 class BenchmarkDriver::Runner::CommandStdout
@@ -91,9 +92,9 @@ class BenchmarkDriver::Runner::CommandStdout
   end
 
   def execute(*args)
-    stdout = IO.popen(args, &:read)
-    unless $?.success?
-      raise "Failed to execute: #{args.shelljoin} (status: #{$?.exitstatus})"
+    stdout, stderr, status = Open3.capture3(*args)
+    unless status.success?
+      raise "Failed to execute: #{args.shelljoin} (status: #{$?.exitstatus}):\n[stdout]:\n#{stdout}\n[stderr]:\n#{stderr}"
     end
     stdout
   end

data/lib/benchmark_driver/version.rb

@@ -1,3 +1,3 @@
 module BenchmarkDriver
-  VERSION = '0.10.2'
+  VERSION = '0.10.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: benchmark_driver
 version: !ruby/object:Gem::Version
-  version: 0.10.2
+  version: 0.10.3
 platform: ruby
 authors:
 - Takashi Kokubun