belt 0.6.8 → 0.6.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c8fdcdc85f77c9538860db16ba868045f1a4482487ce7cfbf6b3e1921e9c793
-  data.tar.gz: 996b9b570963202a4b9acde7fdaa4e83550606a7e6ba9ba89cf20dabff1c5cf7
+  metadata.gz: d7f8eec96efe780f5d58b8242c0f2c4a8d6dc0e46f53e4484d1b10072ab059aa
+  data.tar.gz: a065c3fbd7b2a5ada177a4b516a07314408988c53e498e302e88b0903c01029c
 SHA512:
-  metadata.gz: 3dbbf13ab635583594d630355888e2197f8a07052348eee39f47a1c328fba39392df21c88f12a8ab34252de920ecf711ba1915785de606a527afc79299ed69e8
-  data.tar.gz: e2f3a01545969526003d72e5c0b486e412c852ef8f6cdd6220ad92be5c6771dba8e0e3f5a1880ed691c72ad9e27a5e0caf11a2916717fcdf74c6e81fe05e871b
+  metadata.gz: 3aca3754425f363160d92b60b9385a8b3efaada2a4182e059361acf42e6763001ee9f53834386705e5b638a54c32e2608025f154a284e3280053de096558f99e
+  data.tar.gz: 4c314ee70436b6fd009493051349e83e2986956d0e42f7cf22d3a55461ad7f05024aecc7901428da8873fba8d1e0c5c03bf6559763a098c4822b3dadec105945

data/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Changelog
 
+## 0.6.9
+
+### Fixed
+
+- **`belt deploy` no longer hangs forever on an interactive terraform prompt.**
+  `run_terraform_plan` shelled out to `terraform plan` via `Open3.popen3` with
+  no `-input=false` and left the child's stdin open. If terraform ever hit a
+  prompt (a missing variable, a backend/provider confirmation), it blocked on
+  `read()` from a pipe nobody was feeding — an unattended `belt deploy --auto`
+  could sit at 0% CPU indefinitely (observed: ~8 hours). The plan now runs with
+  `-input=false`, sets `TF_IN_AUTOMATION=1`, and closes the child's stdin so
+  terraform gets EOF instead of blocking. `terraform init`, the ACM-bootstrap
+  `terraform apply`, the final `terraform apply`, and the automated
+  `terraform destroy` all gained `-input=false` for the same reason. The
+  manual `belt init/plan/apply` subcommands (`terraform_command.rb`) stay
+  interactive — they inherit a real TTY on purpose.
+
 ## 0.6.8
 
 ### Added

data/lib/belt/cli/deploy_command.rb

@@ -772,7 +772,9 @@ module Belt
 
       def run_init
         puts '━━━ terraform init ━━━'
-        success = system('terraform', 'init')
+        # -input=false: never block on an interactive prompt. In an automated
+        # deploy there is nobody at the keyboard, so a prompt would hang forever.
+        success = system('terraform', 'init', '-input=false')
         abort "\n✗ terraform init failed" unless success
         puts ''
       end
@@ -794,7 +796,17 @@ module Belt
         require 'open3'
         stderr_buffer = +''
 
-        Open3.popen3('terraform', 'plan', '-out=tfplan', *@extra_args) do |_stdin, stdout, stderr, wait_thr|
+        # -input=false makes terraform fail fast on any missing input instead of
+        # prompting. TF_IN_AUTOMATION trims interactive hints from the output.
+        # We also close stdin immediately below so that even if terraform tried
+        # to read from it, it gets EOF rather than blocking forever — this is
+        # what caused `belt deploy` to hang indefinitely on an unanswered prompt.
+        tf_env = { 'TF_IN_AUTOMATION' => '1' }
+        tf_cmd = ['terraform', 'plan', '-input=false', '-out=tfplan', *@extra_args]
+
+        Open3.popen3(tf_env, *tf_cmd) do |stdin, stdout, stderr, wait_thr|
+          stdin.close
+
           stdout_thread = Thread.new do
             while (line = stdout.gets)
               print line
@@ -838,7 +850,8 @@ module Belt
         puts ''
 
         # Phase 1: Create the certificate only
-        success = system('terraform', 'apply', '-target=module.app.aws_acm_certificate.app', '-auto-approve')
+        success = system('terraform', 'apply', '-input=false',
+                         '-target=module.app.aws_acm_certificate.app', '-auto-approve')
         unless success
           puts ''
           puts '  ✗ Certificate creation failed.'
@@ -881,7 +894,7 @@ module Belt
 
       def run_apply
         puts '━━━ terraform apply ━━━'
-        success = system('terraform', 'apply', 'tfplan')
+        success = system('terraform', 'apply', '-input=false', 'tfplan')
         cleanup_plan
         abort "\n✗ terraform apply failed" unless success
       end

data/lib/belt/cli/destroy_command.rb

@@ -401,8 +401,9 @@ module Belt
           # Empty S3 buckets before destroy — terraform can't delete non-empty buckets
           empty_s3_buckets_in_state
 
-          # Run destroy with auto-approve (user already confirmed)
-          unless system('terraform', 'destroy', '-auto-approve')
+          # Run destroy with auto-approve (user already confirmed). -input=false
+          # keeps it from blocking on an interactive prompt in an automated run.
+          unless system('terraform', 'destroy', '-input=false', '-auto-approve')
             puts "\n✗ terraform destroy failed."
             puts '  Infrastructure may still be running. Fix and retry, or use --skip-terraform.'
             exit 1

data/lib/belt/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Belt
-  VERSION = '0.6.8'
+  VERSION = '0.6.9'
 
   # Ruby version new apps run on in Lambda. Rendered into the conveyor-belt
   # provider block (`ruby_version`) by `belt new` / `belt generate environment`.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: belt
 version: !ruby/object:Gem::Version
-  version: 0.6.8
+  version: 0.6.9
 platform: ruby
 authors:
 - Stowzilla