belongs_to_hstore 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 39dc6679c57af7b7ec58fb67390f88b79e1c65d4
-  data.tar.gz: 87df0683e7f0c7117f5945f145e6130176ddd4a0
+  metadata.gz: 232f79dff9040e7feaebb58925a85decacfcc4d8
+  data.tar.gz: 5fa6bfadf9dddc1c55796465d27cac518419be9d
 SHA512:
-  metadata.gz: 40f37bd2411560d6cbbdba0f434ef5145d3963657f5b8ade05724b5551856add50872d3f73cb6be345916e8ca2c48879d89c1ecf89545d61b27347f002402c20
-  data.tar.gz: de2357f110d067525e1a54bd6644a56816c7ab9a25ecef8d9c5ff974de19351005ea654a377bad6dca0d0852adbf8a749e5a19cdfaa354e97e64c5e3abd09ad5
+  metadata.gz: 4a47729427dbcd63db020d7c1cbcf7c3178c12807a81a3fb905f0e5586769ccecdb6d8954bc1a4477ff3837ff621e51ab6de3344fe2911fa88be19736e3b019d
+  data.tar.gz: 04f21bb7cc8e98c7459902be0734009c5786864b12f27f95fb61292e853b44559d6dbedc6e65fd42aa29c866bb1593cc32470a396671515091d63f0e346ef0a1

data/Gemfile

@@ -2,3 +2,13 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in belongs_to_hstore.gemspec
 gemspec
+
+group :development do
+  gem 'rake'
+  gem 'sqlite3'
+end
+
+group :test do
+  gem 'rspec'
+  gem 'coveralls', require: false
+end

data/README.md

@@ -1,4 +1,5 @@
-# BelongsToHstore [![Build Status](https://travis-ci.org/evanlok/belongs_to_hstore.png?branch=master)](https://travis-ci.org/evanlok/belongs_to_hstore)
+# BelongsToHstore 
+[![Build Status](https://travis-ci.org/evanlok/belongs_to_hstore.png?branch=master)](https://travis-ci.org/evanlok/belongs_to_hstore) [![Gem Version](https://badge.fury.io/rb/belongs_to_hstore.png)](http://badge.fury.io/rb/belongs_to_hstore) [![Code Climate](https://codeclimate.com/github/evanlok/belongs_to_hstore.png)](https://codeclimate.com/github/evanlok/belongs_to_hstore) [![Coverage Status](https://coveralls.io/repos/evanlok/belongs_to_hstore/badge.png)](https://coveralls.io/r/evanlok/belongs_to_hstore)
 
 Create ActiveRecord belongs_to associations using postgresql hstore columns. Compatible with polymorphic associations
 and supports eager loading.

data/belongs_to_hstore.gemspec

@@ -19,9 +19,5 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "activerecord", ">= 3.1"
-
   spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
-  spec.add_development_dependency "sqlite3"
 end

data/lib/belongs_to_hstore/association.rb

@@ -17,11 +17,11 @@ module BelongsToHstore
         key_type = key.gsub(/_id$/, '_type')
 
         store_accessor store_attribute, key.to_s
-        self.belongs_to_hstore_attributes[key.to_s]= true
+        self.belongs_to_hstore_attributes[key.to_s]= Integer
 
         if options[:polymorphic]
           store_accessor store_attribute, key_type
-          self.belongs_to_hstore_attributes[key_type]= true
+          self.belongs_to_hstore_attributes[key_type]= String
         end
 
         belongs_to name, options
@@ -34,8 +34,12 @@ module BelongsToHstore
     end
 
     def read_attribute(attr_name)
-      if self.class.belongs_to_hstore_attributes[attr_name]
-        send(attr_name)
+      if attr_type = self.class.belongs_to_hstore_attributes[attr_name]
+        attr_value = send(attr_name)
+        if attr_type == Integer
+          attr_value = (attr_value.is_a?(String) && attr_value.empty?) ? nil : attr_value.to_i
+        end
+        attr_value
       else
         super
       end

data/lib/belongs_to_hstore/version.rb

@@ -1,3 +1,3 @@
 module BelongsToHstore
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/spec/belongs_to_hstore_spec.rb

@@ -10,7 +10,7 @@ class Widget < ActiveRecord::Base
 end
 
 class ExtendedWidget < Widget
-  belongs_to_hstore :properties, :additonal_item, :class_name => 'Item'
+  belongs_to_hstore :properties, :additional_item, :class_name => 'Item'
 end
 
 class Item < ActiveRecord::Base
@@ -18,6 +18,7 @@ end
 
 describe BelongsToHstore do
   let(:item) { Item.create }
+  let(:extra_item) { Item.create(:name=>'extra') }
   let(:widget) { Widget.new }
   let(:extended_widget) { ExtendedWidget.new }
 
@@ -61,17 +62,26 @@ describe BelongsToHstore do
     end
 
     it 'sets/gets properties from subclass' do
-      extended_widget.additonal_item = item
-      extended_widget.properties['additonal_item_id'].should == item.id.to_s
-      extended_widget.additonal_item.should == item
+      extended_widget.additional_item = item
+      extended_widget.properties['additional_item_id'].should == item.id.to_s
+      extended_widget.additional_item.should == item
     end
 
     it 'does not add subclass properties to base class' do
-      expect{widget.additonal_item = item}.to raise_error(NameError)
-      expect{widget.additonal_item}.to raise_error(NameError)
+      expect{widget.additional_item = item}.to raise_error(NameError)
+      expect{widget.additional_item}.to raise_error(NameError)
       Widget.belongs_to_hstore_attributes.should include('item_id')
       Widget.belongs_to_hstore_attributes.should_not include('additional_item_id')
     end
   end
 
+  context 'preload associations' do
+    it 'works with includes' do
+      5.times { ExtendedWidget.create(:name => 'preload', :item => item, :additional_item => extra_item) }
+      widgets = ExtendedWidget.where(:name => 'preload').includes(:item, :additional_item).to_a
+      expect(widgets.size).to eq(5)
+      expect(widgets[0].item).to eq(widgets[1].item)
+    end
+  end
+
 end

data/spec/spec_helper.rb

@@ -6,6 +6,9 @@
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 Dir[File.expand_path("spec/support/**/*.rb")].each { |f| require f }
 require 'belongs_to_hstore'
+require 'coveralls'
+
+Coveralls.wear!
 
 RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: belongs_to_hstore
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Evan Lok
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-03 00:00:00.000000000 Z
+date: 2014-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -38,48 +38,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: sqlite3
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Allows hstore columns to store belongs_to association foreign keys with
   the same functionality as the default belongs_to
 email:
@@ -126,7 +84,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Allows hstore columns to store belongs_to associations