belated 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8c9e0e522a8de63f70d61dfeb7d02e8382c957f9e39858a5ce76fc063d4b2beb
-  data.tar.gz: 5cd83e71ab30ce2ceb5bc357bf53963399ed6b8aae5beae6930eff98a0f79b10
+  metadata.gz: 422e1b6b1f3973315fb01e1e47b7a976d0ac1a62897c0d32880fd21a7dec8c92
+  data.tar.gz: 3daed6a19c67909b50bb93c8b39ba729b43d33dbbd3a6966ed425249c6eec89f
 SHA512:
-  metadata.gz: 3cc2687dd4cdbbae82dc205a5c2ea851dd8b6a7f24471b424e8e1aae547a3fb01be063adbf765f92de10fcf886cf5eb10ac23b2c1144fa7c2d0c5cff59acb803
-  data.tar.gz: 748fd28b0eed08dfb16f221e3519c11c41235cdfd7527fe0ce68c6cdd5b996614c7e61ca6b48f31b66c32f3e20d94dce681be307abbcc616f8df39f6752df3b3
+  metadata.gz: 489ee717aaf5a1cbdf26f134e4341894dd088d4ba067f9b0f16c9c64a8f4692252e98b4dfa21d0e45fe45ba8c8cbfda77118483758bc0649b031bf8d9049c785
+  data.tar.gz: 811c5bc89bdbafaee6869a8f267e0c748ef5ca98ccc10edd65780e1a548205471ad881c879e12dc8e6162331e7065d8afb4bd765c96c694de8748600854f6feb

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## [Unreleased]
 
+## [0.6.2] - 2021-08-20
+
+- Use a mutex for the proc_table used by the client. Fixes
+`RuntimeError: can't add a new key into hash during iteration (Most recent call first)`, so starting improving thread safety with this fix. 
+
 ## [0.6.1] - 2021-08-20
 
 When the client closes and worker has a reference to a proc, a `DRb::ConnError` is raised. Rescueing it and ignoring it.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    belated (0.6.1)
+    belated (0.6.2)
       drb
       dry-configurable
       sorted_set

data/lib/belated/client.rb

@@ -22,6 +22,7 @@ class Belated
       self.bank = Thread::Queue.new
       self.queue = DRbObject.new_with_uri(server_uri)
       @started = true
+      @mutex = Mutex.new
     end
     alias initialize start
 
@@ -54,7 +55,9 @@ class Belated
       return if proc_table.empty?
 
       proc_table.select { |_k, v| v.completed }.each do |key, _value|
-        proc_table.delete(key)
+        @mutex.synchronize do
+          proc_table.delete(key)
+        end
       end
     end
 
@@ -65,15 +68,11 @@ class Belated
     # @param max_retries [Integer] - Times the job should be retried if it fails.
     # @return [JobWrapper] - The job wrapper for the queue.
     def perform(job, at: nil, max_retries: 5)
-      log 'Passing a proc and at time is deprecated and will be removed in 0.6' if job.instance_of?(Proc) && !at.nil?
-
-      job_wrapper = if job.is_a?(JobWrapper)
-                      job
-                    else
-                      JobWrapper.new(job: job, at: at, max_retries: max_retries)
-                    end
+      job_wrapper = wrap_job(job, at: at, max_retries: max_retries)
       bank.push(job_wrapper)
-      proc_table[job_wrapper.object_id] = job_wrapper if job_wrapper.proc_klass
+      @mutex.synchronize do
+        proc_table[job_wrapper.object_id] = job_wrapper if job_wrapper.proc_klass
+      end
       start_banker_thread if banker_thread.nil?
       job_wrapper
     end
@@ -82,6 +81,12 @@ class Belated
 
     private
 
+    def wrap_job(job, at:, max_retries:)
+      return job if job.is_a?(JobWrapper)
+
+      JobWrapper.new(job: job, at: at, max_retries: max_retries)
+    end
+
     def drb_connected?
       queue.connected?
     rescue StandardError

data/lib/belated/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Belated
-  VERSION = '0.6.1'
+  VERSION = '0.6.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: belated
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - Sampo Kuokkanen