belated 0.4.3 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 598cfda479ae3ec79564557a4f111ff5600c255bdf3cc8b3e03194b0b0b6ce86
-  data.tar.gz: f6b07150c218bf9754f5d40625e7e5d26673f87bf4d8a1baa4ef87814edbbc09
+  metadata.gz: b946c5167a28af0cd73bad436d52c47ad19af699d88bd8a20c592b8fb2327ea1
+  data.tar.gz: da03cfda6b0c4ec8b9a9a7ef4cb52747294f3b582633ad023cc98aa5e88c697f
 SHA512:
-  metadata.gz: 43ab001fcc721b6750ec2c7d3ee00f32ab58ff9909268bb9dda92d7096a5cca85782fbd8f3502295cc07086ac6ef18c056124f55ef4a706b607d2aab3c667ef8
-  data.tar.gz: c83cec5063743c8ed84a28a1b5995b7b3d7deeade1f6f352d81d1dca5b1531231dc46678f14e1ad6795662d8105dfc957ca81f7868996b310bc8b4128132e0c9
+  metadata.gz: 5add925bbaca101aef9a35c8d4ae6cc544b736ebbbcbae4e6603faf0e42a0a248bd04844b0af8fa6dceb32f021948c105bf18031fd0c97d12cfc85ac9d9cde3f
+  data.tar.gz: 13ac76b9f2b956e9b0b363d16ec3e615365ee39132fe788022c11c2ff90ed7fa9234c403903ac268efae0c63a51afbe6bc9893eb95cd8bbdf5d20b75e6a85aaf

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## [Unreleased]
 
+
+## [0.4.4] - 2021-08-07
+
+- Now if you pass something with a syntax error in it as a job, it should not bring down the whole app! 
+
 ## [0.4.3] - 2021-08-06
 
 - Client now starts the banker thread to execute jobs that were enqueued when there was no connection to Belated only if necessary. 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    belated (0.4.3)
+    belated (0.4.4)
       drb
       dry-configurable
 

data/README.md

@@ -2,7 +2,7 @@
 
 [![CodeFactor](https://www.codefactor.io/repository/github/sampokuokkanen/belated/badge)](https://www.codefactor.io/repository/github/sampokuokkanen/belated) [![Gem Version](https://badge.fury.io/rb/belated.svg)](https://badge.fury.io/rb/belated)
 
-This is Belated, a new Ruby backend job library! It supports running procs and classes in the background. To deal with restarts, it uses YAML to load the queue into a file, which it then calls at startup to find the previous jobs.
+This is Belated, a new Ruby backend job library! It supports running procs, lambdas and classes in the background. To deal with restarts, it uses YAML to load the queue into a file, which it then calls at startup to find the previous jobs. There is no way in Ruby to save procs or lambdas to a file, so they are discarded when the process restarts.
 
 Belated uses the Ruby Queue class, so it's First In, First Out (FIFO). 
 
@@ -14,14 +14,14 @@ Can be used with or without Rails.
 
 TODO LIST:
 
+- Add retries for jobs
 - Add some checks to the client for proper jobs.
-- Don't crash on errors (Partially done)
 - Have multiple queues?
 - Maybe support ActiveJob?
 - Have a web UI
 - Do some performance testing
 - Deploy a Rails app to production that is using Belated
-  and mention it in the readme. 
+  and mention it in the readme. (Capistrano support?)
 - Add a section telling people to use Sidekiq if they can
 
 ## Installation
@@ -90,6 +90,7 @@ and you can use the client!
 Call
 
 ```ruby
+job = proc { 2 / 1 }
 client.perform_belated(job)
 ```
 
@@ -101,7 +102,7 @@ If you don't want the job to run right away, you can also pass it a keyword para
 client.perform_belated(job, Time.now + 1.month)
 ```
 
-Note that you probably want to memoize the client, as it always creates a 'banker thread' now if you have no connection. Maybe even use it as a global!(`$client`)
+Note that you probably want to memoize the client, as it always creates a 'banker thread' now if you have no connection and there is the overhead of connecting to dRuby. Maybe even use it as a global!(`$client`)
 
 # Settings
 

data/lib/belated.rb

@@ -1,15 +1,15 @@
 # frozen_string_literal: true
 
+require_relative 'belated/logging'
 require_relative 'belated/version'
 require_relative 'belated/worker'
-require_relative 'belated/logging'
+require 'belated/client'
+require 'belated/queue'
 require 'drb'
-require 'yaml'
-require 'singleton'
 require 'dry-configurable'
-require 'belated/client'
 require 'logger'
-require 'belated/queue'
+require 'singleton'
+require 'yaml'
 
 # Belated is a pure Ruby job backend.
 # It has limited functionality, as it only accepts
@@ -64,7 +64,11 @@ class Belated
           @@queue.push(:shutdown)
         end
         Thread.new { stop_workers }
-        sleep 0.1 until @@queue.empty? || $TESTING
+        # Max 30 seconds to shutdown
+        timeout = 0
+        until (timeout += 0.1) >= 30 || @@queue.empty? || $TESTING
+          sleep 0.1
+        end
         exit
       end
     end

data/lib/belated/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Belated
-  VERSION = '0.4.3'
+  VERSION = '0.4.4'
 end

data/lib/belated/worker.rb

@@ -22,14 +22,21 @@ class Belated
       end
     end
 
+    # rubocop:disable Lint/RescueException
     def call_job(job)
       if job.respond_to?(:call)
         job.call
       else
         job.perform
       end
-    rescue StandardError => e
-      e.inspect
+    rescue Exception => e
+      case e.class
+      when Interrupt, SignalException
+        raise e
+      else
+        e.inspect
+      end
     end
+    # rubocop:enable Lint/RescueException
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: belated
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors:
 - Sampo Kuokkanen
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-06 00:00:00.000000000 Z
+date: 2021-08-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: drb