beeradvocate 0.0.2 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 202edfe8ff06b907a1ede18c66e0b968f7edf8db
-  data.tar.gz: 8eceab449dd7654a5e68f9f1420be37b675016ee
+  metadata.gz: 6fb8952be83417794f9222e13296641c7d87ffb1
+  data.tar.gz: b8017d20a268d438c73a4694d22ebc4196e34ab1
 SHA512:
-  metadata.gz: b40a9d2c5160968d16ff3bf349548e40f4866d3b53bfd4e221c291f37ab2768686e22fc9b67b1d243ebcc4a2ab7e9e5d47b28b57ba7d57be055c83013f3bbb44
-  data.tar.gz: 4be5c6d7ce4135bf744602cda53dbe3fcc6a75e1689fe366bd548738aa452ae889397bc48515a66c2b10b274d19d2cdef1ad53c302030dce2495b20c963c7d4f
+  metadata.gz: 331eb8c63e71c5c3b6369fedb03eecaace7bd7f70b80350b4057fd6ccbbb30da02e3bc25ee79663d628f0922149a9006254c5f98987ac3476260e788c1e204b9
+  data.tar.gz: 22bcf557a75b6b227f0b8100a83b1878aec01d8577a4d1a11b551bc7d9fd61d9c1530e7c5fb22e0afc2cd72a37f47e109ba5e846e1e8a379eac2a1fa05d2188f

data/bin/beer

@@ -9,9 +9,15 @@ end
 
 beer_name = ARGV.join(' ')
 
-url = BeerAdvocate.get_url(beer_name)
+unless url = BeerAdvocate.get_url(beer_name)
+  STDERR.puts "Couldn't get url for '#{beer_name}'"
+  exit 2
+end
 
-beer_details = BeerAdvocate.get_beer_details_from_url(url)
+unless beer_details = BeerAdvocate.get_beer_details_from_url(url)
+  STDERR.puts "Couldn't parse beer details for url '#{url}'"
+  exit 3
+end
 
 puts JSON.pretty_generate(beer_details)
 

data/lib/beer_advocate.rb

@@ -8,23 +8,32 @@ require 'beer_advocate/version'
 module BeerAdvocate
   class << self
 
-    ## Given a beer name, return the URL for the top Beer Advocate beer
-    ## search result.
-    def get_url(beer_name)
-      page = Nokogiri::HTML(open(
-        "http://www.beeradvocate.com/search/?qt=beer&q=" +
+    ## Given a beer name, returns the URL for the top Beer Advocate beer
+    ## search result.  Throws an exception if something goes wrong.
+    def get_url!(beer_name)
+      search_url = "http://www.beeradvocate.com/search/?qt=beer&q=" +
         URI.escape(beer_name)
-      ))
 
-      "http://www.beeradvocate.com" +
-        page.css('ul li a').first.attributes['href'].text
+      page = Nokogiri::HTML(open(search_url))
+
+      href = page.css('ul li a').
+        map {|tag| tag.attributes['href'].text rescue nil}.
+        select {|h| h && h.match(%r{^/beer/profile})}.
+        first
+
+      "http://www.beeradvocate.com" + href
     end
 
+    ## Given a beer name, returns the URL for the top Beer Advocate beer
+    ## search result.  Returns nil upon error.
+    def get_url(beer_name)
+      get_url!(beer_name) rescue nil
+    end
 
-    ## Given a URL for a Beer Advocate beer page, return a hash containing
+    ## Given a URL for a Beer Advocate beer page, returns a hash containing
     ## info about the beer, including `name`, `brewery`, `style`, `abv`,
-    ## and `score`.
-    def get_beer_details_from_url(url)
+    ## and `score`.  Throws an exception if something goes wrong.
+    def get_beer_details_from_url!(url)
       page = Nokogiri::HTML(open(url))
 
       table = page.css('#ba-content table')[1]
@@ -55,6 +64,13 @@ module BeerAdvocate
       }
     end
 
+    ## Given a URL for a Beer Advocate beer page, returns a hash containing
+    ## info about the beer, including `name`, `brewery`, `style`, `abv`,
+    ## and `score`.  Returns nil upon error.
+    def get_beer_details_from_url(url)
+      get_beer_details_from_url!(url) rescue nil
+    end
+
   end
 end
 

data/lib/beer_advocate/version.rb

@@ -1,5 +1,5 @@
 module BeerAdvocate
-  VERSION = '0.0.2'
+  VERSION = '0.1.0'
   VERSION_DATE = '2015-07-02'
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: beeradvocate
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors:
 - Pete Gamache