beaker 4.22.1 → 4.23.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0a089feb0e8311631a3778e1839e5942694ec2e9f14bb873fbfb07d5ae854bca
-  data.tar.gz: b0e75901ec90f523a2b2f276658e8ede706a0fb3df3f09fcd58779263a28d630
+  metadata.gz: 90b746c013603a55023f75c05cfa79a8301fa58729b82a1dcc677067dde77ab1
+  data.tar.gz: f76631826758f41afb1517224fed593bdf988278bb1c18a23dd6ddea0d74ca8a
 SHA512:
-  metadata.gz: bfb8cfe1965440e36c4e8093548a454c0de51100d1ec5c4a5d001c083fc20aa5b2715301abba1b2a4ddb3425701c51298e4cbcb41f965896a41f59c003c2b97d
-  data.tar.gz: 39fb8a21b0e289c81b8967deb089bb50418a726d0bec337cec4ad6230d4b5ce3587b37c2ee1144cef61d1f944b77df1a1f6cc0a2ae79c9214efe66c55dcd463a
+  metadata.gz: 24dc7d2592f0de06a51a6534f9f0014a5075851295926c696b5fd0d2ea835f7f95bf4f630f12c91f645fccf33ab43eb3acb8fe33fd1a841e0ae4bd52a529e3a8
+  data.tar.gz: 9556e24844dd480c3bab6b30bb6e29db3b34ae4e6a76fd53f47c76fb018d805804eb1e2de87a6798850e1880ea5960cfd90902a99856caff8284f172f0b5f4f6

data/CHANGELOG.md

@@ -20,7 +20,24 @@ The headers used in [Keep a Changelog](http://keepachangelog.com) are:
 - Fixed - for any bug fixes.
 - Security - in case of vulnerabilities.
 
-# [Unreleased](https://github.com/puppetlabs/beaker/compare/4.22.1...master)
+# [Unreleased](https://github.com/puppetlabs/beaker/compare/4.23.0...master)
+
+# [4.23.0](https://github.com/puppetlabs/beaker/compare/4.22.1...4.23.0)
+
+### Added
+
+- Relaxed dependency on `net-ssh` to `>= 5` to support newer versions. (#1648)
+- `cat` DSL method added. Works on both Unix and Windows hosts. (#1645)
+
+### Changed
+
+- The `mkdir_p` and `mv` commands now double quote their file arguments. (#1644) If you rely on file globbing in these methods or elsewhere, please open an issue on the BEAKER project.
+- Change `reboot` method to use `who -b` for uptime detection (#1643)
+
+### Fixed
+
+- Use Base64 UTF-16LE encoding for commands (#1626)
+- Fix `tmpdir` method for Powershell on Windows (#1645)
 
 # [4.22.1](https://github.com/puppetlabs/beaker/compare/4.22.0...4.22.1)
 

data/beaker.gemspec

@@ -44,7 +44,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency 'rb-readline', '~> 0.5.3'
 
   s.add_runtime_dependency 'hocon', '~> 1.0'
-  s.add_runtime_dependency 'net-ssh', '~> 5.0'
+  s.add_runtime_dependency 'net-ssh', '>= 5.0'
   s.add_runtime_dependency 'net-scp', '~> 1.2'
   s.add_runtime_dependency 'inifile', '~> 3.0'
 

data/lib/beaker/dsl/helpers/host_helpers.rb

@@ -550,7 +550,6 @@ module Beaker
           file_contents = nil
 
           split_path = win_ads_path(file_path)
-
           if file_exists_on(host, split_path[:path])
             if host['platform'] =~ /windows/
               file_path.gsub!('/', '\\')

data/lib/beaker/dsl/helpers/web_helpers.rb

@@ -14,10 +14,11 @@ module Beaker
 
         #Determine is a given URL is accessible
         #@param [String] link The URL to examine
-        #@return [Boolean] true if the URL has a '200' HTTP response code, false otherwise
+        #@param [Integer] limit redirect limit, will follow redirects that many times
+        #@return [Boolean] true if the ultimate URL after following redirects (301&302) has a '200' HTTP response code, false otherwise
         #@example
         #  extension = link_exists?("#{URL}.tar.gz") ? ".tar.gz" : ".tar"
-        def link_exists?(link)
+        def link_exists?(link, limit=10)
           begin
             require "net/http"
             require "net/https"
@@ -26,8 +27,12 @@ module Beaker
             http = Net::HTTP.new(url.host, url.port)
             http.use_ssl = (url.scheme == 'https')
             http.verify_mode = (OpenSSL::SSL::VERIFY_NONE)
-            http.start do |http|
-              return http.head(url.request_uri).code == "200"
+            response = http.start { |http| http.head(url.request_uri) }
+            if (['301', '302'].include? response.code) && limit > 0
+              logger.debug("#{__method__} following #{response.code} to #{response['location']}")
+              link_exists?(response['location'], limit - 1)
+            else
+              response.code == "200"
             end
           rescue
             return false

data/lib/beaker/dsl/wrappers.rb

@@ -75,18 +75,14 @@ module Beaker
         Command.new("powershell.exe", ps_args)
       end
 
-      # Convert the provided command string to Base64
+      # Convert the provided command string to Base64 encoded UTF-16LE command
       # @param [String] cmd The command to convert to Base64
       # @return [String] The converted string
       # @api private
       def encode_command(cmd)
-        cmd = cmd.chars.to_a.join("\x00").chomp
-        cmd << "\x00" unless cmd[-1].eql? "\x00"
         # use strict_encode because linefeeds are not correctly handled in our model
-        cmd = Base64.strict_encode64(cmd).chomp
-        cmd
+        Base64.strict_encode64(cmd.encode(Encoding::UTF_16LE)).chomp
       end
-
     end
   end
 end

data/lib/beaker/host/pswindows/file.rb

@@ -7,14 +7,23 @@ module PSWindows::File
   end
 
   def tmpdir(name = '')
-    result = exec(powershell('[System.IO.Path]::GetTempPath()'))
-    result.stdout.chomp()
+    tmp_path = exec(powershell('[System.IO.Path]::GetTempPath()')).stdout.chomp()
+
+    if name == ''
+      name = exec(powershell('[System.IO.Path]::GetRandomFileName()')).stdout.chomp()
+    end
+    exec(powershell("New-Item -Path '#{tmp_path}' -Force -Name '#{name}' -ItemType 'directory'"))
+    File.join(tmp_path, name)
   end
 
   def path_split(paths)
     paths.split(';')
   end
 
+  def cat(path)
+    exec(powershell("type #{path}"))
+  end
+
   def file_exist?(path)
     result = exec(Beaker::Command.new("if exist #{path} echo true"), :acceptable_exit_codes => [0, 1])
     result.stdout =~ /true/

data/lib/beaker/host/unix/exec.rb

@@ -12,20 +12,23 @@ module Unix::Exec
   #
   # Will throw an exception RebootFailure if it fails
   def reboot(wait_time=10, max_connection_tries=9, uptime_retries=18)
+    require 'time'
+
     begin
-      original_uptime = exec(Beaker::Command.new("uptime"))
-      original_uptime_str = parse_uptime original_uptime.stdout
-      original_uptime_int = uptime_int original_uptime_str
+      original_boot_time_str = exec(Beaker::Command.new('who -b'), {:max_connection_tries => max_connection_tries, :silent => true}).stdout
+      original_boot_time_line = original_boot_time_str.lines.grep(/boot/).first
 
-      if self['platform'] =~ /solaris/
-        exec(Beaker::Command.new("reboot"), :expect_connection_failure => true)
-      else
-        exec(Beaker::Command.new("/sbin/shutdown -r now"), :expect_connection_failure => true)
-      end
+      raise Beaker::Host::RebootFailure, "Could not find system boot time using 'who -b': #{original_boot_time_str}" unless original_boot_time_line
+
+      original_boot_time = Time.parse(original_boot_time_line)
+
+      exec(Beaker::Command.new('/bin/systemctl reboot -i || reboot || /sbin/shutdown -r now'), :expect_connection_failure => true)
     rescue Beaker::Host::CommandFailure => e
       raise Beaker::Host::RebootFailure, "Command failed when attempting to reboot: #{e.message}"
     rescue RuntimeError => e
       raise Beaker::Host::RebootFailure, "Unexpected exception in reboot: #{e.message}"
+    rescue ArgumentError => e
+      raise Beaker::Host::RebootFailure, "Unable to parse time: #{e.message}"
     end
 
     attempts = 0
@@ -34,18 +37,19 @@ module Unix::Exec
       @logger.debug("Waiting #{wait_time} for host to shut down.")
       sleep wait_time
 
-      #use uptime to check if the host has rebooted
-      current_uptime_exec = exec(Beaker::Command.new("uptime"), {:max_connection_tries => max_connection_tries, :silent => true})
-      current_uptime = current_uptime_exec.stdout
-      current_uptime_str = parse_uptime current_uptime
-      current_uptime_int = uptime_int current_uptime_str
-      unless original_uptime_int > current_uptime_int
-        raise Beaker::Host::RebootFailure, "Uptime did not reset. Reboot appears to have failed."
+      current_boot_time_str = exec(Beaker::Command.new('who -b'), {:max_connection_tries => max_connection_tries, :silent => true}).stdout
+      current_boot_time = Time.parse(current_boot_time_str.lines.grep(/boot/).first)
+
+      @logger.debug("Original Boot Time: #{original_boot_time}")
+      @logger.debug("Current Boot Time: #{current_boot_time}")
+
+      unless current_boot_time > original_boot_time
+        raise Beaker::Host::RebootFailure, "Boot time did not reset. Reboot appears to have failed."
       end
     rescue Beaker::Host::RebootFailure => e
       attempts += 1
       if attempts < uptime_retries
-        @logger.debug("Uptime did not reset. Will retry #{uptime_retries - attempts} more times.")
+        @logger.debug("Boot time did not reset. Will retry #{uptime_retries - attempts} more times.")
         retry
       else
         raise
@@ -54,6 +58,8 @@ module Unix::Exec
       raise Beaker::Host::RebootFailure, "Command failed when attempting to reboot: #{e.message}"
     rescue RuntimeError => e
       raise Beaker::Host::RebootFailure, "Unexpected exception in reboot: #{e.message}"
+    rescue ArgumentError => e
+      raise Beaker::Host::RebootFailure, "Unable to parse time: #{e.message}"
     end
   end
 
@@ -127,7 +133,7 @@ module Unix::Exec
   # @param [String] dir The directory structure to create on the host
   # @return [Boolean] True, if directory construction succeeded, otherwise False
   def mkdir_p dir
-    cmd = "mkdir -p #{dir}"
+    cmd = "mkdir -p \"#{dir}\""
     result = exec(Beaker::Command.new(cmd), :acceptable_exit_codes => [0, 1])
     result.exit_code == 0
   end
@@ -144,7 +150,7 @@ module Unix::Exec
   # @param [Boolean] rm Remove the destination prior to move
   def mv orig, dest, rm=true
     rm_rf dest unless !rm
-    execute("mv #{orig} #{dest}")
+    execute("mv \"#{orig}\" \"#{dest}\"")
   end
 
   # Attempt to ping the provided target hostname

data/lib/beaker/host/unix/file.rb

@@ -58,6 +58,10 @@ module Unix::File
     execute("ls -ld #{path}")
   end
 
+  def cat(path)
+    execute("cat #{path}")
+  end
+
   # Handles any changes needed in a path for SCP
   #
   # @param [String] path File path to SCP to

data/lib/beaker/version.rb

@@ -1,5 +1,5 @@
 module Beaker
   module Version
-    STRING = '4.22.1'
+    STRING = '4.23.0'
   end
 end

data/spec/beaker/host/pswindows/file_spec.rb

@@ -0,0 +1,87 @@
+require 'spec_helper'
+
+module Beaker
+  describe PSWindows::File do
+    class PSWindowsFileTest
+      include PSWindows::File
+      include Beaker::DSL::Wrappers
+
+      def initialize(hash, logger)
+        @hash = hash
+        @logger = logger
+      end
+
+      def [](k)
+        @hash[k]
+      end
+
+      def to_s
+        "me"
+      end
+    end
+
+    let (:opts)     { @opts || {} }
+    let (:logger)   { double( 'logger' ).as_null_object }
+    let (:instance) { PSWindowsFileTest.new(opts, logger) }
+
+    describe '#cat' do
+      it 'reads output for file' do
+        path = '/path/to/delete'
+        expect(instance).to receive(:exec)
+        expect(Beaker::Command).to receive(:new).with('powershell.exe', array_including("-Command type #{path}"))
+        instance.cat(path)
+      end
+    end
+
+    describe '#tmpdir' do
+      let(:tmp_path) { 'C:\\tmpdir\\' }
+      let(:fake_command) { Beaker::Command.new('command1') }
+
+      before do
+        allow(instance).to receive(:execute).with(anything)
+
+      end
+
+      context 'with dirname sent' do
+        let(:name) { 'my_dir' }
+        it 'returns the path to my_dir' do
+          expect(Beaker::Command).to receive(:new).
+            with('powershell.exe', array_including('-Command [System.IO.Path]::GetTempPath()')).
+            and_return(fake_command)
+          expect(instance).to receive(:exec).with(instance_of(Beaker::Command)).and_return(double(stdout: tmp_path))
+
+          expect(Beaker::Command).to receive(:new).
+            with('powershell.exe', array_including("-Command New-Item -Path '#{tmp_path}' -Force -Name '#{name}' -ItemType 'directory'")).
+            and_return(fake_command)
+          expect(instance).to receive(:exec).with(instance_of(Beaker::Command)).and_return(true)
+
+          expect(instance.tmpdir(name)).to eq(File.join(tmp_path, name))
+        end
+      end
+
+      context 'without dirname sent' do
+        let(:name) { '' }
+        let(:random_dir) { 'dirname' }
+
+        it 'returns the path to random name dir' do
+          expect(Beaker::Command).to receive(:new).
+            with('powershell.exe', array_including('-Command [System.IO.Path]::GetTempPath()')).
+            and_return(fake_command)
+          expect(instance).to receive(:exec).with(instance_of(Beaker::Command)).and_return(double(stdout: tmp_path))
+
+          expect(Beaker::Command).to receive(:new).
+            with('powershell.exe', array_including('-Command [System.IO.Path]::GetRandomFileName()')).
+            and_return(fake_command)
+          expect(instance).to receive(:exec).with(instance_of(Beaker::Command)).and_return(double(stdout: random_dir))
+
+          expect(Beaker::Command).to receive(:new).
+            with('powershell.exe', array_including("-Command New-Item -Path '#{tmp_path}' -Force -Name '#{random_dir}' -ItemType 'directory'")).
+            and_return(fake_command)
+          expect(instance).to receive(:exec).with(instance_of(Beaker::Command)).and_return(true)
+
+          expect(instance.tmpdir).to eq(File.join(tmp_path, random_dir))
+        end
+      end
+    end
+  end
+end

data/spec/beaker/host/unix/exec_spec.rb

@@ -40,13 +40,13 @@ module Beaker
 
       it 'rm first' do
         expect( instance ).to receive(:execute).with("rm -rf #{destination}").and_return(0)
-        expect( instance ).to receive(:execute).with("mv #{origin} #{destination}").and_return(0)
+        expect( instance ).to receive(:execute).with("mv \"#{origin}\" \"#{destination}\"").and_return(0)
         expect( instance.mv(origin, destination) ).to be === 0
 
       end
 
       it 'does not rm' do
-         expect( instance ).to receive(:execute).with("mv #{origin} #{destination}").and_return(0)
+         expect( instance ).to receive(:execute).with("mv \"#{origin}\" \"#{destination}\"").and_return(0)
          expect( instance.mv(origin, destination, false) ).to be === 0
       end
     end
@@ -171,94 +171,135 @@ module Beaker
     describe '#reboot' do
       # no-op response
       let (:response) { double( 'response' ) }
-      let (:uptime_initial_response) { double( 'response' ) }
-      let (:uptime_initial_stdout) { '19:52  up 14 mins, 2 users, load averages: 2.95 4.19 4.31' }
+      let (:boot_time_initial_response) { double( 'response' ) }
 
-      let (:uptime_success_response) { double( 'response' ) }
-      let (:uptime_success_stdout) { '19:52  up 0 mins, 2 users, load averages: 2.95 4.19 4.31' }
+      let (:boot_time_success_response) { double( 'response' ) }
       let (:sleep_time) { 10 }
 
       before :each do
-        # stubs enough to survive the first uptime call & output parsing
+        # stubs enough to survive the first boot_time call & output parsing
         #   note: just stubs input-chain between calls, parsing methods still run
-        allow(Beaker::Command).to receive(:new).with("uptime").and_return(:uptime_command_stub)
+        allow(Beaker::Command).to receive(:new).with('who -b').and_return(:boot_time_command_stub)
 
-        # mock initial uptime call
-        allow(instance).to receive( :exec ).with(:uptime_command_stub).and_return(uptime_initial_response).once
-        allow(uptime_initial_response).to receive(:stdout).and_return(uptime_initial_stdout)
-
-        allow(uptime_success_response).to receive(:stdout).and_return(uptime_success_stdout)
+        allow(boot_time_initial_response).to receive(:stdout).and_return(boot_time_initial_stdout)
+        allow(boot_time_success_response).to receive(:stdout).and_return(boot_time_success_stdout)
 
         allow(instance).to receive(:sleep)
 
-        allow(Beaker::Command).to receive(:new).with("/sbin/shutdown -r now").and_return(:shutdown_command_stub)
+        allow(Beaker::Command).to receive(:new).with("/bin/systemctl reboot -i || reboot || /sbin/shutdown -r now").and_return(:shutdown_command_stub)
       end
 
-      it 'raises a reboot failure when command fails' do
-        expect(instance).not_to receive(:sleep)
-        expect(instance).to receive(:exec).with(:shutdown_command_stub, anything).and_raise(Host::CommandFailure).once
-        expect{ instance.reboot }.to raise_error(Beaker::Host::RebootFailure, /Command failed when attempting to reboot: .*/)
-      end
+      context 'new boot time greater than old boot time' do
+        let (:boot_time_initial_stdout) { '      system boot  2020-05-13 03:51' }
+        let (:boot_time_success_stdout) { '      system boot  2020-05-13 03:52' }
 
-      it 'raises a reboot failure when we receive an unexpected error' do
-        expect(instance).not_to receive(:sleep)
-        expect(instance).to receive(:exec).with(:shutdown_command_stub, anything).and_raise(Net::SSH::HostKeyError).once
-        expect { instance.reboot }.to raise_error(Beaker::Host::RebootFailure, /Unexpected exception in reboot: .*/)
-      end
+        it 'passes with defaults' do
+          expect(instance).to receive(:sleep).with(sleep_time)
+          # bypass shutdown command itself
+          expect(instance).to receive( :exec ).with(:shutdown_command_stub, anything).and_return(response)
+          # allow the second boot_time and the hash arguments in exec
+          expect(instance).to receive( :exec ).with(:boot_time_command_stub, anything).and_return(boot_time_initial_response).once
+          expect(instance).to receive( :exec ).with(:boot_time_command_stub, anything).and_return(boot_time_success_response).once
 
-      it 'raises RebootFailure if new uptime is never less than old uptime' do
-        expect(instance).to receive(:sleep).with(sleep_time)
-        # bypass shutdown command itself
-        expect(instance).to receive( :exec ).with(:shutdown_command_stub, anything).and_return(response).once
-        # allow the second uptime and the hash arguments in exec, repeated 18 times by default in order to replicate the previous behavior of the ping based Host.down?
-        expect(instance).to receive( :exec ).with(:uptime_command_stub, anything).and_return(uptime_initial_response).exactly(18).times
+          expect(instance.reboot).to be(nil)
+        end
 
-        expect { instance.reboot }.to raise_error(Beaker::Host::RebootFailure, /Uptime did not reset/)
-      end
+        it 'passes with wait_time_parameter' do
+          expect(instance).to receive(:sleep).with(10)
+          # bypass shutdown command itself
+          expect(instance).to receive( :exec ).with(:shutdown_command_stub, anything).and_return(response).once
+          expect(instance).to receive( :exec ).with(:boot_time_command_stub, anything).and_return(boot_time_initial_response).once
+          # allow the second boot_time and the hash arguments in exec
+          expect(instance).to receive( :exec ).with(:boot_time_command_stub, anything).and_return(boot_time_success_response).once
 
-      it 'raises RebootFailure if new uptime is never less than old uptime when the number of retries is changed' do
-        expect(instance).to receive(:sleep).with(sleep_time)
-        # bypass shutdown command itself
-        expect(instance).to receive( :exec ).with(:shutdown_command_stub, anything).and_return(response).once
-        # allow the second uptime and the hash arguments in exec, repeated 10 times by default
-        expect(instance).to receive( :exec ).with(:uptime_command_stub, anything).and_return(uptime_initial_response).exactly(10).times
+          expect(instance.reboot(10)).to be(nil)
+        end
 
-        expect { instance.reboot(wait_time=sleep_time, max_connection_tries=9, uptime_retries=10) }.to raise_error(Beaker::Host::RebootFailure, /Uptime did not reset/)
-      end
+        it 'passes with max_connection_tries parameter' do
+          expect(instance).to receive(:sleep).with(sleep_time)
+          # bypass shutdown command itself
+          expect(instance).to receive( :exec ).with(:shutdown_command_stub, anything).and_return(response).once
+          expect(instance).to receive( :exec ).with(:boot_time_command_stub, anything).and_return(boot_time_initial_response).once
+          # allow the second boot_time and the hash arguments in exec
+          expect(instance).to receive( :exec ).with(:boot_time_command_stub, hash_including(:max_connection_tries => 20)).and_return(boot_time_success_response).once
+
+          expect(instance.reboot(sleep_time, 20)).to be(nil)
+        end
+
+        context 'command errors' do
+          before :each do
+            allow(instance).to receive( :exec ).with(:boot_time_command_stub, anything).and_return(boot_time_initial_response).once
+          end
 
-      it 'passes if new uptime is less than old uptime' do
-        expect(instance).to receive(:sleep).with(sleep_time)
-        # bypass shutdown command itself
-        expect(instance).to receive( :exec ).with(:shutdown_command_stub, anything).and_return(response).once
-        # allow the second uptime and the hash arguments in exec
-        expect(instance).to receive( :exec ).with(:uptime_command_stub, anything).and_return(uptime_success_response).once
+          it 'raises a reboot failure when command fails' do
+            expect(instance).not_to receive(:sleep)
+            expect(instance).to receive(:exec).with(:shutdown_command_stub, anything).and_raise(Host::CommandFailure).once
 
-        expect(instance.reboot).to be(nil)
+            expect{ instance.reboot }.to raise_error(Beaker::Host::RebootFailure, /Command failed when attempting to reboot: .*/)
+          end
+
+          it 'raises a reboot failure when we receive an unexpected error' do
+            expect(instance).not_to receive(:sleep)
+            expect(instance).to receive(:exec).with(:shutdown_command_stub, anything).and_raise(Net::SSH::HostKeyError).once
+
+            expect { instance.reboot }.to raise_error(Beaker::Host::RebootFailure, /Unexpected exception in reboot: .*/)
+          end
+
+          context 'incorrect time string' do
+            context 'original time' do
+              let (:boot_time_initial_stdout) { 'boot bad' }
+
+              it 'raises a reboot failure' do
+                expect(instance).not_to receive(:sleep)
+
+                expect { instance.reboot }.to raise_error(Beaker::Host::RebootFailure, /Unable to parse time: .*/)
+              end
+            end
+
+            context 'current time' do
+              let (:boot_time_success_stdout) { 'boot bad' }
+
+              it 'raises a reboot failure' do
+                expect(instance).to receive(:exec).with(:shutdown_command_stub, anything).and_return(response).once
+                expect(instance).to receive( :exec ).with(:boot_time_command_stub, anything).and_return(boot_time_initial_response).once
+                # allow the second boot_time and the hash arguments in exec, repeated 10 times by default
+                expect(instance).to receive( :exec ).with(:boot_time_command_stub, anything).and_return(boot_time_success_response).once
+
+                expect { instance.reboot }.to raise_error(Beaker::Host::RebootFailure, /Unable to parse time: .*/)
+              end
+            end
+          end
+        end
       end
 
-      context 'with wait_time_parameter' do
-        it 'passes if new uptime is less than old uptime' do
-          expect(instance).to receive(:sleep).with(10)
+      context 'new boot time less than old boot time' do
+        let (:boot_time_initial_stdout) { '      system boot  2020-05-13 03:51' }
+        let (:boot_time_success_stdout) { '      system boot  2020-05-13 03:50' }
+
+        it 'raises RebootFailure' do
+          expect(instance).to receive(:sleep).with(sleep_time)
           # bypass shutdown command itself
           expect(instance).to receive( :exec ).with(:shutdown_command_stub, anything).and_return(response).once
-          # allow the second uptime and the hash arguments in exec
-          expect(instance).to receive( :exec ).with(:uptime_command_stub, anything).and_return(uptime_success_response).once
 
-          expect(instance.reboot(10)).to be(nil)
+          expect(instance).to receive( :exec ).with(:boot_time_command_stub, anything).and_return(boot_time_initial_response).once
+          # allow the second boot_time and the hash arguments in exec, repeated 18 times by default in order to replicate the previous behavior of the ping based Host.down?
+          expect(instance).to receive( :exec ).with(:boot_time_command_stub, anything).and_return(boot_time_success_response).exactly(18).times
+
+          expect { instance.reboot }.to raise_error(Beaker::Host::RebootFailure, /Boot time did not reset/)
         end
-      end
 
-      context 'with max_connection_tries parameter' do
-        it 'passes if new uptime is less than old uptime' do
+        it 'raises RebootFailure if the number of retries is changed' do
           expect(instance).to receive(:sleep).with(sleep_time)
           # bypass shutdown command itself
           expect(instance).to receive( :exec ).with(:shutdown_command_stub, anything).and_return(response).once
-          # allow the second uptime and the hash arguments in exec
-          expect(instance).to receive( :exec ).with(:uptime_command_stub, hash_including(:max_connection_tries => 20)).and_return(uptime_success_response).once
+          expect(instance).to receive( :exec ).with(:boot_time_command_stub, anything).and_return(boot_time_initial_response).once
+          # allow the second boot_time and the hash arguments in exec, repeated 10 times by default
+          expect(instance).to receive( :exec ).with(:boot_time_command_stub, anything).and_return(boot_time_success_response).exactly(10).times
 
-          expect(instance.reboot(sleep_time, 20)).to be(nil)
+          expect { instance.reboot(wait_time=sleep_time, max_connection_tries=9, boot_time_retries=10) }.to raise_error(Beaker::Host::RebootFailure, /Boot time did not reset/)
         end
       end
+
     end
 
     describe '#enable_remote_rsyslog' do

data/spec/beaker/host/unix/file_spec.rb

@@ -196,6 +196,14 @@ module Beaker
       end
     end
 
+    describe '#cat' do
+      let (:path) { '/path/to/cat/on' }
+      it 'calls cat for path' do
+        expect( instance ).to receive( :execute ).with( "cat #{path}" ).and_return( 0 )
+        expect( instance.cat( path ) ).to be === 0
+      end
+    end
+
     describe '#chmod' do
       context 'not recursive' do
         it 'calls execute with chmod' do

data/spec/beaker/host_spec.rb

@@ -325,7 +325,7 @@ module Beaker
         allow( result ).to receive( :exit_code ).and_return( 0 )
         allow( host ).to receive( :exec ).and_return( result )
 
-        expect( Beaker::Command ).to receive(:new).with("mkdir -p test/test/test")
+        expect( Beaker::Command ).to receive(:new).with("mkdir -p \"test/test/test\"")
         expect( host.mkdir_p('test/test/test') ).to be == true
 
       end
@@ -337,7 +337,7 @@ module Beaker
         allow( result ).to receive( :exit_code ).and_return( 0 )
         allow( host ).to receive( :exec ).and_return( result )
 
-        expect( Beaker::Command ).to receive(:new).with("mkdir -p test/test/test")
+        expect( Beaker::Command ).to receive(:new).with("mkdir -p \"test/test/test\"")
         expect( host.mkdir_p('test/test/test') ).to be == true
 
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: beaker
 version: !ruby/object:Gem::Version
-  version: 4.22.1
+  version: 4.23.0
 platform: ruby
 authors:
 - Puppet
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-08 00:00:00.000000000 Z
+date: 2020-05-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -216,14 +216,14 @@ dependencies:
   name: net-ssh
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
 - !ruby/object:Gem::Dependency
@@ -630,6 +630,7 @@ files:
 - spec/beaker/host/mac/user_spec.rb
 - spec/beaker/host/mac_spec.rb
 - spec/beaker/host/pswindows/exec_spec.rb
+- spec/beaker/host/pswindows/file_spec.rb
 - spec/beaker/host/pswindows/user_spec.rb
 - spec/beaker/host/pswindows_spec.rb
 - spec/beaker/host/unix/exec_spec.rb