beaker-puppet 0.1.0 → 0.2.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MzZhZjg0NGIxMjBhNDkyMjQ5NGEyYmNjYzljMTYyZDVmZWFhMmM4YQ==
+    YTc4YzBjMDRiNWE2NGYwOWQzODViZTFkZjQ1OTk2ZmYwMGU3M2I1MA==
   data.tar.gz: !binary |-
-    OTQ0YjQ4MTkzOTAzMWU5ZGYwZjZlNTE1ZTg5MGMxNzk0Y2VmNjBlYw==
+    ZTY3ZGFmZWJhZjJiODlkNTk1ZjA2YTk3NWZiMWJiMWFlOTYzNDYwMg==
 SHA512:
   metadata.gz: !binary |-
-    NmY3YTljNDMxOGViNTFlYWM3MDJlNmQ3MmU4OTk0MjdkMjE2Y2RmOGU3OWU0
-    Yjc0ZjRjN2I2YWYyZTU0NjJhNjYwZGMwMTBmNDJiYzg3OTBiMjA5ZGI5NDE0
-    YmQ3NzNkY2NmNDhiNGJjNGY0NjRjMTg4Njg1MDU4YTI0Y2YxZGE=
+    OTNlZGU0NDBlNzllNzNlMWY5ZWRmOGMxYjVlNjEwNzFjYmZkOWIyODZhNzMw
+    ZTU0ODMxNDg5MDdiMTg0ODk3NDk3ZDA5NGRhNWNiYjBiYjZkYmExYjM3NGE2
+    ZWU0MTZjNjA5OWYzMmY0NzE4MmIyOTQ5YTY4Nzk3N2ExNWZlNjE=
   data.tar.gz: !binary |-
-    ZjA3NmY0YTcyMDI3NmMxNjc2MWY2YzllODFjMjc0YTZiODE1MzUzZjc5YzFi
-    YjcyZTcyMTljNmM1YTYyN2IwODI5Y2NkZGU5M2M3ZjgxMDc5OWJjYWY4YTRk
-    ZWUwOTc2M2MwZTAwNjA0MmFmMWMxYjNiNDZkYzk4OTZlOTYyOWY=
+    YjM0Yzc1NmUwNWM4OWEwMjU2NDBjNTgyMTQyYTllYjliYTc0MWQwYjkyN2U4
+    ZmIxOGViZDZmODEwNDExMGJiYjcwZDE3ZmMxNjNkOTQ1OTllMTQ2NGI4Y2Rk
+    MjdmYjM2MDNkNDU1MDAxM2E3OTNhYzdjMWRhMjM3NTcyNzVmZDg=

data/HISTORY.md

@@ -1,8 +1,42 @@
 # worker - History
 ## Tags
-* [LATEST - 16 Jun, 2017 (310921d4)](#LATEST)
+* [LATEST - 28 Jun, 2017 (63cbd942)](#LATEST)
+* [0.1.0 - 16 Jun, 2017 (e9be23b0)](#0.1.0)
 
 ## Details
-### <a name = "LATEST">LATEST - 16 Jun, 2017 (310921d4)
+### <a name = "LATEST">LATEST - 28 Jun, 2017 (63cbd942)
+
+* (GEM) update beaker-puppet version to 0.2.0 (63cbd942)
+
+* Merge pull request #7 from johnduarte/issues/master/bkr-1147/fail-to-pkg-install-on-ec2-el (dd8d640f)
+
+
+```
+Merge pull request #7 from johnduarte/issues/master/bkr-1147/fail-to-pkg-install-on-ec2-el
+
+(BKR-1147) Fail to pkg install on ec2 for dev-repo
+```
+* (BKR-1147) Fail to pkg install on ec2 for dev-repo (89909fa7)
+
+
+```
+(BKR-1147) Fail to pkg install on ec2 for dev-repo
+
+This commit modifies the `install_puppet_agent_dev_repo_on` method
+to install the puppet-agent package if the host is on ec2 and el.
+This is done because the ec2 instance does not have access to the
+default dev repo.
+```
+* Merge pull request #5 from kevpl/bkr895_installutils_tests (e54d7fd2)
+
+
+```
+Merge pull request #5 from kevpl/bkr895_installutils_tests
+
+(BKR-895) add missing install_utils tests
+```
+* (BKR-895) add missing install_utils tests (d6f243ed)
+
+### <a name = "0.1.0">0.1.0 - 16 Jun, 2017 (e9be23b0)
 
 * Initial release.

data/lib/beaker-puppet/install_utils/foss_utils.rb

@@ -1114,8 +1114,8 @@ module Beaker
 
             case variant
             when /^(fedora|el|centos|debian|ubuntu|cumulus|huaweios|cisco_nexus|cisco_ios_xr)$/
-              if arch == 's390x'
-                logger.trace("#install_puppet_agent_dev_repo_on: s390x arch detected for host #{host}. using dev package")
+              if arch== 's390x' || host['hypervisor'] == 'ec2'
+                logger.trace("#install_puppet_agent_dev_repo_on: unsupported host #{host} for repo detected. using dev package")
               else
                 opts[:dev_builds_repos] ||= [ opts[:puppet_collection] ]
                 install_puppetlabs_dev_repo( host, 'puppet-agent', puppet_agent_version, nil, opts )
@@ -1125,7 +1125,7 @@ module Beaker
               end
             when /^(eos|osx|windows|solaris|sles|aix)$/
               # Download installer package file & run install manually.
-              # Done below, so that el hosts with s390x arch can use this
+              # Done below, so that el hosts with s390x arch or on ec2 can use this
               # workflow as well
             else
               raise "No repository installation step for #{variant} yet..."
@@ -1147,7 +1147,7 @@ module Beaker
             case variant
             when /^eos/
               host.install_from_file( release_file )
-            when /^(sles|aix|el)$/
+            when /^(sles|aix|fedora|el|centos)$/
               # NOTE: AIX does not support repo management. This block assumes
               # that the desired rpm has been mirrored to the 'repos' location.
               # NOTE: the AIX 7.1 package will only install on 7.2 with

data/lib/beaker-puppet/version.rb

@@ -1,3 +1,3 @@
 module BeakerPuppet
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/spec/beaker-puppet/install_utils/foss_utils_spec.rb

@@ -0,0 +1,1332 @@
+require 'spec_helper'
+
+class ClassMixedWithDSLInstallUtils
+  include Beaker::DSL::InstallUtils
+  include Beaker::DSL::Wrappers
+  include Beaker::DSL::Helpers
+  include Beaker::DSL::Structure
+  include Beaker::DSL::Roles
+  include Beaker::DSL::Patterns
+
+  def logger
+    @logger ||= RSpec::Mocks::Double.new('logger').as_null_object
+  end
+end
+
+describe ClassMixedWithDSLInstallUtils do
+  let(:metadata)      { @metadata ||= {} }
+  let(:presets)       { Beaker::Options::Presets.new }
+  let(:opts)          { presets.presets.merge(presets.env_vars).merge({ :type => 'foss' }) }
+  let(:basic_hosts)   { make_hosts( { :pe_ver => '3.0',
+                                      :platform => 'linux',
+                                      :roles => [ 'agent' ],
+                                      :type  => 'foss' }, 4 ) }
+  let(:hosts)         { basic_hosts[0][:roles] = ['master', 'database', 'dashboard']
+                        basic_hosts[1][:platform] = 'windows'
+                        basic_hosts[2][:platform] = 'osx-10.9-x86_64'
+                        basic_hosts[3][:platform] = 'eos'
+                        basic_hosts  }
+  let(:hosts_sorted)  { [ hosts[1], hosts[0], hosts[2], hosts[3] ] }
+  let(:winhost)       { make_host( 'winhost', { :platform => 'windows',
+                                                :pe_ver => '3.0',
+                                                :working_dir => '/tmp',
+                                                :type => 'foss',
+                                                :is_cygwin => true} ) }
+  let(:winhost_non_cygwin) { make_host( 'winhost_non_cygwin', { :platform => 'windows',
+                                                :pe_ver => '3.0',
+                                                :working_dir => '/tmp',
+                                                :type => 'foss',
+                                                :is_cygwin => 'false' } ) }
+  let(:machost)       { make_host( 'machost', { :platform => 'osx-10.9-x86_64',
+                                                :pe_ver => '3.0',
+                                                :type => 'foss',
+                                                :working_dir => '/tmp' } ) }
+  let(:freebsdhost9)   { make_host( 'freebsdhost9', { :platform => 'freebsd-9-x64',
+                                                :pe_ver => '3.0',
+                                                :working_dir => '/tmp' } ) }
+  let(:freebsdhost10)   { make_host( 'freebsdhost10', { :platform => 'freebsd-10-x64',
+                                                :pe_ver => '3.0',
+                                                :working_dir => '/tmp' } ) }
+  let(:unixhost)      { make_host( 'unixhost', { :platform => 'linux',
+                                                 :pe_ver => '3.0',
+                                                 :working_dir => '/tmp',
+                                                :type => 'foss',
+                                                 :dist => 'puppet-enterprise-3.1.0-rc0-230-g36c9e5c-debian-7-i386' } ) }
+  let(:eoshost)       { make_host( 'eoshost', { :platform => 'eos',
+                                                :pe_ver => '3.0',
+                                                :working_dir => '/tmp',
+                                                :type => 'foss',
+                                                :dist => 'puppet-enterprise-3.7.1-rc0-78-gffc958f-eos-4-i386' } ) }
+  let(:el6hostaio)    { make_host( 'el6hostaio', { :platform => Beaker::Platform.new('el-6-i386'),
+                                                 :pe_ver => '3.0',
+                                                 :working_dir => '/tmp',
+                                                :type => 'aio',
+                                                 :dist => 'puppet-enterprise-3.1.0-rc0-230-g36c9e5c-centos-6-i386' } ) }
+  let(:el6hostfoss)   { make_host( 'el6hostfoss', { :platform => Beaker::Platform.new('el-6-i386'),
+                                                 :pe_ver => '3.0',
+                                                 :working_dir => '/tmp',
+                                                :type => 'foss',
+                                                 :dist => 'puppet-enterprise-3.1.0-rc0-230-g36c9e5c-centos-6-i386' } ) }
+
+  let(:win_temp)      { 'C:\\Windows\\Temp' }
+
+
+  context '#configure_foss_defaults_on' do
+    it 'uses aio paths for hosts with role aio' do
+      hosts.each do |host|
+        host[:pe_ver] = nil
+        host[:version] = nil
+        host[:roles] = host[:roles] | ['aio']
+      end
+      expect(subject).to receive(:add_foss_defaults_on).exactly(hosts.length).times
+      expect(subject).to receive(:add_aio_defaults_on).exactly(hosts.length).times
+      expect(subject).to receive(:add_puppet_paths_on).exactly(hosts.length).times
+
+      subject.configure_foss_defaults_on( hosts )
+    end
+
+    it 'uses no paths for hosts with no type' do
+      hosts.each do |host|
+        host[:type] = nil
+      end
+      expect(subject).to receive(:add_aio_defaults_on).never
+      expect(subject).to receive(:add_foss_defaults_on).never
+      expect(subject).to receive(:add_puppet_paths_on).never
+
+      subject.configure_foss_defaults_on( hosts )
+    end
+
+    it 'uses aio paths for hosts with aio type (backwards compatability)' do
+      hosts.each do |host|
+        host[:pe_ver] = nil
+        host[:version] = nil
+        host[:type] = 'aio'
+      end
+      expect(subject).to receive(:add_aio_defaults_on).exactly(hosts.length).times
+      expect(subject).to receive(:add_foss_defaults_on).never
+      expect(subject).to receive(:add_puppet_paths_on).exactly(hosts.length).times
+
+      subject.configure_foss_defaults_on( hosts )
+    end
+
+    it 'uses aio paths for hosts of version >= 4.0' do
+      hosts.each do |host|
+        host[:version] = '4.0'
+        host[:pe_ver] = nil
+        host[:roles] = host[:roles] - ['aio']
+      end
+      expect(subject).to receive(:add_aio_defaults_on).exactly(hosts.length).times
+      expect(subject).to receive(:add_foss_defaults_on).exactly(hosts.length).times
+      expect(subject).to receive(:add_puppet_paths_on).exactly(hosts.length).times
+
+      subject.configure_foss_defaults_on( hosts )
+    end
+
+    it 'uses foss paths for hosts of version < 4.0' do
+      hosts.each do |host|
+        host[:version] = '3.8'
+        host[:pe_ver] = nil
+      end
+      expect(subject).to receive(:add_foss_defaults_on).exactly(hosts.length).times
+      expect(subject).to receive(:add_aio_defaults_on).never
+      expect(subject).to receive(:add_puppet_paths_on).exactly(hosts.length).times
+
+      subject.configure_foss_defaults_on( hosts )
+    end
+
+    it 'uses foss paths for foss-like type foss-package' do
+      hosts.each do |host|
+        host[:type] = 'foss-package'
+        host[:version] = '3.8'
+        host[:pe_ver] = nil
+      end
+      expect(subject).to receive(:add_foss_defaults_on).exactly(hosts.length).times
+      expect(subject).to receive(:add_aio_defaults_on).never
+      expect(subject).to receive(:add_puppet_paths_on).exactly(hosts.length).times
+
+      subject.configure_foss_defaults_on( hosts )
+    end
+
+  end
+
+  context 'lookup_in_env' do
+    it 'returns a default properly' do
+      env_var = subject.lookup_in_env('noway', 'nonesuch', 'returnme')
+      expect(env_var).to be == 'returnme'
+      env_var = subject.lookup_in_env('noway', nil, 'returnme')
+      expect(env_var).to be == 'returnme'
+    end
+    it 'finds correct env variable' do
+      allow(ENV).to receive(:[]).with(nil).and_return(nil)
+      allow(ENV).to receive(:[]).with('REALLYNONE').and_return(nil)
+      allow(ENV).to receive(:[]).with('NONESUCH').and_return('present')
+      allow(ENV).to receive(:[]).with('NOWAY_PROJ_NONESUCH').and_return('exists')
+      env_var = subject.lookup_in_env('nonesuch', 'noway-proj', 'fail')
+      expect(env_var).to be == 'exists'
+      env_var = subject.lookup_in_env('nonesuch')
+      expect(env_var).to be == 'present'
+      env_var = subject.lookup_in_env('reallynone')
+      expect(env_var).to be == nil
+      env_var = subject.lookup_in_env('reallynone',nil,'default')
+      expect(env_var).to be == 'default'
+    end
+  end
+
+  context 'build_giturl' do
+    it 'returns urls properly' do
+      allow(ENV).to receive(:[]).with('SERVER').and_return(nil)
+      allow(ENV).to receive(:[]).with('FORK').and_return(nil)
+      allow(ENV).to receive(:[]).with('PUPPET_FORK').and_return(nil)
+      allow(ENV).to receive(:[]).with('PUPPET_SERVER').and_return(nil)
+      url = subject.build_giturl('puppet')
+      expect(url).to be == 'https://github.com/puppetlabs/puppet.git'
+      url = subject.build_giturl('puppet', 'er0ck')
+      expect(url).to be == 'https://github.com/er0ck/puppet.git'
+      url = subject.build_giturl('puppet', 'er0ck', 'bitbucket.com')
+      expect(url).to be == 'https://bitbucket.com/er0ck-puppet.git'
+      url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'https://')
+      expect(url).to be == 'https://github.com/er0ck/puppet.git'
+      url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'https')
+      expect(url).to be == 'https://github.com/er0ck/puppet.git'
+      url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'git@')
+      expect(url).to be == 'git@github.com:er0ck/puppet.git'
+      url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'git')
+      expect(url).to be == 'git@github.com:er0ck/puppet.git'
+      url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'ssh')
+      expect(url).to be == 'git@github.com:er0ck/puppet.git'
+    end
+
+    it 'uses ENV to build urls properly' do
+      allow(ENV).to receive(:[]).with('SERVER').and_return(nil)
+      allow(ENV).to receive(:[]).with('FORK').and_return(nil)
+      allow(ENV).to receive(:[]).with('PUPPET_FORK').and_return('er0ck/repo')
+      allow(ENV).to receive(:[]).with('PUPPET_SERVER').and_return('gitlab.com')
+      url = subject.build_giturl('puppet')
+      expect(url).to be == 'https://gitlab.com/er0ck/repo-puppet.git'
+      url = subject.build_giturl('puppet', 'er0ck')
+      expect(url).to be == 'https://gitlab.com/er0ck-puppet.git'
+      url = subject.build_giturl('puppet', 'er0ck', 'bitbucket.com')
+      expect(url).to be == 'https://bitbucket.com/er0ck-puppet.git'
+      url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'https://')
+      expect(url).to be == 'https://github.com/er0ck/puppet.git'
+      url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'https')
+      expect(url).to be == 'https://github.com/er0ck/puppet.git'
+      url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'git@')
+      expect(url).to be == 'git@github.com:er0ck/puppet.git'
+      url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'git')
+      expect(url).to be == 'git@github.com:er0ck/puppet.git'
+      url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'ssh')
+      expect(url).to be == 'git@github.com:er0ck/puppet.git'
+    end
+  end
+
+  context 'extract_repo_info_from' do
+    [{ :protocol => 'git', :path => 'git://github.com/puppetlabs/project.git' },
+     { :protocol => 'ssh', :path => 'git@github.com:puppetlabs/project.git' },
+     { :protocol => 'https', :path => 'https://github.com:puppetlabs/project' },
+     { :protocol => 'file', :path => 'file:///home/example/project' }
+    ].each do |type|
+      it "handles #{ type[:protocol] } uris" do
+        uri = "#{ type[:path] }#master"
+        repo_info = subject.extract_repo_info_from uri
+        expect( repo_info[:name] ).to be == 'project'
+        expect( repo_info[:path] ).to be ==  type[:path]
+        expect( repo_info[:rev] ).to  be == 'master'
+      end
+    end
+  end
+
+  context 'order_packages' do
+    it 'orders facter, hiera before puppet, before anything else' do
+      named_repos = [
+        { :name => 'puppet_plugin' }, { :name => 'puppet' }, { :name => 'facter' }
+      ]
+      ordered_repos = subject.order_packages named_repos
+      expect( ordered_repos[0][:name] ).to be == 'facter'
+      expect( ordered_repos[1][:name] ).to be == 'puppet'
+      expect( ordered_repos[2][:name] ).to be == 'puppet_plugin'
+    end
+  end
+
+  context 'find_git_repo_versions' do
+    it 'returns a hash of :name => version' do
+      host        = double( 'Host' )
+      repository  = { :name => 'name' }
+      path        = '/path/to/repo'
+      cmd         = 'cd /path/to/repo/name && git describe || true'
+      logger = double.as_null_object
+
+      allow( subject ).to receive( :metadata ).and_return( metadata )
+      expect( subject ).to receive( :logger ).and_return( logger )
+      expect( subject ).to receive( :on ).with( host, cmd ).and_yield
+      expect( subject ).to receive( :stdout ).and_return( '2' )
+
+      subject.instance_variable_set( :@metadata, {} )
+      version = subject.find_git_repo_versions( host, path, repository )
+
+      expect( version ).to be == { 'name' => '2' }
+    end
+  end
+
+  context 'install_puppet_from_rpm_on' do
+    it 'installs PC1 release repo when AIO' do
+      expect(subject).to receive(:install_puppetlabs_release_repo).with(el6hostaio,'pc1',{})
+
+      subject.install_puppet_from_rpm_on( el6hostaio, {}  )
+    end
+
+    it 'installs non-PC1 package when not-AIO' do
+      expect(subject).to receive(:install_puppetlabs_release_repo).with(el6hostfoss,nil,{})
+
+      subject.install_puppet_from_rpm_on( el6hostfoss, {}  )
+    end
+  end
+
+  context 'install_puppet_from_freebsd_ports_on' do
+    it 'installs puppet on FreeBSD 9' do
+      expect(freebsdhost9).to receive(:install_package).with('puppet')
+
+      subject.install_puppet_from_freebsd_ports_on( freebsdhost9, {}  )
+    end
+
+    it 'installs puppet on FreeBSD 10' do
+      expect(freebsdhost10).to receive(:install_package).with('sysutils/puppet')
+
+      subject.install_puppet_from_freebsd_ports_on( freebsdhost10, {}  )
+    end
+  end
+
+  context 'install_puppet_from_msi' do
+    before :each do
+      [winhost, winhost_non_cygwin].each do |host|
+        allow(host).to receive(:system_temp_path).and_return(win_temp)
+      end
+    end
+
+    it 'installs puppet on cygwin windows' do
+      allow(subject).to receive(:link_exists?).and_return( true )
+      expect(subject).to receive(:on).with(winhost, "curl -o \"#{win_temp}\\puppet-3.7.1.msi\" -O http://downloads.puppetlabs.com/windows/puppet-3.7.1.msi")
+      expect(subject).to receive(:on).with(winhost, " echo 'export PATH=$PATH:\"/cygdrive/c/Program Files (x86)/Puppet Labs/Puppet/bin\":\"/cygdrive/c/Program Files/Puppet Labs/Puppet/bin\"' > /etc/bash.bashrc ")
+      expect(subject).to receive(:install_msi_on).with(winhost, "#{win_temp}\\puppet-3.7.1.msi", {}, {:debug => nil})
+
+      subject.install_puppet_from_msi( winhost, {:version => '3.7.1', :win_download_url => 'http://downloads.puppetlabs.com/windows'}  )
+    end
+
+    it 'installs puppet on non-cygwin windows' do
+      allow(subject).to receive(:link_exists?).and_return( true )
+
+      expect(winhost_non_cygwin).to receive(:mkdir_p).with('C:\\ProgramData\\PuppetLabs\\puppet\\etc\\modules')
+
+      expect(subject).to receive(:on).with(winhost_non_cygwin, instance_of( Beaker::Command )) do |host, beaker_command|
+        expect(beaker_command.command).to eq('powershell.exe')
+        expect(beaker_command.args).to eq(["-ExecutionPolicy Bypass", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-Command $webclient = New-Object System.Net.WebClient;  $webclient.DownloadFile('http://downloads.puppetlabs.com/windows/puppet-3.7.1.msi','#{win_temp}\\puppet-3.7.1.msi')"])
+      end.once
+
+      expect(subject).to receive(:install_msi_on).with(winhost_non_cygwin, "#{win_temp}\\puppet-3.7.1.msi", {}, {:debug => nil})
+
+      subject.install_puppet_from_msi( winhost_non_cygwin, {:version => '3.7.1', :win_download_url => 'http://downloads.puppetlabs.com/windows'}   )
+    end
+  end
+
+  context 'clone_git_repo_on' do
+    it 'does a ton of stuff it probably shouldnt' do
+      repo = { :name => 'puppet',
+               :path => 'git://my.server.net/puppet.git',
+               :rev => 'master' }
+      path = '/path/to/repos'
+      host = { 'platform' => 'debian' }
+      logger = double.as_null_object
+
+      allow( subject ).to receive( :metadata ).and_return( metadata )
+      allow( subject ).to receive( :configure_foss_defaults_on ).and_return( true )
+
+      expect( subject ).to receive( :logger ).exactly( 2 ).times.and_return( logger )
+      expect( subject ).to receive( :on ).exactly( 3 ).times
+
+      subject.instance_variable_set( :@metadata, {} )
+      subject.clone_git_repo_on( host, path, repo )
+    end
+
+    it 'allows a checkout depth of 1' do
+      repo   = { :name => 'puppet',
+                 :path => 'git://my.server.net/puppet.git',
+                 :rev => 'master',
+                 :depth => 1 }
+
+      path   = '/path/to/repos'
+      cmd    = "test -d #{path}/#{repo[:name]} || git clone --branch #{repo[:rev]} --depth #{repo[:depth]} #{repo[:path]} #{path}/#{repo[:name]}"
+      host   = { 'platform' => 'debian' }
+      logger = double.as_null_object
+      allow( subject ).to receive( :metadata ).and_return( metadata )
+      allow( subject ).to receive( :configure_foss_defaults_on ).and_return( true )
+      expect( subject ).to receive( :logger ).exactly( 2 ).times.and_return( logger )
+      expect( subject ).to receive( :on ).with( host, "test -d #{path} || mkdir -p #{path}", {:accept_all_exit_codes=>true} ).exactly( 1 ).times
+      # this is the the command we want to test
+      expect( subject ).to receive( :on ).with( host, cmd, {:accept_all_exit_codes=>true} ).exactly( 1 ).times
+      expect( subject ).to receive( :on ).with( host, "cd #{path}/#{repo[:name]} && git remote rm origin && git remote add origin #{repo[:path]} && git fetch origin +refs/pull/*:refs/remotes/origin/pr/* +refs/heads/*:refs/remotes/origin/* && git clean -fdx && git checkout -f #{repo[:rev]}", {:accept_all_exit_codes=>true} ).exactly( 1 ).times
+
+      subject.instance_variable_set( :@metadata, {} )
+      subject.clone_git_repo_on( host, path, repo )
+    end
+
+    it 'allows a checkout depth with a rev from a specific branch' do
+      repo   = { :name => 'puppet',
+                 :path => 'git://my.server.net/puppet.git',
+                 :rev => 'a2340acddadfeafd234230faf',
+                 :depth => 50,
+                 :depth_branch => 'master' }
+
+      path   = '/path/to/repos'
+      cmd    = "test -d #{path}/#{repo[:name]} || git clone --branch #{repo[:depth_branch]} --depth #{repo[:depth]} #{repo[:path]} #{path}/#{repo[:name]}"
+      host   = { 'platform' => 'debian' }
+      allow( subject ).to receive( :configure_foss_defaults_on ).and_return( true )
+      logger = double.as_null_object
+      allow( subject ).to receive( :metadata ).and_return( metadata )
+      expect( subject ).to receive( :logger ).exactly( 2 ).times.and_return( logger )
+      expect( subject ).to receive( :on ).with( host, "test -d #{path} || mkdir -p #{path}", {:accept_all_exit_codes=>true} ).exactly( 1 ).times
+      # this is the the command we want to test
+      expect( subject ).to receive( :on ).with( host, cmd, {:accept_all_exit_codes=>true} ).exactly( 1 ).times
+      expect( subject ).to receive( :on ).with( host, "cd #{path}/#{repo[:name]} && git remote rm origin && git remote add origin #{repo[:path]} && git fetch origin +refs/pull/*:refs/remotes/origin/pr/* +refs/heads/*:refs/remotes/origin/* && git clean -fdx && git checkout -f #{repo[:rev]}", {:accept_all_exit_codes=>true} ).exactly( 1 ).times
+
+      subject.instance_variable_set( :@metadata, {} )
+      subject.clone_git_repo_on( host, path, repo )
+    end
+  end
+
+  context 'install_from_git' do
+    it 'does a ton of stuff it probably shouldnt' do
+      repo = { :name => 'puppet',
+               :path => 'git://my.server.net/puppet.git',
+               :rev => 'master' }
+      path = '/path/to/repos'
+      host = { 'platform' => 'debian' }
+      logger = double.as_null_object
+
+      allow( subject ).to receive( :metadata ).and_return( metadata )
+      allow( subject ).to receive( :configure_foss_defaults_on ).and_return( true )
+
+      expect( subject ).to receive( :logger ).exactly( 3 ).times.and_return( logger )
+      expect( subject ).to receive( :on ).exactly( 4 ).times
+
+      subject.instance_variable_set( :@metadata, {} )
+      subject.install_from_git( host, path, repo )
+    end
+
+    it 'should attempt to install ruby code' do
+      repo   = { :name => 'puppet',
+                 :path => 'git://my.server.net/puppet.git',
+                 :rev => 'master',
+                 :depth => 1 }
+
+      path   = '/path/to/repos'
+      cmd    = "test -d #{path}/#{repo[:name]} || git clone --branch #{repo[:rev]} --depth #{repo[:depth]} #{repo[:path]} #{path}/#{repo[:name]}"
+      host   = { 'platform' => 'debian' }
+      logger = double.as_null_object
+      allow( subject ).to receive( :metadata ).and_return( metadata )
+      allow( subject ).to receive( :configure_foss_defaults_on ).and_return( true )
+      expect( subject ).to receive( :logger ).exactly( 3 ).times.and_return( logger )
+      expect( subject ).to receive( :on ).with( host, "test -d #{path} || mkdir -p #{path}", {:accept_all_exit_codes=>true} ).exactly( 1 ).times
+      expect( subject ).to receive( :on ).with( host, cmd, {:accept_all_exit_codes=>true} ).exactly( 1 ).times
+      expect( subject ).to receive( :on ).with( host, "cd #{path}/#{repo[:name]} && git remote rm origin && git remote add origin #{repo[:path]} && git fetch origin +refs/pull/*:refs/remotes/origin/pr/* +refs/heads/*:refs/remotes/origin/* && git clean -fdx && git checkout -f #{repo[:rev]}", {:accept_all_exit_codes=>true} ).exactly( 1 ).times
+      expect( subject ).to receive( :on ).with( host, "cd #{path}/#{repo[:name]} && if [ -f install.rb ]; then ruby ./install.rb ; else true; fi", {:accept_all_exit_codes=>true} ).exactly( 1 ).times
+
+      subject.instance_variable_set( :@metadata, {} )
+      subject.install_from_git_on( host, path, repo )
+    end
+   end
+
+  describe '#install_puppet' do
+    let(:hosts) do
+      make_hosts({:platform => platform })
+    end
+
+    before do
+      allow( subject ).to receive(:options).and_return(opts)
+      allow( subject ).to receive(:hosts).and_return(hosts)
+      allow( subject ).to receive(:on).and_return(Beaker::Result.new({},''))
+    end
+    context 'on el-6' do
+      let(:platform) { Beaker::Platform.new('el-6-i386') }
+      it 'installs' do
+        expect(hosts[0]).to receive(:install_package_with_rpm).with(/puppetlabs-release-el-6\.noarch\.rpm/, '--replacepkgs', {:package_proxy=>false})
+        expect(hosts[0]).to receive(:install_package).with('puppet')
+        subject.install_puppet
+      end
+      it 'installs in parallel' do
+        InParallel::InParallelExecutor.logger = logger
+        FakeFS.deactivate!
+        hosts.each{ |host|
+          allow(host).to receive(:install_package_with_rpm).with(/puppetlabs-release-el-6\.noarch\.rpm/, '--replacepkgs', {:package_proxy=>false})
+          allow(host).to receive(:install_package).with('puppet')
+        }
+        opts[:run_in_parallel] = true
+        # This will only get hit if forking processes is supported and at least 2 items are being submitted to run in parallel
+        expect( InParallel::InParallelExecutor ).to receive(:_execute_in_parallel).with(any_args).and_call_original.exactly(3).times
+        subject.install_puppet(opts)
+      end
+      it 'installs specific version of puppet when passed :version' do
+        expect(hosts[0]).to receive(:install_package).with('puppet-3')
+        subject.install_puppet( :version => '3' )
+      end
+      it 'can install specific versions of puppets dependencies' do
+        expect(hosts[0]).to receive(:install_package).with('puppet-3')
+        expect(hosts[0]).to receive(:install_package).with('hiera-2001')
+        expect(hosts[0]).to receive(:install_package).with('facter-1999')
+        subject.install_puppet( :version => '3', :facter_version => '1999', :hiera_version => '2001' )
+      end
+    end
+    context 'on el-5' do
+      let(:platform) { Beaker::Platform.new('el-5-i386') }
+      it 'installs' do
+        expect(hosts[0]).to receive(:install_package_with_rpm).with(/puppetlabs-release-el-5\.noarch\.rpm/, '--replacepkgs', {:package_proxy=>false})
+        expect(hosts[0]).to receive(:install_package).with('puppet')
+        subject.install_puppet
+      end
+    end
+    context 'on fedora' do
+      let(:platform) { Beaker::Platform.new('fedora-18-x86_84') }
+      it 'installs' do
+        expect(hosts[0]).to receive(:install_package_with_rpm).with(/puppetlabs-release-fedora-18\.noarch\.rpm/, '--replacepkgs', {:package_proxy=>false})
+        expect(hosts[0]).to receive(:install_package).with('puppet')
+        subject.install_puppet
+      end
+    end
+    context 'on archlinux' do
+      let(:platform) { Beaker::Platform.new('archlinux-2015.09.01-x86_84') }
+      it 'installs' do
+        expect(hosts[0]).to receive(:install_package).with('puppet')
+        subject.install_puppet
+      end
+    end
+    context 'on debian' do
+      PlatformHelpers::DEBIANPLATFORMS.each do |platform|
+        let(:platform) { Beaker::Platform.new("#{platform}-ver-arch") }
+        it "installs latest on #{platform} if given no version info" do
+          hosts.each do |host|
+            expect(subject).to receive(:install_puppetlabs_release_repo).with(host)
+          end
+          expect(hosts[0]).to receive(:install_package).with('puppet')
+          subject.install_puppet
+        end
+      end
+      it 'installs specific version of puppet when passed :version' do
+        expect(hosts[0]).to receive(:install_package).with('puppet=3-1puppetlabs1')
+        expect(hosts[0]).to receive(:install_package).with('puppet-common=3-1puppetlabs1')
+        subject.install_puppet( :version => '3' )
+      end
+      it 'can install specific versions of puppets dependencies' do
+        expect(hosts[0]).to receive(:install_package).with('facter=1999-1puppetlabs1')
+        expect(hosts[0]).to receive(:install_package).with('hiera=2001-1puppetlabs1')
+        expect(hosts[0]).to receive(:install_package).with('puppet-common=3-1puppetlabs1')
+        expect(hosts[0]).to receive(:install_package).with('puppet=3-1puppetlabs1')
+        subject.install_puppet( :version => '3', :facter_version => '1999', :hiera_version => '2001' )
+      end
+    end
+    context 'on windows' do
+      let(:platform) { Beaker::Platform.new('windows-2008r2-i386') }
+
+      before :each do
+        allow(winhost).to receive(:tmpdir).and_return(win_temp)
+        allow(winhost).to receive(:is_cygwin?).and_return(true)
+        allow(subject).to receive(:link_exists?).and_return( true )
+        allow(subject).to receive(:install_msi_on).with(any_args)
+      end
+
+      it 'installs specific version of puppet when passed :version' do
+        hosts.each do |host|
+          if host != winhost
+            allow(subject).to receive(:on).with(host, anything)
+          else
+            expect(subject).to receive(:on).with(winhost, "curl -o \"#{win_temp}\\puppet-3.msi\" -O http://downloads.puppetlabs.com/windows/puppet-3.msi")
+            expect(subject).to receive(:on).with(winhost, " echo 'export PATH=$PATH:\"/cygdrive/c/Program Files (x86)/Puppet Labs/Puppet/bin\":\"/cygdrive/c/Program Files/Puppet Labs/Puppet/bin\"' > /etc/bash.bashrc ")
+            expect(subject).to receive(:install_msi_on).with(winhost, "#{win_temp}\\puppet-3.msi", {}, {:debug => nil}).exactly(1).times
+          end
+        end
+        subject.install_puppet(:version => '3')
+      end
+      it 'installs from custom url when passed :win_download_url' do
+        hosts.each do |host|
+          if host != winhost
+            allow(subject).to receive(:on).with(host, anything)
+          else
+            expect(subject).to receive(:on).with(winhost, "curl -o \"#{win_temp}\\puppet-3.msi\" -O http://nightlies.puppetlabs.com/puppet-latest/repos/windows/puppet-3.msi")
+            expect(subject).to receive(:install_msi_on).with(winhost, "#{win_temp}\\puppet-3.msi", {}, {:debug => nil})
+          end
+        end
+        subject.install_puppet( :version => '3', :win_download_url => 'http://nightlies.puppetlabs.com/puppet-latest/repos/windows' )
+      end
+    end
+    describe 'on unsupported platforms' do
+      let(:platform) { Beaker::Platform.new('solaris-11-x86_64') }
+      let(:host) { make_host('henry', :platform => 'solaris-11-x86_64') }
+      let(:hosts) { [host] }
+      it 'by default raises an error' do
+        expect(subject).to_not receive(:on)
+        expect { subject.install_puppet }.to raise_error(/unsupported platform/)
+      end
+      it 'falls back to installing from gem when given :default_action => "gem_install"' do
+        result = double
+        gem_env_string = '{"RubyGems Environment": [ {"GEM PATHS": [], "EXECUTABLE DIRECTORY": "/does/not/exist" } ] }'
+        allow( result ).to receive(:stdout).and_return gem_env_string
+        allow(subject).to receive(:on).with(host, /gem environment/).and_return result
+        expect(subject).to receive(:on).with(host, /gem install/)
+        subject.install_puppet :default_action => 'gem_install'
+      end
+    end
+  end
+
+  describe 'configure_puppet_on' do
+    context 'on debian' do
+      PlatformHelpers::DEBIANPLATFORMS.each do |platform|
+        let(:platform) { Beaker::Platform.new("#{platform}-ver-arch") }
+        let(:host) { make_host('testbox.test.local', :platform => "#{platform}") }
+        it "it sets the puppet.conf file to the provided config on #{platform}" do
+          config = { 'main' => {'server' => 'testbox.test.local'} }
+          expected_config_string = "[main]\nserver=testbox.test.local\n\n"
+
+          expect( subject ).to receive( :create_remote_file ).with(
+              host, anything, expected_config_string
+          )
+          subject.configure_puppet_on(host, config)
+        end
+      end
+    end
+    context 'on windows' do
+      let(:platform) { 'windows-2008R2-amd64' }
+      let(:host) { make_host('testbox.test.local', :platform => 'windows-2008R2-amd64') }
+
+      it 'it sets the puppet.conf file to the provided config' do
+        config = { 'main' => {'server' => 'testbox.test.local'} }
+        expected_config_string = "[main]\nserver=testbox.test.local\n\n"
+
+        expect( subject ).to receive( :create_remote_file ).with(
+          host, anything, expected_config_string
+        )
+        subject.configure_puppet_on(host, config)
+      end
+    end
+  end
+
+  describe 'configure_puppet' do
+    let(:hosts) do
+      make_hosts({:platform => platform })
+    end
+
+    before do
+      allow( subject ).to receive(:hosts).and_return(hosts)
+      allow( subject ).to receive(:on).and_return(Beaker::Result.new({},''))
+    end
+
+    context 'on debian' do
+      PlatformHelpers::DEBIANPLATFORMS.each do |platform|
+        let(:platform) { Beaker::Platform.new("#{platform}-ver-arch") }
+        it "calls configure_puppet_on correctly on #{platform}" do
+          config = { 'main' => {'server' => 'testbox.test.local'} }
+          expect( subject ).to receive( :configure_puppet_on ).with(
+              anything, config
+          ).exactly( hosts.length ).times
+          subject.configure_puppet(config)
+        end
+      end
+    end
+
+    context 'on windows' do
+      let(:platform) { 'windows-2008R2-amd64' }
+
+      it 'calls configure_puppet_on correctly' do
+        config = { 'main' => {'server' => 'testbox.test.local'} }
+        expect( subject ).to receive( :configure_puppet_on ).with(
+          anything, config
+        ).exactly( hosts.length ).times
+        subject.configure_puppet(config)
+      end
+    end
+  end
+
+  describe "#install_puppetlabs_release_repo" do
+    let( :platform ) { Beaker::Platform.new('solaris-7-i386') }
+    let( :host ) do
+      FakeHost.create('fakevm', platform.to_s)
+    end
+
+    before do
+      allow(subject).to receive(:options) { opts }
+      allow( subject ).to receive( :configure_foss_defaults_on ).and_return( true )
+    end
+
+    describe "When host is unsupported platform" do
+      let( :platform ) { Beaker::Platform.new('solaris-7-i386') }
+
+      it "raises an exception." do
+        expect{
+          subject.install_puppetlabs_release_repo host
+        }.to raise_error(RuntimeError, /No repository installation step for/)
+      end
+    end
+
+    describe "When host is a debian-like platform" do
+      let( :platform ) { Beaker::Platform.new('debian-7-i386') }
+
+      it "downloads a deb file, installs, and updates the apt cache." do
+        expect(subject).to receive(:on).with( host, /wget .*/ ).ordered
+        expect(subject).to receive(:on).with( host, /dpkg .*/ ).ordered
+        expect(subject).to receive(:on).with( host, "apt-get update" ).ordered
+        subject.install_puppetlabs_release_repo host
+      end
+
+    end
+
+  end
+
+  describe '#install_puppetlabs_release_repo_on' do
+    let( :host ) do
+      FakeHost.create( 'fakevm', platform.to_s )
+    end
+
+    before :each do
+      allow( subject ).to receive( :options ) { opts }
+    end
+
+    context 'on cisco platforms' do
+      context 'version 5' do
+        let( :platform ) { Beaker::Platform.new( 'cisco_nexus-7-x86_64' ) }
+
+        it 'calls host.install_package' do
+          expect( host ).to receive( :install_package ).with( /\.rpm$/ )
+          subject.install_puppetlabs_release_repo_on( host )
+        end
+      end
+
+      context 'version 7' do
+        let( :platform ) { Beaker::Platform.new( 'cisco_ios_xr-6-x86_64' ) }
+
+        it 'uses yum localinstall to install the package' do
+          expect( subject ).to receive( :on ).with( host, /^yum.*localinstall.*\.rpm$/ )
+          subject.install_puppetlabs_release_repo_on( host )
+        end
+      end
+    end
+
+  end
+
+  describe "#install_puppetlabs_dev_repo" do
+    let( :package_name ) { "puppet" }
+    let( :package_version ) { "7.5.6" }
+    let( :host ) do
+      h = FakeHost.create('fakvm', platform.to_s, opts)
+      allow( h ).to receive( :link_exists? ).and_return( true )
+      h
+    end
+    let( :logger_double ) do
+      logger_double = Object.new
+      allow(logger_double).to receive(:debug)
+      allow(logger_double).to receive(:trace)
+      allow( subject ).to receive( :configure_foss_defaults_on ).and_return( true )
+      subject.instance_variable_set(:@logger, logger_double)
+      logger_double
+    end
+
+    RSpec.shared_examples "install-dev-repo" do
+
+      it "scp's files to SUT then modifies them with find-and-sed 2-hit combo" do
+        allow(rez).to receive(:exit_code) { 0 }
+        allow(subject).to receive(:link_exists?).and_return(true)
+        expect(subject).to receive(:scp_to).with( host, repo_config, /.*/ ).ordered
+        subject.install_puppetlabs_dev_repo host, package_name, package_version
+      end
+
+    end
+
+    describe "When host is unsupported platform" do
+      let( :platform ) { Beaker::Platform.new('solaris-7-i386') }
+
+      it "raises an exception." do
+        # expect(subject).to receive(:on).with( host, /^mkdir -p .*$/ ).ordered
+        allow(subject).to receive(:options) { opts }
+        expect{
+          subject.install_puppetlabs_dev_repo host, package_name, package_version
+        }.to raise_error(RuntimeError, /No repository installation step for/)
+      end
+    end
+
+    describe 'When on supported platforms' do
+      # These are not factored into the `before` block above because they
+      # are expectations in the share examples, but aren't interesting
+      # beyond those basic tests
+      def stub_uninteresting_portions_of_install_puppetlabs_dev_repo!
+        allow(subject).to receive(:scp_to).with( host, repo_config, /.*/ ).ordered
+      end
+
+      let( :repo_config ) { "repoconfig" }
+      let( :repo_dir ) { "repodir" }
+      let( :rez ) { double }
+
+      before do
+        allow(subject).to receive(:fetch_http_file) { repo_config }
+        allow(subject).to receive(:fetch_http_dir) { repo_dir }
+        allow(subject).to receive(:on).with(host, "apt-get update") { }
+        allow(subject).to receive(:options) { opts }
+        allow(subject).to receive(:on).with( host, /^.* -d .*/, {:acceptable_exit_codes =>[0,1]} ).and_return(rez)
+      end
+
+      describe "that are debian-like" do
+        PlatformHelpers::DEBIANPLATFORMS.each do |platform|
+          let(:platform) { Beaker::Platform.new("#{platform}-ver-arch") }
+          before { allow(subject).to receive(:link_exists?).and_return(true) }
+
+          include_examples "install-dev-repo"
+
+        end
+      end
+
+      describe "that are redhat-like" do
+        let( :platform ) { Beaker::Platform.new('el-7-i386') }
+        include_examples "install-dev-repo"
+      end
+    end
+  end
+
+  describe '#install_packages_from_local_dev_repo' do
+    let( :package_name ) { 'puppet-agent' }
+    let( :platform ) { @platform || 'other' }
+    let( :host ) do
+      FakeHost.create('fakvm', platform, opts)
+    end
+
+    before :each do
+      allow( subject ).to receive( :configure_foss_defaults_on ).and_return( true )
+    end
+
+    it 'sets the find command correctly for el-based systems' do
+      @platform = 'el-1-3'
+      expect( subject ).to receive( :on ).with( host, /\*\.rpm.+rpm\s-ivh/ )
+      subject.install_packages_from_local_dev_repo( host, package_name )
+    end
+
+    it 'sets the find command correctly for debian-based systems' do
+      @platform = 'debian-1-3'
+      expect( subject ).to receive( :on ).with( host, /\*\.deb.+dpkg\s-i/ )
+      subject.install_packages_from_local_dev_repo( host, package_name )
+    end
+
+    it 'fails correctly for systems not accounted for' do
+      @platform = 'eos-1-3'
+      expect{ subject.install_packages_from_local_dev_repo( host, package_name ) }.to raise_error RuntimeError
+    end
+
+  end
+
+  describe '#install_puppet_agent_from_msi_on' do
+    let( :opts )     { { :puppet_agent_version => 'VERSION', :win_download_url => 'http://downloads.puppetlabs.com/windows' } }
+    let( :platform ) { 'windows' }
+    let( :host )     { { :platform => platform } }
+
+    it 'returns error when link incorrect' do
+      allow(subject).to receive(:link_exists?).with(anything()).and_return( false )
+      expect( host ).to receive( :is_x86_64? ).and_return( true )
+
+      expect{
+        subject.install_puppet_agent_from_msi_on( host, opts )
+      }.to raise_error(RuntimeError, /Puppet MSI at http:\/\/downloads.puppetlabs.com\/windows\/puppet-agent-VERSION-x64.msi does not exist!/)
+    end
+
+    it 'uses x86 msi when host is_x86_64 and install_32 is set on the host' do
+      host['install_32'] = true
+
+      expect( host ).to receive( :is_x86_64? ).and_return( true )
+      expect( subject ).to receive( :install_a_puppet_msi_on ).with( host, opts )
+
+      subject.install_puppet_agent_from_msi_on( host, opts )
+      expect( host['dist'] ).to be == "puppet-agent-VERSION-x86"
+
+    end
+
+    it 'uses x86 msi when host is_x86_64 and install_32 is set on the options' do
+      opts['install_32'] = true
+
+      expect( host ).to receive( :is_x86_64? ).and_return( true )
+      expect( subject ).to receive( :install_a_puppet_msi_on ).with( host, opts )
+
+      subject.install_puppet_agent_from_msi_on( host, opts )
+      expect( host['dist'] ).to be == "puppet-agent-VERSION-x86"
+
+    end
+
+    it 'uses x86 msi when host is_x86_64 and ruby_arch is x86 on the host' do
+      host['ruby_arch'] = 'x86'
+
+      expect( host ).to receive( :is_x86_64? ).and_return( true )
+      expect( subject ).to receive( :install_a_puppet_msi_on ).with( host, opts )
+
+      subject.install_puppet_agent_from_msi_on( host, opts )
+      expect( host['dist'] ).to be == "puppet-agent-VERSION-x86"
+
+    end
+
+    it 'uses x86 msi when host !is_x86_64' do
+
+      expect( host ).to receive( :is_x86_64? ).and_return( false )
+      expect( subject ).to receive( :install_a_puppet_msi_on ).with( host, opts )
+
+      subject.install_puppet_agent_from_msi_on( host, opts )
+      expect( host['dist'] ).to be == "puppet-agent-VERSION-x86"
+
+    end
+
+    it 'uses x64 msi when host is_x86_64, no install_32 and ruby_arch != x86' do
+
+      expect( host ).to receive( :is_x86_64? ).and_return( true )
+      expect( subject ).to receive( :install_a_puppet_msi_on ).with( host, opts )
+
+      subject.install_puppet_agent_from_msi_on( host, opts )
+      expect( host['dist'] ).to be == "puppet-agent-VERSION-x64"
+
+    end
+  end
+
+  describe '#install_puppet_agent_pe_promoted_repo_on' do
+
+
+
+  end
+
+  describe '#install_cert_on_windows' do
+    before do
+      allow(subject).to receive(:on).and_return(Beaker::Result.new({},''))
+    end
+
+    context 'on windows' do
+      let(:platform) { 'windows-2008R2-amd64' }
+      let(:host) { make_host('testbox.test.local', :platform => 'windows-2008R2-amd64') }
+
+      it 'should install all 3 certs' do
+        cert = 'geotrust_global_ca'
+        content = <<-EOM
+        -----BEGIN CERTIFICATE-----
+        MIIDVDCCAjygAwIBAgIDAjRWMA0GCSqGSIb3DQEBBQUAMEIxCzAJBgNVBAYTAlVT
+        MRYwFAYDVQQKEw1HZW9UcnVzdCBJbmMuMRswGQYDVQQDExJHZW9UcnVzdCBHbG9i
+        YWwgQ0EwHhcNMDIwNTIxMDQwMDAwWhcNMjIwNTIxMDQwMDAwWjBCMQswCQYDVQQG
+        EwJVUzEWMBQGA1UEChMNR2VvVHJ1c3QgSW5jLjEbMBkGA1UEAxMSR2VvVHJ1c3Qg
+        R2xvYmFsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA2swYYzD9
+        9BcjGlZ+W988bDjkcbd4kdS8odhM+KhDtgPpTSEHCIjaWC9mOSm9BXiLnTjoBbdq
+        fnGk5sRgprDvgOSJKA+eJdbtg/OtppHHmMlCGDUUna2YRpIuT8rxh0PBFpVXLVDv
+        iS2Aelet8u5fa9IAjbkU+BQVNdnARqN7csiRv8lVK83Qlz6cJmTM386DGXHKTubU
+        1XupGc1V3sjs0l44U+VcT4wt/lAjNvxm5suOpDkZALeVAjmRCw7+OC7RHQWa9k0+
+        bw8HHa8sHo9gOeL6NlMTOdReJivbPagUvTLrGAMoUgRx5aszPeE4uwc2hGKceeoW
+        MPRfwCvocWvk+QIDAQABo1MwUTAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBTA
+        ephojYn7qwVkDBF9qn1luMrMTjAfBgNVHSMEGDAWgBTAephojYn7qwVkDBF9qn1l
+        uMrMTjANBgkqhkiG9w0BAQUFAAOCAQEANeMpauUvXVSOKVCUn5kaFOSPeCpilKIn
+        Z57QzxpeR+nBsqTP3UEaBU6bS+5Kb1VSsyShNwrrZHYqLizz/Tt1kL/6cdjHPTfS
+        tQWVYrmm3ok9Nns4d0iXrKYgjy6myQzCsplFAMfOEVEiIuCl6rYVSAlk6l5PdPcF
+        PseKUgzbFbS9bZvlxrFUaKnjaZC2mqUPuLk/IH2uSrW4nOQdtqvmlKXBx4Ot2/Un
+        hw4EbNX/3aBd7YdStysVAq45pmp06drE57xNNB6pXE0zX5IJL4hmXXeXxx12E6nV
+        5fEWCRE11azbJHFwLJhWC9kXtNHjUStedejV0NxPNO3CBWaAocvmMw==
+        -----END CERTIFICATE-----
+        EOM
+
+        expect(subject).to receive(:create_remote_file) do |host, file_path, file_content|
+          expect(file_path).to eq("C:\\Windows\\Temp\\#{cert}.pem")
+        end
+
+        expect(subject).to receive(:on) do |host, command|
+          expect(command).to eq("certutil -v -addstore Root C:\\Windows\\Temp\\#{cert}.pem")
+        end
+
+        subject.install_cert_on_windows(host, cert, content)
+      end
+    end
+  end
+
+  describe '#install_puppet_agent_dev_repo_on' do
+    let( :package_name ) { 'puppet-agent' }
+    let( :platform ) { @platform || 'other' }
+    let( :host ) do
+      FakeHost.create( 'fakvm', platform, opts )
+    end
+
+    before :each do
+      allow( subject ).to receive( :configure_foss_defaults_on ).and_return( true )
+    end
+
+    it 'raises an exception when host platform is unsupported' do
+      platform = Object.new()
+      allow(platform).to receive(:to_array) { ['ptan', '5', 'x4']}
+      host = basic_hosts.first
+      host['platform'] = platform
+      opts = { :version => '0.1.0' }
+      allow( subject ).to receive( :options ).and_return( {} )
+
+      expect{
+        subject.install_puppet_agent_dev_repo_on( host, opts )
+      }.to raise_error(RuntimeError, /No repository installation step for/)
+    end
+
+    it 'runs the correct install for el-based platforms' do
+      platform = Object.new()
+      allow(platform).to receive(:to_array) { ['el', '5', 'x4']}
+      host = basic_hosts.first
+      host['platform'] = platform
+      sha_value = 'ereiuwoiur'
+      opts = { :version => '0.1.0', :puppet_agent_sha => sha_value }
+      allow( subject ).to receive( :options ).and_return( {} )
+
+      expect( subject ).to receive( :install_puppetlabs_dev_repo ).with(
+        host, 'puppet-agent', sha_value, nil, anything )
+      expect( host ).to receive( :install_package ).with( 'puppet-agent' )
+
+      subject.install_puppet_agent_dev_repo_on( host, opts )
+    end
+
+    it 'runs the correct install for el-based platforms on s390x architectures' do
+      platform = Object.new()
+      allow(platform).to receive(:to_array) { ['el', '5', 's390x'] }
+      host = basic_hosts.first
+      host['platform'] = platform
+      sha_value = 'ereiuwoiur'
+      opts = { :version => '0.1.0', :puppet_agent_sha => sha_value }
+      allow( subject ).to receive( :options ).and_return( {} )
+
+      release_path_end = 'fake_release_path_end'
+      release_file = 'fake_29835_release_file'
+      expect( host ).to receive( :puppet_agent_dev_package_info ).and_return(
+        [ release_path_end, release_file ] )
+
+      expect(subject).not_to receive(:install_puppetlabs_dev_repo)
+      expect(host).not_to receive(:install_package)
+
+      expect(subject).to receive(:fetch_http_file).once.with(/#{release_path_end}$/, release_file, /\/el$/)
+      expect(subject).to receive(:scp_to).once.with(host, /#{release_file}$/, anything)
+      expect(subject).to receive(:on).ordered.with(host, /rpm -ivh.*#{release_file}$/)
+
+      subject.install_puppet_agent_dev_repo_on( host, opts )
+    end
+
+    it 'runs the correct agent install for el-based platforms on ec2 hypervisor' do
+      platform = Object.new()
+      allow(platform).to receive(:to_array) { ['el', '5', 'x4'] }
+      host = basic_hosts.first
+      host['platform'] = platform
+      host['hypervisor'] = 'ec2'
+      sha_value = 'ereiuwoiur'
+      opts = { :version => '0.1.0', :puppet_agent_sha => sha_value }
+      allow( subject ).to receive( :options ).and_return( {} )
+
+      release_path_end = 'fake_release_path_end'
+      release_file = 'fake_29835_release_file'
+      expect( host ).to receive( :puppet_agent_dev_package_info ).and_return(
+        [ release_path_end, release_file ] )
+
+      expect(subject).not_to receive(:install_puppetlabs_dev_repo)
+      expect(host).not_to receive(:install_package)
+
+      expect(subject).to receive(:fetch_http_file).once.with(/#{release_path_end}$/, release_file, /\/el$/)
+      expect(subject).to receive(:scp_to).once.with(host, /#{release_file}$/, anything)
+      expect(subject).to receive(:on).ordered.with(host, /rpm -ivh.*#{release_file}$/)
+
+      subject.install_puppet_agent_dev_repo_on( host, opts )
+    end
+
+    it 'runs the correct install for debian-based platforms' do
+      platform = Object.new()
+      allow(platform).to receive(:to_array) { ['debian', '5', 'x4']}
+      host = basic_hosts.first
+      host['platform'] = platform
+      sha_value = 'ereigregerge'
+      opts = { :version => '0.1.0', :puppet_agent_sha => sha_value }
+      allow( subject ).to receive( :options ).and_return( {} )
+
+      expect( subject ).to receive( :install_puppetlabs_dev_repo ).with(
+        host, 'puppet-agent', sha_value, nil, anything )
+      expect( host ).to receive( :install_package ).with( 'puppet-agent' )
+
+      subject.install_puppet_agent_dev_repo_on( host, opts )
+    end
+
+    it 'runs the correct install for windows platforms' do
+      platform = Object.new()
+      allow(platform).to receive(:to_array) { ['windows', '5', 'x64']}
+      host = winhost
+      external_copy_base = 'tmp_install_windows_copy_base_1325'
+      allow( host ).to receive( :external_copy_base ).and_return( external_copy_base )
+      host['platform'] = platform
+      opts = { :version => '0.1.0' }
+      allow( subject ).to receive( :options ).and_return( {} )
+      copied_path = "#{win_temp}\\puppet-agent-0.1.0-x86.msi"
+      mock_echo = Object.new()
+      allow( mock_echo ).to receive( :raw_output ).and_return( copied_path )
+
+      expect(subject).to receive(:fetch_http_file).once.with(/\/windows$/, 'puppet-agent-0.1.0-x86.msi', /\/windows$/)
+      expect(subject).to receive(:scp_to).once.with(host, /\/puppet-agent-0.1.0-x86.msi$/, /#{external_copy_base}/)
+      expect(subject).to receive(:install_msi_on).with(host, copied_path, {}, {:debug => nil}).once
+      expect(subject).to receive(:on).ordered.with(host, /echo/).and_return(mock_echo)
+
+      subject.install_puppet_agent_dev_repo_on( host, opts )
+    end
+
+    it 'runs the correct install for osx platforms' do
+      platform = Object.new()
+      allow(platform).to receive(:to_array) { ['osx', '10.9', 'x86_64', 'mavericks']}
+      host = machost
+      host['platform'] = platform
+      sha_value = 'runs the correct install for osx platforms'
+      copy_dir_external = 'fake_15_copy_dir_external'
+      opts = {
+        :version => '0.1.0',
+        :puppet_agent_sha => sha_value,
+        :copy_dir_external => copy_dir_external
+      }
+
+      release_path_end = 'fake_release_path_end'
+      release_file = 'fake_29835_release_file'
+      expect( host ).to receive( :puppet_agent_dev_package_info ).and_return(
+        [ release_path_end, release_file ] )
+
+      expect(subject).to receive(:fetch_http_file).once.with(/#{release_path_end}$/, release_file, /\/osx$/)
+      expect(subject).to receive(:scp_to).once.with(host, /#{release_file}$/, copy_dir_external)
+      # the star is necessary, as that's not the entire filename, & we rely on
+      # the globbing to get this right on OSX SUTs
+      expect(host).to receive( :install_package ).with( /^puppet-agent-0.1.0\*$/ )
+
+      subject.install_puppet_agent_dev_repo_on( host, opts )
+    end
+
+    it 'runs the correct install for solaris platforms' do
+      @platform = 'solaris-10-x86_64'
+      opts = { :version => '0.1.0' }
+      allow( subject ).to receive( :options ).and_return( {} )
+
+      release_path_end = 'fake_release_path_end'
+      release_file = 'fake_sol10_8495_release_file'
+      expect( host ).to receive( :puppet_agent_dev_package_info ).and_return(
+        [ release_path_end, release_file ] )
+
+      expect( subject ).to receive( :fetch_http_file ).once.with(
+        /#{release_path_end}$/, release_file, anything )
+      expect( subject ).to receive( :scp_to ).once.with(
+        host, /#{release_file}$/, anything )
+
+      expect( host ).to receive( :solaris_install_local_package )
+
+      allow( subject ).to receive( :configure_type_defaults_on )
+      subject.install_puppet_agent_dev_repo_on( host, opts )
+    end
+
+    it 'allows you to override the local copy directory' do
+      # only applies to hosts that don't go down the
+      # install_puppetlabs_dev_repo route
+      platform = Object.new()
+      allow( platform ).to receive( :to_array ) { ['eos', '5', 'x4'] }
+      host = eoshost
+      host['platform'] = platform
+      sha_value = 'dahdahdahdah'
+      copy_base_local_override = 'face'
+      opts = {
+        :version => '0.1.0',
+        :copy_base_local => copy_base_local_override,
+        :puppet_agent_sha => sha_value
+      }
+      allow( subject ).to receive( :options ).and_return( {} )
+
+      allow( host ).to receive( :puppet_agent_dev_package_info ).and_return( ['', ''] )
+
+      allow( host ).to receive( :get_remote_file).once.with(anything)
+      allow( host ).to receive( :install_from_file )
+
+      subject.install_puppet_agent_dev_repo_on( host, opts )
+    end
+
+    it 'allows you to override the external copy directory' do
+      platform = Object.new()
+      allow(platform).to receive(:to_array) { ['osx', '5', 'x4']}
+      host = basic_hosts.first
+      host['platform'] = platform
+      copy_dir_custom = 'muppetsBB8-1435'
+      opts = { :version => '0.1.0', :copy_dir_external => copy_dir_custom }
+      allow( subject ).to receive( :options ).and_return( {} )
+
+      allow( host ).to receive( :puppet_agent_dev_package_info ).and_return( ['', ''] )
+
+      allow( subject ).to receive( :fetch_http_file ).once
+      expect( subject ).to receive( :scp_to ).once.with(
+        host, anything, /#{copy_dir_custom}/ )
+      allow( host ).to receive( :install_package )
+
+      subject.install_puppet_agent_dev_repo_on( host, opts )
+    end
+
+    it 'copies package to the cygwin root directory and installs it' do
+      @platform = 'windows-7-x86_64'
+      expect( subject ).to receive( :install_msi_on ).with( any_args )
+      copy_base = 'copy_base_cygwin'
+      allow( host ).to receive( :external_copy_base ).and_return( copy_base )
+      expect( subject ).to receive( :scp_to ).with( host, /puppet-agent-1\.0\.0-x86\.msi/, /#{copy_base}/ )
+      expect( subject ).to receive( :configure_type_defaults_on ).with(host)
+      expect( subject ).to receive( :fetch_http_file ).with( /[^\/]\z/, anything, anything )
+      subject.install_puppet_agent_dev_repo_on( host, opts.merge({ :puppet_agent_version => '1.0.0' }) )
+    end
+
+    it 'installs on different hosts without erroring' do
+      mhosts = hosts
+      mhosts[3] = eoshost
+
+      mhosts.each_with_index do |host, index|
+        platform = Object.new()
+        if index == 0
+          allow(platform).to receive(:to_array) { ['solaris', '5', 'x4']}
+          allow(host).to receive(:external_copy_base) {'/host0'}
+        elsif index == 1
+          allow(platform).to receive(:to_array) { ['windows', '5', 'x4']}
+          allow(host).to receive(:external_copy_base) {'/host1'}
+        elsif index == 2
+          allow(platform).to receive(:to_array) { ['osx', '5', 'x4']}
+          allow(host).to receive(:external_copy_base) {'/host2'}
+        elsif index == 3
+          allow(platform).to receive(:to_array) { ['eos', '5', 'x4']}
+          allow(host).to receive(:external_copy_base) {'/host3'}
+        end
+        host['platform'] = platform
+        allow(host).to receive(:puppet_agent_dev_package_info).with(any_args).and_return(["test", "blah"])
+      end
+
+      expect( subject ).to receive(:add_role).with( any_args ).exactly(mhosts.length).times
+
+      expect( subject ).to receive(:fetch_http_file).with( any_args ).exactly(3).times
+      expect( subject ).to receive(:scp_to).with( any_args ).exactly(3).times
+
+      expect( subject ).to receive(:install_msi_on).with( mhosts[1], 'xyz', {}, anything).exactly(1).times
+      expect( mhosts[0] ).to receive(:solaris_install_local_package).with( "blah", "/host0" ).exactly(1).times
+      expect( mhosts[2] ).to receive(:install_package).with( any_args ).exactly(1).times
+      expect( mhosts[3] ).to receive(:install_from_file).with( "blah" ).exactly(1).times
+
+      result = object_double(Beaker::Result.new({}, "foo"), :raw_output=> "xyz")
+      allow(subject).to receive(:on).with(mhosts[1], anything).and_return(result)
+
+      expect( subject ).to receive(:configure_type_defaults_on).with( any_args ).exactly(mhosts.length).times
+
+      subject.install_puppet_agent_dev_repo_on( mhosts, opts.merge({:puppet_agent_version => '1.0.0' }) )
+    end
+
+    it 'installs on different hosts with options specifying :copy_dir_external' do
+      mhosts = hosts
+      mhosts[3] = eoshost
+
+      mhosts.each_with_index do |host, index|
+        platform = Object.new()
+        if index == 0
+          allow(platform).to receive(:to_array) { ['solaris', '5', 'x4']}
+          allow(host).to receive(:external_copy_base) {'/host0'}
+        elsif index == 1
+          allow(platform).to receive(:to_array) { ['windows', '5', 'x4']}
+          allow(host).to receive(:external_copy_base) {'/host1'}
+        elsif index == 2
+          allow(platform).to receive(:to_array) { ['osx', '5', 'x4']}
+          allow(host).to receive(:external_copy_base) {'/host2'}
+        elsif index == 3
+          allow(platform).to receive(:to_array) { ['eos', '5', 'x4']}
+          allow(host).to receive(:external_copy_base) {'/host3'}
+        end
+        allow(host).to receive(:puppet_agent_dev_package_info).with(any_args).and_return(["test", "/blah"])
+        host['platform'] = platform
+      end
+
+      expect( subject ).to receive(:add_role).with( any_args ).exactly(mhosts.length).times
+
+      expect( subject ).to receive(:fetch_http_file).with( any_args ).exactly(3).times
+      expect( subject ).to receive(:scp_to).with( any_args ).exactly(3).times
+
+      expect( subject ).to receive(:install_msi_on).with(mhosts[1], 'xyz', {}, anything ).exactly(1).times
+      expect( mhosts[0] ).to receive(:solaris_install_local_package).with( '/blah', '/tmp').exactly(1).times
+      expect( mhosts[2] ).to receive(:install_package).with( any_args ).exactly(1).times
+      expect( mhosts[3] ).to receive(:install_from_file).with( '/blah').exactly(1).times
+      expect( mhosts[0] ).to receive(:external_copy_base).with( no_args ).exactly(0).times
+      expect( mhosts[1] ).to receive(:external_copy_base).with( no_args ).exactly(0).times
+      expect( mhosts[2] ).to receive(:external_copy_base).with( no_args ).exactly(0).times
+      expect( mhosts[3] ).to receive(:external_copy_base).with( no_args ).exactly(0).times
+
+      result = object_double(Beaker::Result.new({}, "foo"), :raw_output=> "xyz")
+      allow(subject).to receive(:on).with(mhosts[1], anything).and_return(result)
+
+      expect( subject ).to receive(:configure_type_defaults_on).with( any_args ).exactly(mhosts.length).times
+
+      subject.install_puppet_agent_dev_repo_on( mhosts, opts.merge({:puppet_agent_version => '1.0.0', :copy_dir_external => '/tmp' }) )
+    end
+  end
+
+  describe '#install_puppet_agent_pe_promoted_repo_on' do
+    let( :package_name ) { 'puppet-agent' }
+    let( :platform ) { @platform || 'other' }
+    let( :host ) do
+      FakeHost.create( 'fakvm', platform, opts )
+    end
+
+    before :each do
+      allow( subject ).to receive( :configure_foss_defaults_on ).and_return( true )
+      allow( subject ).to receive( :install_msi_on ).with( any_args )
+    end
+
+    def test_fetch_http_file_no_ending_slash(platform)
+      @platform = platform
+      allow( subject ).to receive( :scp_to )
+      allow( subject ).to receive( :configure_type_defaults_on ).with(host)
+
+      expect( subject ).to receive( :fetch_http_file ).with( /[^\/]\z/, anything, anything )
+      subject.install_puppet_agent_pe_promoted_repo_on( host, opts )
+    end
+
+    context 'on windows' do
+
+      it 'calls fetch_http_file with no ending slash' do
+        test_fetch_http_file_no_ending_slash( 'windows-7-x86_64' )
+      end
+    end
+
+    it 'calls fetch_http_file with no ending slash' do
+      test_fetch_http_file_no_ending_slash( 'debian-5-x86_64' )
+    end
+  end
+
+  describe '#remove_puppet_on' do
+    supported_platforms   = [ 'aix-53-power',
+                              'aix-61-power',
+                              'aix-71-power',
+                              'solaris-10-x86_64',
+                              'solaris-10-x86_64',
+                              'solaris-11-x86_64',
+                              'cumulus-2.2-amd64',
+                              'el-6-x86_64',
+                              'redhat-7-x86_64',
+                              'centos-7-x86_64',
+                              'oracle-7-x86_64',
+                              'scientific-7-x86_64',
+                              'sles-10-x86_64',
+                              'sles-11-x86_64',
+                              'sles-12-s390x'
+                            ]
+
+    supported_platforms.each do |platform|
+      let(:host) { make_host(platform, :platform => platform) }
+
+      pkg_list = 'foo bar'
+
+      it "uninstalls packages on #{platform}" do
+        result = Beaker::Result.new(host,'')
+        result.stdout = pkg_list
+
+        expected_list = pkg_list
+        cmd_args = ''
+
+        expect( subject ).to receive(:on).exactly(2).times.and_return(result, result)
+        expect( host ).to receive(:uninstall_package).with(expected_list, cmd_args)
+
+        subject.remove_puppet_on( host )
+      end
+    end
+
+    let(:ubuntu12) { make_host('ubuntu-1204-amd64', :platform => 'ubuntu-1204-amd64') }
+    it 'raises error on unsupported platforms' do
+      expect { subject.remove_puppet_on( ubuntu12 ) }.to raise_error(RuntimeError, /unsupported platform/)
+    end
+
+  end
+
+end