bea_api 0.0.6 → 0.0.7

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZDM4NWI2OWE3OTQ4OWRiMmZiYTI2NTMzMzQ4YmNkNjk5MGU1MGI2OQ==
+    MWJiNjliZTIwOGU1ZTJhOGM3MmE2OGVjMGUxYmZlZjYyOTNhMjY2Zg==
   data.tar.gz: !binary |-
-    OGJhMGUzNjdkNmE1OWI4MjhmMGNjYzUzMWU3MWI3NzM1YzFhZmYwMg==
+    NGQ5NmRlYmRhZDFhYzk4ZTEzYTNkYmE2ZTFjYjRjNjQxNDFmNzYwMg==
 SHA512:
   metadata.gz: !binary |-
-    MTdlYjAyODI5Zjk2Mzc5NzhlNmJkOWFkMTdkZmQ5NWMwZjJiZGQ2ZGEyNjY2
-    ZWNhMjdiOGZjODVhZDZhNDIwOGQ5ODExZTJhNmNhMTE2ODdkNmNmOGQ3YTE2
-    OGI3OWJmMjhhYWEwMzdkMjY0MDcwZGFlZjY4YzVhYTExNjFiNTk=
+    NmFlMTI5ZDFmNzhkYmYwNzVhZTg2NTczZGQzNWMyYzY4NmRhN2YxODQwY2Jj
+    NjM4MWUzN2Y3NmU0YzdlNWM3NTRmNzlmZjU0MGMwNDExYjBjNzg3NWYzMTdj
+    N2U1MjAyNjIzNDFmMzVkYTE1OTk3MmY4YzUwNGFkNzI0MDk1NmQ=
   data.tar.gz: !binary |-
-    OGRiNzg5OTZiMDUwYmVjYTU0OGM3ZDZmNTUzN2RhYjRjZDNhMmE4NjRjYTk2
-    MjE3NWZlOGEwNmFhM2RhNDQzYWFmNDg3MDNmYjEzMzc5YzA5ODdiZTFiMjcz
-    ZDg4YjIzOTJmNDI2OGViYTAxNDhhYjcyNTdlYzczZWY4NDEyOWI=
+    MTU3Y2Y4YmEzNmVhZTIwNDkxZTUzMGFjM2FjZGE5MjE5YTRjNWViY2I0YTI5
+    MTk3MmE3NGVlNzEzMWVlODRiYjQwZDQyNTNmYjkyNTlmNzVlZjg0NmM0MWM1
+    YTA1MjRjY2MxNWFiNjk3NDJhNzhiZWI3ZTllZjljNzIwMGRmZTU=

data/lib/bea_api/request.rb

@@ -54,14 +54,9 @@ module BeaApi
     end
 
     def _parse_data(response)
-      if (!response["BEAAPI"]["Results"]["Data"].nil?)
-        h = response["BEAAPI"]["Results"]["Data"]
-      elsif (!response["BEAAPI"]["Data"].nil?)
-        h = response["BEAAPI"]["Data"]
-      else
-        h = response["BEAAPI"]["Results"].first[1]
-      end
-      h
+      h   = response["BEAAPI"]["Results"]["Data"]
+      h ||= response["BEAAPI"]["Data"]
+      h ||= response["BEAAPI"]["Results"].first[1]
     end
 
     def _parse_notes(response)

data/lib/bea_api/version.rb

@@ -1,3 +1,3 @@
 module BeaApi
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end

data/spec/bea_api/client_spec.rb

@@ -16,10 +16,22 @@ describe BeaApi::Client do
 
     it 'should initialize with an api_key' do
       VCR.use_cassette('initialize_client') do
-        @client = BeaApi::Client.new(api_key)
+        expect { @client = BeaApi::Client.new(api_key) }.not_to raise_error
         expect(@client.api_key).to eq(api_key)
       end
     end
+
+    it 'should throw an HTTP error' do
+      VCR.use_cassette('initialize_http_error') do
+        url = BeaApi::Request::BEA_URL
+        begin
+          expect { BeaApi::Request::BEA_URL = 'http://example.com/404' }.to output(/already initialized constant/).to_stderr
+          expect { @client = BeaApi::Client.new(api_key) }.to raise_error
+        ensure
+          expect { BeaApi::Request::BEA_URL = url }.to output(/already initialized constant/).to_stderr
+        end
+      end
+    end
   end
 
   describe 'get datasets' do
@@ -115,7 +127,7 @@ describe BeaApi::Client do
         VCR.use_cassette('get data for RegionalData with valid parameters') do
           @client = BeaApi::Client.new(api_key)
           r = @client.get_data(dataset, { "KeyCode" => "PCPI_CI", "GeoFIPS" => "STATE:00000,01000,02000,04000", "Year" => 2009 } )
-          expect(r.response.count).to eq(4)
+          expect(r.response.count).to be > 0
         end
       end
     end
@@ -132,7 +144,7 @@ describe BeaApi::Client do
         VCR.use_cassette('get data for NIPA with valid parameters') do
           @client = BeaApi::Client.new(api_key)
           r = @client.get_data(dataset, { "TableID" => 1, "Frequency" => "A", "Year" => 2009 } )
-          expect(r.response.count).to eq(25)
+          expect(r.response.count).to be > 0
         end
       end
     end
@@ -149,7 +161,7 @@ describe BeaApi::Client do
         VCR.use_cassette('get data for NI Underlying Detail with valid parameters') do
           @client = BeaApi::Client.new(api_key)
           r = @client.get_data(dataset, { "TableID" => 79, "Frequency" => "A", "Year" => 2004 } )
-          expect(r.response.count).to eq(30)
+          expect(r.response.count).to be > 0
         end
       end
     end
@@ -166,7 +178,7 @@ describe BeaApi::Client do
         VCR.use_cassette('get data for MNE with valid parameters') do
           @client = BeaApi::Client.new(api_key)
           r = @client.get_data(dataset, { "DirectionOfInvestment" => 'inward', "Classification" => "Country", "Year" => 2009, "State" => "01" } )
-          expect(r.response.count).to eq(1544)
+          expect(r.response.count).to be > 0
         end
       end
     end
@@ -183,7 +195,7 @@ describe BeaApi::Client do
         VCR.use_cassette('get data for FixedAssets with valid parameters') do
           @client = BeaApi::Client.new(api_key)
           r = @client.get_data(dataset, { "TableID" => 1, "Year" => 2009 } )
-          expect(r.response.count).to eq(24)
+          expect(r.response.count).to be > 0
         end
       end
     end
@@ -224,7 +236,7 @@ describe BeaApi::Client do
         VCR.use_cassette('get data for IIP with valid parameters') do
           @client = BeaApi::Client.new(api_key)
           r = @client.get_data(dataset, { "Frequency" => "A", "Year" => 2009 } )
-          expect(r.response.count).to eq(450)
+          expect(r.response.count).to be > 0
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bea_api
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Chad Hoersten