bc-lightstep-ruby 1.1.6 → 1.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae2b58de5cad4cb1d3f95f0392e8e5a2f26bc92d7166f0786973d1db2365c34c
-  data.tar.gz: fb76f4e5520ae29ba6c9cf51765ea4ef29b953478edece1d0d613bd38969b7a1
+  metadata.gz: 402c34ffb90db4b5f068099b70c80cc933dc8f4f5f4914de05bd2c09398842a7
+  data.tar.gz: af092007c4a9a2ceca3bebd200e332e38c2539e8438a3ec9a840a7c03aaf66e5
 SHA512:
-  metadata.gz: ce9814bbece997fe409cf3bf369a7c4ee086b14c486e9d16eeae7bd10ffe9a9a69b2d60c591dd111587dbfa5d485da82091211b72d829b27fb2ee22e2c21ff41
-  data.tar.gz: 6112a5d04acc35a38109cc5541fd88d2571e7ba699ec64a1bde19007bf442ed2c482619de4b65b8ae035a94eb4d5c9554c5dc10c9065891833b6744543074932
+  metadata.gz: 1adafe2e08b065730025e548b6711b6c6ec673f0c92e022d7b6cd9bf2cef8547ca0867efb3b9b692eccb3f929f2277c8338700ca22c38ef68653fc5ba1c2951b
+  data.tar.gz: dd4ebff9ddbc843051745e3762a1bc0d8ac2790b5341483192e22dee990718221191c6f20850cec6f68f38ce1e8f914df3b99c0e85e6d056ef8d2c0f795a67a5

data/CHANGELOG.md

@@ -2,6 +2,12 @@ Changelog for the bc-lightstep-ruby gem.
 
 h3. Pending Release
 
+h3. 1.1.7
+
+- Better handling of exceptions and tagged errors
+- Lower timeouts for collector connections to reduce impact if collector is down/unreachable
+- Always ensure spans are reported even in the case of exceptional failure 
+
 h3. 1.1.6
 
 - First OSS release

data/README.md

@@ -1,6 +1,6 @@
 # bc-lightstep-ruby - LightStep distributed tracing
 
-[![Build Status](https://travis-ci.com/bigcommerce/bc-lightstep-ruby.svg?token=D3Cc4LCF9BgpUx4dpPpv&branch=master)](https://travis-ci.com/bigcommerce/bc-lightstep-ruby)
+[![Build Status](https://travis-ci.com/bigcommerce/bc-lightstep-ruby.svg?token=D3Cc4LCF9BgpUx4dpPpv&branch=master)](https://travis-ci.com/bigcommerce/bc-lightstep-ruby) [![Gem Version](https://badge.fury.io/rb/bc-lightstep-ruby.svg)](https://badge.fury.io/rb/bc-lightstep-ruby) [![Inline docs](http://inch-ci.org/github/bigcommerce/bc-lightstep-ruby.svg?branch=master)](http://inch-ci.org/github/bigcommerce/bc-lightstep-ruby)
 
 Adds [LightStep](https://lightstep.com) tracing support for Ruby. This is an extension of the 
 [LightStep ruby gem](https://github.com/lightstep/lightstep-tracer-ruby) and adds extra functionality and resiliency.
@@ -8,7 +8,7 @@ Adds [LightStep](https://lightstep.com) tracing support for Ruby. This is an ext
 ## Installation
 
 ```ruby
-gem 'bc-lightstep-ruby', git: 'git@github.com/bigcommerce/bc-lightstep-ruby'
+gem 'bc-lightstep-ruby'
 ```
 
 Then in an initializer or before use:
@@ -48,7 +48,7 @@ bc-lightstep-ruby can be automatically configured from these ENV vars, if you'd
 | LIGHTSTEP_SSL_VERIFY_PEER | If using 443 as the port, toggle SSL verification. Defaults to true. |
 | LIGHTSTEP_VERBOSITY | The verbosity level of lightstep logs. Defaults to 1. |
 
-Most BC systems will only need to customize the component name.
+Most systems will only need to customize the component name.
 
 ### Instrumenting Rails Controllers
 
@@ -70,7 +70,7 @@ end
 
 Spans will be built with the external service name. It's generally _not_ a good idea to use the Faraday adapter
 with internal services that are also instrumented with LightStep - use the Faraday adapter on external services
-or systems outside of our instrumenting control. 
+or systems outside of your instrumenting control. 
 
 ## License
 

data/lib/bigcommerce/lightstep/rails_controller_instrumentation.rb

@@ -56,6 +56,7 @@ module Bigcommerce
         headers.each do |k, v|
           fk = k.to_s.downcase.gsub('http_', '').tr('_', '-')
           next unless OPEN_TRACING_HEADER_KEYS.include?(fk)
+
           filtered_ot_headers[fk] = v
         end
         filtered_ot_headers

data/lib/bigcommerce/lightstep/tracer.rb

@@ -58,13 +58,18 @@ module Bigcommerce
         self.active_span = span
 
         # run the process
-        result = yield span
-
-        # finish this span if the reporter is initialized
-        span.finish if reporter_initialized?
-
-        # now set back the parent as the active span
-        self.active_span = last_active_span
+        begin
+          result = yield span
+        rescue StandardError
+          span.set_tag('error', true)
+          raise
+        ensure
+          # finish this span if the reporter is initialized
+          span.finish if reporter_initialized?
+
+          # now set back the parent as the active span
+          self.active_span = last_active_span
+        end
 
         # return result
         result

data/lib/bigcommerce/lightstep/transport.rb

@@ -47,8 +47,8 @@ module Bigcommerce
         verbose: 0,
         encryption: ENCRYPTION_TLS,
         ssl_verify_peer: true,
-        open_timeout: 20,
-        read_timeout: 20,
+        open_timeout: 2,
+        read_timeout: 2,
         continue_timeout: nil,
         keep_alive_timeout: 2,
         logger: nil
@@ -64,7 +64,9 @@ module Bigcommerce
         @keep_alive_timeout = keep_alive_timeout.to_i
 
         raise ::Bigcommerce::Lightstep::Errors::InvalidAccessToken, 'access_token must be a string' unless access_token.is_a?(String)
+
         raise ::Bigcommerce::Lightstep::Errors::InvalidAccessToken, 'access_token cannot be blank'  if access_token.empty?
+
         @access_token = access_token.to_s
         @logger = logger || ::Logger.new(STDOUT)
       end

data/lib/bigcommerce/lightstep/version.rb

@@ -15,6 +15,6 @@
 #
 module Bigcommerce
   module Lightstep
-    VERSION = '1.1.6'.freeze
+    VERSION = '1.1.7'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bc-lightstep-ruby
 version: !ruby/object:Gem::Version
-  version: 1.1.6
+  version: 1.1.7
 platform: ruby
 authors:
 - Shaun McCormick
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-06 00:00:00.000000000 Z
+date: 2018-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler