bbr 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5206e2906defefb4036a52d112acfc7af7fde7bf
-  data.tar.gz: 52427a4d6e6dd5ffa52fc47cac29db4e2a3c5901
+  metadata.gz: 0b952dd23a4593e8211abea713f57043c68ee9e1
+  data.tar.gz: 90730c15a0c7f350f19aa8e49dc30f7e90f7a652
 SHA512:
-  metadata.gz: 8e9b06cff2c82f4dc63ce097019e1f79a495c74b4f636a3aab0383302e9be418c202ecc2d626689db381211bcbac2e959522683caa27f90d5c9be2bea155f17c
-  data.tar.gz: 19b4eabca26002133e609dab5810975185cfb81507cb500ea1a51cdfd178683266883056fbfd234499396e67052928cb224ac05df9a370199fc4ecf001890dc9
+  metadata.gz: dc738b79f72bffdd1b46fe61123be3083cc4416bb54bdedb21d514d2189f1a14e6dbc6f1011427ea5e3111ebdb672ceaed7f8f1c15bff00ee64e39fd614bcca6
+  data.tar.gz: 2c02b86122de465ccfa58057945723458f9446297eb07f29aa310b4fd8cb06c3a6aef6e3da759d2380f3040aa4ddc20ae8f6e4c83702ac136f6959ce9cdc5176

data/CHANGELOG.md

@@ -9,3 +9,8 @@
 ## v.1.0.2
 
 * change response format
+
+## v.1.0.3
+
+* add attr accessors to BBR module
+* change response structure

data/README.md

@@ -24,9 +24,10 @@ Or install it yourself as:
 ## Usage
 
 ### ENVIRONMENT VARIABLES
+in initializer
 ```ruby
-ENV['BBR_USERNAME']='xxxx'
-ENV['BBR_PASSWORD']='xxxx'
+BBR.username = ENV['BBR_USERNAME']
+BBR.password = ENV['BBR_PASSWORD']
 ```
 Contact Nicolai or Jesper for credentials if you are a member of the Abtion Team
 

data/lib/bbr/get_building_data_from_id.rb

@@ -25,8 +25,8 @@ module BBR
           building: {
             age: (Time.now.year - response.at_xpath("//Opfoerselsaar").try(:content).to_i).to_i,
             area: response.at_xpath("//BebyggetAreal").try(:content),
+            floors: response.at_xpath("//AntalEtager").try(:content),
             roof: {
-              type: response.at_xpath("//Tagdaekningsmateriale/Value").try(:content),
               material: response.at_xpath("//Tagdaekningsmateriale/Value").try(:content),
               area: response.at_xpath("//UdnyttetTagetageareal").try(:content)
 
@@ -37,9 +37,6 @@ module BBR
             },
             outer_wall: {
               material: response.at_xpath("//Ydervaegsmateriale/Value").try(:content),
-            },
-            floor: {
-              numbers: response.at_xpath("//AntalEtager").try(:content)
             }
           }
         }

data/lib/bbr/version.rb

@@ -1,3 +1,3 @@
 module Bbr
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/lib/bbr.rb

@@ -6,6 +6,10 @@ require 'bbr/get_id_from_address'
 require 'bbr/get_building_data_from_id'
 
 module BBR
+  class << self
+    attr_accessor :username, :password
+  end
+
   def self.building_data_from_address(address)
     building_data_from_bbr_id(bbr_id_from_address(address))
   end
@@ -49,8 +53,8 @@ private
         <soapenv:Header>
           <Security xmlns="http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd">
             <UsernameToken>
-                <Username>#{ ENV['BBR_USERNAME'] }</Username>
-                <Password>#{ ENV['BBR_PASSWORD'] }</Password>
+                <Username>#{ BBR.username }</Username>
+                <Password>#{ BBR.password }</Password>
             </UsernameToken>
           </Security>
         </soapenv:Header>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bbr
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Jesper Sørensen & Nicolai Seerup