bbc_standards 0.1.1 → 0.1.3

data/lib/bbc_standards/validator.rb

@@ -7,7 +7,7 @@ module BBCStandards
     def initialize(xml)
       @xml = xml
       # TODO: remove this once Barlesque sorts out the BBC Search form
-      @xml.sub!('<form method="get" action="http://search.bbc.co.uk/search" accept-charset="utf-8"><fieldset><input',
+      @xml.sub!('<form method="get" action="http://search.bbc.co.uk/search" accept-charset="utf-8"> <fieldset>  <input',
         '<form method="get" action="http://search.bbc.co.uk/search" accept-charset="utf-8"><fieldset><legend>foo</legend><input')
       @doc = Nokogiri::HTML(xml)
       @errors = []
@@ -57,14 +57,25 @@ module BBCStandards
     end
     
     def test_bbc_standards
+      rt = Raakt::Test.new(@xml)
+      # Check title structure
       @errors << Error.new("Title is not valid") unless @xml =~ /<title>\w+( - )?([^<-]+)?( - )?([^<-]+)?<\/title>/
+      # Check 1 h1 tag
       @errors << Error.new("Page doesn't have 1 <h1> tag") unless @doc.xpath('//h1').size == 1
-      @errors << Error.new("Page doesn't have any <h2> tags") unless @doc.xpath('//h2').size > 0
+      # Check heading structure
+      @errors << Error.new("Document heading structure is wrong") unless rt.check_document_structure.size == 0
+      # Check images have alt tags
+      @errors += rt.check_images.map { |e| Error.new(e.text) }
+      # Check images have width and height attributes
+      @errors += @doc.xpath('//img[not(@width) or not(@height)]').map { |img| Error.new("No width or height attribute for #{img.to_s}") }
+      # Check use of <br/> for whitespace (more than one consecutive <br/>)
       @errors << Error.new("Page is using <br> for whitespace") if @xml =~ /<br\/>\s*<br\/>/
-      %w(b i font marquee).each do |tag|
+      # Check for banned tags
+      %w(b i big blink marquee s strike tt u center nobr font).each do |tag|
         @errors << Error.new("Page is using <#{tag}>") if @doc.xpath("//#{tag}").any?
       end
     end
+    
   end
   
   class Error

data/lib/bbc_standards.rb

@@ -5,5 +5,5 @@ require 'bbc_standards/validator'
 require 'bbc_standards/rspec'
 
 module BBCStandards
-  VERSION = '0.1.1'
+  VERSION = '0.1.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: bbc_standards
 version: !ruby/object:Gem::Version 
-  version: 0.1.1
+  version: 0.1.3
 platform: ruby
 authors: 
 - Patrick Sinclair
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-01-07 00:00:00 +00:00
+date: 2010-04-06 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -63,6 +63,6 @@ rubyforge_project:
 rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
-summary: What this thing does
+summary: BBCStandards provides rspec helpers for checking whether documents conform to the BBC FM&T Guidelines and Standards.
 test_files: []