bbc-a11y 0.0.16 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8dd9e7e73e7a90b1f1a0151176196f940e149c8e
-  data.tar.gz: f793efc23dc248e5c1261368ea5f5ec0c2ec3e16
+  metadata.gz: a03ce44ea3d9fc6824112a5764a70b34008e2391
+  data.tar.gz: baeaa81881cefee49c813497c0a946a8d8cc4768
 SHA512:
-  metadata.gz: db950a702d499d56739b17087ee83b69ffd62c0548ee91e9b91d3dfa1e4d8dcfd740505dfcd708803be56690f2913e4994b008c516fefbd79dde54b80720a012
-  data.tar.gz: 9c2706280a6e6767469c2af7c1fea8c6abb1d88288034b02dd4c34742e518eaa22aa3cef34255c2a9505a0349f0d39179d838de090a28e8ff458c8d4f5757535
+  metadata.gz: f0488992d7713f61ecf7a540f3c674808e4bcd87bb302ef9cd695f185dfec776beada3a00060e5ad49541fa1275dc478f9415277b77054b9a3811a717fd6d249
+  data.tar.gz: c0b23d60238dc0ca04091a4df5dacecf1cfc88a9d5e097177c1918840b44516f0846511dcdeec0507cace911996e60a7d57ea27426e46aea9e17ff15e54e91a3

data/bbc-a11y.gemspec

@@ -14,6 +14,8 @@ Gem::Specification.new do |s|
   s.required_ruby_version = ">= 1.9.3"
 
   s.add_dependency 'capybara'
+  s.add_dependency 'phantomjs'
+  s.add_dependency 'poltergeist'
   s.add_dependency 'colorize'
 
   s.add_development_dependency 'rspec',  '~> 3.0'

data/circle.yml

@@ -0,0 +1,3 @@
+test:
+  override:
+    - bundle exec rake

data/features/check_standards/focusable_controls.feature

@@ -42,7 +42,7 @@ Feature: Focusable Controls
           <li><a href="#entertainmenttab">Entertainment</a></li>
       </ul>
       """
-    When I validate the anchor hrefs standards
+    When I validate the "anchors must have hrefs" standard
     Then it passes
 
   Scenario: Some anchor tags do not have href attributes
@@ -54,7 +54,7 @@ Feature: Focusable Controls
           <li><a>Entertainment</a></li>
       </ul>
       """
-    When I validate the anchor hrefs standards
+    When I validate the "anchors must have hrefs" standard
     Then it fails with the message:
       """
       Anchor has no href attribute: /html/body/ul/li[1]/a

data/features/check_standards/form_interactions.feature

@@ -27,7 +27,7 @@ Feature: Form Interactions
         <input type="submit" value="Search">
       </form>
       """
-    When I validate the form submit buttons standards
+    When I validate the "forms must have submit buttons" standard
     Then it passes
 
   Scenario: Form with no submit button
@@ -38,7 +38,7 @@ Feature: Form Interactions
         <input type="text" name="q" id="q">
       </form>
       """
-    When I validate the form submit buttons standards
+    When I validate the "forms must have submit buttons" standard
     Then it fails with the message:
       """
       Form has no submit button: /html/body/form
@@ -52,6 +52,5 @@ Feature: Form Interactions
         <button type="submit">Search</button>
       </form>
       """
-    When I validate the form submit buttons standards
+    When I validate the "forms must have submit buttons" standard
     Then it passes
-

data/features/check_standards/form_labels.feature

@@ -29,7 +29,7 @@ Feature: Correctly use form labels
 
       <input type="text" name="q" title="Search the BBC" />
       """
-    When I validate the form labels standards
+    When I validate the "fields must have labels or titles" standard
     Then it passes
 
   Scenario: Some fields without labels or title attributes
@@ -44,7 +44,7 @@ Feature: Correctly use form labels
       <input type="text" name="q" aria-label="Search the BBC" />
       <input type="text" name="q" placeholder="Search the BBC" />
       """
-    When I validate the form labels standards
+    When I validate the "fields must have labels or titles" standard
     Then it fails with the message:
       """
       Field has no label or title attribute: /html/body/textarea
@@ -60,5 +60,5 @@ Feature: Correctly use form labels
       """
       <input type=hidden name=a value=b>
       """
-    When I validate the form labels standards
-    Then it passes
+    When I validate the "fields must have labels or titles" standard
+    Then it passes

data/features/check_standards/headings.feature

@@ -23,10 +23,10 @@ Feature: Headings
       """
       <h2>Heading 2</h2>
       """
-    When I validate the heading standards
+    When I validate the "exactly one main heading" standard
     Then it fails with the message:
       """
-      A document must have exactly one main heading. Found 0 h1 elements.
+      Found 0 h1 elements.
       """
 
   Scenario: More than one main heading
@@ -36,10 +36,10 @@ Feature: Headings
       <h2>Heading 2</h2>
       <h1>Heading 1</h1>
       """
-    When I validate the heading standards
+    When I validate the "exactly one main heading" standard
     Then it fails with the message:
       """
-      A document must have exactly one main heading. Found 2 h1 elements.
+      Found 2 h1 elements: /html/body/h1[1] /html/body/h1[2]
       """
 
   Scenario: Headings in ascending order
@@ -52,7 +52,7 @@ Feature: Headings
       <h5>Heading 5</h5>
       <h6>Heading 6</h6>
       """
-    When I validate the heading standards
+    When I validate the "headings must be in ascending order" standard
     Then it passes
 
   Scenario: Headings in invalid order
@@ -62,10 +62,10 @@ Feature: Headings
       <h3>Heading 3</h3>
       <h2>Heading 2</h2>
       """
-    When I validate the heading standards
+    When I validate the "headings must be in ascending order" standard
     Then it fails with the message:
       """
-      Headings are not in order: h1 is followed by h3
+      Headings are not in order: /html/body/h1 /html/body/h3
       """
 
   Scenario: Headings jump back up more than one level
@@ -78,7 +78,7 @@ Feature: Headings
       <h2>Heading 2b</h2>
       <h3>Heading 3b</h3>
       """
-    When I validate the heading standards
+    When I validate the "headings must be in ascending order" standard
     Then it passes
 
   Scenario: Heading is hidden
@@ -88,10 +88,10 @@ Feature: Headings
       <h3 style="display:none">Heading 3</h3>
       <h2>Heading 2</h2>
       """
-    When I validate the heading standards
+    When I validate the "headings must be in ascending order" standard
     Then it fails with the message:
       """
-      Headings are not in order: h1 is followed by h3
+      Headings are not in order: /html/body/h1 /html/body/h3
       """
 
   Scenario: Heading in a script tag
@@ -103,7 +103,7 @@ Feature: Headings
       </script>
       <h2>Heading 2</h2>
       """
-    When I validate the heading standards
+    When I validate the "headings must be in ascending order" standard
     Then it passes
 
   Scenario: Subheading before the first main heading
@@ -113,7 +113,7 @@ Feature: Headings
       <h1>Heading 1</h1>
       <h2>Heading 2</h2>
       """
-    When I validate the heading standards
+    When I validate the "headings must be in ascending order" standard
     Then it passes
 
     Scenario: Content between headings
@@ -125,13 +125,14 @@ Feature: Headings
           <h2>Another heading</h2>
           <p>non-heading content</p>
           <h3>Main content</h3>
+          non-heading content
           <h2>Secondary content</h2>
           <p>non-heading content</p>
           <h2>Tertiary content</h2>
-          <p>Lorem ipsum…</p>
+          non-heading content
         </div>
         """
-      When I validate the heading standards
+      When I validate the "content must follow headings" standard
       Then it passes
 
   Scenario: No content between headings
@@ -145,8 +146,8 @@ Feature: Headings
         <p>non-heading content</p>
       </div>
       """
-    When I validate the heading standards
+    When I validate the "content must follow headings" standard
     Then it fails with the message:
       """
-      Heading elements must be followed by content. No content follows a h2.
+      No content follows: /html/body/div/h2[1]
       """

data/features/check_standards/image_alt.feature

@@ -23,7 +23,7 @@ Feature: Image alternative content
       <img src="a.jpeg" alt="A picture of something" />
       <img src="b.jpeg" alt="" />
       """
-    When I validate the image alt standards
+    When I validate the "images must have alt attributes" standard
     Then it passes
 
   Scenario: Images without alt attributes
@@ -32,8 +32,8 @@ Feature: Image alternative content
       <img src="a.jpeg" alt="A picture of something" />
       <img src="b.jpeg" />
       """
-    When I validate the image alt standards
+    When I validate the "images must have alt attributes" standard
     Then it fails with the message:
       """
-      Image has no alt attribute (src="b.jpeg")
+      Image has no alt attribute: /html/body/img[2]
       """

data/features/check_standards/language.feature

@@ -23,7 +23,7 @@ Feature: Specify content language
         </body>
       </html>
       """
-    When I validate the language attribute standards
+    When I validate the "html must have lang attribute" standard
     Then it passes
 
   Scenario: Missing lang attribute on html element
@@ -39,8 +39,8 @@ Feature: Specify content language
         </body>
       </html>
       """
-    When I validate the language attribute standards
+    When I validate the "html must have lang attribute" standard
     Then it fails with the message:
       """
-      The main language must be specified. <html> tag has no lang attribute.
+      html tag has no lang attribute: /html
       """

data/features/check_standards/main_landmark.feature

@@ -12,7 +12,7 @@ Feature: Main landmark
       """
       <div role="main">Main element</div>
       """
-    When I validate the landmark standards
+    When I validate the "exactly one main landmark" standard
     Then it passes
 
   Scenario: Page has two main elements
@@ -21,10 +21,10 @@ Feature: Main landmark
       <div role="main">Main one</div>
       <div role="main">Main two</div>
       """
-    When I validate the landmark standards
+    When I validate the "exactly one main landmark" standard
     Then it fails with the message:
       """
-      A document must have exactly one main landmark. Found 2 elements with role="main".
+      Found 2 elements with role="main": /html/body/div[1] /html/body/div[2]
       """
 
   Scenario: Page has zero main elements
@@ -32,8 +32,8 @@ Feature: Main landmark
       """
       <div role="not-main">Main one</div>
       """
-    When I validate the landmark standards
+    When I validate the "exactly one main landmark" standard
     Then it fails with the message:
       """
-      A document must have exactly one main landmark. Found 0 elements with role="main".
+      Found 0 elements with role="main".
       """

data/features/check_standards/minimum_text_size.feature

@@ -0,0 +1,36 @@
+Feature: Minimum text size
+
+  At default browser level all text **must** have a minimum calculated size of
+  11px and all core content **must** have a minimum calculated size of 13px.
+
+  Rationale
+  =========
+
+  Having a minimum text size will reduce the number of users who need to make
+  use of browser based text resize or page zoom. This is a particular issue with
+  an ageing audience, many of whom will not consider themselves as having low
+  vision and there will not have access to assistive technology or be familiar
+  with browser tools to resize content.
+
+  Scenario: Small text
+    Given a page with the HTML:
+      """
+      <style>
+        body {
+          font-size: 62.5%; /* Set default size of 1em to 10px */
+        }
+
+        b {
+          font-size: 9px;
+        }
+      </style>
+      <span>Some text</span> with <span>more <b>text</b> also</span>.
+      """
+    When I validate the "minimum text size" standard
+    Then it fails with the message:
+      """
+      Text size too small (10px): /html/body
+      Text size too small (10px): /html/body/span[1]
+      Text size too small (10px): /html/body/span[2]
+      Text size too small (9px): /html/body/span[2]/b
+      """

data/features/check_standards/tab_index.feature

@@ -24,7 +24,7 @@ Feature: Correctly use `tabindex` attributes
       <button type="submit">Search</button>
       <div tabindex="-1"></div>
       """
-    When I validate the tab index standards
+    When I validate the "elements with zero tab index must be fields" standard
     Then it passes
 
   Scenario: Focusable elements with zero tab index
@@ -36,7 +36,7 @@ Feature: Correctly use `tabindex` attributes
       <select tabindex="0"></select>
       <textarea tabindex="0"></textarea>
       """
-    When I validate the tab index standards
+    When I validate the "elements with zero tab index must be fields" standard
     Then it passes
 
   Scenario: Unfocusable element with zero tab index
@@ -47,8 +47,8 @@ Feature: Correctly use `tabindex` attributes
       <div tabindex="3"></div>
       <div tabindex="0"></div>
       """
-    When I validate the tab index standards
+    When I validate the "elements with zero tab index must be fields" standard
     Then it fails with the message:
       """
-      tabindex="0" must not be used on <div> elements (not focusable by default)
+      Non-field element with tabindex=0: /html/body/div[2]
       """

data/features/check_standards/title_attribute.feature

@@ -23,7 +23,7 @@ Feature: Correctly use `title` attributes
         <img src="close.png" />
       </button>
       """
-    When I validate the title attribute standards
+    When I validate the "title attributes only on inputs" standard
     Then it passes
 
   Scenario: Anchor tag with title attribute
@@ -33,8 +33,8 @@ Feature: Correctly use `title` attributes
         <img src="close.png" />
       </a>
       """
-    When I validate the title attribute standards
+    When I validate the "title attributes only on inputs" standard
     Then it fails with the message:
       """
-      Element (not a form input) has a title attribute: /html/body/a
+      Non-input element has title attribute: /html/body/a
       """

data/features/cli/coloured_output.feature

@@ -0,0 +1,15 @@
+Feature: Coloured Output
+  To make console output easy to interpret
+  Only terminals that support coloured output should show colours
+
+  @keep-ansi-escape-sequences
+  Scenario: TTY terminals show coloured output
+    Given I am using a TTY terminal
+    When I run a11y against a failing page
+    Then I see red in the output
+
+  @keep-ansi-escape-sequences
+  Scenario: Non-TTY terminals show monochrome output
+    Given I am using a Non-TTY terminal
+    When I run a11y against a failing page
+    Then I see monochrome output

data/features/cli/display_failing_result.feature

@@ -6,5 +6,5 @@ Feature: Display failing result
     Then it should fail with:
       """
       ✗ http://localhost:54321/missing_header.html
-        - A document must have exactly one main heading. Found 0 h1 elements.
+        - Found 0 h1 elements.
       """

data/features/cli/display_result_summary.feature

@@ -7,11 +7,11 @@ Feature: Display result summary
       page "http://localhost:54321/perfect.html"
       page "http://localhost:54321/missing_header.html"
       page "http://localhost:54321/missing_header.html?again!" do
-        skip_standard /ExactlyOneMainHeading/
+        skip_standard "exactly one main heading"
       end
       """
     When I run `a11y`
     Then it should fail with:
       """
-      Tested 3 pages, errors: 1, skipped: 1
+      3 pages checked, 1 error found, 1 standard skipped
       """

data/features/cli/missing_config_file_warning.feature

@@ -0,0 +1,10 @@
+Feature: Missing configuration file warning
+
+  Scenario: Running the tool with no arguments and no config file
+    When I run `a11y`
+    Then it should fail with:
+      """
+      Missing configuration file (a11y.rb).
+
+      Please visit http://www.rubydoc.info/gems/bbc-a11y for more information.
+      """

data/features/cli/skipping_standards.feature

@@ -5,7 +5,7 @@ Feature: Skipping Standards
     And a file named "a11y.rb" with:
       """
       page "http://localhost:54321/missing_header.html" do
-        skip_standard /head/i
+        skip_standard "exactly one main heading"
       end
       """
     When I run `a11y`

data/features/mute_errors.feature

@@ -16,10 +16,10 @@ Feature: Mute errors
       """
       <p>yo</p>
       """
-    When I validate the exactly one main heading standard
+    When I validate the "exactly one main heading" standard
     Then it fails with the message:
       """
-      A document must have exactly one main heading. Found 0 h1 elements.
+      Found 0 h1 elements.
       """
     When I add a configuration with:
       """
@@ -27,6 +27,6 @@ Feature: Mute errors
           "exactly-one-main-heading"
         ]
       """
-    And I validate the exactly one main heading standard
+    And I validate the "exactly one main heading" standard
     Then it shows 0 errors, 1 muted
     And it passes