bbc-a11y 0.0.14 → 0.0.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1a61b097a2dc056c61ed0d54a9d8769fd440240c
-  data.tar.gz: 2e07e34604600083e9d2f6f40a07f43247e43f8b
+  metadata.gz: 17ede39ffd3b5ba558b9981710dd720808ffc5b6
+  data.tar.gz: dc7906e1b703f766942c30cefcbe35c87a30cc10
 SHA512:
-  metadata.gz: ccb2b2f9b9c393f9c0fcb1ee8d88ed48c021352a2e9c222f8d5abdf2de27d61ee129bb4a828d30926bb3eec81faf1fbba09268cd9f00995bec2a634901502221
-  data.tar.gz: 4862bbd7b13d671b8e66c1c2cb1e03336533d31181a76f388763b72c9f1e4f9bf3889700ec3a1c1096c8924c6cd49b95cfd03a2bfa9c081df41fea70b30fb1d0
+  metadata.gz: 1a73e2a295bbb009a9d8e1626cee41321903010a3cdb95c52030375bc7b1db665c2cb0cee1e07c52af9ac00cd5c7eff90b2dbf1d35555ea5278a28ddb5410556
+  data.tar.gz: f623f9903f1f290bc2830e802116ece5c323682433f255012f7ce4a93b7156441cddcf99534e0db1730737811150c725d06ca8d3afb742d1eac010700e656884

data/features/check_standards/form_interactions.feature

@@ -18,7 +18,7 @@ Feature: Form Interactions
   is particularly important to users with cognitive disabilities, but is also
   beneficial to low vision users as an indication of the end of the form.
 
-  Scenario: Form with a submit button
+  Scenario: Form with a submit input
     Given a page with the HTML:
       """
       <form action="/search">
@@ -43,3 +43,15 @@ Feature: Form Interactions
       """
       Form has no submit button: /html/body/form
       """
+  Scenario: Form with a submit button
+    Given a page with the HTML:
+      """
+      <form action="/search">
+        <label for="q">Search term:</label>
+        <input type="text" name="q" id="q">
+        <button type="submit">Search</button>
+      </form>
+      """
+    When I validate the form submit buttons standards
+    Then it passes
+

data/features/check_standards/form_labels.feature

@@ -53,3 +53,12 @@ Feature: Correctly use form labels
       Field has no label or title attribute: /html/body/input[4]
       Field has no label or title attribute: /html/body/input[5]
       """
+
+  Scenario: Hidden fields do not need titles
+
+    Given a page with the HTML:
+      """
+      <input type=hidden name=a value=b>
+      """
+    When I validate the form labels standards
+    Then it passes

data/features/check_standards/headings.feature

@@ -39,9 +39,7 @@ Feature: Headings
     When I validate the heading standards
     Then it fails with the message:
       """
-      A document must have exactly one heading. Found 2 h1 elements:
-        /html/body/h1[1]
-        /html/body/h1[2]
+      A document must have exactly one heading. Found 2 h1 elements.
       """
 
   Scenario: Headings in ascending order

data/features/mute_errors.feature

@@ -3,116 +3,30 @@ Feature: Mute errors
   Things like ORB and Barlesque that we don't control will clutter up our pages
   with violations.
 
-  We need a way to ignore the errors generated by these areas of the page so
+  We need a way to ignore these kinds of problems, so
   we can focus on the problems that we can actually fix.
 
-  Rules:
+  Questions:
 
-  - exclude any errors that match the filtering rules
+  - how can we ignore / remove specific areas of the page? What are some
+    real examples?
 
-  Scenario: Mute an error with no specific elements in it
-
-    Where the standard (e.g. exactly one main heading standard) applies to the
-    whole page, we still report an error even when we have an ignore rule.
-
-    Given a page with no h1s
-    And an ignore rule for a region of the page
-    When I validate the exactly one main heading standard
-    Then it fails with the message:
-      """
-      A document must have exactly one heading. Found 0 h1 elements.
-      """
-
-  Scenario: Mute an error that mentions just one HTML element
-
-  Scenario: Mute an error that mentions one or more elements
+  Scenario: Mute any errors from a specific standard
     Given a page with the HTML:
       """
-      <div id="dodgy-legacy-banner">
-        <h1>I am a legacy</h1>
-      </div>
-      <h1>The real heading</h1>
+      <p>yo</p>
       """
     When I validate the exactly one main heading standard
     Then it fails with the message:
       """
-      A document must have exactly one heading. Found 2 h1 elements:
-        /html/body/div/h1
-        /html/body/h1
+      A document must have exactly one heading. Found 0 h1 elements.
       """
     When I add a configuration with:
       """
         mute: [
-          {
-            standard: "exactly-one-main-heading",
-            css: "#dodgy-legacy-banner h1"
-          }
+          "exactly-one-main-heading"
         ]
       """
     And I validate the exactly one main heading standard
-    Then it passes
-
-  Scenario: Mute an error about one bad element, but still see other similar problems on the page
-    Given a page with the HTML:
-      """
-      <div id="dodgy-legacy-banner">
-        <h1>I am a legacy</h1>
-      </div>
-      <h1>The real heading</h1>
-      <h1>Team, fix me</h1>
-      """
-    When I validate the exactly one main heading standard
-    Then it fails with the message:
-      """
-      A document must have exactly one heading. Found 3 h1 elements:
-        /html/body/div/h1
-        /html/body/h1[1]
-        /html/body/h1[2]
-      """
-    When I add a configuration with:
-      """
-        mute: [
-          {
-            standard: "exactly-one-main-heading",
-            css: "#dodgy-legacy-banner h1"
-          }
-        ]
-      """
-    When I validate the exactly one main heading standard
-    Then it fails with the message:
-      """
-      A document must have exactly one heading. Found 2 h1 elements:
-        /html/body/h1[1]
-        /html/body/h1[2]
-      """
-
-  Scenario: Mute an error about one bad element, but still see other similar problems on the page
-    Given a page with the HTML:
-      """
-      <div id="legacy">
-        <input type="text" name="txtName"/>
-      </div>
-      <input type="text" name="name"/>
-      """
-    When I validate the form labels standards
-    Then it fails with the message:
-      """
-      Field has no label or title attribute:
-        /html/body/div/input
-        /html/body/input
-      """
-    When I add a configuration with:
-      """
-        mute: [
-          {
-            standard: "form-labels",
-            css: "#legacy input"
-          }
-        ]
-      """
-    When I validate the form labels standard
-    Then it fails with the message:
-      """
-      Field has no label or title attribute:
-        /html/body/input
-      """
+    Then it shows 0 errors, 1 muted
+    And it passes

data/lib/bbc/a11y/standards/form_labels.rb

@@ -18,7 +18,7 @@ module BBC
         private
 
         def potential_offenders
-          "input:not([title]), textarea:not([title]), select:not([title])"
+          "input:not([title]):not([type='hidden']), textarea:not([title]), select:not([title])"
         end
 
         def offender?(field)

data/lib/bbc/a11y/standards/form_submit_buttons.rb

@@ -8,7 +8,7 @@ module BBC
 
         def call(errors)
           @page.all("form").each do |form|
-            submits = form.all("input[type=submit]")
+            submits = form.all("input[type=submit], button[type=submit]")
             if submits.empty?
               errors << "Form has no submit button: #{form.path}"
             end

data/lib/bbc/a11y/version

@@ -1 +1 @@
-0.0.14
+0.0.15

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bbc-a11y
 version: !ruby/object:Gem::Version
-  version: 0.0.14
+  version: 0.0.15
 platform: ruby
 authors:
 - Matt Wynne
@@ -230,7 +230,7 @@ rubyforge_project:
 rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
-summary: bbc-a11y-0.0.14
+summary: bbc-a11y-0.0.15
 test_files:
 - features/README.md
 - features/check_standards/focusable_controls.feature