batting_leaders 0.1.5 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6d8b2ec66701c3379736ff828ad45e260859f2a8
-  data.tar.gz: dd7119fc6c31a5b4f7313ee5035baebe2905c34e
+  metadata.gz: 3599c03952b20715f7f09073f1b35417de757c4c
+  data.tar.gz: 42a68494f1d6e58d1f1b6014e20c08d2d2049619
 SHA512:
-  metadata.gz: 0cac709f237c56f99d788946f3dc0dfe092baf5ca00825b7c8a9105661a9906c62e5229d1f4e56bd31e70f38c8d0ce6232a4d2a0cc84c7ce50fa2e698a56c46b
-  data.tar.gz: 7feaf3be90968cbebeadc8407ae6ae6d45974d163c0a5f7bf6ef37aa9a4c56c9c030f78cc62c6bf34193fb17e160058f9c3020d901f6b4aa60f1350d59ea2845
+  metadata.gz: 8d956dd1ecee7711685b258b817bf50568b39ae87e9163b2225c44c4f4e80d532495fff0dfa2c1a85684f9152ff390a95030017b5cdde6d33ca6e1eb12c2202b
+  data.tar.gz: 98068f1736e4b937b22b638a1248858e7fcd6fd487ba18a4f1b8833c79a7a61ab24b633e74cc3f12c3345a2a01f806fabaa5ed8e8ed3722cc5da349c0a8fb99c

data/lib/batting_leaders/cli.rb

@@ -20,8 +20,8 @@ class BattingLeaders::CLI
     puts ""
     if number_players == 10 || number_players == 20 || number_players == 30 || number_players == 40
       puts "---Player--------------------batting ave---"
-      @sorted_leading_batters[0,number_players].each_with_index do |player, index|
-        printf("%-3s", "#{index + 1}:")
+      @sorted_leading_batters[0,number_players].each.with_index(1) do |player, index|
+        printf("%-3s", "#{index}:")
         printf("%-27s", "#{player.name}")
         puts "#{player.batting_ave}"
       end
@@ -57,15 +57,15 @@ class BattingLeaders::CLI
     player = BattingLeaders::Player.find_player_by_url(player_url)
     puts "name: #{player.name}"
     puts "batting ave: #{player.batting_ave}"
-    puts "number and position: #{player.number_position}"
-    puts "team: #{player.team}"
-    puts "HR (this season): #{player.homerun}"
-    puts "RBI (this season): #{player.rbi}"
-    puts "OBP (this season): #{player.obp}"
-    puts "birth date: #{player.birth_date}"
-    puts "experience: #{player.experience}"
-    puts "college: #{player.college}"
-    puts "Ht/Wt: #{player.ht_wt}"
+    puts "number and position: #{player.other_details[:number_position]}"
+    puts "team: #{player.other_details[:team]}"
+    puts "HR (this season): #{player.other_details[:homerun]}"
+    puts "RBI (this season): #{player.other_details[:rbi]}"
+    puts "OBP (this season): #{player.other_details[:obp]}"
+    puts "birth date: #{player.other_details[:birth_date]}"
+    puts "experience: #{player.other_details[:experience]}"
+    puts "college: #{player.other_details[:college]}"
+    puts "Ht/Wt: #{player.other_details[:ht_wt]}"
     puts ""
   end
 

data/lib/batting_leaders/player.rb

@@ -1,12 +1,25 @@
 require 'open-uri'
 require 'nokogiri'
-# require 'pry'
+require 'pry'
 
 
 class BattingLeaders::Player
   attr_accessor :name, :batting_ave, :url
   @@all = []
 
+  PlayerDetails = {
+  #  @team => ".general-info .last"
+    team: [".general-info .last", 0, ""],
+    number_position: [".general-info .first", 0, ""],
+    birth_date: [".player-metadata li", 0, "Birth Date"],
+    homerun: [".header-stats td", 1, ""],
+    experience: [".player-metadata li", 2, "Experience"],
+    college: [".player-metadata li", 3, "College"],
+    ht_wt: [".player-metadata li", 4, "Ht/Wt"],
+    rbi: [".header-stats td", 2, ""],
+    obp: [".header-stats td", 3, ""]
+  }
+
   def initialize(player_hash)
     @name = player_hash[:name]
     @batting_ave = player_hash[:batting_ave]
@@ -19,20 +32,14 @@ class BattingLeaders::Player
   end
 
   def self.sorted_batters
-    self.batting_leaders.sort_by {|player| player.batting_ave}.reverse! #sort by attribute (batting_ave) of Player's instance
+    self.batting_leaders.sort {|player, player2| player2.batting_ave <=> player.batting_ave} #sort by attribute (batting_ave) of Player's instance
   end
 
   def self.batting_leaders
-    self.row_scraper("odd")
-    self.row_scraper("even")
-    self.all
-  end
-
-  def self.row_scraper(oddEven)
-    oddEven =="odd" ? odd_or_even_row = "oddrow" : odd_or_even_row = "evenrow"
-    get_page = Nokogiri::HTML(open"http://espn.go.com/mlb/stats/batting/_/year/2016/seasontype/2")
-
-    get_page.css("tr.#{odd_or_even_row}").collect do |player|
+#    oddEven =="odd" ? odd_or_even_row = "oddrow" : odd_or_even_row = "evenrow"
+    current_year = Date.today.year
+    get_page = Nokogiri::HTML(open"http://espn.go.com/mlb/stats/batting/_/#{current_year}/2016/seasontype/2")
+    get_page.css("tr.oddrow,.evenrow").collect do |player|
       player_attributes = {:name => player.css("a").text,
                            :url => player.css("a").attribute("href").value,
                            :batting_ave => player.css(".sortcell").text}
@@ -48,40 +55,12 @@ class BattingLeaders::Player
     @doc ||= Nokogiri::HTML(open"#{@url}").css(".mod-content")
   end
 
-  def number_position
-    @number_position ||= doc.css(".general-info .first").text
-  end
-
-  def team
-    @team ||= doc.css(".general-info .last").text
-  end
-
-  def birth_date
-    @birth_date ||= doc.css(".player-metadata li")[0].text.gsub("Birth Date", "")
-  end
-
-  def experience
-    @experience ||= doc.css(".player-metadata li")[2].text.gsub("Experience", "")
-  end
-
-  def college
-    @college ||= doc.css(".player-metadata li")[3].text.gsub("College", "")
-  end
-
-  def ht_wt
-    @ht_wt ||= doc.css(".player-metadata li")[4].text.gsub("Ht/Wt", "")
-  end
-
-  def homerun
-    @homerun ||= doc.css(".header-stats td")[1].text
-  end
-
-  def rbi
-    @rbi ||= doc.css(".header-stats td")[2].text
-  end
-
-  def obp
-    @obp ||= doc.css(".header-stats td")[3].text
+  def other_details
+    player_detail_hash = {}
+    PlayerDetails.each do |attribute, values|  #values = ["css selector", index, "erased text using gsub" ]
+      player_detail_hash[attribute] ||= doc.css(values[0])[values[1]].text.gsub(values[2], "")
+    end
+    player_detail_hash
   end
 
 end

data/lib/batting_leaders/version.rb

@@ -1,3 +1,3 @@
 module BattingLeaders
-  VERSION = "0.1.5"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: batting_leaders
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.2.0
 platform: ruby
 authors:
 - Han Lee
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-22 00:00:00.000000000 Z
+date: 2017-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -128,7 +128,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.6.3
 signing_key: 
 specification_version: 4
 summary: A CLI app for listing MLB batting leaders for batting average