batch_factory 0.0.6 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6f33676dbbb2880f05b0d68c8354d73842e800e8
-  data.tar.gz: 8b73db2c704de678ffe46edcde50e4e88f655fb6
+  metadata.gz: 426ee0a9312cf54ccc7c7c8dba99955b2f3f7bb4
+  data.tar.gz: 866ca63ab2d7fb83584b4a244898a9f5c0af964e
 SHA512:
-  metadata.gz: 3458d01dcee4626806d1cf1c002c0321376cac3d530973a96f479f9d57477c9fe3a7dc421e409154fe06e0ddc8d530622050c62433c5f719bcb9ad8e9643a629
-  data.tar.gz: 84957e02bb3382aab41a53eee4f594551988cb87da3c6b48f241cd8585d0b59501f5dc6b5a3f711d0e36165eabd275b923fda7918405bd5632497afb3215414b
+  metadata.gz: bf14a17f8bea356ce0ed6e7976213b6edffe92c45a84ae2f83728a29094ed20ac754af04faf729c9e1c3f6c5fd796a320fb35425032a9654d25fc89511d2b8fd
+  data.tar.gz: b586db47d5c3064cdc0fd2b1db6fe5b80497836e0de9e24f58ad3b82355d8ab905635b7b6e54c2a2f39c68596108249421cf39466987ea38380fceb09c1f983f

data/lib/batch_factory.rb

@@ -9,9 +9,9 @@ require 'batch_factory/hashed_worksheet'
 
 module BatchFactory
   class << self
-    def from_file file_location, keys = nil
+    def from_file(file_location, options = {})
       parser = BatchFactory::Parser.new
-      parser.open file_location, 0, keys
+      parser.open file_location, options
       parser.parse!
 
       parser.hashed_worksheet

data/lib/batch_factory/hashed_worksheet.rb

@@ -2,18 +2,25 @@ module BatchFactory
   class HashedWorksheet
     attr_accessor :keys, :rows
 
+    @@proxy_methods = Enumerable.public_instance_methods + Array.public_instance_methods
+
     def initialize(keys, rows)
       @keys = keys
       @rows = rows
     end
 
     def method_missing(method, *args, &block)
-      if (Enumerable.public_instance_methods + Array.public_instance_methods).include? method.to_sym
+      if should_proxy_method?(method.to_sym)
         @rows.send(method, *args, &block)
       else
         super
       end
     end
 
+    private
+
+    def should_proxy_method?(method)
+      @@proxy_methods.include? method
+    end
   end
 end

data/lib/batch_factory/parser.rb

@@ -1,6 +1,7 @@
 module BatchFactory
   class Parser
-    attr_accessor :worksheet, :user_heading_keys, :heading_keys, :column_bounds, :row_hashes
+    attr_accessor :worksheet, :user_heading_keys,
+      :heading_keys, :column_bounds, :row_hashes
 
     def initialize
       @heading_keys = []
@@ -8,9 +9,9 @@ module BatchFactory
       @row_hashes = []
     end
 
-    def open(file_location, sheet_number = 0, user_keys = nil)
-      @worksheet = SpreadsheetDocument.new(file_location, sheet_number)
-      @user_heading_keys = user_keys
+    def open(file_location, options = {})
+      @worksheet = SpreadsheetDocument.new(file_location, options)
+      @user_heading_keys = options[:keys]
     end
 
     def parse!

data/lib/batch_factory/version.rb

@@ -1,3 +1,11 @@
 module BatchFactory
-  VERSION = '0.0.6'
+  module VERSION
+    MAJOR = 0
+    MINOR = 1
+    PATCH = 0
+    SUFFIX = nil
+
+    STRING = [MAJOR, MINOR, PATCH, SUFFIX].compact.join('.')
+  end
 end
+

data/lib/spreadsheet_document.rb

@@ -1,7 +1,13 @@
 require 'roo'
+
 class SpreadsheetDocument
-  def initialize(file_name, sheet_number)
-    @spreadsheet = case file_name.split('.').last
+  attr_reader :filetype, :sheet_number
+
+  def initialize(file_name, options = {})
+    @sheet_number = options[:sheet_number] || 0
+    @filetype = options[:filetype] || detect_filetype(file_name)
+
+    @spreadsheet = case @filetype
       when 'xls'
         Roo::Excel.new(file_name)
       when 'xlsx'
@@ -11,7 +17,7 @@ class SpreadsheetDocument
       else
         Roo::CSV.new(file_name)
     end
-    @current_sheet = @spreadsheet.sheets[sheet_number]
+    @current_sheet = @spreadsheet.sheets[@sheet_number]
   end
 
   def method_missing(method, *args, &block)
@@ -22,4 +28,11 @@ class SpreadsheetDocument
       super
     end
   end
+
+  private
+
+  def detect_filetype(file_name)
+    File.extname(file_name)[1..-1]
+  end
 end
+

data/spec/{unit/batch_factory.rb → batch_factory/batch_factory_spec.rb}

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe BatchFactory do
-  
   context 'w/ class methods' do
     it 'should open a file and return a hashed workbook' do
       worksheet = BatchFactory.from_file VALID_SPREADSHEET
@@ -10,5 +9,5 @@ describe BatchFactory do
       worksheet[0][:age].should == 50
     end
   end
-  
 end
+

data/spec/{unit/batch_factory/hashed_worksheet.rb → batch_factory/hashed_worksheet_spec.rb}

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe BatchFactory::HashedWorksheet do
-
   context 'w/ instance methods' do
     let(:worksheet) do
       parser = BatchFactory::Parser.new
@@ -27,3 +26,4 @@ describe BatchFactory::HashedWorksheet do
   end
 
 end
+

data/spec/{unit/batch_factory/parser.rb → batch_factory/parser_spec.rb}

@@ -37,7 +37,7 @@ describe BatchFactory::Parser do
 
     context 'when parsing second worksheet' do
       before do
-        parser.open VALID_SPREADSHEET, 1
+        parser.open VALID_SPREADSHEET, sheet_number: 1
         parser.parse!
       end
 
@@ -60,6 +60,6 @@ describe BatchFactory::Parser do
         worksheet.keys.should == parser.heading_keys
       end
     end
-
   end
 end
+

data/spec/batch_factory/spreadsheet_document_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe SpreadsheetDocument do
+  context 'w/ filetype option' do
+    subject { described_class.new(VALID_SPREADSHEET) }
+
+    its(:filetype) { should eq('xls') }
+  end
+
+  context 'with filetype option' do
+    subject { described_class.new(VALID_SPREADSHEET, filetype: 'xls') }
+
+    its(:filetype) { should eq('xls') }
+  end
+end
+

data/spec/spec_helper.rb

@@ -1,5 +1,16 @@
 require 'rspec'
+require 'rspec/its'
+
 require 'batch_factory'
 
-ASSETS_DIR = File.expand_path File.join(File.dirname(__FILE__), 'files')
+ASSETS_DIR = File.expand_path File.join(File.dirname(__FILE__), 'support', 'files')
 VALID_SPREADSHEET = File.join(ASSETS_DIR, 'valid-spreadsheet.xls')
+
+RSpec.configure do |config|
+  config.mock_with :rspec
+  config.order = 'random'
+  config.filter_run focus: true
+  config.run_all_when_everything_filtered = true
+  config.fail_fast = false
+end
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: batch_factory
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.1.0
 platform: ruby
 authors:
 - Denis Ivanov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-17 00:00:00.000000000 Z
+date: 2015-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: roo
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.10'
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Assumes first row to be keys and returns hashes for consecutive rows
 email:
 - visible@jumph4x.net
@@ -64,10 +78,11 @@ files:
 - lib/batch_factory/parser.rb
 - lib/batch_factory/version.rb
 - lib/spreadsheet_document.rb
+- spec/batch_factory/batch_factory_spec.rb
+- spec/batch_factory/hashed_worksheet_spec.rb
+- spec/batch_factory/parser_spec.rb
+- spec/batch_factory/spreadsheet_document_spec.rb
 - spec/spec_helper.rb
-- spec/unit/batch_factory.rb
-- spec/unit/batch_factory/hashed_worksheet.rb
-- spec/unit/batch_factory/parser.rb
 homepage: https://github.com/jumph4x/batch-factory
 licenses: []
 metadata: {}
@@ -92,7 +107,8 @@ signing_key:
 specification_version: 4
 summary: Meaningful spreadsheet access
 test_files:
+- spec/batch_factory/batch_factory_spec.rb
+- spec/batch_factory/hashed_worksheet_spec.rb
+- spec/batch_factory/parser_spec.rb
+- spec/batch_factory/spreadsheet_document_spec.rb
 - spec/spec_helper.rb
-- spec/unit/batch_factory/hashed_worksheet.rb
-- spec/unit/batch_factory/parser.rb
-- spec/unit/batch_factory.rb