batch-loader 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c9c2a37ad6f642d238140812bad2ec413e220c0d
-  data.tar.gz: e57a956992150ef4578edb133075b4ac3b1eb741
+  metadata.gz: 0c89e0468fac3840ce82631d0a0f9ac61eeda081
+  data.tar.gz: ec6c5021e04a5bc067356305659325431caa2753
 SHA512:
-  metadata.gz: 024e3fc9ad27f32668f38a83260ea9f642094518f94e26144559c06240a2fe9ebe236e6028678362218276d9da8f5a603a943c712e4cb0b160ab7b7573e6fb45
-  data.tar.gz: 9caaea9dfeadb9d3534cf850a221a68a7296ced09c1f8aa2e5af8c13777c3eb3c2b1fae527a8d4fed351f7a38aa09a50baa1978b66c039d9acc2b77587495c6a
+  metadata.gz: 6551811eace7cb180cdea08c28b77695d8c243af3e6675e9da8d172645cab35ba51803f036359c4ecd8a6cc65a1ec2b95e2b1824f829c0454da2c0570748e396
+  data.tar.gz: 78c0481961a045060a64c155ddb196f125da805944014ad59052464fb7b3a884e41cd6462ab5ceb186931cbcbd1e210f61d963007e4af8f1124809a2ec698e62

data/.gitignore

@@ -10,3 +10,4 @@
 
 # rspec failure tracking
 .rspec_status
+.ruby-version

data/.travis.yml

@@ -1,7 +1,23 @@
 sudo: false
 language: ruby
-rvm:
-  - 2.3.4
-env:
-  - CI=true
-before_install: gem install bundler -v 1.15.3
+before_install: gem install bundler -v 1.17.1
+matrix:
+  include:
+    - gemfile: graphql-1.7.gemfile
+      env: GRAPHQL_RUBY_VERSION=1_7 CI=true
+      rvm: 2.3.8
+    - gemfile: graphql-1.8.gemfile
+      env: GRAPHQL_RUBY_VERSION=1_8 CI=true
+      rvm: 2.3.8
+    - gemfile: graphql-1.7.gemfile
+      env: GRAPHQL_RUBY_VERSION=1_7 CI=true
+      rvm: 2.4.5
+    - gemfile: graphql-1.8.gemfile
+      env: GRAPHQL_RUBY_VERSION=1_8 CI=true
+      rvm: 2.4.5
+    - gemfile: graphql-1.7.gemfile
+      env: GRAPHQL_RUBY_VERSION=1_7 CI=true
+      rvm: 2.5.3
+    - gemfile: graphql-1.8.gemfile
+      env: GRAPHQL_RUBY_VERSION=1_8 CI=true
+      rvm: 2.5.3

data/CHANGELOG.md

@@ -8,10 +8,14 @@ one of the following labels: `Added`, `Changed`, `Deprecated`,
 to manage the versions of this gem so
 that you can set version constraints properly.
 
-#### [Unreleased](https://github.com/exAspArk/batch-loader/compare/v1.2.1...HEAD)
+#### [Unreleased](https://github.com/exAspArk/batch-loader/compare/v1.2.2...HEAD)
 
 * WIP
 
+#### [v1.2.2](https://github.com/exAspArk/batch-loader/compare/v1.2.1...v1.2.2)
+
+* `Fixed`: Identify item by `key` object instead of `key` string representation. [#27](https://github.com/exAspArk/batch-loader/pull/27)
+
 #### [v1.2.1](https://github.com/exAspArk/batch-loader/compare/v1.2.0...v1.2.1)
 
 * `Fixed`: Do not depend on `method_missing` for `respond_to?`. [#14](https://github.com/exAspArk/batch-loader/pull/14)

data/README.md

@@ -2,7 +2,7 @@
 
 [![Build Status](https://travis-ci.org/exAspArk/batch-loader.svg?branch=master)](https://travis-ci.org/exAspArk/batch-loader)
 [![Coverage Status](https://coveralls.io/repos/github/exAspArk/batch-loader/badge.svg)](https://coveralls.io/github/exAspArk/batch-loader)
-[![Code Climate](https://img.shields.io/codeclimate/github/exAspArk/batch-loader.svg)](https://codeclimate.com/github/exAspArk/batch-loader)
+[![Code Climate](https://img.shields.io/codeclimate/maintainability/exAspArk/batch-loader.svg)](https://codeclimate.com/github/exAspArk/batch-loader/maintainability)
 [![Downloads](https://img.shields.io/gem/dt/batch-loader.svg)](https://rubygems.org/gems/batch-loader)
 [![Latest Version](https://img.shields.io/gem/v/batch-loader.svg)](https://rubygems.org/gems/batch-loader)
 
@@ -295,9 +295,9 @@ end
 For batches where the value is some kind of collection, such as an Array or Hash, `loader` also supports being called with a block, which yields the _current_ value, and returns the _next_ value. This is extremely useful for 1:Many relationships:
 
 ```ruby
-BatchLoader.for(user.id).batch(default_value: []) do |comment_ids, loader|
+BatchLoader.for(user.id).batch(default_value: []) do |user_ids, loader|
   Comment.where(user_id: user_ids).each do |comment|
-    loader.call(user.id) { |memo| memo << comment }
+    loader.call(comment.user_id) { |memo| memo << comment }
   end
 end
 ```

data/graphql-1.7.gemfile

@@ -0,0 +1,7 @@
+source "https://rubygems.org"
+
+gem 'coveralls'
+
+gem "graphql", "~> 1.7"
+
+gemspec

data/graphql-1.8.gemfile

@@ -0,0 +1,7 @@
+source "https://rubygems.org"
+
+gem 'coveralls'
+
+gem "graphql", "~> 1.8"
+
+gemspec

data/lib/batch_loader/executor_proxy.rb

@@ -9,7 +9,7 @@ class BatchLoader
     def initialize(default_value, key, &block)
       @default_value = default_value
       @block = block
-      @block_hash_key = "#{key}#{block.source_location}"
+      @block_hash_key = [block.source_location, key]
       @global_executor = BatchLoader::Executor.ensure_current
     end
 

data/lib/batch_loader/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class BatchLoader
-  VERSION = "1.2.1"
+  VERSION = "1.2.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: batch-loader
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - exAspArk
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-12-16 00:00:00.000000000 Z
+date: 2018-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -117,7 +117,6 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
-- ".ruby-version"
 - ".travis.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
@@ -128,6 +127,8 @@ files:
 - batch-loader.gemspec
 - bin/console
 - bin/setup
+- graphql-1.7.gemfile
+- graphql-1.8.gemfile
 - lib/batch-loader.rb
 - lib/batch_loader.rb
 - lib/batch_loader/executor.rb
@@ -155,7 +156,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Powerful tool to avoid N+1 DB or HTTP queries

data/.ruby-version

@@ -1 +0,0 @@
-2.3.4