batch-loader 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9c1006b1dafb626b3f813414b950eee5ed8ad9d1
-  data.tar.gz: 4933dd5d233cb7758ee3f7a95074db31b68e0b22
+  metadata.gz: bb37551b8e0c52cb65a331801fa0110e311aebf9
+  data.tar.gz: 9f5a59bd9626c0341103c2d5c422119ff71aedba
 SHA512:
-  metadata.gz: 53a253059db7baf8900aad0d7cb57aca0a91d551013ea67fb869a0c2a9415e89488641b6990c1b9dfe3cf84cadd5d0d1f83f6039cfbf7097e231d3d7ca2f3475
-  data.tar.gz: 73214bc99ebb831e2a2f3ecb3edb970762408c289ddb7d42fab6d57119aea89f7c984436fc1dccc4860596a466e207f8701bf572553fc0c72e6ee1e16cbbb0a0
+  metadata.gz: 92e829a4416c25050380ef59dbe43873f89911140ade537b9420bc05fb6bb45364591781010b0b0ecab5f71e1a5ec1bb56fa15f4cdb6ef4859547687e3bb30d0
+  data.tar.gz: 6101f58d4292906aa512ae16e88f3c563c351984c2edea960fc1d4ff7ddd87a95dbb69e0fdd201376e93d0f189638f27ad0a76ff191c30dc79ba6d5fbf61b5c2

data/CHANGELOG.md

@@ -8,10 +8,17 @@ one of the following labels: `Added`, `Changed`, `Deprecated`,
 to manage the versions of this gem so
 that you can set version constraints properly.
 
-#### [Unreleased](https://github.com/exAspArk/batch-loader/compare/v1.0.1...HEAD)
+#### [Unreleased](https://github.com/exAspArk/batch-loader/compare/v1.0.2...HEAD)
 
 * WIP
 
+#### [v1.0.2](https://github.com/exAspArk/batch-loader/compare/v1.0.1...v1.0.2) – 2017-09-14
+
+* `Added`: `BatchLoader#inspect` method because of Pry, which [swallows errors](https://github.com/pry/pry/issues/1642).
+* `Added`: benchmarks.
+* `Fixed`: caching `nil`s for not loaded values only after successful `#batch` execution.
+* `Changed`: internal implementation with Ruby `Forwardable`, don't delegate methods like `object_id` and `__send__`.
+
 #### [v1.0.1](https://github.com/exAspArk/batch-loader/compare/v1.0.0...v1.0.1) – 2017-09-03
 
 * `Fixed`: loading `BatchLoader` by requiring `Set`.

data/Gemfile

@@ -1,7 +1,5 @@
 source "https://rubygems.org"
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
-
 gem 'coveralls', require: false
 
 # Specify your gem's dependencies in batch-loader.gemspec

data/batch-loader.gemspec

@@ -28,4 +28,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "graphql", "~> 1.6"
   spec.add_development_dependency "pry-byebug", "~> 3.4"
+  spec.add_development_dependency "benchmark-ips", "~> 2.7"
 end

data/lib/batch_loader.rb

@@ -1,12 +1,20 @@
 # frozen_string_literal: true
 
 require "set"
+require "forwardable"
+
 require "batch_loader/version"
 require "batch_loader/executor_proxy"
 require "batch_loader/middleware"
 require "batch_loader/graphql"
 
 class BatchLoader
+  extend Forwardable
+
+  IMPLEMENTED_INSTANCE_METHODS = %i[object_id __id__ __send__ singleton_method_added batch_loader? respond_to? batch inspect].freeze
+  REPLACABLE_INSTANCE_METHODS = %i[batch inspect].freeze
+  LEFT_INSTANCE_METHODS = (IMPLEMENTED_INSTANCE_METHODS - REPLACABLE_INSTANCE_METHODS).freeze
+
   NoBatchError = Class.new(StandardError)
 
   def self.for(item)
@@ -32,7 +40,11 @@ class BatchLoader
   end
 
   def respond_to?(method_name)
-    method_name == :batch_loader? || method_missing(:respond_to?, method_name)
+    LEFT_INSTANCE_METHODS.include?(method_name) || method_missing(:respond_to?, method_name)
+  end
+
+  def inspect
+    "#<BatchLoader:0x#{(object_id << 1)}>"
   end
 
   private
@@ -62,28 +74,22 @@ class BatchLoader
 
     items = executor_proxy.list_items
     loader = ->(item, value) { executor_proxy.load(item: item, value: value) }
-    items.each { |item| loader.call(item, nil) }
+
     @batch_block.call(items, loader)
+    items.each do |item|
+      next if executor_proxy.value_loaded?(item: item)
+      loader.call(item, nil) # use "nil" for not loaded item after succesfull batching
+    end
     executor_proxy.delete(items: items)
   end
 
   def singleton_class
-    class << self
-      self
-    end
+    class << self ; self ; end
   end
 
   def replace_with!(value)
-    BatchLoader.send(:without_warnings) do
-      ignore_method_names = %i[singleton_method_added].freeze
-      singleton_class.class_eval do
-        (value.methods - ignore_method_names).each do |method_name|
-          define_method(method_name) do |*args, &block|
-            value.public_send(method_name, *args, &block)
-          end
-        end
-      end
-    end
+    @loaded_value = value
+    singleton_class.class_eval { def_delegators :@loaded_value, *(value.methods - LEFT_INSTANCE_METHODS) }
   end
 
   def purge_cache
@@ -98,19 +104,5 @@ class BatchLoader
     end
   end
 
-  class << self
-    private
-
-    def without_warnings(&block)
-      warning_level = $VERBOSE
-      $VERBOSE = nil
-      block.call
-      $VERBOSE = warning_level
-    end
-  end
-
-  without_warnings do
-    leave_method_names = %i[batch batch_loader? respond_to?].freeze
-    (instance_methods - leave_method_names).each { |method_name| undef_method(method_name) }
-  end
+  (instance_methods - IMPLEMENTED_INSTANCE_METHODS).each { |method_name| undef_method(method_name) }
 end

data/lib/batch_loader/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class BatchLoader
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: batch-loader
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - exAspArk
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-09-03 00:00:00.000000000 Z
+date: 2017-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.4'
+- !ruby/object:Gem::Dependency
+  name: benchmark-ips
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.7'
 description: Powerful tool to avoid N+1 DB or HTTP queries
 email:
 - exaspark@gmail.com