bastion 0.2.2 → 0.2.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZjkzYzNhMmUxNGIwYTA0NWRjOWRhNjI1MGU1ZGE3ZDc2NTQyMTIyYQ==
+    NmU2ZTZkYTg5N2EwNmM1NTI5YTQyOTk3Yjg1NzY3NDQ3OWU5ZjlkYQ==
   data.tar.gz: !binary |-
-    YTNhMTE1NzdhOGIzNDZmNGJhNmU0MThmZTU1MDhlNzQwMjM2NmVmMA==
+    ZTdkMTRkN2M0NTdkZjNhOGI3ZDg0MmJmYmUzNWRiNWUyMmM5ZmJjMA==
 SHA512:
   metadata.gz: !binary |-
-    ZmMwZjRlN2E1NDNkYzUxYWVjOTRlZWVhZDc4M2JjYjVmOGNjYWMwOWFhYTZm
-    OTkwM2ViYzYxMzE2YjdmOTAxNWIxNjVjZTNjMzk2NGVmNTNmNDFhZDcxNTVm
-    YTYyMmFjN2EwOThkNjMxM2Q0ZWE0NDRjOGU0MWQ4YzI1ZTgwZWI=
+    YjBiNjdiNWE2ZmU3ODJhOTNiNzU4MWNhMDI0Y2U5OGI2ZTJjMjJiMWNlZDlh
+    NmFhYzc5MmMyZjI5NmNhNWQ1MzZhYThmY2EwZmM5ZGMxNDY2ZDUzOGUyZmU1
+    MTY0YTdjYWQ1MmY2MmI3NTBjYTAwZjY1MjM5NTgxMDIwYzA5NjM=
   data.tar.gz: !binary |-
-    NTkxYmRhZWZhNmQ1YjRhN2M0NzI2M2YxZGE2YWMwNjEyZjc5OWU4MTY2Mzhj
-    YzEwMjlhZWFkZGVjZTFlN2NkN2Q5OTRlM2U0YWYwNDAwZWI1YTRlOGUzZTBh
-    N2JiZWRmYzI1Njk3NmQ1MDhjOTgxZmQ1ZjZmZGNiOWI1MTg0YjM=
+    ZDU1MzA3ZjRhNGJkMzk3Y2U0ODc2MTZkNzExYmQyYTE0NTJlMjgwYzQ1YTUw
+    M2IzOGMwNDdmMTVlZGNhM2UxYjZmMTJmZDAwNjYxNGE4ZjM4NjQ5YTM5ODdm
+    YWZiNTNkZjIwNjM0NzQ3OTIwOGIwZGU0NDY3MDFkNDE0NjBjYWU=

data/Gruntfile.js

@@ -15,4 +15,11 @@ module.exports = function (grunt) {
     var bastion = require('./bastion.js');
 
     bastion(grunt);
+
+    grunt.registerTask('ci', [
+        'eslint',
+        'jshint',
+        'htmlhint',
+        'karma:ci'
+    ]);
 };

data/app/assets/javascripts/bastion/auth/auth.module.js

@@ -48,10 +48,9 @@ angular.module('Bastion.auth').config(['$httpProvider', '$provide',
                                 message = translate('You are not authorized to perform this action.');
                                 response.data.errors = [message];
                                 response.data.displayMessage = message;
-                                return $q.reject(response);
-                            } else {
-                                return $q.reject(response);
                             }
+
+                            return $q.reject(response);
                         }
                     };
                 }]
@@ -76,7 +75,7 @@ angular.module('Bastion.auth').run(['$rootScope', '$window', 'Authorization',
     function ($rootScope, $window, Authorization) {
         $rootScope.$on('$stateChangeStart', function (event, toState) {
             var permission = toState.permission;
-            if (permission !== false && (permission === undefined || Authorization.denied(permission))) {
+            if (permission !== false && (angular.isUndefined(permission) || Authorization.denied(permission))) {
                 $window.location.href = '/katello/403';
             }
         });

data/app/assets/javascripts/bastion/bastion.module.js

@@ -47,7 +47,7 @@ angular.module('Bastion').config(
 
         $httpProvider.defaults.headers.common = {
             Accept: 'application/json, text/plain, version=2; */*',
-            'X-CSRF-TOKEN': $('meta[name=csrf-token]').attr('content')
+            'X-CSRF-TOKEN': angular.element('meta[name=csrf-token]').attr('content')
         };
 
         $urlRouterProvider.rule(function ($injector, $location) {
@@ -81,7 +81,7 @@ angular.module('Bastion').config(
             return {
                 request: function (config) {
                     if (config.url.indexOf('.html') !== -1) {
-                        if ($templateCache.get(config.url) === undefined) {
+                        if (angular.isUndefined($templateCache.get(config.url))) {
                             config.url = '/' + config.url;
                         }
                     }
@@ -138,7 +138,7 @@ angular.module('Bastion').run(['$rootScope', '$state', '$stateParams', 'gettextC
         };
 
         $rootScope.stateIncludes = function (state, params) {
-            if (params !== undefined) {
+            if (angular.isDefined(params)) {
                 angular.forEach(params, function (value, key) {
                     params[key] = value.toString();
                 });

data/app/assets/javascripts/bastion/components/bst-alerts.directive.js

@@ -40,7 +40,7 @@ angular.module('Bastion.components').directive('bstAlerts', function () {
             scope.types = ['success', 'info', 'warning', 'danger'];
 
             function handleMessages(type, messages) {
-                scope.alerts[type] =  messages;
+                scope.alerts[type] = messages;
             }
 
             scope.$watch('successMessages', function (messages) {

data/app/assets/javascripts/bastion/components/bst-dropdown.directive.js

@@ -11,7 +11,7 @@ angular.module('Bastion.components').directive('bstDropdown', function () {
         restrict: 'EA',
         replace: true,
         scope: {
-            'dropdown' : '=bstDropdown'
+            'dropdown': '=bstDropdown'
         },
         templateUrl: 'components/views/bst-dropdown.html',
 

data/app/assets/javascripts/bastion/components/bst-edit.directive.js

@@ -37,6 +37,27 @@ angular.module('Bastion.components')
     .controller('BstEditController', ['$scope', '$filter', function ($scope, $filter) {
         var previousValue;
 
+        function handleAction(action) {
+            $scope.editMode = false;
+            $scope.workingMode = true;
+
+            if (angular.isDefined(action) && action.hasOwnProperty('then')) {
+                action.then(
+                    function () {
+                        $scope.updateDisplay($scope.model);
+                        $scope.workingMode = false;
+                    },
+                    function () {
+                        $scope.workingMode = false;
+                        $scope.editMode = true;
+                    }
+                );
+
+            } else {
+                $scope.workingMode = false;
+            }
+        }
+
         $scope.edit = function () {
             var options;
 
@@ -44,11 +65,11 @@ angular.module('Bastion.components')
                 $scope.editMode = true;
                 previousValue = $scope.model;
 
-                if ($scope.handleOptions !== undefined) {
+                if (angular.isDefined($scope.handleOptions)) {
                     options = $scope.handleOptions();
                 }
 
-                if (options !== undefined) {
+                if (angular.isDefined(options)) {
                     if (options.hasOwnProperty('then')) {
                         $scope.workingMode = true;
                         $scope.editMode = false;
@@ -93,27 +114,6 @@ angular.module('Bastion.components')
             handleAction(action);
         };
 
-        function handleAction(action) {
-            $scope.editMode = false;
-            $scope.workingMode = true;
-
-            if (action !== undefined && action.hasOwnProperty('then')) {
-                action.then(
-                    function () {
-                        $scope.updateDisplay($scope.model);
-                        $scope.workingMode = false;
-                    },
-                    function () {
-                        $scope.workingMode = false;
-                        $scope.editMode = true;
-                    }
-                );
-
-            } else {
-                $scope.workingMode = false;
-            }
-        }
-
         $scope.cancel = function () {
             $scope.editMode = false;
             $scope.disableSave = false;
@@ -132,7 +132,7 @@ angular.module('Bastion.components')
 
             handleDelete = $scope.handleDelete({ value: $scope.model });
 
-            if (handleDelete !== undefined && handleDelete.hasOwnProperty('then')) {
+            if (angular.isDefined(handleDelete) && handleDelete.hasOwnProperty('then')) {
 
                 handleDelete.then(
                     function () {
@@ -169,7 +169,7 @@ angular.module('Bastion.components')
         // Watch the model and displayed values for changes
         // and update the displayed value accordingly.
         $scope.$watch('model + displayValue', function (newValue) {
-            if (newValue !== undefined) {
+            if (angular.isDefined(newValue)) {
                 $scope.updateDisplay($scope.model);
             }
         });
@@ -255,7 +255,7 @@ angular.module('Bastion.components')
             },
             templateUrl: 'components/views/bst-edit-select.html',
             compile: function (element, attrs) {
-                var optionsFormat = attrs['optionsFormat'];
+                var optionsFormat = attrs.optionsFormat;
                 if (optionsFormat) {
                     element.find('select').attr('ng-options', optionsFormat);
                 }
@@ -341,7 +341,7 @@ angular.module('Bastion.components')
 
             handleAdd = $scope.handleAdd(value);
 
-            if (handleAdd !== undefined && handleAdd.hasOwnProperty('then')) {
+            if (angular.isDefined(handleAdd) && handleAdd.hasOwnProperty('then')) {
 
                 handleAdd.then(
                     function () {

data/app/assets/javascripts/bastion/components/bst-flyout.directive.js

@@ -12,7 +12,7 @@ angular.module('Bastion.components').directive('bstFlyout', function () {
         restrict: 'EA',
         replace: true,
         scope: {
-            'flyout' : '=bstFlyout'
+            'flyout': '=bstFlyout'
         },
         templateUrl: 'components/views/bst-flyout.html'
     };

data/app/assets/javascripts/bastion/components/bst-form-buttons.directive.js

@@ -38,7 +38,7 @@ angular.module('Bastion.components').directive('bstFormButtons', function () {
         },
         link: function (scope, iElement, iAttrs, controller) {
 
-            if (scope.working === undefined) {
+            if (angular.isUndefined(scope.working)) {
                 scope.working = false;
             }
 

data/app/assets/javascripts/bastion/components/bst-infinite-scroll.directive.js

@@ -38,7 +38,8 @@ angular.module('Bastion.components').directive('bstInfiniteScroll', [function ()
         },
         controller: function ($scope, $element) {
 
-            var result, raw = $element[0];
+            var result, getScrollHeight, isPromise, loadUntilScroll,
+                raw = $element[0];
 
             $element.bind('scroll', function () {
                 var sliderPosition = raw.scrollTop + raw.offsetHeight;
@@ -47,24 +48,25 @@ angular.module('Bastion.components').directive('bstInfiniteScroll', [function ()
                 }
             });
 
-            var getScrollHeight = function () {
+            getScrollHeight = function () {
                 var scrollHeight = 0;
                 $element.children().each(function () {
-                    scrollHeight = scrollHeight + $(this).get(0).scrollHeight;
+                    scrollHeight = scrollHeight + angular.element(this).get(0).scrollHeight;
                 });
                 return scrollHeight;
             };
 
-            var isPromise = function (promise) {
+            isPromise = function (promise) {
                 return promise && promise.hasOwnProperty('then');
             };
 
-            var loadUntilScroll = function () {
-                var result;
+            loadUntilScroll = function () {
+                var loadResult;
+
                 if (getScrollHeight() < $element.height()) {
-                    result = $scope.loadMoreFunction();
-                    if (isPromise(result)) {
-                        result.then(function () {
+                    loadResult = $scope.loadMoreFunction();
+                    if (isPromise(loadResult)) {
+                        loadResult.then(function () {
                             if (getScrollHeight() < $element.height()) {
                                 loadUntilScroll();
                             }
@@ -73,7 +75,7 @@ angular.module('Bastion.components').directive('bstInfiniteScroll', [function ()
                 }
             };
 
-            if (!$scope.skipInitialLoad && ($scope.data === undefined || $scope.data.length === 0)) {
+            if (!$scope.skipInitialLoad && (angular.isUndefined($scope.data) || $scope.data.length === 0)) {
                 result = $scope.loadMoreFunction();
                 if (isPromise(result)) {
                     result.then(loadUntilScroll);

data/app/assets/javascripts/bastion/components/bst-menu.directive.js

@@ -13,7 +13,7 @@ angular.module('Bastion.components').directive('bstMenu', ['$window', function (
         replace: true,
         scope: {
             'menu': '=bstMenu',
-            'compact' : '@'
+            'compact': '@'
         },
         templateUrl: 'components/views/bst-menu.html',
         controller: ['$scope', function ($scope) {
@@ -38,11 +38,11 @@ angular.module('Bastion.components').directive('bstMenu', ['$window', function (
         link: function (scope, element, attrs) {
             var elementOriginalOffset;
 
-            if (attrs.compact !== undefined) {
-                elementOriginalOffset = $(element).offset().top;
+            if (angular.isDefined(attrs.compact)) {
+                elementOriginalOffset = angular.element(element).offset().top;
 
                 angular.element($window).bind('scroll', function () {
-                    var windowScrollTop = $($window).scrollTop();
+                    var windowScrollTop = angular.element($window).scrollTop();
 
                     if (windowScrollTop > elementOriginalOffset + 2) {
                         element.parent().addClass('compact');

data/app/assets/javascripts/bastion/components/bst-modal.directive.js

@@ -43,8 +43,8 @@ angular.module('Bastion.components').directive('bstModal',
 
                 modalController = ['$scope', '$modalInstance', 'model', function ($scope, $modalInstance, model) {
                     $scope[scope.modelName] = model;
-                    $scope['modalHeader'] = scope.modalHeader;
-                    $scope['modalBody'] = scope.modalBody;
+                    $scope.modalHeader = scope.modalHeader;
+                    $scope.modalBody = scope.modalBody;
 
                     $scope.ok = function () {
                         $modalInstance.close();

data/app/assets/javascripts/bastion/components/bst-table.directive.js

@@ -112,16 +112,16 @@ angular.module('Bastion.components')
             scope: true,
             controller: 'BstTableHeadController',
             compile: function (tElement, tAttrs) {
-                if (tAttrs.rowSelect !== undefined) {
+                if (angular.isDefined(tAttrs.rowSelect)) {
                     tElement.prepend(rowSelectTemplate());
-                } else if (tAttrs.rowChoice !== undefined) {
+                } else if (angular.isDefined(tAttrs.rowChoice)) {
                     tElement.prepend(rowChoiceTemplate());
                 }
 
                 return function (scope, element, attrs, bstTableController) {
-                    if (tAttrs.rowSelect !== undefined) {
+                    if (angular.isDefined(tAttrs.rowSelect)) {
                         scope.table.rowSelect = true;
-                    } else  if (tAttrs.rowChoice !== undefined) {
+                    } else if (angular.isDefined(tAttrs.rowChoice)) {
                         scope.table.rowChoice = true;
                     }
 
@@ -156,19 +156,21 @@ angular.module('Bastion.components')
             controller: ['$scope', function ($scope) {
                 $scope.column = { show: true };
             }],
-            compile: function (element, attributes) {
-                if (attributes.hasOwnProperty("sortable")) {
-                    var newElement = angular.element(sortIconTemplate);
-                    newElement.find('.sort-icon').before(element.html());
+            compile: function (tElement, tAttributes) {
+                var newElement;
+
+                if (tAttributes.hasOwnProperty("sortable")) {
+                    newElement = angular.element(sortIconTemplate);
+                    newElement.find('.sort-icon').before(tElement.html());
                     newElement.addClass('sortable');
-                    newElement.addClass(element.attr('class'));
-                    element.replaceWith(newElement);
+                    newElement.addClass(tElement.attr('class'));
+                    tElement.replaceWith(newElement);
                 }
                 return function (scope, element, attributes, bstTableHeadController) {
                     if (attributes.hasOwnProperty("sortable")) {
                         $compile(element)(scope);
                     }
-                    scope.column.id = attributes["bstTableColumn"];
+                    scope.column.id = attributes.bstTableColumn;
                     bstTableHeadController.addColumn(scope.column);
 
                     scope.$watch('column.show', function (show) {
@@ -202,7 +204,7 @@ angular.module('Bastion.components')
 
         activeRowTemplate = function (activeTest) {
             return '<i class="fa fa-chevron-right selected-icon" ' +
-                   'ng-show="' + activeTest  + ' "></i>';
+                   'ng-show="' + activeTest + ' "></i>';
         };
 
         return {
@@ -212,19 +214,19 @@ angular.module('Bastion.components')
             controller: 'BstTableRowController',
             compile: function (tElement, tAttrs) {
 
-                if (tAttrs.activeRow !== undefined) {
+                if (angular.isDefined(tAttrs.activeRow)) {
                     tElement.find('td:first-child').append(activeRowTemplate(tAttrs.activeRow));
                 }
 
-                if (tAttrs.rowSelect !== undefined) {
+                if (angular.isDefined(tAttrs.rowSelect)) {
                     tElement.prepend(rowSelectTemplate(tAttrs.rowSelect));
                 }
 
-                if (tAttrs.rowChoice !== undefined) {
+                if (angular.isDefined(tAttrs.rowChoice)) {
                     tElement.prepend(rowChoiceTemplate(tAttrs.rowChoice));
                 }
 
-                if (tAttrs.activeRow !== undefined) {
+                if (angular.isDefined(tAttrs.activeRow)) {
                     tElement.find('td').attr('ng-class', '{ "active-row": ' + tAttrs.activeRow + ' }');
                 }
 

data/app/assets/javascripts/bastion/components/formatters/boolean-to-yes-no.filter.js

@@ -25,10 +25,10 @@ angular.module('Bastion.components.formatters').filter('booleanToYesNo', ['trans
         yesValue = yesValue || translate("Yes");
         noValue = noValue || translate("No");
 
-        if (boolValue !== '' && boolValue !== null && boolValue !== undefined) {
+        if (boolValue !== '' && boolValue !== null && angular.isDefined(boolValue)) {
             return (boolValue === true) ? yesValue : noValue;
-        } else {
-            return "";
         }
+
+        return "";
     };
 }]);

data/app/assets/javascripts/bastion/components/nutupane-table.directive.js

@@ -16,16 +16,9 @@ angular.module('Bastion.components').directive('nutupaneTable', ['$compile', '$w
             var originalTable, clonedTable, clonedThs,
                 windowElement = angular.element($window);
 
-            scope.$on("$stateChangeSuccess", function (event, newState, newParams, oldState) {
-                // Only clone the table if the collapsed value changed or it's the first time.
-                if (newState.collapsed !== oldState.collapsed || !oldState.name) {
-                    buildTable();
-                } else {
-                    element.find("table:not(.cloned-nutupane-table)").find('thead').hide();
-                }
-            });
-
             function buildTable() {
+                var rowSelect;
+
                 element.find('.cloned-nutupane-table').remove();
 
                 originalTable = element.find('table');
@@ -42,7 +35,7 @@ angular.module('Bastion.components').directive('nutupaneTable', ['$compile', '$w
                 $compile(element.find('.cloned-nutupane-table'))(scope);
 
                 // Need to remove duplicate row-select created by second $compile
-                var rowSelect = element.find(".row-select")[0];
+                rowSelect = element.find(".row-select")[0];
                 if (rowSelect) {
                     angular.element(rowSelect).remove();
                 }
@@ -69,6 +62,15 @@ angular.module('Bastion.components').directive('nutupaneTable', ['$compile', '$w
                 });
             }
 
+            scope.$on("$stateChangeSuccess", function (event, newState, newParams, oldState) {
+                // Only clone the table if the collapsed value changed or it's the first time.
+                if (newState.collapsed !== oldState.collapsed || !oldState.name) {
+                    buildTable();
+                } else {
+                    element.find("table:not(.cloned-nutupane-table)").find('thead').hide();
+                }
+            });
+
             buildTable();
         }
     };

data/app/assets/javascripts/bastion/components/nutupane.factory.js

@@ -116,10 +116,11 @@ angular.module('Bastion.components').factory('Nutupane',
             };
 
             self.table.autocomplete = function (term) {
-                var data, promise, params;
+                var data, promise, localParams;
+
                 if (resource.autocomplete) {
-                    params = self.getParams();
-                    params.search = term;
+                    localParams = self.getParams();
+                    localParams.search = term;
                     data = resource.autocomplete(params);
                 } else {
                     data = self.table.fetchAutocomplete(term);
@@ -127,13 +128,12 @@ angular.module('Bastion.components').factory('Nutupane',
 
                 promise = data.$promise;
                 if (promise) {
-                    return promise.then(function (data) {
-                        return self.table.transformScopedSearch(data);
+                    return promise.then(function (response) {
+                        return self.table.transformScopedSearch(response);
                     });
                 }
-                else {
-                    return data;
-                }
+
+                return data;
             };
 
             self.table.transformScopedSearch = function (results) {
@@ -292,7 +292,7 @@ angular.module('Bastion.components').factory('Nutupane',
             self.table.nextPage = function () {
                 var table = self.table;
                 if (table.working || !table.hasMore()) {
-                    return;
+                    return false;
                 }
                 return self.query();
             };
@@ -300,12 +300,13 @@ angular.module('Bastion.components').factory('Nutupane',
             self.table.hasMore = function () {
                 var length = self.table.rows.length,
                     subtotal = self.table.resource.subtotal,
-                    hasMore = false;
+                    hasMore = false,
+                    justBegun;
 
                 if (!subtotal) {
                     hasMore = false;
                 } else {
-                    var justBegun = (length === 0 && subtotal !== 0);
+                    justBegun = (length === 0 && subtotal !== 0);
                     hasMore = (length < subtotal) || justBegun;
                 }
                 return hasMore;

data/app/assets/javascripts/bastion/components/page-title.directive.js

@@ -33,18 +33,20 @@ angular.module('Bastion.components').directive('pageTitle', ['PageTitle', functi
             var title;
 
             return function (scope, iElem, iAttrs, ngModel) {
+                var unbind;
+
                 transclude(scope, function (clone) {
                     title = clone.text();
                 });
 
                 if (ngModel) {
-                    var unbind = scope.$watch(function () {
+                    unbind = scope.$watch(function () {
                         return ngModel.$viewValue;
                     }, function (model) {
                         unbind();
                         if (model.hasOwnProperty('$promise')) {
-                            model.$promise.then(function (model) {
-                                scope[scope.modelName] = model;
+                            model.$promise.then(function (data) {
+                                scope[scope.modelName] = data;
                                 PageTitle.setTitle(title, scope);
                             });
                         } else {

data/app/assets/javascripts/bastion/components/page-title.service.js

@@ -26,8 +26,10 @@ angular.module('Bastion.components').service('PageTitle', ['$window', '$interpol
         this.titles = [];
 
         this.setTitle = function (title, locals) {
+            var interpolated;
+
             if (title) {
-                var interpolated = $interpolate(title);
+                interpolated = $interpolate(title);
 
                 $window.document.title = interpolated(locals);
                 this.titles.push($window.document.title);

data/app/assets/javascripts/bastion/components/path-selector.directive.js

@@ -36,7 +36,32 @@ angular.module('Bastion.components').directive('pathSelector',
         templateUrl: 'components/views/path-selector.html',
         link: function (scope, element, attrs, ngModel) {
             var activeItemId, convertPathObjects, selectionRequired;
-            selectionRequired = attrs['selectionRequired'] ? attrs['selectionRequired'] === 'true' : true;
+            selectionRequired = attrs.selectionRequired ? attrs.selectionRequired === 'true' : true;
+
+            function forEachItem(callback) {
+                angular.forEach(scope.paths, function (path) {
+                    angular.forEach(path, function (item) {
+                        callback(item);
+                    });
+                });
+            }
+
+            function selectById(id) {
+                forEachItem(function (item) {
+                    if (item.id === id) {
+                        ngModel.$setViewValue(item);
+                        item.selected = true;
+                    }
+                });
+            }
+
+            function unselectActive() {
+                forEachItem(function (item) {
+                    if (item.id === activeItemId) {
+                        item.selected = false;
+                    }
+                });
+            }
 
             scope.itemChanged = function (item) {
                 if (item && scope.mode === 'singleSelect') {
@@ -52,7 +77,7 @@ angular.module('Bastion.components').directive('pathSelector',
 
             convertPathObjects = function (paths) {
                 if (scope.pathAttribute) {
-                    paths =  _.pluck(paths, scope.pathAttribute);
+                    paths = _.pluck(paths, scope.pathAttribute);
                 }
                 return paths;
             };
@@ -79,31 +104,6 @@ angular.module('Bastion.components').directive('pathSelector',
                     item.disabled = disable;
                 });
             });
-
-            function selectById(id) {
-                forEachItem(function (item) {
-                    if (item.id === id) {
-                        ngModel.$setViewValue(item);
-                        item.selected = true;
-                    }
-                });
-            }
-
-            function unselectActive() {
-                forEachItem(function (item) {
-                    if (item.id === activeItemId) {
-                        item.selected = false;
-                    }
-                });
-            }
-
-            function forEachItem(callback) {
-                angular.forEach(scope.paths, function (path) {
-                    angular.forEach(path, function (item) {
-                        callback(item);
-                    });
-                });
-            }
         }
     };
 });

data/app/assets/javascripts/bastion/components/typeahead-empty.directive.js

@@ -30,10 +30,9 @@ angular.module('Bastion.components').directive('typeaheadEmpty', function () {
         require: 'ngModel',
         link: function (scope, element, attrs, modelCtrl) {
             element.bind('focus', function () {
-                if (modelCtrl.$viewValue === undefined || modelCtrl.$viewValue === '') {
+                if (angular.isUndefined(modelCtrl.$viewValue) || modelCtrl.$viewValue === '') {
                     modelCtrl.$setViewValue(' ');
-                }
-                else {
+                } else {
                     modelCtrl.$setViewValue(modelCtrl.$viewValue);
                 }
             });

data/app/assets/javascripts/bastion/features/bst-feature-flag.directive.js

@@ -44,7 +44,7 @@
             scope: true,
             link: function (scope, element, attrs) {
                 attrs.ngIf = function () {
-                    return FeatureFlag.featureEnabled(attrs['bstFeatureFlag']);
+                    return FeatureFlag.featureEnabled(attrs.bstFeatureFlag);
                 };
 
                 ngIf.link.apply(ngIf, arguments);

data/app/assets/javascripts/bastion/features/feature-flag.service.js

@@ -48,7 +48,7 @@
          * @returns {Boolean}
          */
         this.featureEnabled = function (flag) {
-            return (featureFlags[flag] === undefined) ? true : featureFlags[flag].enabled;
+            return angular.isUndefined(featureFlags[flag]) ? true : featureFlags[flag].enabled;
         };
 
         /**
@@ -83,9 +83,9 @@
         this.addStates = function (feature, states) {
             feature = featureFlags[feature];
 
-            if (feature === undefined) {
+            if (angular.isUndefined(feature)) {
                 feature = {states: []};
-            } else if (feature.states === undefined) {
+            } else if (angular.isUndefined(undefined)) {
                 feature.states = [];
             }
 

data/app/assets/javascripts/bastion/menu/menu-expander.service.js

@@ -34,9 +34,9 @@ angular.module('Bastion.menu').service('MenuExpander', [function () {
     this.getMenu = function (menuName) {
         if (this.menu.hasOwnProperty(menuName)) {
             return this.menu[menuName];
-        } else {
-            return [];
         }
+
+        return [];
     };
 
     this.setMenu = function (menuName, items) {

data/bastion.js

@@ -4,6 +4,7 @@ module.exports = function (grunt) {
     var configs = requireDir('./grunt');
 
     grunt.loadTasks(__dirname + '/node_modules/grunt-contrib-jshint/tasks');
+    grunt.loadTasks(__dirname + '/node_modules/grunt-eslint/tasks');
     grunt.loadTasks(__dirname + '/node_modules/grunt-htmlhint/tasks');
     grunt.loadTasks(__dirname + '/node_modules/grunt-bower-task/tasks');
     grunt.loadTasks(__dirname + '/node_modules/grunt-karma/tasks');

data/grunt/eslint.js

@@ -0,0 +1,10 @@
+module.exports = {
+    options: {
+        configFile: __dirname + '/../eslint.yaml'
+    },
+    target: [
+        'Gruntfile.js',
+        'app/assets/javascripts/**/*.js',
+        '!app/assets/javascripts/bastion/i18n/translations.js'
+    ]
+};

data/lib/bastion/version.rb

@@ -1,3 +1,3 @@
 module Bastion
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

data/package.json

@@ -15,7 +15,10 @@
     "grunt-htmlhint": "~0.4.1",
     "grunt-concurrent": "~1.0.0",
     "generator-bastion": "~0.1.2",
-    "grunt-angular-gettext": "~0.2.15"
+    "grunt-angular-gettext": "~0.2.15",
+    "grunt-eslint": "~6.0.0",
+    "eslint": "~0.14.1",
+    "eslint-plugin-angular": "0.0.3"
   },
   "engines": {
     "node": ">=0.8.0"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bastion
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Katello
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-09 00:00:00.000000000 Z
+date: 2015-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: angular-rails-templates
@@ -159,6 +159,7 @@ files:
 - config/routes.rb
 - config/routes/mount_engine.rb
 - grunt/bower.js
+- grunt/eslint.js
 - grunt/htmlhint.js
 - grunt/jshint.js
 - grunt/karma.js