bastet 0.1.1 → 0.1.2

data/README.markdown

@@ -1,4 +1,4 @@
-# Bastet - The group based feature rollout beast
+# Bastet - The criteria based feature rollout beast [![Build Status](https://secure.travis-ci.org/itsmeduncan/bastet.png)](http://travis-ci.org/itsmeduncan/bastet)
 
 ## Gemfile
 
@@ -11,16 +11,30 @@
 
 ## Usage
 
+### Activate
+
     group = Bastet::Group.new('admin_users') { |user| user.admin? }
     bastet.activate("admin_only_feature", group)
 
+### Test
+
     user = User.new(admin: true)
     bastet.active?("admin_only_feature", user) #=> true
 
+
+### Deactivate
+
     bastet.deactivate("admin_only_feature", group)
     bastet.inactive?("admin_only_feature", user) #=> true
 
-## To do
+### Criteria
+
+    Bastet::Group.new('all') { true } # true for everyone
+    Bastet::Group.new('none') { false } # false for everyone
+    Bastet::Group.new('admins') { |user| user.admin? } # True for entities that respond to #admin? with true
+    Bastet::Group.new('10_percent') { |user| (entity.id % 10) < (20 / 10) } # True for 20% of entities based on the id
+
+## To Do
 
 1. Support activating/deactivating for multiple users/groups at once
 2. Percentage support
@@ -28,8 +42,6 @@
 
 ## Contibuting
 
-[![Build Status](https://secure.travis-ci.org/itsmeduncan/bastet.png)](http://travis-ci.org/itsmeduncan/bastet)
-
 1. Fork Basteet
 2. Create a topic branch - `git checkout -b my_branch`
 3. Push to your branch - `git push origin my_branch`

data/bastet.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |s|
   s.authors     = ["Duncan Grazier"]
   s.email       = ["itsmeduncan@gmail.com"]
   s.homepage    = "https://github.com/itsmeduncan/bastet"
-  s.summary     = %q{Simple feature rollout for users, and groups}
-  s.description = %q{Simple feature rollout for users, and groups}
+  s.summary     = %q{Simple feature rollout for criteria based groups}
+  s.description = %q{Simple feature rollout for criteria based groups}
 
   s.rubyforge_project = "bastet"
 

data/lib/bastet/base.rb

@@ -4,15 +4,15 @@ class Bastet::Base
   include Singleton
 
   def activate feature, group
-    Bastet.redis.sadd("feature_#{feature}", group.name)
+    act(:sadd, feature, group)
   end
 
   def deactivate feature, group
-    Bastet.redis.srem("feature_#{feature}", group.name)
+    act(:srem, feature, group)
   end
 
   def active? feature, entity
-    group_names = Bastet.redis.smembers("feature_#{feature}")
+    group_names = Bastet.redis.smembers(feature_key(feature))
     groups = Bastet.groups.select { |group| group_names.include?(group.name) }
     groups.any? { |group| group.criteria.call(entity) }
   end
@@ -20,4 +20,14 @@ class Bastet::Base
   def inactive? feature, entity
     !active? feature, entity
   end
+
+  private
+
+    def act method, feature, group
+      Bastet.redis.send(method, feature_key(feature), group.name)
+    end
+
+    def feature_key feature
+      "feature_#{feature}"
+    end
 end

data/lib/bastet/group.rb

@@ -16,16 +16,14 @@ class Bastet::Group
   end
 
   def contains? entity
-    criteria.call(entity)
+    criteria.call(entity) rescue false
   end
 
   private
 
     def validate_name! name
-      if Bastet.redis.sismember('bastet_groups', name)
+      if Bastet::Group.find(name)
         raise ArgumentError.new("#{name} is already initialized as a group.")
-      else
-        Bastet.redis.sadd('bastet_groups', name)
       end
     end
 

data/lib/bastet/version.rb

@@ -1,3 +1,3 @@
 module Bastet
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/bastet/base_spec.rb

@@ -13,6 +13,23 @@ describe Bastet::Base do
       @bastet.activate(:banana, group)
       @bastet.active?(:banana, user).should be_true
     end
+
+    describe "complex criteria" do
+      before do
+        @group = Bastet::Group.new("20_percent") { |entity| (entity.id % 10) < (20 / 10) }
+        @bastet.activate(:secret_feature, @group)
+      end
+
+      it "should be true for the user" do
+        user = mock('user', id: 20)
+        @bastet.active?(:secret_feature, user).should be_true
+      end
+
+      it "should be false for the user" do
+        user = mock('user', id: 19)
+        @bastet.active?(:secret_feature, user).should be_false
+      end
+    end
   end
 
   describe "deactivate" do
@@ -27,4 +44,11 @@ describe Bastet::Base do
       @bastet.inactive?(:banana, user).should be_true
     end
   end
+
+  describe "default to inactive" do
+    it "should default to inactive for new features" do
+      user = mock('user')
+      @bastet.active?(:unknown_feature, user).should be_false
+    end
+  end
 end

data/spec/bastet/group_spec.rb

@@ -72,5 +72,13 @@ describe Bastet::Group do
       group = Bastet::Group.new('none') { |entity| false }
       group.contains?(mock).should be_false
     end
+
+    it "should be false if the object doesn't respond to that criteria" do
+      fake = stub
+      fake.expects(:foo?).raises(NoMethodError)
+
+      group = Bastet::Group.new('foo') { |entity| entity.foo? }
+      group.contains?(fake).should be_false
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bastet
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-12-05 00:00:00.000000000 Z
+date: 2011-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70222723844920 !ruby/object:Gem::Requirement
+  requirement: &70284937960540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 0.9.2.2
   type: :development
   prerelease: false
-  version_requirements: *70222723844920
+  version_requirements: *70284937960540
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70222723844380 !ruby/object:Gem::Requirement
+  requirement: &70284937960040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: 2.7.0
   type: :development
   prerelease: false
-  version_requirements: *70222723844380
+  version_requirements: *70284937960040
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &70222723843860 !ruby/object:Gem::Requirement
+  requirement: &70284937959580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 0.10.0
   type: :development
   prerelease: false
-  version_requirements: *70222723843860
+  version_requirements: *70284937959580
 - !ruby/object:Gem::Dependency
   name: redis
-  requirement: &70222723843400 !ruby/object:Gem::Requirement
+  requirement: &70284937959120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: 2.2.2
   type: :development
   prerelease: false
-  version_requirements: *70222723843400
+  version_requirements: *70284937959120
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70222723843020 !ruby/object:Gem::Requirement
+  requirement: &70284937958660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,8 +65,8 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70222723843020
-description: Simple feature rollout for users, and groups
+  version_requirements: *70284937958660
+description: Simple feature rollout for criteria based groups
 email:
 - itsmeduncan@gmail.com
 executables: []
@@ -113,7 +113,7 @@ rubyforge_project: bastet
 rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
-summary: Simple feature rollout for users, and groups
+summary: Simple feature rollout for criteria based groups
 test_files:
 - spec/bastet/base_spec.rb
 - spec/bastet/group_spec.rb