basketball 0.0.26 → 0.0.27

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 11631dcd181d791f3eb5d9ca7af6bbfab2527c1837302ac83d72ff77bd990345
-  data.tar.gz: 4f9a808e1579e83d7ca7c811e1e75a82af919f1b9c53d9f5f67c9a4d2e846db2
+  metadata.gz: 3fdbeeaeb0a6e0382cc1af0031199691ac64ba039b3bfa4fa6bde0ac0bde2b17
+  data.tar.gz: 3ed2a71522e8aae3aa78cd5af06941f966341b01f4c85a81a04f772b561a349d
 SHA512:
-  metadata.gz: 4e52ca8ea4a738af4dd3548b4332e60cac35cef0469c3a9e6698d7936358f624ddb30a79de5bfb54a43425ec83a9a20a77e7ec4f94663d9c6e2064f41d33f7ba
-  data.tar.gz: b0b07ad92d1aacab9a0d5aaba9dea3713b12ae4f1deeb8bcf9b08fa3d95b6a857b0b4dd2237a8cb979e37aa651bd770c4413d324ea92875b7b004e3ffa85f6a8
+  metadata.gz: 2b76fa1d6b90f0c93e49b73c44028792909d94da7a42a472c923e9c23ab504fdd3acfcf037696479fa2851e9cd106c83dca4b951ead2dc25b02e9d5d996eee2c
+  data.tar.gz: 6ef6f13785dc387ad3df3feeb55cd9d6f2619fa992cd866b38819d4e4c249862b7400c65c0a44552c7e483750068e7957e9776d35f37fbe05e993a08f4574802

data/.rubocop.yml

@@ -19,7 +19,7 @@ RSpec/NestedGroups:
   Max: 5
 
 RSpec/MultipleExpectations:
-  Max: 2
+  Max: 10
 
 Metrics/ParameterLists:
   Max: 6

data/lib/basketball/season/record.rb

@@ -19,29 +19,9 @@ module Basketball
       end
 
       def accept!(result)
-        if result.home_opponent == self
-          detail = Detail.new(
-            date: result.date,
-            opponent: result.away_opponent,
-            score: result.home_score,
-            opponent_score: result.away_score,
-            home: true
-          )
-
-          add!(detail)
-        elsif result.away_opponent == self
-          detail = Detail.new(
-            date: result.date,
-            opponent: result.home_opponent,
-            score: result.away_score,
-            opponent_score: result.home_score,
-            home: false
-          )
-
-          add!(detail)
-        else
-          raise OpponentNotFoundError, "#{result} has no opponent for #{self}"
-        end
+        detail = result_to_detail(result)
+
+        add!(detail)
       end
 
       def detail_for(date)
@@ -99,6 +79,34 @@ module Basketball
       def details_for(opponent_type = nil)
         details.select { |d| opponent_type.nil? || d.opponent_type == opponent_type }
       end
+
+      def result_to_detail(result)
+        base_args = {
+          date: result.date,
+          opponent_type: result.opponent_type
+        }
+
+        all_args =
+          if result.home_opponent == self
+            base_args.merge(
+              opponent: result.away_opponent,
+              score: result.home_score,
+              opponent_score: result.away_score,
+              home: true
+            )
+          elsif result.away_opponent == self
+            base_args.merge(
+              opponent: result.home_opponent,
+              score: result.away_score,
+              opponent_score: result.home_score,
+              home: false
+            )
+          else
+            raise OpponentNotFoundError, "#{result} has no opponent for #{self}"
+          end
+
+        Detail.new(**all_args)
+      end
     end
   end
 end

data/lib/basketball/season/result.rb

@@ -11,7 +11,7 @@ module Basketball
 
       attr_reader :game, :home_score, :away_score
 
-      def_delegators :game, :date, :home_opponent, :away_opponent, :teams
+      def_delegators :game, :date, :home_opponent, :away_opponent, :teams, :opponent_type
 
       def initialize(game:, home_score:, away_score:)
         raise ArgumentError, 'game is required' unless game

data/lib/basketball/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Basketball
-  VERSION = '0.0.26'
+  VERSION = '0.0.27'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: basketball
 version: !ruby/object:Gem::Version
-  version: 0.0.26
+  version: 0.0.27
 platform: ruby
 authors:
 - Matthew Ruggio
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-07-10 00:00:00.000000000 Z
+date: 2023-07-25 00:00:00.000000000 Z
 dependencies: []
 description: "    This library is meant to serve as the domain for a basketball league/season
   simulator/turn-based game. It models core ideas such as: players, general managers,