basketball 0.0.25 → 0.0.26

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e02bf31c8332d0d1010f8ad9ff18cb09ddd3f97e4a7cefcb14ddf11d38633d67
-  data.tar.gz: 9c4b3b0e1771c0a4d22e8c83ba9040089fae019f3726c8cda55ddecbb3d69fa1
+  metadata.gz: 11631dcd181d791f3eb5d9ca7af6bbfab2527c1837302ac83d72ff77bd990345
+  data.tar.gz: 4f9a808e1579e83d7ca7c811e1e75a82af919f1b9c53d9f5f67c9a4d2e846db2
 SHA512:
-  metadata.gz: 65a444b460b134eeceecea00213a0e4887dc635b7d012f402e09404e4d3e2dea44931810f413da167ae72ea6fb9e2b1533aea4691d3b5d99ba841709388f95e0
-  data.tar.gz: b193b20e0ba49d4cf4686150cc7abef344a3289bcefdeb4bfc168e57e2eb8f1c6d776e3eafdc6a618096ea29e0ae9d3e94d96b3c78f341efc461efab6f746b16
+  metadata.gz: 4e52ca8ea4a738af4dd3548b4332e60cac35cef0469c3a9e6698d7936358f624ddb30a79de5bfb54a43425ec83a9a20a77e7ec4f94663d9c6e2064f41d33f7ba
+  data.tar.gz: b0b07ad92d1aacab9a0d5aaba9dea3713b12ae4f1deeb8bcf9b08fa3d95b6a857b0b4dd2237a8cb979e37aa651bd770c4413d324ea92875b7b004e3ffa85f6a8

data/lib/basketball/season/detail.rb

@@ -7,12 +7,14 @@ module Basketball
       value_reader :date,
                    :home,
                    :opponent_score,
+                   :opponent_type,
                    :opponent,
                    :score
 
       alias home? home
 
-      def initialize(date:, home:, opponent:, opponent_score:, score:)
+      # rubocop:disable Metrics/CyclomaticComplexity
+      def initialize(date:, home:, opponent:, opponent_score:, score:, opponent_type:)
         super()
 
         raise ArgumentError,  'date is required'           unless date
@@ -21,15 +23,30 @@ module Basketball
         raise ArgumentError,  'opponent_score is required' unless opponent_score
         raise ArgumentError,  'home is required'           if home.nil?
         raise CannotTieError, 'scores cannot be equal'     if score == opponent_score
+        raise ArgumentError,  'opponent_type is required'  unless opponent_type
 
         @date           = date
         @opponent       = opponent
         @score          = score
         @opponent_score = opponent_score
         @home           = home
+        @opponent_type  = OpponentType.parse(opponent_type)
 
         freeze
       end
+      # rubocop:enable Metrics/CyclomaticComplexity
+
+      def divisional?
+        opponent_type == INTRA_DIVISIONAL
+      end
+
+      def intra_conference?
+        opponent_type == INTRA_CONFERENCE
+      end
+
+      def inter_conterence?
+        opponent_type == INTER_CONFERENCE
+      end
 
       def win?
         score > opponent_score
@@ -40,7 +57,10 @@ module Basketball
       end
 
       def to_s
-        "[#{date}] #{win? ? 'Win' : 'Loss'} #{home? ? 'vs' : 'at'} #{opponent} (#{score}-#{opponent_score})"
+        win_display = win? ? 'win' : 'loss'
+        vs_display  = home? ? 'vs' : 'at'
+
+        "[#{date}] #{opponent_type} #{win_display} #{vs_display} #{opponent} (#{score}-#{opponent_score})"
       end
     end
   end

data/lib/basketball/season/game.rb

@@ -4,19 +4,21 @@ module Basketball
   module Season
     # Base class describing what all games have in common.
     class Game < ValueObject
-      value_reader :date, :home_opponent, :away_opponent
+      value_reader :date, :home_opponent, :away_opponent, :opponent_type
 
-      def initialize(date:, home_opponent:, away_opponent:)
+      def initialize(date:, home_opponent:, away_opponent:, opponent_type:)
         super()
 
         raise ArgumentError, 'date is required'             unless date
         raise ArgumentError, 'home_opponent is required'    unless home_opponent
         raise ArgumentError, 'away_opponent is required'    unless away_opponent
         raise ArgumentError, 'teams cannot play themselves' if home_opponent == away_opponent
+        raise ArgumentError, 'opponent_type is required'    unless opponent_type
 
         @date          = date
         @home_opponent = home_opponent
         @away_opponent = away_opponent
+        @opponent_type = OpponentType.parse(opponent_type)
 
         freeze
       end

data/lib/basketball/season/opponent_type.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module Basketball
+  module Season
+    # Describes the relationship between two teams.
+    module OpponentType
+      INTRA_DIVISIONAL = :intra_divisional
+      INTRA_CONFERENCE = :intra_conference
+      INTER_CONFERENCE = :inter_conference
+
+      class << self
+        def parse(value)
+          OpponentType.const_get(value.to_s.upcase.to_sym)
+        end
+      end
+    end
+  end
+end

data/lib/basketball/season/record.rb

@@ -52,26 +52,28 @@ module Basketball
         details_by_date.values
       end
 
-      def win_percentage
+      def win_percentage(opponent_type = nil)
+        game_count = game_count(opponent_type)
+
         return 0 unless game_count.positive?
 
-        (win_count.to_f / game_count).round(3)
+        (win_count(opponent_type).to_f / game_count).round(3)
       end
 
-      def win_percentage_display
-        format('%.3f', win_percentage)
+      def win_percentage_display(opponent_type = nil)
+        format('%.3f', win_percentage(opponent_type))
       end
 
-      def game_count
-        details.length
+      def game_count(opponent_type)
+        details_for(opponent_type).length
       end
 
-      def win_count
-        details.count(&:win?)
+      def win_count(opponent_type = nil)
+        details_for(opponent_type).count(&:win?)
       end
 
-      def loss_count
-        details.count(&:loss?)
+      def loss_count(opponent_type = nil)
+        details_for(opponent_type).count(&:loss?)
       end
 
       def to_s
@@ -93,6 +95,10 @@ module Basketball
       private
 
       attr_reader :details_by_date
+
+      def details_for(opponent_type = nil)
+        details.select { |d| opponent_type.nil? || d.opponent_type == opponent_type }
+      end
     end
   end
 end

data/lib/basketball/season/scheduler.rb

@@ -160,16 +160,19 @@ module Basketball
         matchups = matchup_plan(league)
 
         matchups.each do |(team1, team2), count|
-          candidates = calendar.available_regular_matchup_dates(team1, team2)
-          dates      = candidates.sample(count)
-          games      = balanced_games(dates, team1, team2)
+          determine_opponent_type(league, team1, team2)
+          candidates    = calendar.available_regular_matchup_dates(team1, team2)
+          dates         = candidates.sample(count)
+          games         = balanced_games(dates, team1, team2, league)
 
           games.each { |game| calendar.add!(game) }
         end
       end
 
-      def balanced_games(dates, team1, team2)
+      def balanced_games(dates, team1, team2, league)
         dates.map.with_index(1) do |date, index|
+          opponent_type = determine_opponent_type(league, team1, team2)
+
           home_opponent, away_opponent =
             if index.even?
               [Opponent.from(team1), Opponent.from(team2)]
@@ -177,7 +180,7 @@ module Basketball
               [Opponent.from(team2), Opponent.from(team1)]
             end
 
-          Regular.new(date:, home_opponent:, away_opponent:)
+          Regular.new(date:, home_opponent:, away_opponent:, opponent_type:)
         end
       end
 
@@ -198,8 +201,9 @@ module Basketball
 
             next if candidates.empty?
 
-            date = candidates.sample
-            game = random_exhibition_game(date, team, other_team)
+            opponent_type = determine_opponent_type(league, team, other_team)
+            date          = candidates.sample
+            game          = random_exhibition_game(date, team, other_team, opponent_type)
 
             calendar.add!(game)
 
@@ -208,7 +212,17 @@ module Basketball
         end
       end
 
-      def random_exhibition_game(date, team1, team2)
+      def determine_opponent_type(league, team1, team2)
+        if league.division_for(team1) == league.division_for(team2)
+          OpponentType::INTRA_DIVISIONAL
+        elsif league.conference_for(team1) == league.conference_for(team2)
+          OpponentType::INTRA_CONFERENCE
+        else
+          OpponentType::INTER_CONFERENCE
+        end
+      end
+
+      def random_exhibition_game(date, team1, team2, opponent_type)
         home_opponent, away_opponent =
           if rand(1..2) == 1
             [Opponent.from(team1), Opponent.from(team2)]
@@ -216,7 +230,7 @@ module Basketball
             [Opponent.from(team2), Opponent.from(team1)]
           end
 
-        Exhibition.new(date:, home_opponent:, away_opponent:)
+        Exhibition.new(date:, home_opponent:, away_opponent:, opponent_type:)
       end
     end
   end

data/lib/basketball/season.rb

@@ -6,6 +6,7 @@ require_relative 'season/calendar'
 require_relative 'season/game'
 require_relative 'season/matchup'
 require_relative 'season/opponent'
+require_relative 'season/opponent_type'
 require_relative 'season/result'
 
 # League Common

data/lib/basketball/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Basketball
-  VERSION = '0.0.25'
+  VERSION = '0.0.26'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: basketball
 version: !ruby/object:Gem::Version
-  version: 0.0.25
+  version: 0.0.26
 platform: ruby
 authors:
 - Matthew Ruggio
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-06-30 00:00:00.000000000 Z
+date: 2023-07-10 00:00:00.000000000 Z
 dependencies: []
 description: "    This library is meant to serve as the domain for a basketball league/season
   simulator/turn-based game. It models core ideas such as: players, general managers,
@@ -62,6 +62,7 @@ files:
 - lib/basketball/season/league.rb
 - lib/basketball/season/matchup.rb
 - lib/basketball/season/opponent.rb
+- lib/basketball/season/opponent_type.rb
 - lib/basketball/season/player.rb
 - lib/basketball/season/position.rb
 - lib/basketball/season/record.rb