basic_temperature 0.1.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: abc9f2d631494075604ae36162102c4aff070974a2bd391a198ac7f95cd4e23c
-  data.tar.gz: 22459a3590a5af282596f6d4bb819a96e6442b6ebfd739274de9e02221c2d96d
+  metadata.gz: 7b20510122a2cac35b771c18843e418c0441e926b421f0f10ae316385af7529d
+  data.tar.gz: 697c43df7e678d701d1052fd872a3cf0afaffd5eeec666d9ae90927f9f693e0d
 SHA512:
-  metadata.gz: f1a4b929508305ce833ae0ad9bda5fc4e4b1c539fa20041a2914e7f8e2e3d6239e9ab28daa90ff9c9bf7caa1f6d66a7a7b666b8c65280b397fa46ebeaff9afef
-  data.tar.gz: 642cf6da0c1acf3b375a6cf02c4cad7251a67f08c31762dead3d75c91ee014ae8c9d31d7d4a21d54c23151247c940986ae69c657c3fa432257eceb08e791e91e
+  metadata.gz: faf2b656ce8787e1a891dd2784e825b5ac2d42238915ad1f4636bce69fe92cddfb5b7c51fe89aa7a0dbe348606dbf6796efc435f331194efa78e6213f9927717
+  data.tar.gz: f813145375bd5823ad63fb3e11aed3fbf3a6bbb9e3c6a9eb600ec7b6264f0c63c98b3d4a23b02b53878ebeaa80237a2b11d14de194c5d7acade689dbf3c07e0a

data/.gitignore

@@ -9,3 +9,6 @@
 
 # rspec failure tracking
 .rspec_status
+
+# Hide `byebug` history
+.byebug_history

data/.rubocop.yml

@@ -0,0 +1,13 @@
+AllCops:
+  Exclude:
+    - .git/**/*
+    - bin/**/*
+    - pkg/**/*
+    - spec/**/*
+    - vendor/bundle/**/*
+
+Layout/LineLength:
+  Max: 110
+
+Style/RedundantSelf:
+  Enabled: No

data/.travis.yml

@@ -1,6 +1,19 @@
 ---
 language: ruby
+
 cache: bundler
+
+before_install:
+  - yes | gem update --system --force
+  - gem install bundler -v 2.1.2
+
 rvm:
+  - 2.3.0
+  - 2.4.0
+  - 2.5.0
+  - 2.6.0
   - 2.7.0
-before_install: gem install bundler -v 2.1.2
+
+script:
+  - bundle exec rubocop
+  - bundle exec rspec

data/CHANGELOG.md

@@ -1,2 +1,15 @@
+## 0.2.1
+### Features:
+  - Spaceship operator <=>
+
+### Tech improvements:
+  - [byebug](https://github.com/deivid-rodriguez/byebug) as dev dependency
+  - [rspec](https://rspec.info/) as dev dependency
+  - [rubocop](https://github.com/rubocop-hq/rubocop) as dev dependency
+  - [Travis CI](https://travis-ci.com/) setup
+
+## 0.2.0
+  - 'Accidentally' yanked
+
 ## 0.1.0
   - Initial Release.

data/Gemfile

@@ -1,7 +1,6 @@
-source "https://rubygems.org"
+# frozen_string_literal: true
+
+source 'https://rubygems.org'
 
 # Specify your gem's dependencies in basic_temperature.gemspec
 gemspec
-
-gem "rake", "~> 12.0"
-gem "rspec", "~> 3.0"

data/Gemfile.lock

@@ -1,13 +1,21 @@
 PATH
   remote: .
   specs:
-    basic_temperature (0.1.0)
+    basic_temperature (0.2.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
+    ast (2.4.0)
+    byebug (10.0.2)
     diff-lcs (1.3)
+    jaro_winkler (1.5.4)
+    parallel (1.19.1)
+    parser (2.7.0.3)
+      ast (~> 2.4.0)
+    rainbow (3.0.0)
     rake (12.3.3)
+    rexml (3.2.4)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
@@ -21,14 +29,26 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.2)
+    rubocop (0.80.0)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.7.0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      rexml
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    ruby-progressbar (1.10.1)
+    unicode-display_width (1.6.1)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   basic_temperature!
+  byebug (~> 10.0)
   rake (~> 12.0)
   rspec (~> 3.0)
+  rubocop (~> 0.80.0)
 
 BUNDLED WITH
    2.1.2

data/Rakefile

@@ -1,6 +1,8 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/basic_temperature.gemspec

@@ -1,26 +1,39 @@
+# frozen_string_literal: true
+
 require_relative 'lib/basic_temperature/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "basic_temperature"
-  spec.version       = BasicTemperature::VERSION
-  spec.authors       = ["Marian Kostyk"]
-  spec.email         = ["mariankostyk13895@gmail.com"]
+  spec.name = 'basic_temperature'
+  spec.version = BasicTemperature::VERSION
+
+  spec.authors = ['Marian Kostyk']
+  spec.email = ['mariankostyk13895@gmail.com']
+
+  spec.summary = 'Value object for basic temperature operations.'
+  spec.description =
+    'Value object for basic temperature operations like ' \
+    'conversions from Celcius to Fahrenhait or Kelvin etc.'
 
-  spec.summary       = %q{Value object for basic temperature operations.}
-  spec.description   = %q{Value object for basic temperature operations like conversions from Celcius to Fahrenhait or Kelvin etc.}
-  spec.homepage      = "https://github.com/marian13/basic_temperature"
-  spec.license       = "MIT"
-  spec.required_ruby_version = Gem::Requirement.new(">= 2.0.0")
+  spec.homepage = 'https://github.com/marian13/basic_temperature'
 
-  spec.metadata["homepage_uri"] = spec.homepage
-  spec.metadata["source_code_uri"] = spec.homepage
-  spec.metadata["changelog_uri"] = "#{spec.homepage}/CHANGELOG.md"
+  spec.license = 'MIT'
+
+  spec.required_ruby_version = Gem::Requirement.new('>= 2.3.0')
+
+  spec.metadata['homepage_uri'] = spec.homepage
+  spec.metadata['source_code_uri'] = spec.homepage
+  spec.metadata['changelog_uri'] = "#{spec.homepage}/CHANGELOG.md"
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
+  spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
 
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
+
+  spec.add_development_dependency 'byebug', '~> 10.0'
+  spec.add_development_dependency 'rake', '~> 12.0'
+  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'rubocop', '~> 0.80.0'
 end

data/lib/basic_temperature.rb

@@ -1,10 +1,14 @@
+# frozen_string_literal: true
+
 require 'basic_temperature/version'
 
+# Value Object for basic temperature operations like conversions from Celcius to Fahrenhait or Kelvin etc.
+# rubocop:disable Metrics/ClassLength
 class BasicTemperature
   class InitializationArgumentsError < StandardError; end
   class InvalidDegreesError < StandardError; end
   class InvalidScaleError < StandardError; end
-  class InvalidAddendError < StandardError; end
+  class InvalidOtherError < StandardError; end
   class CoersionError < StandardError; end
 
   SCALES =
@@ -13,7 +17,6 @@ class BasicTemperature
       FAHRENHEIT = 'fahrenheit',
       KELVIN = 'kelvin'
     ]
-    .map(&:freeze)
     .freeze
 
   attr_reader :degrees, :scale
@@ -24,18 +27,22 @@ class BasicTemperature
 
     if keyword_arguments.any?
       initialize_via_keywords_arguments(keyword_arguments)
-    elsif positional_arguments.any?
+    else # positional_arguments.any?
       initialize_via_positional_arguments(positional_arguments)
     end
   end
 
+  # rubocop:disable Naming/AccessorMethodName
   def set_degrees(degrees)
     BasicTemperature.new(degrees, scale)
   end
+  # rubocop:enable Naming/AccessorMethodName
 
+  # rubocop:disable Naming/AccessorMethodName
   def set_scale(scale)
     self.to_scale(scale)
   end
+  # rubocop:enable Naming/AccessorMethodName
 
   def to_scale(scale)
     case cast_scale(scale)
@@ -98,28 +105,28 @@ class BasicTemperature
     @to_kelvin = BasicTemperature.new(degrees, KELVIN)
   end
 
-  def ==(other_temperature)
-    return false unless other_temperature.instance_of?(BasicTemperature)
+  def ==(other)
+    return false unless other.instance_of?(BasicTemperature)
 
-    self.degrees == other_temperature.degrees && self.scale == other_temperature.scale
+    self.degrees == other.degrees && self.scale == other.scale
   end
 
-  def +(addend)
+  def +(other)
     degrees, scale =
-      case addend
+      case other
       when Numeric
-        [self.degrees + addend, self.scale]
+        [self.degrees + other, self.scale]
       when BasicTemperature
-        [self.to_scale(addend.scale).degrees + addend.degrees, addend.scale]
+        [self.to_scale(other.scale).degrees + other.degrees, other.scale]
       else
-        raise_invalid_addend_error(addend)
+        raise_invalid_other_error(other)
       end
 
     BasicTemperature.new(degrees, scale)
   end
 
-  def -(subtrahend)
-    self + (-subtrahend)
+  def -(other)
+    self + -other
   end
 
   def -@
@@ -136,6 +143,12 @@ class BasicTemperature
     "#{degrees.to_i} #{scale.capitalize}"
   end
 
+  def <=>(other)
+    return unless other.instance_of?(BasicTemperature)
+
+    self.to_scale(other.scale).degrees <=> other.degrees
+  end
+
   private
 
   def initialize_via_positional_arguments(positional_arguments)
@@ -173,9 +186,7 @@ class BasicTemperature
   end
 
   def assert_numeric_or_temperature!(numeric_or_temperature)
-    if numeric_or_temperature.is_a?(Numeric) || numeric_or_temperature.instance_of?(BasicTemperature)
-      return
-    end
+    return if numeric_or_temperature.is_a?(Numeric) || numeric_or_temperature.instance_of?(BasicTemperature)
 
     raise_coersion_error(numeric_or_temperature)
   end
@@ -199,16 +210,17 @@ class BasicTemperature
   def raise_invalid_scale_error
     message =
       'scale has invalid value, ' \
-      "valid values are #{SCALES.map { |scale| "'#{scale}'"}.join(', ')}."
+      "valid values are #{SCALES.map { |scale| "'#{scale}'" }.join(', ')}."
 
     raise InvalidScaleError, message
   end
 
-  def raise_invalid_addend_error(addend)
-    raise InvalidAddendError, "`#{addend}` is neither Numeric nor Temperature."
+  def raise_invalid_other_error(other)
+    raise InvalidOtherError, "`#{other}` is neither Numeric nor Temperature."
   end
 
   def raise_coersion_error(object)
     raise CoersionError, "#{object} is neither Numeric nor Temperature."
   end
 end
+# rubocop:enable Metrics/ClassLength

data/lib/basic_temperature/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BasicTemperature
-  VERSION = '0.1.0'.freeze
-end
+  VERSION = '0.2.1'
+end

metadata

@@ -1,15 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: basic_temperature
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Marian Kostyk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-14 00:00:00.000000000 Z
-dependencies: []
+date: 2020-02-27 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.80.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.80.0
 description: Value object for basic temperature operations like conversions from Celcius
   to Fahrenhait or Kelvin etc.
 email:
@@ -20,6 +76,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
@@ -47,7 +104,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="