basecrm 1.3.8 → 1.3.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ace86b32daf827a102ee89fdf376030f5f7eecfd9e7a4311f51afab5a39f862f
-  data.tar.gz: 8d5d2b5222e0d12ad92f7f59c483f89b99f4e852909b4966767f93be86e2109a
+  metadata.gz: afa9bee39abea53bd2f89300e5e50cb638021d64b31372c0de31f8658f52a21b
+  data.tar.gz: e2f9681713ab28c138f64355ea069f95774b705cb85466ff26b69874bd2a7200
 SHA512:
-  metadata.gz: cd8e4346fe4cad4d0cdab9e0b6ee1f7ef36537939259dd381c3f65f0b8e52fcfc2bcd9b4c54410d5f4c537e743669f22b67350d3b33c5b2c0e1ced09ac98be90
-  data.tar.gz: f2cbebc01aa6cd103a0aef1930e5328f8be7103b90a7021cbc08500521495de48695eea0a74adde753beb8547a51921b74ddb99bfa0cb652088aee400bda54cb
+  metadata.gz: 43f0e183a4f134c48347cbad9866ea8dd7f59f9cbf7df06c185f9e22279c630673d9889a2efb10367564c6241914f38144cf6f322484ff9c244dca87dfb43786
+  data.tar.gz: 431333dce4e47268eb3f43d41b2206bb7befdadf60f7ca4dc152fa32c56b4cfeab18284876a81fa17bdfcc6450108c033693be823277a3adaa328dd949e57202

data/README.md

@@ -483,6 +483,12 @@ Actions:
 ## Bug Reports
 Report [here](https://github.com/zendesk/basecrm-ruby/issues).
 
+## Releasing new version of gem
+
+1. Update version [lib/basecrm/version.rb](lib/basecrm/version.rb) and [VERSION](VERSION) and push to `master`
+2. Create new GitHub release with tag name starting with `v` and the version, for example `v1.0.0`
+3. Gem will be automatically built and pushed to rubygems.org with GitHub Action
+
 ## Copyright and license
 
 Copyright 2013 Zendesk

data/lib/basecrm/services/deals_service.rb

@@ -2,7 +2,7 @@
 
 module BaseCRM
   class DealsService
-    OPTS_KEYS_TO_PERSIST = Set[:contact_id, :currency, :custom_fields, :hot, :loss_reason_id, :name, :owner_id, :source_id, :stage_id, :tags, :value, :last_stage_change_at, :estimated_close_date, :customized_win_likelihood]
+    OPTS_KEYS_TO_PERSIST = Set[:contact_id, :currency, :custom_fields, :hot, :loss_reason_id, :unqualified_reason_id, :name, :owner_id, :source_id, :stage_id, :tags, :value, :last_stage_change_at, :estimated_close_date, :customized_win_likelihood]
 
     def initialize(client)
       @client = client

data/lib/basecrm/version.rb

@@ -1,3 +1,3 @@
 module BaseCRM
-  VERSION = "1.3.8"
+  VERSION = "1.3.9"
 end

data/spec/factories/contact.rb

@@ -2,7 +2,7 @@ FactoryBot.define do
   factory :contact, class: BaseCRM::Contact do
 
     description { "I know him via Tom" }
-    email { "mark@designservices.com" }
+    email { "mark#{SecureRandom.hex}@example.com" }
     facebook { "mjohnson" }
     fax { "+44-208-1234567" }
     first_name { Faker::Name.first_name }
@@ -17,7 +17,7 @@ FactoryBot.define do
     tags { ["important"] }
     title { "CEO" }
     twitter { "mjohnson" }
-    website { "www.designservices.com" }
+    website { "www.example.com" }
 
 
     to_create do |contact|

data/spec/factories/deal_source.rb

@@ -1,7 +1,7 @@
 FactoryBot.define do
   factory :deal_source, class: BaseCRM::DealSource do
 
-    name { Faker::Name.name }
+    name { "source#{SecureRandom.hex}" }
 
 
     to_create do |deal_source|

data/spec/factories/deal_unqualified_reason.rb

@@ -1,7 +1,7 @@
 FactoryBot.define do
   factory :deal_unqualified_reason, class: BaseCRM::DealUnqualifiedReason do
 
-    name { Faker::Name.name }
+    name { "unqualified_reason#{SecureRandom.hex}" }
 
 
     to_create do |deal_unqualified_reason|

data/spec/factories/lead.rb

@@ -2,7 +2,7 @@ FactoryBot.define do
   factory :lead, class: BaseCRM::Lead do
 
     description { "I know him via Tom" }
-    email { "mark@designservices.com" }
+    email { "mark#{SecureRandom.hex}@example.com" }
     facebook { "mjohnson" }
     fax { "+44-208-1234567" }
     first_name { Faker::Name.first_name }
@@ -16,7 +16,7 @@ FactoryBot.define do
     tags { ["important"] }
     title { "CEO" }
     twitter { "mjohnson" }
-    website { "www.designservices.com" }
+    website { "www.example.com" }
 
 
     to_create do |lead|

data/spec/factories/lead_source.rb

@@ -1,7 +1,7 @@
 FactoryBot.define do
   factory :lead_source, class: BaseCRM::LeadSource do
 
-    name { Faker::Name.name }
+    name { "source#{SecureRandom.hex}" }
 
 
     to_create do |lead_source|

data/spec/factories/loss_reason.rb

@@ -1,7 +1,7 @@
 FactoryBot.define do
   factory :loss_reason, class: BaseCRM::LossReason do
 
-    name { Faker::Name.name }
+    name { "loss_reason#{Time.now.to_i}" }
 
 
     to_create do |loss_reason|

data/spec/factories/source.rb

@@ -1,7 +1,7 @@
 FactoryBot.define do
   factory :source, class: BaseCRM::Source do
 
-    name { Faker::Name.name }
+    name { "source#{SecureRandom.hex}" }
 
 
     to_create do |source|

data/spec/factories/tag.rb

@@ -1,7 +1,7 @@
 FactoryBot.define do
   factory :tag, class: BaseCRM::Tag do
 
-    name { Faker::Name.name }
+    name { "tag#{SecureRandom.hex}" }
 
     resource_type { :contact }
 

data/spec/spec_helper.rb

@@ -1,6 +1,7 @@
 require 'rspec/collection_matchers'
 require 'factory_bot'
 require 'faker'
+require 'securerandom'
 
 require 'basecrm'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: basecrm
 version: !ruby/object:Gem::Version
-  version: 1.3.8
+  version: 1.3.9
 platform: ruby
 authors:
 - Zendesk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-11 00:00:00.000000000 Z
+date: 2021-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -267,54 +267,54 @@ signing_key:
 specification_version: 4
 summary: Zendesk Sell Official API V2 library client for ruby
 test_files:
+- spec/factories/lead_source.rb
+- spec/factories/call.rb
+- spec/factories/note.rb
+- spec/factories/tag.rb
 - spec/factories/associated_contact.rb
+- spec/factories/task.rb
 - spec/factories/lead.rb
-- spec/factories/lead_source.rb
 - spec/factories/product.rb
-- spec/factories/line_item.rb
-- spec/factories/tag.rb
+- spec/factories/loss_reason.rb
 - spec/factories/source.rb
+- spec/factories/contact.rb
+- spec/factories/lead_unqualified_reason.rb
 - spec/factories/text_message.rb
 - spec/factories/order.rb
-- spec/factories/lead_unqualified_reason.rb
-- spec/factories/task.rb
 - spec/factories/deal.rb
-- spec/factories/note.rb
-- spec/factories/loss_reason.rb
-- spec/factories/deal_source.rb
 - spec/factories/deal_unqualified_reason.rb
-- spec/factories/contact.rb
-- spec/factories/call.rb
-- spec/services/call_outcomes_service_spec.rb
-- spec/services/contacts_service_spec.rb
-- spec/services/visit_outcomes_service_spec.rb
-- spec/services/lead_unqualified_reasons_service_spec.rb
-- spec/services/line_items_service_spec.rb
+- spec/factories/deal_source.rb
+- spec/factories/line_item.rb
+- spec/basecrm/sync_spec.rb
+- spec/support/client_helpers.rb
+- spec/utils/coercion_spec.rb
+- spec/utils/coercion.rb
+- spec/spec_helper.rb
+- spec/middlewares/raise_error_spec.rb
 - spec/services/deals_service_spec.rb
-- spec/services/associated_contacts_service_spec.rb
-- spec/services/leads_service_spec.rb
-- spec/services/orders_service_spec.rb
-- spec/services/notes_service_spec.rb
 - spec/services/sync_service_spec.rb
-- spec/services/stages_service_spec.rb
-- spec/services/deal_sources_service_spec.rb
-- spec/services/users_service_spec.rb
 - spec/services/loss_reasons_service_spec.rb
+- spec/services/stages_service_spec.rb
 - spec/services/products_service_spec.rb
-- spec/services/lead_sources_service_spec.rb
 - spec/services/tasks_service_spec.rb
-- spec/services/calls_service_spec.rb
-- spec/services/text_messages_service_spec.rb
+- spec/services/notes_service_spec.rb
+- spec/services/lead_unqualified_reasons_service_spec.rb
+- spec/services/deal_sources_service_spec.rb
+- spec/services/visit_outcomes_service_spec.rb
 - spec/services/pipelines_service_spec.rb
-- spec/services/accounts_service_spec.rb
+- spec/services/sources_service_spec.rb
+- spec/services/lead_sources_service_spec.rb
+- spec/services/tags_service_spec.rb
+- spec/services/contacts_service_spec.rb
+- spec/services/associated_contacts_service_spec.rb
 - spec/services/deal_unqualified_reasons_service_spec.rb
+- spec/services/orders_service_spec.rb
+- spec/services/calls_service_spec.rb
 - spec/services/visits_service_spec.rb
-- spec/services/tags_service_spec.rb
-- spec/services/sources_service_spec.rb
-- spec/spec_helper.rb
-- spec/middlewares/raise_error_spec.rb
+- spec/services/text_messages_service_spec.rb
+- spec/services/accounts_service_spec.rb
+- spec/services/line_items_service_spec.rb
+- spec/services/call_outcomes_service_spec.rb
+- spec/services/users_service_spec.rb
+- spec/services/leads_service_spec.rb
 - spec/models/sync_meta_spec.rb
-- spec/basecrm/sync_spec.rb
-- spec/support/client_helpers.rb
-- spec/utils/coercion_spec.rb
-- spec/utils/coercion.rb