basecrm 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5944afdba7dc0d91c937ab939bb6e1fb019e058f
-  data.tar.gz: a1939878b665013a2a9591beea66f448e0b17a78
+  metadata.gz: 6e2f77ee02273e60432ee07afc45df2546472675
+  data.tar.gz: 23887aee3f8184ec91663fdf95eb0ab67ede5487
 SHA512:
-  metadata.gz: 2d5710f54131a3461b6c7ae51fda0bf8e1f83bc8366e0406a2b901acb1853a6520b903b3c2cdfd24feea9c6362d520bbca213abb55cdc9c0f6a3b914e0d429b9
-  data.tar.gz: 1e537e6befde7c148eb1c570cd602bc1abcd067c2594b06c45a374e516cacb56b19eab9443438f3ec716a0f1832341b6db67d46b631d5120fdcefeb765f69594
+  metadata.gz: 2d2ab3ddf64bad4837691302b17768c268c3aeee11d143cb5801eec61bfcd0f9d9dc5660570af6a4256f5a03f97f18dd5374d5909a0f32f70ce7d13ae2bed869
+  data.tar.gz: bac89ab72524eb5d5cd81a0d92af9eafd0c911c882d77583a83e80f9f534a6b3305ea2cdb3fc3dfbc7a2ad1c4c8162641546ca7a3a2fc33924920a85c9b5d48f

data/.travis.yml

@@ -2,6 +2,5 @@ language: ruby
 rvm:
   - 1.9.3
   - 2.0.0
-  - rbx-18mode
-  - rbx-19mode
+  - 2.1.0
 script: "bundle exec rspec"

data/README.md

@@ -4,9 +4,6 @@
 
 New and shiny client for the Base CRM API
 
-NOTE: This is still a very early release. There might be a lot of
-breaking changes. You have been warned.
-
 ## Installation
 
 The gem available via Rubygems. To install it, use the following command:

data/lib/base_crm.rb

@@ -2,6 +2,7 @@ require "api_client"
 require "base_crm/version"
 require "base_crm/config"
 require "base_crm/api_client_ext"
+require "base_crm/custom_fieldable"
 
 module BaseCrm
 
@@ -18,7 +19,6 @@ module BaseCrm
   autoload :Task,               "base_crm/task"
   autoload :Taskable,           "base_crm/taskable"
   autoload :Lead,               "base_crm/lead"
-  autoload :CustomFieldable,    "base_crm/custom_fieldable"
 
 end
 

data/lib/base_crm/contact.rb

@@ -4,7 +4,7 @@ module BaseCrm
     include BaseCrm::Resource
     include BaseCrm::Noteable
     include BaseCrm::Taskable
-    include BaseCrm::CustomFieldable
+    include BaseCrm::CustomFieldable('custom_fields')
 
     namespace "contact"
 

data/lib/base_crm/custom_fieldable.rb

@@ -1,35 +1,32 @@
 module BaseCrm
-
-  module CustomFieldable
-
-    def initialize(attributes, original_scope = nil)
-      super
-      simplify_custom_fields
-    end
-
-    def simplify_custom_fields
-      fields = self['custom_fields'] || {}
-      self['custom_fields'] = fields.inject(Hashie::Mash.new) do |memo, field|
-        name, value = field
-        memo[name] = value['value']
-        memo
+  def self.CustomFieldable(custom_fields_field_name)
+    Module.new do
+      def initialize(attributes, original_scope = nil)
+        super
+        simplify_custom_fields
       end
-    end
 
-    private
+      define_method :simplify_custom_fields do
+        fields = self[custom_fields_field_name] || {}
+        self[custom_fields_field_name] = fields.inject(Hashie::Mash.new) do |memo, field|
+          name, value = field
+          memo[name] = value['value']
+          memo
+        end
+      end
 
-    # Because custom fields are hashes, and hashes result in
-    # new instances of BaseCrm::Contact, we end up with a stack level too deep
-    # because simplify_custom_fields gets fired all the time
-    def convert_value(val, duping=false) #:nodoc:
-      if val.is_a?(Hash) or val.is_a?(::Hash)
-        val
-      else
-        super
+      private
+
+      # Because custom fields are hashes, and hashes result in
+      # new instances of BaseCrm::Contact, we end up with a stack level too deep
+      # because simplify_custom_fields gets fired all the time
+      def convert_value(val, duping=false) #:nodoc:
+        if val.is_a?(Hash) or val.is_a?(::Hash)
+          val
+        else
+          super
+        end
       end
     end
-
   end
-
 end
-

data/lib/base_crm/lead.rb

@@ -4,7 +4,7 @@ module BaseCrm
     include BaseCrm::Resource
     include BaseCrm::Noteable
     include BaseCrm::Taskable
-    include BaseCrm::CustomFieldable
+    include BaseCrm::CustomFieldable('custom_field_values')
 
     namespace "lead"
 

data/lib/base_crm/version.rb

@@ -1,3 +1,3 @@
 module BaseCrm
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/base_crm/deal_spec.rb

@@ -65,10 +65,7 @@ describe BaseCrm::Deal do
     context "when it is not found" do
       before do
         subject.stub(:pass_headers).with(BaseCrm::Source).and_return(scope)
-        scope.
-          stub(:find).
-          with(source_id).
-          and_raise(ApiClient::Errors::NotFound)
+        scope.stub(:find).with(source_id)
       end
       it { subject.source.should == nil }
     end
@@ -109,10 +106,7 @@ describe BaseCrm::Deal do
     context "when it is not found" do
       before do
         subject.stub(:pass_headers).with(BaseCrm::Contact).and_return(scope)
-        scope.
-          stub(:find).
-          with(entity_id).
-          and_raise(ApiClient::Errors::NotFound)
+        scope.stub(:find).with(entity_id)
       end
       it { subject.contact.should == nil }
     end

data/spec/base_crm/lead_spec.rb

@@ -22,7 +22,7 @@ describe BaseCrm::Lead do
   describe "simplify_custom_fields" do
 
     it "converts a hash into the value" do
-      subject.custom_fields = {
+      subject.custom_field_values = {
         'test' => { 'value' => 'yes!' }
       }
       result = subject.simplify_custom_fields

data/spec/support/noteable_shared_examples.rb

@@ -21,9 +21,9 @@ shared_examples "noteable" do |noteable_type|
   end
 
   describe "#notes.create" do
-    let(:message) { mock }
-    let(:note) { mock }
-    let(:fetch_scope) { mock }
+    let(:message) { double }
+    let(:note) { double }
+    let(:fetch_scope) { double }
 
     it "passes the token and applies the params" do
       subject.
@@ -46,9 +46,9 @@ shared_examples "noteable" do |noteable_type|
   end
 
   describe "#create_note" do
-    let(:message) { mock }
-    let(:notes) { mock }
-    let(:note) { mock }
+    let(:message) { double }
+    let(:notes) { double }
+    let(:note) { double }
 
     it "creates a new note" do
       subject.should_receive(:notes).and_return(notes)

data/spec/support/taskable_shared_examples.rb

@@ -50,9 +50,9 @@ shared_examples "taskable" do |taskable_type|
     let(:params) do
       { :content => task_content }
     end
-    let(:task_content) { mock }
-    let(:tasks) { mock }
-    let(:task) { mock }
+    let(:task_content) { double }
+    let(:tasks) { double }
+    let(:task) { double }
 
     it "creates a new task" do
       subject.should_receive(:tasks).and_return(tasks)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: basecrm
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Marcin Bunsch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-14 00:00:00.000000000 Z
+date: 2014-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: api_client