base_editing_bootstrap 1.13.0 → 1.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 03c295a72d7902af261c7c01405cc45a7b81d243c846f60c1974f4e07e5e648e
-  data.tar.gz: 5281b24d0df35c81db386217c763e266bf29affa07ca33c34632527981f5be5b
+  metadata.gz: 74db6610e2c8ab5c7f25de60eb6fb1c7ba1fa83570cd552a3356674356f02518
+  data.tar.gz: 8aea6970cecd4fa8623711b21d9ec77e2b2657757dfa94c91e94028b687a074e
 SHA512:
-  metadata.gz: cdd4c188cef1aba14fadc79888e24fbdf3dafdbcc204ec933a1558ef5fbbed0255f36924c4e327c244e8176e777452077404a3c0c23b3ebeb1c869af62bf9ae3
-  data.tar.gz: 74c856a196196dd319d42446c474d5ba5449cefb2d01a7333d3e20bc2b4bcbb1273777b01363381e52a0fc8abbdd9bc9249a8cd5da4cd8dc60d2e470408994f3
+  metadata.gz: 5713323d93896548db8ee7fd75b187e5b7b6b61efb76c3855a92c79139eaa993af1a480a6cc1fe85c84a95e9b8af1f2c0dabe615ce14815728450bbd4390b10e
+  data.tar.gz: 1a6068cc2a7b296c4f8d0a3a20097efd9dddb1752bb6e5e4844053ec8f6997eac49183af26d6873949c44d4bce05235ebfb655f171d7c0d2e203a48bef8988ae

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 All notable changes to this project will be documented in this file. See [conventional commits](https://www.conventionalcommits.org/) for commit guidelines.
 
 - - -
+## 1.14.0 - 2026-03-19
+#### Features
+- Nested elements with limit from rails config (#24) - (f003ce4) - Marino Bonetti
+#### Bug Fixes
+- Correct nested_form when elements are marked for destruction - (9fd6544) - Marino Bonetti
+
+- - -
+
 ## 1.13.0 - 2026-02-03
 #### Features
 - Form submit button inheritance value - (00b04b1) - Marino Bonetti

data/README.md

@@ -35,16 +35,34 @@ $ bundle exec rails g base_editing_bootstrap:install
 
 **Si presume quindi che ActiveStorage sia correttamente installato, completo del javascript per il direct upload**
 
+### Upgrade Notes
+- From <= 1.13:
+  In `app/javascript/controllers/application.js` replace:
+  ```js
+  import RailsNestedForm from '@stimulus-components/rails-nested-form'
+  application.register('nested-form', RailsNestedForm)
+  ```
+  with:
+  ```js
+  import NestedForm from 'nested_form_controller';
+  application.register('nested-form', NestedForm);
+  ```
+  in `config/importmap.rb` remove: 
+  ```ruby
+  pin "@stimulus-components/rails-nested-form"
+  ```
+  and finaly remove in vendor/javascript the `@stimulus-components/rails-nested-form` downloaded dependencies
+
 ### Note for NestedAttributes
 
-Seguire le istruzioni per installare anche NestedAttributeForm Controller per stimulus:
+Il controller nested attributes viene importato da importmaps dell'engine.
+E' necessagio registrare il nuovo controller in app/javascript/application.js
 
-```shell
-bin/importmap pin @stimulus-components/rails-nested-form
+```js
+import NestedForm from 'nested_form_controller'; // Mappato con import maps locale
+application.register('nested-form', NestedForm); // Utilizzato nell'interfaccia della form.
 ```
 
-e seguire installazione https://www.stimulus-components.com/docs/stimulus-rails-nested-form
-
 ### Generators
 
 Then Install dependency (if you run base_editing_bootstrap:install you are good to go):

data/app/assets/config/base_editing_bootstrap_manifest.js

@@ -0,0 +1 @@
+//= link nested_form_controller.js

data/app/assets/javascripts/nested_form_controller.js

@@ -0,0 +1,48 @@
+import NestedForm from "@stimulus-components/rails-nested-form"
+
+// Connects to data-controller="nested-form"
+export default class extends NestedForm {
+
+  static values = {
+    limit: Number,
+  }
+
+  add(e) {
+    super.add(e);
+    this.check_for_enabling_add_button(e);
+  }
+
+  remove(e) {
+    super.remove(e);
+    this.check_for_enabling_add_button(e);
+  }
+
+  // Elenco elementi presenti visibili (e quindi non settati per essere cancellati)
+  total_active_elements() {
+    let count = 0;
+
+    this.targetTarget.parentElement.querySelectorAll(this.wrapperSelectorValue).forEach((ele) => {
+      if (ele.checkVisibility()) {
+        count += 1;
+      }
+    })
+    return count;
+  }
+
+  check_for_enabling_add_button(e) {
+    if (this.hasLimitValue) {
+      if (this.total_active_elements() >= this.limitValue) {
+        // Aggiungiamo classe disable sull'elemento che ha lanciato questo evento
+        this.add_button().disabled = "disabled";
+      } else {
+        this.add_button().removeAttribute("disabled");
+      }
+    }
+  }
+
+  add_button() {
+    return this.element.querySelector('[data-action="nested-form#add"]')
+  }
+
+
+}

data/app/views/base_editing/_nested_row_form.html.erb

@@ -1,4 +1,4 @@
-<tr class="nested-form-wrapper" data-new-record="<%= form.object.new_record? %>" id="<%= dom_id(form.object) %>">
+<tr class="nested-form-wrapper <%= (form.object.marked_for_destruction? ? "d-none" : "") %>" data-new-record="<%= form.object.new_record? %>" id="<%= dom_id(form.object) %>">
 
   <% policy(form.object).editable_attributes.each do |field| %>
     <td>

data/app/views/base_editing/form_field/_accept_has_many_nested_field.html.erb

@@ -1,5 +1,25 @@
 <%# locals: (form:, field:,new_object:) -%>
-<%= content_tag :table, class: "table", data: {controller: 'nested-form'} do %>
+<%
+
+  ##
+  # Costruisco le opzioni per limitare tramite interfaccia (ricevuta da configurazione di Rails nested_attributes_for)
+  # il numero di nested elements
+  controller_data = {controller: 'nested-form'}
+  if (limit = form.object.class.nested_attributes_options[field].dig(:limit))
+    controller_data["nested-form-limit-value"] = \
+      case limit
+      when Symbol #TODO add tests
+        form.object.class.send(limit)
+      when Proc #TODO add tests
+        limit.call
+      else
+        limit
+      end
+  end
+
+%>
+
+<%= content_tag :table, class: "table", data: controller_data do %>
 
   <thead>
   <tr>

data/config/importmap.rb

@@ -0,0 +1,2 @@
+pin "@stimulus-components/rails-nested-form", to: "https://ga.jspm.io/npm:@stimulus-components/rails-nested-form@5.0.0/dist/stimulus-rails-nested-form.mjs" # @5.0.0
+pin_all_from File.expand_path("../app/assets/javascripts", __dir__)

data/lib/base_editing_bootstrap/VERSION

@@ -1 +1 @@
-1.13.0
+1.14.0

data/lib/base_editing_bootstrap/engine.rb

@@ -5,5 +5,13 @@ module BaseEditingBootstrap
       app.deprecators[:base_editing_bootstrap] = BaseEditingBootstrap.deprecator
     end
 
+    initializer "base_editing_bootstrap.importmap", before: "importmap" do |app|
+      app.config.importmap.paths << Engine.root.join("config/importmap.rb")
+    end
+
+    initializer "base_editing_bootstrap.assets.precompile" do |app|
+      app.config.assets.precompile << "nested_form_controller.js"
+    end
+
   end
 end

data/lib/generators/base_editing_bootstrap/install/install_generator.rb

@@ -35,9 +35,9 @@ module BaseEditingBootstrap
         # attualmente penso sia più sensato semplicemente scrivere a video i passaggi necessari, dato che
         # potrebbe essere già presente importmap, nested_attribute_controller e le varie configurazioni
 
-        say "Install dependencies for nested attributes:"
-        say "   bin/importmap pin @stimulus-components/rails-nested-form"
-        say "Attiva quindi come spiegato qua: https://www.stimulus-components.com/docs/stimulus-rails-nested-form il controller"
+        say "Install nested attributes controller, add to application.js:"
+        say " import NestedForm from 'nested_form_controller' \n
+              application.register('nested-form', NestedForm)"
 
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: base_editing_bootstrap
 version: !ruby/object:Gem::Version
-  version: 1.13.0
+  version: 1.14.0
 platform: ruby
 authors:
 - Marino Bonetti
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-02-03 00:00:00.000000000 Z
+date: 2026-03-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -320,6 +320,7 @@ files:
 - README.md
 - Rakefile
 - app/assets/config/base_editing_bootstrap_manifest.js
+- app/assets/javascripts/nested_form_controller.js
 - app/controllers/.keep
 - app/controllers/base_editing_controller.rb
 - app/controllers/restricted_area_controller.rb
@@ -389,6 +390,7 @@ files:
 - app/views/kaminari/_paginator.html.erb
 - app/views/kaminari/_prev_page.html.erb
 - base_editing_bootstrap.gemspec
+- config/importmap.rb
 - config/initializers/base_field_error_proc.rb
 - config/locales/it.yml
 - config/routes.rb