barsoom_utils 0.2.0.77 → 0.2.0.78

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a689d68093a31c8481296dfbf97d19a683637dca75178cb142164b4ce11260a5
-  data.tar.gz: 8477a0ab5a7700c7bf0897c7a239ec8b48d155f934b81ffaef0c93d75c42faf9
+  metadata.gz: f10ec24dca48ed3703590008317664ee7993d1efbfd0b3d4c5cc1d876c5712ca
+  data.tar.gz: c9d43fdc45e23e2a267c390007cc5c685273d5da581f8a413fb2da106ec25d08
 SHA512:
-  metadata.gz: bb2a240db5388ccb1634a17fd3820aa3f6dbc161ec953be78ed03ceb111e1832b0d5350adec45bd81eb1ea6133d32507243811ab106e306c1342a6d3bdfea766
-  data.tar.gz: 7f45fde4df510c8f92895eda05b97300dc6e3f272bb4f9220f50cb516b9748a2d1c89277f60bc1e2d24789354423bc8360d7e6992508f2831fa364943e7feb30
+  metadata.gz: bfb7e4a46b94501ce9d505c0b19b674006f75c48cd3b16f18c7573c6d006ab41f9b3196529a5fa6a383d7c2454a41ac12dcfacd3da05db9e40b19f217715ae32
+  data.tar.gz: f9e748ad9dfb716d217df3420fafb7ac93c859d07b240e24dcd9c668b9ff741f9d6631a6f467abea7ca24a71867e39ed8b37885a4ea53ab15e0ee83f3593b277

data/VERSION

@@ -1 +1 @@
-0.2.0.77
+0.2.0.78

data/lib/barsoom_utils/exception_notifier.rb

@@ -11,12 +11,16 @@ module BarsoomUtils
         raise "Expected an exception but got: #{exception.inspect}"
       end
 
-      result = Honeybadger.notify(exception, context: context)
+      ensure_notifier!
+
+      result = Honeybadger.notify(exception, context: context) if defined?(Honeybadger)
       Sentry.capture_exception(exception, extra: context) if defined?(Sentry)
       result
     end
 
     def self.message(message, details_or_context = nil, context_or_nothing = nil)
+      ensure_notifier!
+
       if context_or_nothing
         details = details_or_context
         context = context_or_nothing
@@ -28,11 +32,13 @@ module BarsoomUtils
         context = {}
       end
 
-      result = Honeybadger.notify(
-        error_class: message,
-        error_message: (details || "(no message)").to_s,
-        context: context.to_h,
-      )
+      if defined?(Honeybadger)
+        result = Honeybadger.notify(
+          error_class: message,
+          error_message: (details || "(no message)").to_s,
+          context: context.to_h,
+        )
+      end
 
       if defined?(Sentry)
         title = details ? "#{message}: #{details}" : message.to_s
@@ -41,5 +47,14 @@ module BarsoomUtils
 
       result
     end
+
+    private
+
+    private_class_method \
+    def self.ensure_notifier!
+      return if defined?(Honeybadger) || defined?(Sentry)
+
+      raise "Cannot notify: neither Honeybadger nor Sentry is available."
+    end
   end
 end

data/spec/exception_notifier_spec.rb

@@ -52,6 +52,29 @@ RSpec.describe BarsoomUtils::ExceptionNotifier do
         expect(Honeybadger).to have_received(:notify).with(ex, context: { foo: "bar" })
       end
     end
+
+    context "without Honeybadger" do
+      before { hide_const("Honeybadger") }
+
+      it "still notifies Sentry and raises nothing" do
+        BarsoomUtils::ExceptionNotifier.notify(ex, context: { foo: "bar" })
+
+        expect(Sentry).to have_received(:capture_exception).with(ex, extra: { foo: "bar" })
+      end
+    end
+
+    context "without either notifier" do
+      before do
+        hide_const("Honeybadger")
+        hide_const("Sentry")
+      end
+
+      it "raises" do
+        expect {
+          BarsoomUtils::ExceptionNotifier.notify(ex)
+        }.to raise_error(/neither Honeybadger nor Sentry/)
+      end
+    end
   end
 
   describe ".message" do
@@ -124,5 +147,28 @@ RSpec.describe BarsoomUtils::ExceptionNotifier do
         )
       end
     end
+
+    context "without Honeybadger" do
+      before { hide_const("Honeybadger") }
+
+      it "still notifies Sentry and raises nothing" do
+        BarsoomUtils::ExceptionNotifier.message("Boom!", "Details!", foo: "bar")
+
+        expect(Sentry).to have_received(:capture_message).with("Boom!: Details!", extra: { foo: "bar" })
+      end
+    end
+
+    context "without either notifier" do
+      before do
+        hide_const("Honeybadger")
+        hide_const("Sentry")
+      end
+
+      it "raises" do
+        expect {
+          BarsoomUtils::ExceptionNotifier.message("Boom!")
+        }.to raise_error(/neither Honeybadger nor Sentry/)
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: barsoom_utils
 version: !ruby/object:Gem::Version
-  version: 0.2.0.77
+  version: 0.2.0.78
 platform: ruby
 authors:
 - Tomas Skogberg