barrage 0.0.4 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c5e6522f3f124106fc417a39339d72c0f4638c63
-  data.tar.gz: fca0bf19d7db713e35d6ed7f3d068176d2d48ab9
+  metadata.gz: 247efe0edfb9aae9c762b6698e5c90816c95f781
+  data.tar.gz: 117e43352f37892a675334b48e2b398a90fe167b
 SHA512:
-  metadata.gz: 078eeb02f1f9cefc13b4fa66f37df1363702b76b1c51896638da71a2fd7129720a6b1722837a26e28b2eaef5be03757a639b91b734acbf28f0df2614d414703c
-  data.tar.gz: 54e4ced79f10c2a3cba742006e055d2005caa46e6fe6b85e683e216ea6d71f436cb7424260166546fc9dbb4ed8bb00713a2fbc77a3c2abda0a1b3642a0b11968
+  metadata.gz: ef97bd700202ccdd92acb5a1c498d8ca1245fd6ac8a077acd8ce3f2f9e536de3f04989e77717128a956c30f5714f6c2947e3a3f115a19ec937a428d448ba16af
+  data.tar.gz: 27265f705dfb1d087a441c86747f70496a505346751a7bbf24c14ff9e9357ec8a91a680a901ff446f3fff52716332f09760c9407c423906bfbf0202eb29aecf3

data/.travis.yml

@@ -1,3 +1,7 @@
 language: ruby
 rvm:
-  - 2.1.1
+  - 2.0.0
+  - 2.1.2
+services:
+  - redis-server
+script: bundle exec rake spec

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELOG
 
+## 0.1.0
+
+  * Fix RedisWorkerId's worker_id handling
+  * Release old worker_id only if it is before ttl
+  * Add required_options to generators
+
 ## 0.0.4
 
   * [redis_worker_id generator] Release current worker_id before reaching real ttl

data/Guardfile

@@ -0,0 +1,11 @@
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+guard :rspec,
+  cmd: "bundle exec rspec",
+  all_after_pass: true,
+  all_on_start: true do
+    watch(%r{^spec/.+_spec\.rb$})
+    watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
+    watch('spec/spec_helper.rb')  { "spec" }
+end

data/README.md

@@ -1,5 +1,8 @@
 # Barrage
 
+[![Gem Version](https://badge.fury.io/rb/barrage.svg)](http://badge.fury.io/rb/barrage)
+[![Coverage Status](https://img.shields.io/coveralls/drecom/barrage.svg)](https://coveralls.io/r/drecom/barrage)
+
 Distributed ID generator(like twitter/snowflake)
 
 ## Installation
@@ -34,7 +37,7 @@ barrage = Barrage.new(
   ]
 )
 barrage.next
-# => Generated ID
+# => Generated 64bit ID
 ```
 
 ### Generators
@@ -48,13 +51,14 @@ barrage.next
 ```ruby
 module Barrage::Generators
   class YourOwnGenerator < Base
+    self.required_options += %w(your_option_value)
     def generate
-	  # generated code
-	end
+      # generated code
+    end
 
     def your_option_value
-	  options["your_option_value"]
-	end
+      options["your_option_value"]
+    end
   end
 end
 

data/barrage.gemspec

@@ -22,8 +22,12 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.6"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "3.0.0.beta2"
+  spec.add_development_dependency "rspec", "~> 3.0.0"
+  spec.add_development_dependency "rspec-its"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "guard-rspec"
   spec.add_development_dependency "redis"
+  spec.add_development_dependency "fakeredis"
+  spec.add_development_dependency "delorean"
+  spec.add_development_dependency "coveralls"
 end

data/lib/barrage.rb

@@ -50,3 +50,5 @@ class Barrage
     @generators.inject(0) {|sum, g| sum += g.length }
   end
 end
+
+require "barrage/generators"

data/lib/barrage/generators/base.rb

@@ -1,9 +1,18 @@
+require 'barrage/generators'
+require 'active_support/core_ext/class/attribute'
+
 class Barrage
   module Generators
     class Base
       attr_reader :options
+      class_attribute :required_options, :available_options
+      self.required_options = %w(length)
+      self.available_options = []
 
       def initialize(options = {})
+        if (missing = missing_required_options(options)) && !missing.empty?
+          raise ArgumentError, "Missing Required options: #{missing.join(', ')}"
+        end
         @options = options
       end
 
@@ -18,6 +27,12 @@ class Barrage
       def current
         raise NotImplemented, "Please Override"
       end
+
+      private
+
+      def missing_required_options(given_options)
+        required_options.reject { |k| given_options.has_key?(k) }
+      end
     end
   end
 end

data/lib/barrage/generators/msec.rb

@@ -3,6 +3,8 @@ require 'barrage/generators/base'
 class Barrage
   module Generators
     class Msec < Base
+      self.required_options += %w(start_at)
+
       def generate
         ((Time.now.to_f * 1000).round - start_at) & (2 ** length - 1)
       end

data/lib/barrage/generators/redis_worker_id.rb

@@ -5,6 +5,7 @@ class Barrage
   module Generators
     class RedisWorkerId < Base
       RACE_CONDITION_TTL = 30
+      self.required_options += %w(ttl)
 
       def initialize(options = {})
         @worker_id = nil
@@ -20,22 +21,23 @@ class Barrage
         now = Time.now.to_i
         if @worker_ttl - now <= 0
           @data[1] = @worker_id = renew_worker_id
-          # check redis when passed half of real ttl
+          # check redis after half of real ttl
           @worker_ttl = now + ttl / 2
           @real_ttl   = now + ttl
+          @data[2] = @real_ttl
         end
         @worker_id
       end
       alias_method :current, :generate
 
-      def redis
-        @redis ||= @data[0] = Redis.new(options["redis"] || {})
-      end
-
       def ttl
         options["ttl"]
       end
 
+      def redis
+        @redis ||= @data[0] = Redis.new(options["redis"] || {})
+      end
+
       class Finalizer
         def initialize(data)
           @pid = $$
@@ -44,10 +46,10 @@ class Barrage
 
         def call(*args)
           return if @pid != $$
-          redis, worker_id = *@data
+          redis, worker_id, real_ttl = *@data
 
           if redis.is_a?(Redis) and redis.connected?
-            redis.del("barrage:worker:#{worker_id}")
+            redis.del("barrage:worker:#{worker_id}") if real_ttl > Time.now.to_i
             redis.client.disconnect
           end
         end
@@ -62,30 +64,41 @@ class Barrage
         new_worker_id = redis.evalsha(
           script_sha,
           argv: [2 ** length, rand(2 ** length), @worker_id, ttl, RACE_CONDITION_TTL]
-        ).to_i
-        new_worker_id
+        )
+        new_worker_id or raise StandardError, "Renew redis worker id failed"
+        return new_worker_id.to_i
       end
 
       def script_sha
         @script_sha ||=
           redis.script(:load, <<-EOF.gsub(/^ {12}/, ''))
-            local max_value = ARGV[1]
+            local max_value = tonumber(ARGV[1])
             local new_worker_id = ARGV[2]
             local old_worker_id = ARGV[3]
-            local ttl = ARGV[4]
-            local race_condition_ttl = ARGV[5]
+            local ttl = tonumber(ARGV[4])
+            local race_condition_ttl = tonumber(ARGV[5])
+            local loop_cnt = 0
+
+            local worker_id = nil
+            local candidate_worker_id = tonumber(new_worker_id)
 
             if type(old_worker_id) == "string" and string.len(old_worker_id) > 0 and redis.call('EXISTS', "barrage:worker:" .. old_worker_id) == 1 then
               redis.call("EXPIRE", "barrage:worker:" .. old_worker_id, ttl + race_condition_ttl)
-              new_worker_id = old_worker_id
+              worker_id = old_worker_id
             else
-              while redis.call("SETNX", "barrage:worker:" .. new_worker_id, 1) == 0
+              while redis.call("SETNX", "barrage:worker:" .. candidate_worker_id, 1) == 0 and loop_cnt < max_value
               do
-                new_worker_id = (new_worker_id + 1) % max_value
+                candidate_worker_id = (candidate_worker_id + 1) % max_value
+                loop_cnt = loop_cnt + 1
+              end
+              if loop_cnt >= max_value then
+                return nil
+              else
+                worker_id = candidate_worker_id
               end
-              redis.call("EXPIRE", "barrage:worker:" .. new_worker_id, ttl + race_condition_ttl)
+              redis.call("EXPIRE", "barrage:worker:" .. worker_id, ttl + race_condition_ttl)
             end
-            return new_worker_id
+            return worker_id
           EOF
       end
     end

data/lib/barrage/version.rb

@@ -1,3 +1,3 @@
 class Barrage
-  VERSION = "0.0.4"
+  VERSION = "0.1.0"
 end

data/spec/barrage/generators/msec_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+require 'barrage/generators/msec'
+
+describe Barrage::Generators::Msec do
+  context "When initialized" do
+    subject { described_class.new(options) }
+
+    context "with empty hash" do
+      let(:options) { {} }
+
+      it { expect { subject }.to raise_error(ArgumentError) }
+    end
+
+    context "with required options" do
+      let(:options) { {"length" => 16, "start_at" => (Time.now.to_f * 1000).round } }
+
+      it { is_expected.to be_instance_of(Barrage::Generators::Msec) }
+      its(:length) { is_expected.to eq(options["length"]) }
+      its(:start_at) { is_expected.to eq(options["start_at"]) }
+    end
+  end
+
+  describe "#generate" do
+    subject { described_class.new(options).generate }
+    let(:length) { 39 }
+    let(:start_at) { (Time.parse("2014-01-01 00:00:00").to_f*1000).round }
+    let(:options) { {"length" => length, "start_at" => start_at} }
+
+    it { is_expected.to be_instance_of(Fixnum) }
+    it { is_expected.to be < 2 ** length }
+
+    context "generate two numbers between 10 millisecond " do
+      subject { described_class.new(options) }
+
+      it "numbers difference that generated in interval 10 millisecond should exactly 10" do
+        t = Time.parse("2014-01-01 00:00:00")
+        first = time_travel_to(t) { subject.generate }
+        second = time_travel_to(Time.at(t.to_i, 10000)) { subject.generate }
+        expect(second - first).to eq(10)
+      end
+    end
+  end
+end

data/spec/barrage/generators/redis_worker_id_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+require 'barrage/generators/redis_worker_id'
+
+describe Barrage::Generators::RedisWorkerId do
+  context "When initialized" do
+    subject { described_class.new(options) }
+
+    context "with empty hash" do
+      let(:options) { {} }
+
+      it { expect { subject }.to raise_error(ArgumentError) }
+    end
+
+    context "with required options" do
+      let(:options) { {"length" => 16, "ttl" => 300} }
+
+      it { is_expected.to be_instance_of(Barrage::Generators::RedisWorkerId) }
+      its(:length) { is_expected.to eq(options["length"]) }
+      its(:ttl) { is_expected.to eq(options["ttl"]) }
+    end
+  end
+
+  describe "#generate" do
+    subject { described_class.new(options).generate }
+    let(:length) { 8 }
+    let(:ttl) { 300 }
+    let(:options) { {"length" => length, "ttl" => ttl} }
+
+    it { is_expected.to be_instance_of(Fixnum) }
+    it { is_expected.to be < 2 ** length }
+
+    context "on many instances" do
+      subject { 64.times.map { described_class.new(options) } }
+      let(:length) { 8 }
+
+      it "should generate unique numbers" do
+        numbers = subject.map(&:generate)
+        expect(numbers.size).to eq(numbers.uniq.size)
+      end
+
+      it "generates numbers should less than length" do
+        expect(subject.all? { |s| s.generate < (2 ** length) }).to be true
+      end
+    end
+  end
+end

data/spec/barrage/generators/sequence_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper'
+require 'barrage/generators/sequence'
+
+describe Barrage::Generators::Sequence do
+  context "When initialized" do
+    subject { described_class.new(options) }
+
+    context "with empty hash" do
+      let(:options) { {} }
+
+      it { expect { subject }.to raise_error(ArgumentError) }
+    end
+
+    context "with required options" do
+      let(:options) { {"length" => 16 } }
+
+      it { is_expected.to be_instance_of(Barrage::Generators::Sequence) }
+      its(:length) { is_expected.to eq(options["length"]) }
+    end
+  end
+
+  describe "#generate" do
+    subject { described_class.new(options).generate }
+    let(:length) { 9 }
+    let(:options) { {"length" => length } }
+
+    it { is_expected.to be_instance_of(Fixnum) }
+    it { is_expected.to be < 2 ** length }
+
+    context "When sequence is 0" do
+      before do
+        subject.instance_variable_set(:@sequence, 0)
+      end
+      subject { described_class.new(options) }
+
+      it "should generates '1'" do
+        expect(subject.generate).to eq(1)
+      end
+
+      it "if generate twice in a row, generated numbers should be in succession" do
+        first = subject.generate
+        second = subject.generate
+        expect(first.succ).to eq(second)
+      end
+    end
+
+    context "When sequence is max" do
+      before do
+        subject.instance_variable_set(:@sequence, (2 ** length) - 1)
+      end
+      subject { described_class.new(options) }
+
+      it "should generates zero" do
+        expect(subject.generate).to be_zero
+      end
+    end
+  end
+end

data/spec/barrage_spec.rb

@@ -4,4 +4,45 @@ describe Barrage do
   it 'has a version number' do
     expect(Barrage::VERSION).not_to be nil
   end
+
+  context "when initialized" do
+    subject { Barrage.new(options) }
+
+    context "with empty generators" do
+      let(:options) { {"generators" => []} }
+      its(:generators) { is_expected.to be_empty }
+    end
+
+    context "with generators" do
+      let(:options) {
+        {
+          "generators" => [
+            {"name" => "msec", "length" => 39, "start_at" => 1396278000000},
+            {"name" => "redis_worker_id", "length" => 16, "ttl" => 300},
+            {"name" => "sequence", "length" => 9}
+          ]
+        }
+      }
+      it { expect(subject.generators.size).to eq(options["generators"].size) }
+      its(:generators) {
+        is_expected.to contain_exactly(
+          be_kind_of(Barrage::Generators::Msec),
+          be_kind_of(Barrage::Generators::RedisWorkerId),
+          be_kind_of(Barrage::Generators::Sequence)
+        )
+      }
+
+      describe "#generate" do
+        let(:barrage) { described_class.new(options) }
+        subject { barrage.generate }
+        it { is_expected.to be_kind_of(Integer) }
+        it { is_expected.to be < 2 ** barrage.length }
+      end
+
+      describe "#length" do
+        subject { described_class.new(options).length }
+        it { is_expected.to eq(options["generators"].map { |h| h["length"]}.inject(:+)) }
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,7 +1,15 @@
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+require 'bundler/setup'
+require 'rspec/its'
+require 'delorean'
+
+require 'coveralls'
+Coveralls.wear!
+
 require 'barrage'
 
 RSpec.configure do |config|
+  include Delorean
   config.filter_run focus: true
-  config.run_all_when_everything_filtered
+  config.run_all_when_everything_filtered = true
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: barrage
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.1.0
 platform: ruby
 authors:
 - gussan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-24 00:00:00.000000000 Z
+date: 2014-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -56,16 +56,30 @@ dependencies:
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0.beta2
+        version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0.beta2
+        version: 3.0.0
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -108,6 +122,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: fakeredis
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: delorean
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Distributed id generator
 email:
 - egussan@gmail.com
@@ -120,6 +176,7 @@ files:
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
+- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -133,6 +190,9 @@ files:
 - lib/barrage/generators/sequence.rb
 - lib/barrage/generators/timestamp.rb
 - lib/barrage/version.rb
+- spec/barrage/generators/msec_spec.rb
+- spec/barrage/generators/redis_worker_id_spec.rb
+- spec/barrage/generators/sequence_spec.rb
 - spec/barrage_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/drecom/barrage
@@ -160,5 +220,8 @@ signing_key:
 specification_version: 4
 summary: Distributed id generator
 test_files:
+- spec/barrage/generators/msec_spec.rb
+- spec/barrage/generators/redis_worker_id_spec.rb
+- spec/barrage/generators/sequence_spec.rb
 - spec/barrage_spec.rb
 - spec/spec_helper.rb