barnie 0.1.3 → 0.2.0

data/barnie.gemspec

@@ -1,33 +1,30 @@
 # -*- encoding: utf-8 -*-
-$:.push File.expand_path("../lib", __FILE__)
-require "barnie/version"
+$:.push File.expand_path('../lib', __FILE__)
+require 'barnie/version'
 
 Gem::Specification.new do |s|
-  s.name        = "barnie"
+  s.name        = 'barnie'
   s.version     = Barnie::VERSION
   s.platform    = Gem::Platform::RUBY
-  s.email       = ["code@papercavalier.com"]
-  s.homepage    = "http://gloss.papercavalier.com/barnie"
-  s.authors     = ["Paper Cavalier"]
+  s.email       = 'code@papercavalier.com'
+  s.homepage    = 'http://gloss.papercavalier.com/barnie'
+  s.authors     = ['Paper Cavalier']
   s.description = %q{A fake API to a well-known bookstore}
   s.summary     = %q{A fake API to a well-known bookstore}
 
-  s.rubyforge_project = "barnie"
+  s.rubyforge_project = 'barnie'
 
-  s.add_dependency("mechanize", "~> 1.0.0")
+  s.add_dependency('kosher', '~> 0.2.10')
+  s.add_dependency('mechanize', '~> 1.0.0')
+  s.add_development_dependency('launchy', '~> 0.3.7')
+  s.add_development_dependency('rspec', '~> 2.5.0')
+  s.add_development_dependency('ruby-debug19', '~> 0.11.0')
+  s.add_development_dependency('vcr', '~> 1.7.0')
+  s.add_development_dependency('webmock', '~> 1.6.2')
 
-  s.add_development_dependency("bookland", "0.3.1")
-  s.add_development_dependency("launchy", "~> 0.3.7")
-  s.add_development_dependency("rspec", "~> 2.1.0")
-  s.add_development_dependency("throttler", "~> 0.2.1")
-  s.add_development_dependency("vcr", "~> 1.3.1")
-  s.add_development_dependency("webmock", "~> 1.6.1")
-  if RUBY_VERSION.include?("1.9")
-    s.add_development_dependency("ruby-debug19", "~> 0.11.0")
-  end
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-  s.require_paths = ["lib"]
+  s.require_paths = ['lib']
 end

data/lib/barnie/helpers.rb

@@ -1,8 +1,8 @@
 module Barnie
   module Helpers
     def sanitize_string(string)
-      string.gsub!(/^"|"$/, "")
-      string.gsub!(/\\r|\\n/, "")
+      string.gsub!(/^"|"$/, '')
+      string.gsub!(/\\r|\\n/, '')
       string.strip
     end
 
@@ -10,13 +10,14 @@ module Barnie
       if string !~ /\S/
         0
       else
-        string.gsub!(/\D/, "").to_i
+        string.gsub!(/\D/, '').to_i
       end
     end
 
     def title(html)
-      title = html.search(".title a")
-      title = html.search(".ebooktitle a") unless title.any?
+      title = html.search('.title a')
+      title = html.search('.ebooktitle a') unless title.any?
+
       title
     end
 
@@ -25,27 +26,27 @@ module Barnie
     end
 
     def extract_isbn(string)
-      string.scan(/e\/\d{11,13}\//).first.gsub(/\D/, "").rjust(13,"0") unless string !~ /\S/
+      string.scan(/e\/\d{11,13}\//).first.gsub(/\D/, '').rjust(13, '0') unless string !~ /\S/
     end
 
     def extract_ships_in(string)
       return nil if string !~ /\S/
       string = sanitize_string(string)
 
-      if string.include?("hours")
+      if string.include?('hours')
         string.scan(/\d{2}/).last.to_i
-      elsif string.include?("days")
+      elsif string.include?('days')
         string.scan(/\d{1}/).last.to_i * 24
       end
     end
 
     def extract_link(title)
-      title.first.attributes["href"].value
+      title.first.attributes['href'].value
     end
 
     def extract_authors(html)
-      authors = html.search(".contrib a")
-      authors = html.search(".ebookcontrib a") unless authors.any?
+      authors = html.search('.contrib a')
+      authors = html.search('.ebookcontrib a') unless authors.any?
       authors.map { |author| sanitize_string(author.text) }
     end
 

data/lib/barnie/request.rb

@@ -0,0 +1,34 @@
+require 'mechanize'
+require 'uri'
+
+module Barnie
+  class Request
+    attr_reader :agent
+
+    def initialize(user_agent)
+      @agent = Mechanize.new { |a| a.user_agent = "iPhone #{user_agent}" }
+    end
+
+    def <<(isbns)
+      @isbns = isbns
+    end
+
+    def get
+      page = @agent.get(uri)
+      Response.new(page)
+    end
+
+    private
+
+    def query
+      "ISBNLIST=#{@isbns[0, 50].join(',')}"
+    end
+
+    def uri
+      URI::HTTP.build(
+        :host   => 'productsearch.barnesandnoble.com',
+        :path   => '/search/results.aspx',
+        :query  => query)
+    end
+  end
+end

data/lib/barnie/response.rb

@@ -0,0 +1,43 @@
+require 'kosher'
+require 'barnie/helpers'
+
+module Barnie
+  class Response
+    include Helpers
+
+    attr_accessor :page
+
+    def initialize(page)
+      self.page = page
+    end
+
+    def snapshots
+      raise Error.new('Blank page') if page.body == '' && page.code == 200
+
+      container = page.search('#prod-container')
+      container.map do |html|
+
+        price = extract_price(html.search('.price strong').text)
+        hours = extract_ships_in(html.search('.availability').text) || 999
+        title = title(html)
+        link  = extract_link(title)
+        isbn  = extract_isbn(link)
+
+        Kosher::Snapshot.new(
+          'bn.com',
+          isbn,
+          nil,
+          nil,
+          price > 0 ? 1 : 0,
+          price > 0 ?
+            [Kosher::Offer.new(
+              nil,
+              Kosher::Item.new(price, 'USD', 1, Kosher::Condition.new(1), Kosher::Description.new('')),
+              Kosher::Seller.new(nil, 'Barnes & Noble.com', nil, Kosher::Location.new('US')),
+              Kosher::Shipping.new(0, 'USD', Kosher::Availability.new(hours))
+            )] :
+            [])
+      end
+    end
+  end
+end

data/lib/barnie/version.rb

@@ -1,3 +1,3 @@
 module Barnie #:nodoc:
-  VERSION = "0.1.3"
+  VERSION = '0.2.0'
 end

data/lib/barnie.rb

@@ -1,16 +1,6 @@
-require "mechanize"
-require "uri"
-require "barnie/error"
-require "barnie/helpers"
-require "barnie/client"
+require 'barnie/request'
+require 'barnie/response'
 
-# = Barnie
-# Barnie is a fake Barnes & Noble API
 module Barnie
-
-  # Instantiates a new Barnie::Request
-  def self.new(args={})
-    Barnie::Client.new(args)
-  end
-
+  class Error < StandardError; end
 end

data/spec/{unit/barnie → barnie}/helpers_spec.rb

@@ -4,7 +4,7 @@ require "spec_helper"
 module Barnie
   describe Helpers do
     before do
-      @client = Barnie.new("company details")
+      @client = Response.new(nil)
     end
 
     it "sanitizes string" do
@@ -42,8 +42,12 @@ module Barnie
     end
 
     context "requiring real HTML objects" do
+      let(:request) do
+        Request.new('Company Info')
+      end
+
       before do
-        VCR.insert_cassette('barnie_helpers')
+        VCR.insert_cassette('barnie')
       end
 
       after do
@@ -52,8 +56,9 @@ module Barnie
 
       context "ebook" do
         before do
-          @client.isbns = ["9781400826094"]
-          @html = @client.request.search("#prod-container").first
+          request << ["9781400826094"]
+          @client = request.get
+          @html = @client.page.search("#prod-container").first
         end
 
         it "returns title as XML NodeSet" do
@@ -75,8 +80,9 @@ module Barnie
 
       context "paperback" do
         before do
-          @client.isbns = ["9780816614028"]
-          @html = @client.request.search("#prod-container").first
+          request << ["9780816614028"]
+          @client = request.get
+          @html = @client.page.search("#prod-container").first
         end
 
         it "returns title as XML NodeSet" do
@@ -92,7 +98,7 @@ module Barnie
         end
 
         it "extracts authors" do
-          @client.extract_authors(@html).should =~ ["Felix Guattari", "Gilles Deleuze"]
+          @client.extract_authors(@html).should =~ ["Brian Massumi", "Gilles Deleuze"]
         end
       end
     end

data/spec/barnie/request_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+module Barnie
+  describe Request do
+    let (:request) { Request.new('Company Info') }
+
+    before do
+      VCR.insert_cassette('barnie')
+    end
+
+    after do
+      VCR.eject_cassette
+    end
+
+    describe ".new" do
+      it "requires user agent" do
+        expect do
+          Request.new
+        end.to raise_error /wrong number of arguments/
+      end
+
+      it "sets up a Mechanize agent" do
+        request.instance_variable_get(:@agent).should be_an_instance_of Mechanize
+      end
+    end
+
+    describe "#<<" do
+      it "sets the ISBNs to query" do
+        request << isbns
+        request.instance_variable_get(:@isbns).should == isbns
+      end
+    end
+
+    describe "#get" do
+      it "gets a response" do
+        request << isbns[0, 50]
+        response = request.get
+        response.should be_an_instance_of Response
+      end
+
+      it "raises an exception if no ISBNs are specified" do
+        expect do
+          request.get
+        end.to raise_error
+      end
+    end
+  end
+end

data/spec/barnie/response_spec.rb

@@ -0,0 +1,91 @@
+require 'spec_helper'
+
+module Barnie
+  describe Response do
+    let(:request) do
+      Request.new('Company Info')
+    end
+
+    let(:response) do
+      request << isbns[0, 50]
+      request.get
+    end
+
+    before do
+      VCR.insert_cassette('barnie')
+    end
+
+    after do
+      VCR.eject_cassette
+    end
+
+    it "includes Helpers" do
+      Response.ancestors.should include Helpers
+    end
+
+    describe "#snapshots" do
+      it "returns snapshots" do
+        snapshots = response.snapshots
+
+        snapshots.should be_an_instance_of Array
+        snapshots.first.should be_a Kosher::Snapshot
+      end
+
+      it "returns a result for a single ISBN" do
+        request << [isbns.first]
+        response = request.get
+
+        response.snapshots.size.should eql 1
+      end
+
+      context "when page does not include #prod-container element" do
+
+        let(:mock_page) do
+          page = mock("response")
+          page.stub!(:search).and_return(nil)
+          page
+        end
+
+        context "when page body is empty and HTTP is OK" do
+          before do
+            mock_page.stub!(:body).and_return("")
+            mock_page.stub!(:code).and_return(200)
+          end
+
+          it "throws a Barnie error" do
+            expect do
+              Response.new(mock_page).snapshots
+            end.to raise_error Barnie::Error, 'Blank page'
+          end
+        end
+      end
+
+      it "returns a book that is available for sale" do
+        request << ['9780816614028']
+        response = request.get
+        snapshot = response.snapshots.first
+        snapshot.offers_count.should eql 1
+      end
+
+      it "returns an ebook" do
+        request << ["9781400826094", "9780203029923"]
+        request.get.snapshots.each do |snapshot|
+          snapshot.isbn.should be_an_instance_of String
+          snapshot.offers.first.price.cents.should > 0
+          snapshot.offers.first.shipping.should_not be_kosher
+        end
+      end
+
+      it "returns a book that is not available for sale" do
+        request << ["9780002189347"]
+        snapshot = request.get.snapshots.first
+        snapshot.offers_count.should eql 0
+      end
+
+      it "does not return a book that is not in the Barnes & Noble catalogue" do
+        request << ["9780002196642"]
+        request.get.snapshots.should be_empty
+      end
+    end
+  end
+end