bard 0.5.1 → 0.5.2

data/VERSION

@@ -1 +1 @@
-0.5.1
+0.5.2

data/bard.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{bard}
-  s.version = "0.5.1"
+  s.version = "0.5.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Micah Geisel", "Nick Hogle"]

data/features/bard_check.feature

@@ -37,6 +37,13 @@ Feature: Bard can check its environment for missing dependencies and potential p
     When I type "bard check ."
     Then I should see the fatal error "missing submodule"
 
+  Scenario: Bard check detects submodules with detached heads
+    Given a shared rails project
+    And a submodule
+    And the submodule has a detached head
+    When I type "bard check ."
+    Then I should see the fatal error "submodule has a detached head"
+
   Scenario: Bard check detects missing gems
     Given a shared rails project
     And I have committed a set of changes that adds the test gem as a dependency

data/features/step_definitions/check_steps.rb

@@ -40,6 +40,12 @@ Given /^the submodule is missing$/ do
   type "mkdir submodule"
 end
 
+Given /^the submodule has a detached head$/ do
+  Dir.chdir "submodule" do
+    type "git checkout `git rev-parse HEAD`"
+  end
+end
+
 Given /^my "([^\"]*)" environment variable is "([^\"]*)"$/ do |key, value|
   @env ||= Hash.new
   @env[key] = value

data/lib/bard.rb

@@ -143,6 +143,7 @@ class Bard < Thor
         errors << "pending migrations" if stdout.include? "pending migrations"
 
         errors << "missing submodule" if `git submodule status` =~ /^-/
+        errors << "submodule has a detached head" unless system 'git submodule foreach "git symbolic-ref HEAD"'
         errors << "missing gems" if `rake gems` =~ /\[ \]/
         errors << "you shouldn't be working on the master branch" if `cat .git/HEAD`.include? "refs/heads/master"
         errors << "missing integration branch" if `git branch` !~ /\bintegration\b/

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: bard
 version: !ruby/object:Gem::Version 
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors: 
 - Micah Geisel