barcoop 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: '083d5afc9aa39df36db6326511a599e66e6547bb'
-  data.tar.gz: 4aa91c0f8d399b2330cedb9841fbda05060181b4
+  metadata.gz: fe78a4f14b92fcc57af4a34a86d25bee198a3073
+  data.tar.gz: cfee362b2207fb7e759786a6b83c3643991962c6
 SHA512:
-  metadata.gz: 88e85efb579edba751443d35b6bdb0520df5323a119f34a6554703883a14c3dbef7058fe58824de0cd1d6c29055ee917c7c02c958baa4055dcf7e47c0500aef1
-  data.tar.gz: 9308383757ed2bdbf9a30ad1a7ccf11250a5484e4999f6126827ff46d272aa2fba33ec54dae18b00a3d2cce543bce87a4a59b5202306b9b8064cc3679d11b766
+  metadata.gz: 5aece3f4cfbd163fcc8614bce668a8de73423c7244fa2fb1481b64bce7f51f4378118c1f095ffa8717f16664db73ae8197cb29bb22264d633dfb8b5c1704c877
+  data.tar.gz: df23af6ddd33a2d2444afd21536a7394a98d40d1fbd7b98f5bd3dbdf5f10a679dcc6e4b830d0bb03b3d9ba64331bb607f2df981303c0e12b72f7e5a58a26039b

data/conf/rubocop.yml

@@ -4,7 +4,7 @@
 # for default configuration
 
 require:
-  - barcoop/cops/avoid_timeout.rb
+  - barcoop/cop/barcoo/avoid_timeout.rb
 
 AllCops:
   TargetRubyVersion: 2.3

data/conf/rubocop_rails.yml

@@ -2,8 +2,8 @@ inherit_from:
   - rubocop.yml
 
 require:
-  - barcoop/cops/avoid_rails_env.rb
-  - barcoop/cops/avoid_fixtures.rb
+  - barcoop/cop/barcoo/avoid_rails_env.rb
+  - barcoop/cop/barcoo/avoid_fixtures.rb
 
 Rails:
   Enabled: true

data/lib/barcoop/cop/barcoo/avoid_fixtures.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+# cops are nested this way because the name of the cop is LastModule::ClassName
+module Barcoop
+  module Cop
+    module Barcoo
+      class AvoidFixtures < RuboCop::Cop::Cop
+        def on_send(node)
+          _receiver, method_name = *node
+          if method_name == :fixtures
+            msg = 'Avoid using fixtures, use FactoryGirl instead'
+            add_offense(node, :expression, msg)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/barcoop/cop/barcoo/avoid_rails_env.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+# cops are nested this way because the name of the cop is LastModule::ClassName
+module Barcoop
+  module Cop
+    module Barcoo
+      class AvoidRailsEnv < RuboCop::Cop::Cop
+        # def uncomment_to_test_this_cop()
+        #   _foo = Rails.env.production?
+        # end
+
+        def rails_env?(node)
+          is_rails_env = false
+          if node.send_type?
+            receiver, method_name = *node
+            is_rails_env = method_name == :env && receiver.const_type? && receiver.const_name == 'Rails'
+          end
+          return is_rails_env
+        end
+
+        def on_send(node)
+          receiver, method_name = *node
+          if %i(production? development? test?).include?(method_name)
+            msg = 'Avoid using Rails.env.environment? and prefer adding a feature flag in the configuration file.'
+            add_offense(node, :expression, msg) if rails_env?(receiver)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/barcoop/cop/barcoo/avoid_timeout.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+# cops are nested this way because the name of the cop is LastModule::ClassName
+module Barcoop
+  module Cop
+    module Barcoo
+      class AvoidTimeout < RuboCop::Cop::Cop
+        # def uncomment_to_test_this_cop()
+        #   Timeout.timeout(5) do
+        #     _foo = 'Timeout.timeout sucks http://www.mikeperham.com/2015/05/08/timeout-rubys-most-dangerous-api/'
+        #   end
+        #   timeout(5) do
+        #     _bar = 'This is a deprecated call'
+        #   end
+        # end
+
+        def on_send(node)
+          receiver, method_name = *node
+          if method_name == :timeout
+            if receiver.nil? || (receiver.const_type? && receiver.const_name == 'Timeout')
+              # TODO: add a real link, like AtomLinter/linter-shellcheck
+              msg = 'Timeout.timeout is not thread safe, see http://www.mikeperham.com/2015/05/08/timeout-rubys-most-dangerous-api/'
+              add_offense(node, :expression, msg)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/barcoop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Barcoop
-  VERSION = '0.2.3'
+  VERSION = '0.2.4'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: barcoop
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Sergio Medina
@@ -68,9 +68,9 @@ files:
 - conf/rubocop.yml
 - conf/rubocop_rails.yml
 - lib/barcoop.rb
-- lib/barcoop/cops/avoid_fixtures.rb
-- lib/barcoop/cops/avoid_rails_env.rb
-- lib/barcoop/cops/avoid_timeout.rb
+- lib/barcoop/cop/barcoo/avoid_fixtures.rb
+- lib/barcoop/cop/barcoo/avoid_rails_env.rb
+- lib/barcoop/cop/barcoo/avoid_timeout.rb
 - lib/barcoop/version.rb
 homepage: https://github.com/barcoo/barcoop
 licenses: []

data/lib/barcoop/cops/avoid_fixtures.rb

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-module Barcoop
-  module Cops
-    class AvoidFixtures < RuboCop::Cop::Cop
-      def on_send(node)
-        _receiver, method_name = *node
-        if method_name == :fixtures
-          msg = 'Avoid using fixtures, use FactoryGirl instead'
-          add_offense(node, :expression, msg)
-        end
-      end
-    end
-  end
-end

data/lib/barcoop/cops/avoid_rails_env.rb

@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-module Barcoop
-  module Cops
-    class AvoidRailsEnv < RuboCop::Cop::Cop
-      # def uncomment_to_test_this_cop()
-      #   _foo = Rails.env.production?
-      # end
-
-      def rails_env?(node)
-        is_rails_env = false
-        if node.send_type?
-          receiver, method_name = *node
-          is_rails_env = method_name == :env && receiver.const_type? && receiver.const_name == 'Rails'
-        end
-        return is_rails_env
-      end
-
-      def on_send(node)
-        receiver, method_name = *node
-        if %i(production? development? test?).include?(method_name)
-          msg = 'Avoid using Rails.env.environment? and prefer adding a feature flag in the configuration file.'
-          add_offense(node, :expression, msg) if rails_env?(receiver)
-        end
-      end
-    end
-  end
-end

data/lib/barcoop/cops/avoid_timeout.rb

@@ -1,27 +0,0 @@
-# frozen_string_literal: true
-
-module Barcoop
-  module Cops
-    class AvoidTimeout < RuboCop::Cop::Cop
-      # def uncomment_to_test_this_cop()
-      #   Timeout.timeout(5) do
-      #     _foo = 'Timeout.timeout sucks http://www.mikeperham.com/2015/05/08/timeout-rubys-most-dangerous-api/'
-      #   end
-      #   timeout(5) do
-      #     _bar = 'This is a deprecated call'
-      #   end
-      # end
-
-      def on_send(node)
-        receiver, method_name = *node
-        if method_name == :timeout
-          if receiver.nil? || (receiver.const_type? && receiver.const_name == 'Timeout')
-            # TODO: add a real link, like AtomLinter/linter-shellcheck
-            msg = 'Timeout.timeout is not thread safe, see http://www.mikeperham.com/2015/05/08/timeout-rubys-most-dangerous-api/'
-            add_offense(node, :expression, msg)
-          end
-        end
-      end
-    end
-  end
-end