barcodevalidation 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 84bbd3fe9cbb881208a51ecfafa282d5ee9bc5e9
-  data.tar.gz: 5ac9ff35d2d81d7ea0d67192acde59a29b94e681
+  metadata.gz: 897dd3cdb0c9e0bf7d9f50bfeb98b0ac8be7b79d
+  data.tar.gz: 93fb7cc3b723a9ce5c935c6eba57bfadad217d6a
 SHA512:
-  metadata.gz: f4a4842daa354e183476db6a0c61a70f99d4a0aa426a90f5ff166dba01718fa7557f8d3a7576c6aa13ca2180c51cafc9e0c80ba5a6b2bb85e430e22b8fa09769
-  data.tar.gz: be9e9f1e3a9393c93030a2979e1d4a9232c502b792831e79dc7e5d160c8bfcabd4bf0aa042fea598150facff3aa43e52833ccde03e03b507a9684b4510954fbf
+  metadata.gz: 5a6cee629384d5ff836f8ca9df2a29bbbd3a982498cd3d5f232bfd5b8b86dde9c6cbc569ae2ca01658fd0b887d24c185e5ee523ff82b90f21aa2f280e133b21d
+  data.tar.gz: 2d6659bfb3bf670a7b28d7c55e25ecc81412706421ffeee3ea19043f0d28df50e16d7e4f51d0f6f093d959435725e48d38c74b771af1d5f50229499654a07809

data/lib/barcodevalidation/digit.rb

@@ -2,17 +2,11 @@ require "delegate"
 
 module BarcodeValidation
   class Digit < DelegateClass(Integer)
+    include Adamantium
     include Mixin::ValueObject
 
     INTEGER_CAST_ERRORS = [::ArgumentError, ::TypeError].freeze
 
-    # Memoize constructor based on the integer value given
-    def self.memoization_key(input, *)
-      Integer(input)
-    rescue *INTEGER_CAST_ERRORS
-      nil # the constructor will raise
-    end
-
     def initialize(input)
       value = Integer(input)
       raise ::ArgumentError unless (0..9).cover? value
@@ -21,6 +15,8 @@ module BarcodeValidation
       raise Digit::ArgumentError, input
     end
 
+    alias to_i __getobj__
+
     ArgumentError = Error::ArgumentErrorClass.new(self)
   end
 end

data/lib/barcodevalidation/digit_sequence.rb

@@ -3,16 +3,12 @@ require "forwardable"
 module BarcodeValidation
   class DigitSequence < Array
     extend Forwardable
+    include Adamantium::Flat
     include Mixin::ValueObject
 
     delegate to_s: :join
     delegate cast: "self.class"
 
-    # Memoize constructor based on the integer value given
-    def self.memoization_key(input, *)
-      input.respond_to?(:join) ? input.join : input.to_s
-    end
-
     def self.cast(input)
       input = input.to_s if input.is_a? Integer
       input = input.chars if input.is_a? String
@@ -32,15 +28,6 @@ module BarcodeValidation
       end
     end
 
-    %i(* + - drop first last reverse rotate slice shuffle
-       take).each do |method_name|
-      define_method method_name do |*args|
-        super(*args).tap do |result|
-          return DigitSequence.new(result) if result.is_a? Enumerable
-        end
-      end
-    end
-
     ArgumentError = Error::ArgumentErrorClass.new(DigitSequence)
   end
 end

data/lib/barcodevalidation/gtin.rb

@@ -18,6 +18,7 @@ module BarcodeValidation
     end
 
     class CheckDigit < DelegateClass(Digit)
+      include Adamantium::Flat
       include Mixin::ValueObject
 
       attr_reader :actual, :expected

data/lib/barcodevalidation/mixin/has_check_digit.rb

@@ -17,12 +17,12 @@ module BarcodeValidation
       def weighted_checkable_digit_sum
         checkable_digits
           .zip([3, 1].cycle)
-          .map { |l, r| l * r }
+          .map { |digit, factor| digit * factor }
           .reduce(&:+)
       end
 
       def checkable_digits
-        take(length - 1).reverse
+        take(length - 1).reverse.map(&:to_i)
       end
     end
   end

data/lib/barcodevalidation/mixin/value_object.rb

@@ -5,18 +5,12 @@ module BarcodeValidation
     module ValueObject
       def self.included(mod)
         mod.extend ClassMethods
-        mod.include Adamantium
       end
 
       module ClassMethods
         # Memoizes return values based on the inputs
         def new(*args)
-          (@__new_cache ||= {})[memoization_key(*args)] ||= super
-        end
-
-        # Customise the memoisation logic in classes which include this
-        def memoization_key(*args)
-          args
+          (@__new_cache ||= {})[args] ||= super
         end
       end
 

data/lib/barcodevalidation/version.rb

@@ -1,3 +1,3 @@
 module BarcodeValidation
-  VERSION = "2.0.0".freeze
+  VERSION = "2.1.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: barcodevalidation
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Marketplacer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-04-01 00:00:00.000000000 Z
+date: 2016-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: adamantium