banter 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9f2b3a73cf906e381fe1ca04744d8417ec0ba26b
-  data.tar.gz: ef17591c856e22066c3731f5887b22b7a641ca39
+  metadata.gz: cebf2b048a1f14cd5b896d921a9802744ddb991c
+  data.tar.gz: 721d76e0451ad9890d2f96e1c12b2ab34e3357a1
 SHA512:
-  metadata.gz: 0604404fa2508ca708f28e3e3fdb8dd9668820f1eb12a32bf6cd6e079c40028cc024347bd0076a88539a05157f34e5885b91b619a7f5d44dcc5e4e6a3cc47f7a
-  data.tar.gz: b6999995acd10379efaa21f3209053c2f44a5899653f6bb3c86720604ee0dc1415fed85488af3d9b0f38796223caf6ff6ef859bd7629aada42d683318fb6af37
+  metadata.gz: a34d1cabedddd26176a16415364b28e2f779605b63c1ae8aeb778601045af70e9d03cb2edc63339e8bc956d7ec6251894d82877fe1c99a7536f88835e4fed222
+  data.tar.gz: b3d4f284e093951d471a5f50fcc3cc3ef20a975e894b1c40f524aa2df1ea101b41df8e52119cfb8452d33086bb892fe4591a86f9c9e663da33139994aff90f52

data/banter.gemspec

@@ -23,7 +23,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake", ">= 10.0"
   spec.add_development_dependency "rspec", "~> 3.0.0"
-  spec.add_development_dependency "debugger"
   spec.add_runtime_dependency "activesupport", ">= 3.2"
   spec.add_runtime_dependency "awesome_print", "~> 1.2.0"
   spec.add_runtime_dependency "bunny", ">= 1.2"

data/lib/banter/server/rabbit_mq_subscriber.rb

@@ -71,8 +71,8 @@ module Banter
 
       def teardown
         begin
-          @consumer.cancel if @consumer.present?
           @connection.close if @connection.present?
+          @consumer.cancel if @consumer.present?
         rescue => e
           Airbrake.notify(e, params: { error: e.message }, environment_name: ENV['RAILS_ENV'], backtrace: caller)
         end

data/lib/banter/version.rb

@@ -1,3 +1,3 @@
 module Banter
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/spec/banter/server/rabbitmq_subscriber_spec.rb

@@ -1,25 +1,5 @@
 require 'spec_helper'
 
 describe Banter::Server::RabbitMQSubscriber do
-  let(:durable) { true }
-  let(:routing_key) { 'test.me' }
-  let(:application_name) { 'queue_spec'}
-  let(:queue_name) { "test.me_#{application_name}" }
-  let(:ttl) { 100000 }
-  subject { Banter::Server::RabbitMQSubscriber.new( routing_key, queue_name, ttl, durable) }
-
-  before do
-    Banter::Configuration.application_name = application_name
-  end
-
-  describe "#start" do
-    before do
-    end
-
-    context "mark queue as durable" do
-
-    end
-
-  end
-
+  subject { Banter::Server::RabbitMQSubscriber.new( routing_key ) }
 end

data/spec/banter/server/subscriber_server_spec.rb

@@ -7,10 +7,14 @@ describe Banter::Server::SubscriberServer do
   subject { Banter::Server::SubscriberServer.instance }
   let!(:application_name) { "testsubscriber" }
   let!(:durable) { true }
+
+  before do
+    Banter::Configuration.application_name = application_name
+  end
+
   describe '#set_workers' do
     context "default config" do
       before {
-        Banter::Configuration.application_name = application_name
         allow(Banter::Server::ClientQueueListener).to receive(:new)
         subject.set_workers([MyTestSubscriber1, MyTestSubscriber2])
       }
@@ -24,11 +28,16 @@ describe Banter::Server::SubscriberServer do
     context "set pool_size" do
       before {
         Banter::Configuration.application_name = application_name
+        @default_pool_size = Banter::Configuration.configuration[:pool_size]
         allow(Banter::Server::ClientQueueListener).to receive(:new)
         Banter::Configuration.configuration[:pool_size] = 200
         subject.set_workers([MyTestSubscriber1, MyTestSubscriber2])
       }
 
+      after {
+        Banter::Configuration.configuration[:pool_size] = @default_pool_size
+      }
+
       it "creates queue listeners" do
         expect(Banter::Server::ClientQueueListener).to have_received(:new).with(MyTestSubscriber1, "foo.bar.one", "foo.bar.one_#{application_name}", durable, 200)
         expect(Banter::Server::ClientQueueListener).to have_received(:new).with(MyTestSubscriber2, "foo.bar.two", "foo.bar.two_#{application_name}", durable, 200)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: banter
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - The Honest Company
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-20 00:00:00.000000000 Z
+date: 2014-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -55,20 +55,6 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 3.0.0
-- !ruby/object:Gem::Dependency
-  name: debugger
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement