banter 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,15 @@
 ---
-SHA1:
-  metadata.gz: 626c512c0493b8041f1c1565e6a00c9b50026c19
-  data.tar.gz: 173c35409dcec9b576e20a93966f60aa5b5ad8a2
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    YjNmODc0ZTMwNjliZGQ1ZDg4MmU2YjNjNGU5NmUwMjgzY2NlZjY1Mw==
+  data.tar.gz: !binary |-
+    YTQzM2Y1NzQ2YThkZTNkMzhhMjk4NGRmMWU5MTJhOTk3ZmE2NTlkOA==
 SHA512:
-  metadata.gz: 092e7942da3212e76e7f7fd2301cdfd4278732c57551f7a41933e09afd922c40baaaa25cb4be33b323c5947629e542a04c7ffbd2b639c61c28b10c04416842c7
-  data.tar.gz: fbabc72de1f83cd04f9144d5e497573b2266c83709e5e0dbf1f335dbe8ce68f4251f387a274f39b8ce2f5cdac576eded342f6642ed53ba5e6e5148329f429f63
+  metadata.gz: !binary |-
+    ZTY2OTk1OGFmNTU2M2RkOWQxYzBiYzlhODIyNjVlOTRkMThkZDhkNDUzNTcw
+    OTMxOTM0MjFhNjkwN2Y3MTllNzlhNjM3ZWYzNzkyODBlM2ZmZDI0NzM4OWNk
+    MzRjM2FjZTU1NjE3NDRkNTc2YmU5NTcyYTcwZDAzMGRiMDg0NDA=
+  data.tar.gz: !binary |-
+    MzU2MjY4ODU0NTYwOTNmYmU5MGE5NzI2ODJmNTA0MmJmYTUyYjJlOThhMjA3
+    MTNiYTUyMjc1N2NhYjcwZjI0MTg0MmJlMTYxOWVmMTljYjAwZDBiY2ZmMjM5
+    NWE2MTBmMjIyMGEwM2VkODZmMWM2Y2U0NzJkMzBhMmQ4MzkwODA=

data/lib/banter/publisher.rb

@@ -52,7 +52,7 @@ module Banter
 
       @publisher.on_return do |return_info, properties, content|
         # contents are already transformed into message that we want to send
-        Banter::RabbitLogger.failed_publish(return_info[:routing_key], properties, content)
+        Banter::RabbitLogger.failed_publish(return_info[:routing_key], properties, Hashie::Mash.new(::JSON.parse(content)))
       end
 
     end

data/lib/banter/version.rb

@@ -1,3 +1,3 @@
 module Banter
-  VERSION = "1.0.3"
+  VERSION = "1.0.4"
 end

data/spec/banter/publisher_spec.rb

@@ -6,12 +6,15 @@ describe Banter::Publisher do
   let(:publisher) { Banter::Publisher.new }
   let(:context) { {unique_id: "1234", orig_ip_address: "127.0.0.1"}}
   let(:channel_mocker) {
-    double("::Bunny::Channel",
-      :topic=> double("::Bunny::Exchange",
-        :publish=> true,
-        :on_return=> true )
-    )
+    topic = double("::Bunny::Exchange", :publish=> true )
+    if publish_fails
+      topic.stub(:on_return).and_yield({routing_key: 'a.b.c'}, {some: 'property'}, '{"a":"b"}').and_return(false)
+    else
+      topic.stub(:on_return).and_return true
+    end
+    double("::Bunny::Channel", :topic=> topic)
   }
+  let(:publish_fails){ false}
 
   before do
     allow(Banter::RabbitLogger).to receive(:log_publish)
@@ -40,6 +43,13 @@ describe Banter::Publisher do
 
     end
 
+    context "Publish fails", publish_fails: true do
+      let(:publish_fails){ true }
+      let(:result) { publisher.start }
+
+      specify {expect { result }.not_to raise_error }
+    end
+    
     context "duplicate entries" do
       let(:result) { publisher.delay_messages { operations } }
 
@@ -78,4 +88,4 @@ describe Banter::Publisher do
     end
 
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: banter
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - The Honest Company
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-12 00:00:00.000000000 Z
+date: 2014-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -31,14 +31,14 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
@@ -59,28 +59,28 @@ dependencies:
   name: debugger
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.2'
 - !ruby/object:Gem::Dependency
@@ -101,84 +101,84 @@ dependencies:
   name: bunny
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '1.2'
 - !ruby/object:Gem::Dependency
   name: airbrake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
   name: hashie
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '1.2'
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '1.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '1.8'
 - !ruby/object:Gem::Dependency
   name: celluloid
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0.15'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0.15'
 - !ruby/object:Gem::Dependency
   name: celluloid-io
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0.15'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0.15'
 description: Publish & subscribe to messages
@@ -278,12 +278,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []