banorte_payworks 0.9.3 → 0.9.4

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 6f87eeddc4388c2138183fa961ddabfb7a8ca12a
+  data.tar.gz: ed6a7b90600cafd5f082fb7b617b07948cfbee01
+SHA512:
+  metadata.gz: 72cea3f7058949899ba5bdc18e7e940b44f999337e5ea5c9c85896eedc2d4da1af07edf0adaa3f811675b6d7db51e68eb4983b920c75ed0a551f68ef3657d7ee
+  data.tar.gz: 4fb22db5b147bc1c9747554b75f2567524fcfa6ec2632d21734e64d340ba12415baf494045da000e81a9a52de5642063e8ee976237230db5a89d4b8d9797063d

data/Gemfile.lock

@@ -1,14 +1,18 @@
 PATH
   remote: .
   specs:
-    banorte_payworks (0.9.3)
+    banorte_payworks (0.9.4)
+      faraday
       httpclient (>= 2.3.3)
 
 GEM
   remote: https://rubygems.org/
   specs:
     diff-lcs (1.2.4)
+    faraday (0.8.7)
+      multipart-post (~> 1.1)
     httpclient (2.3.3)
+    multipart-post (1.2.0)
     rake (10.1.0)
     rspec (2.13.0)
       rspec-core (~> 2.13.0)

data/banorte_payworks.gemspec

@@ -5,23 +5,25 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'banorte_payworks/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "banorte_payworks"
+  spec.name          = 'banorte_payworks'
   spec.version       = BanortePayworks::VERSION
-  spec.authors       = ["Jonathan Garay"]
-  spec.email         = ["jonathan@devmask.net"]
+  spec.authors       = ['Jonathan Garay']
+  spec.email         = %w(jonathan@devmask.net)
   spec.description   = %q{Simple TPV for Banorte Payworks Mexican Gateway}
   spec.summary       = %q{Simple TPV implementation for Banorte Payworks}
-  spec.homepage      = "http://devmask.net/banorte_payworks/"
-  spec.license       = "MIT"
+  spec.homepage      = 'http://devmask.net/banorte_payworks/'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = %w(lib)
 
-  spec.add_dependency('httpclient', '>= 2.3.3')
+  spec.add_dependency 'httpclient', '>= 2.3.3'
+  spec.add_dependency 'faraday'
+
+  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec'
 
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
 end

data/lib/banorte_payworks.rb

@@ -1 +1,5 @@
 require File.join(File.dirname(__FILE__), 'banorte_payworks/simple_tpv')
+require File.join(File.dirname(__FILE__), 'banorte_payworks/banorte_transaction')
+
+class BpayworksException < Exception; end
+

data/lib/banorte_payworks/banorte_transaction.rb

@@ -0,0 +1,48 @@
+class BanorteTransaction
+  attr_accessor :error_code, :message, :authnum, :order_id, :amount,
+                :card_number, :cvv, :exp_date, :_original_post,
+                :e, :time_in, :time_out, :card_type, :issuing_bank,
+                :transaction_type, :transaction_status
+
+  def self.from_post(post)
+    #TODO this big huge method needs to be abstracted to an a class and we need to cas the proper primitive types
+    parsed_post = CGI::parse(post)
+    create_with_properties self do |transaction|
+      transaction._original_post = post
+      transaction.error_code = parsed_post['CcErrCode'][0]
+      transaction.message = parsed_post['Text'][0]
+      transaction.authnum = parsed_post['AuthCode'][0]
+      transaction.order_id = parsed_post['OrderId'][0]
+      transaction.amount = parsed_post['Total'][0]
+      transaction.time_in = parsed_post['TimeIn'][0]
+      transaction.time_out = parsed_post['TimeOut'][0]
+
+      transaction.e = [parsed_post['E1'][0],
+                    parsed_post['E2'][0],
+                    parsed_post['E3'][0]]
+
+      transaction.card_type = parsed_post['CardType'][0]
+      transaction.issuing_bank = parsed_post['IssuingBank'][0]
+      transaction.transaction_type = parsed_post['TransType'][0]
+      transaction.transaction_status = parsed_post['TransStat'][0]
+
+      transaction.card_number = parsed_post['Number'][0]
+    end
+  end
+
+  def valid?
+    error_code.eql? '1'
+  end
+
+  def validate!
+    raise BpayworksException.new("Error::#{error_code}: #{message}") unless valid?
+  end
+
+  private
+  def self.create_with_properties(clazz, &block)
+    instance = clazz.new
+    yield instance
+    instance
+  end
+
+end

data/lib/banorte_payworks/simple_tpv.rb

@@ -1,85 +1,70 @@
-module BanortePayworks
+require 'httpclient'
+require 'cgi'
 
-  require 'httpclient'
+module BanortePayworks
 
-  PAYWORKS_URL = "https://eps.banorte.com/recibo"
-  PAYWORKS_3DS_URL = "https://eps.banorte.com/secure3d/Solucion3DSecure.htm"
+  PAYWORKS_URL = 'https://eps.banorte.com/recibo'
+  PAYWORKS_3DS_URL = 'https://eps.banorte.com/secure3d/Solucion3DSecure.htm'
 
   MODE = {
-      :production => 'P',
-      :reject => 'R',
-      :accept => 'Y',
-      :random => 'R'
+    production: 'P',
+    reject: 'R',
+    accept: 'Y',
+    random: 'R'
   }
 
   TYPE = {
-      :auth => 'Auth',
-      :pre_auth => 'PreAuth',
-      :post_auth => 'PostAuth',
-      :void => 'Void',
-      :credit => 'Credit',
-      :force_insert_auth => 'ForceInsertAuth',
-      :verify => 'Verify'
+    auth: 'Auth',
+    pre_auth: 'PreAuth',
+    post_auth: 'PostAuth',
+    void: 'Void',
+    credit: 'Credit',
+    force_insert_auth: 'ForceInsertAuth',
+    verify: 'Verify'
   }
 
-
-  class BpayworksException < Exception
-  end
-
-  class BanorteTransaction
-    require 'cgi'
-
-    attr_accessor :error_code, :message, :authnum, :order_id, :amount, :card_number, :cvv, :exp_date
-
-
-    def self.from_post(post)
-      parsed_post = CGI::parse(post)
-      protocol = BanorteTransaction.new
-      protocol.error_code = parsed_post['CcErrCode'][0]
-      protocol.message = parsed_post['Text'][0]
-      protocol.authnum = parsed_post['AuthCode'][0]
-      protocol.order_id = parsed_post['OrderId'][0]
-      protocol.amount = parsed_post['Total'][0]
-      protocol.card_number = parsed_post['Number'][0]
-      protocol
-    end
-
-
-  end
-
   class SimpleTPV
+    attr_accessor :config
 
-    def initialize(config={})
-      @config = config
+    def initialize(config = {})
+      self.config = config
     end
 
-    #Simple call to payment
     def do_payment(order_id, card_number, exp_date, cvv, amount)
-      do_transaction :card_number => card_number,
-                     :exp_date => exp_date,
-                     :cvv => cvv,
-                     :amount => amount,
-                     :order_id => order_id,
-                     :response_path => 'http://sample.net/',
-                     :type => BanortePayworks::TYPE[:auth]
+      do_transaction card_number: card_number,
+                     exp_date: exp_date,
+                     cvv: cvv,
+                     amount: amount,
+                     order_id: order_id,
+                     response_path: 'http://sample.net/',
+                     type: BanortePayworks::TYPE[:auth]
     end
 
     def void(transaction)
-
-      do_transaction :order_id => transaction.order_id,
-                     :amount => transaction.amount,
-                     :authnum => transaction.authnum,
-                     :card_number => transaction.card_number,
-                     :exp_date => transaction.exp_date,
-                     :cvv => transaction.cvv,
-                     :response_path => 'http://sample.net/',
-                     :type => BanortePayworks::TYPE[:void]
+      do_transaction order_id: transaction.order_id,
+                     amount: transaction.amount,
+                     authnum: transaction.authnum,
+                     card_number: transaction.card_number,
+                     exp_date: transaction.exp_date,
+                     cvv: transaction.cvv,
+                     response_path: 'http://sample.net/',
+                     type: BanortePayworks::TYPE[:void]
 
     end
 
     def do_transaction(properties = {})
+      return_eval BanorteTransaction.from_post payworks_request(properties).first do |protocol|
+        protocol.card_number = properties[:card_number]
+        protocol.cvv = properties[:cvv]
+        protocol.exp_date = properties[:exp_date]
+        protocol.validate!
+      end
+    end
+
+    protected
 
-      location = HTTPClient.new.post(PAYWORKS_URL, {
+    def payworks_request(properties)
+      HTTPClient.new.post(PAYWORKS_URL, {
           'Name' => @config[:username],
           'Password' => @config[:password],
           'ClientId' => @config[:client_id],
@@ -93,26 +78,15 @@ module BanortePayworks
           'ResponsePath' => properties[:response_path],
           'OrderId' => properties[:order_id],
           'AuthCode' => properties[:authnum].to_s
+      }).header['Location']
+    end
 
-      }).header['Location'].to_s
-
-      puts location.inspect if properties[:verbose]
-
-      protocol = BanorteTransaction.from_post location
-
-      #hack ?
-      protocol.card_number = properties[:card_number]
-      protocol.cvv = properties[:cvv]
-      protocol.exp_date = properties[:exp_date]
-
-      if protocol.error_code != '1'
-        raise BpayworksException.new("Error::#{protocol.error_code}: #{protocol.message}")
-      else
-        protocol
-      end
+    private
 
+    def return_eval(object, &block)
+      yield object
+      object
     end
-
   end
 
 end

data/lib/banorte_payworks/version.rb

@@ -1,3 +1,3 @@
 module BanortePayworks
-  VERSION = "0.9.3"
+  VERSION = '0.9.4'
 end

data/spec/banorte_payworks_simpletpv_spec.rb

@@ -1,14 +1,24 @@
 require 'banorte_payworks'
 
 describe BanortePayworks::SimpleTPV do
-  it "Call do transaction" do
-    tpv = BanortePayworks::SimpleTPV.new :username => 'tienda19',
-                                         :password => '2006',
-                                         :client_id=>'19',
-                                         :mode=>BanortePayworks::MODE[:accept]
+  describe '#transaction' do
+    let(:credit_card_number){ 4916098986962263 }
+    let(:expiration_date){ '12/14' }
+    let(:cvv){ 123 }
+    let(:amount){ 1.0 }
+    let(:order_id){ rand(10000) }
 
-    transaction = tpv.do_payment(rand(100000),4916098986962263,'12/13','123',1.0)
-    tpv.void transaction
+    let(:tpv) do
+      BanortePayworks::SimpleTPV.new :username => 'tienda19',
+                                     :password => '2006',
+                                     :client_id=>'19',
+                                     :mode=>BanortePayworks::MODE[:accept]
+    end
 
+    let(:result){tpv.do_payment(rand(100000), credit_card_number, expiration_date, '123', 1.0)}
+
+    it{ expect(result.valid?).to be_true }
+    it{ expect(result.card_number).to_not be_nil }
+    it{ expect(tpv.void(result).valid?).to be_true }
   end
 end

data/spec/spec_helper.rb

@@ -1,5 +1,6 @@
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
+
 require 'rspec'
 require 'banorte_payworks'
 
@@ -8,5 +9,5 @@ require 'banorte_payworks'
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
 
 RSpec.configure do |config|
-  
+
 end

metadata

@@ -1,36 +1,46 @@
 --- !ruby/object:Gem::Specification
 name: banorte_payworks
 version: !ruby/object:Gem::Version
-  version: 0.9.3
-  prerelease: 
+  version: 0.9.4
 platform: ruby
 authors:
 - Jonathan Garay
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-02 00:00:00.000000000 Z
+date: 2013-07-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.3.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.3.3
+- !ruby/object:Gem::Dependency
+  name: faraday
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -38,7 +48,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -46,33 +55,29 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Simple TPV for Banorte Payworks Mexican Gateway
@@ -92,38 +97,35 @@ files:
 - VERSION
 - banorte_payworks.gemspec
 - lib/banorte_payworks.rb
+- lib/banorte_payworks/banorte_transaction.rb
 - lib/banorte_payworks/simple_tpv.rb
 - lib/banorte_payworks/version.rb
 - spec/banorte_payworks_simpletpv_spec.rb
-- spec/banorte_payworks_spec.rb
 - spec/spec_helper.rb
 homepage: http://devmask.net/banorte_payworks/
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Simple TPV implementation for Banorte Payworks
 test_files:
 - spec/banorte_payworks_simpletpv_spec.rb
-- spec/banorte_payworks_spec.rb
 - spec/spec_helper.rb
-has_rdoc: 

data/spec/banorte_payworks_spec.rb

@@ -1,5 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
-
-describe "BanortePayworks" do
-
-end