banktools-se 3.1.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7f07fdb509f30138a506f6f6417ff304ed85500d08898e96c16d431b4f8c3ec3
-  data.tar.gz: 4582e2ed894b372b164d0634663a454aa36a7fc12fddaa65c3a322658daeca40
+  metadata.gz: ae26d83c75f488a904bc1dcaffada866c129f7f923a4083ef4c2886c58c4d605
+  data.tar.gz: 1a52ea7948ea5d90c0df16501455015ff8c870f22f00b64ca7ccf64f050aba83
 SHA512:
-  metadata.gz: 85df98a4cf73147671d52a66af1eb8af728e9610857b9a58a1f078642d33fe0386c973e375d964b47022aae44683f4e62b0313d4352a77434c827007bd83ff23
-  data.tar.gz: 46620b5b9b5f9f4af077bb93862669acbb4ae026ebccfd9cc462caf0711f4b67e14f01ce8ef4a36587c6964c3935530af637a851c7011f20c166300451861d2a
+  metadata.gz: 4ea749b95887d14fce1fa99b3f34537f497706ea1670050014cf94064830b6e23a1db8c3a71caeaab0282a559879562ea4305d9507608f1ad01f04c0ffa859fc
+  data.tar.gz: 3aef88169d2c7be49fcfa7d88148db48db4a2ff2d9f8822cc9898ee03f9fad0cc0b4e7f9197ce0410f1021c3459172b8159d99d49269f20a0f06c98b882f8eb7

data/.github/workflows/ci.yml

@@ -18,11 +18,10 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - name: Set up Ruby ${{ matrix.ruby-version }}
-        uses: ruby/setup-ruby@477b21f02be01bcb8030d50f37cfec92bfa615b6
+        uses: ruby/setup-ruby@ae9cb3b565e36682a2c6045e4f664388da4c73aa
         with:
           ruby-version: ${{ matrix.ruby-version }}
-      - name: Install dependencies
-        run: bundle install
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
       - name: Run tests
         run: bundle exec rake
 

data/.gitignore

@@ -2,3 +2,4 @@
 .bundle
 Gemfile.lock
 pkg/*
+tmp/*

data/.rubocop.yml

@@ -0,0 +1,5 @@
+AllCops:
+  Exclude:
+    - "tmp/**/*"
+inherit_gem:
+  barsoom_utils: shared_rubocop.yml

data/Gemfile

@@ -2,3 +2,8 @@ source "https://rubygems.org"
 
 # Specify your gem's dependencies in bank-tools-se.gemspec
 gemspec
+
+group :development do
+  gem "barsoom_utils", github: "barsoom/barsoom_utils"
+  gem "rubocop"
+end

data/Rakefile

@@ -1,6 +1,6 @@
 require "bundler/gem_tasks"
-require 'rspec/core/rake_task'
+require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/banktools-se.gemspec

@@ -5,14 +5,15 @@ require "banktools-se/version"
 Gem::Specification.new do |s|
   s.name        = "banktools-se"
   s.version     = BankTools::SE::VERSION
-  s.authors     = ["Henrik Nyh"]
-  s.email       = ["henrik@barsoom.se"]
+  s.authors     = [ "Henrik Nyh" ]
+  s.email       = [ "henrik@barsoom.se" ]
   s.homepage    = ""
   s.summary     = %q{Validate and normalize Swedish bank account numbers, plusgiro and bankgiro.}
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.require_paths = ["lib"]
+  s.require_paths = [ "lib" ]
+  s.metadata      = { "rubygems_mfa_required" => "true" }
 
   s.add_development_dependency "rake"
   s.add_development_dependency "rspec"

data/lib/banktools-se/account.rb

@@ -50,8 +50,8 @@ module BankTools
 
       def clearing_number
         [
-          digits[0,4],
-          checksum_for_clearing? ? digits[4,1] : nil
+          digits[0, 4],
+          checksum_for_clearing? ? digits[4, 1] : nil,
         ].compact.join("-")
       end
 
@@ -72,7 +72,7 @@ module BankTools
       end
 
       def bank_data
-        number = digits[0,4].to_i
+        number = digits[0, 4].to_i
         _, found_data = CLEARING_NUMBER_MAP.find { |interval, data| interval.include?(number) }
         found_data || {}
       end
@@ -90,7 +90,7 @@ module BankTools
           Array(serial_number_length).last +
             (checksum_for_clearing? ? 1 : 0)
         else
-          1/0.0  # Infinity.
+          1 / 0.0  # Infinity.
         end
       end
 
@@ -107,7 +107,7 @@ module BankTools
       end
 
       def digits
-        number.to_s.gsub(/\D/, '')
+        number.to_s.gsub(/\D/, "")
       end
 
       def zerofill?

data/lib/banktools-se/bankgiro.rb

@@ -38,7 +38,7 @@ module BankTools
       private
 
       def digits
-        number.to_s.gsub(/\D/, '')
+        number.to_s.gsub(/\D/, "")
       end
 
     end

data/lib/banktools-se/ocr.rb

@@ -20,6 +20,7 @@ module BankTools
         pad = pad.to_s
 
         raise MustBeNumeric unless number.match(/\A\d+\z/)
+
         # Padding isn't something BGC specifies, but we needed it to support a legacy scheme.
         number += pad
         # Adding 2: 1 length digit, 1 check digit.

data/lib/banktools-se/plusgiro.rb

@@ -45,7 +45,7 @@ module BankTools
       private
 
       def digits
-        number.to_s.gsub(/\D/, '')
+        number.to_s.gsub(/\D/, "")
       end
 
     end

data/lib/banktools-se/version.rb

@@ -1,5 +1,5 @@
 module BankTools
   module SE
-    VERSION = "3.1.0"
+    VERSION = "3.1.1"
   end
 end

data/spec/account_spec.rb

@@ -17,7 +17,7 @@ describe BankTools::SE::Account do
 
     it "should be false with errors" do
       account = BankTools::SE::Account.new("foo")
-      allow(account).to receive(:errors).and_return([:error])
+      allow(account).to receive(:errors).and_return([ :error ])
       expect(account).not_to be_valid
     end
   end

data/spec/bankgiro_spec.rb

@@ -15,7 +15,7 @@ describe BankTools::SE::Bankgiro do
 
     it "should be false with errors" do
       account = BankTools::SE::Bankgiro.new("foo")
-      allow(account).to receive(:errors).and_return([:error])
+      allow(account).to receive(:errors).and_return([ :error ])
       expect(account).not_to be_valid
     end
   end

data/spec/plusgiro_spec.rb

@@ -17,7 +17,7 @@ describe BankTools::SE::Plusgiro do
 
     it "should be false with errors" do
       account = BankTools::SE::Plusgiro.new("foo")
-      allow(account).to receive(:errors).and_return([:error])
+      allow(account).to receive(:errors).and_return([ :error ])
       expect(account).not_to be_valid
     end
 

data/spec/spec_helper.rb

@@ -1,4 +1,4 @@
 RSpec.configure do |config|
-  config.filter_run :focus => true
+  config.filter_run focus: true
   config.run_all_when_everything_filtered = true
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: banktools-se
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors:
 - Henrik Nyh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-08-02 00:00:00.000000000 Z
+date: 2021-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -75,6 +75,7 @@ extra_rdoc_files: []
 files:
 - ".github/workflows/ci.yml"
 - ".gitignore"
+- ".rubocop.yml"
 - CHANGELOG.md
 - Gemfile
 - README.markdown
@@ -97,7 +98,8 @@ files:
 - spec/utils_spec.rb
 homepage: ''
 licenses: []
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -113,7 +115,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.25
+rubygems_version: 3.2.28
 signing_key: 
 specification_version: 4
 summary: Validate and normalize Swedish bank account numbers, plusgiro and bankgiro.