banktools-se 0.2.0 → 0.3.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: b0b808f0833e1ba8e7768e6e320d431a6aaa4f93
+  data.tar.gz: 4e1f2304d9c70caa71e7c7268c367a02fe1bebbe
+SHA512:
+  metadata.gz: d6560518065f0eb8f9c1e5cc9926e2ce8fa5fd3d811f14a6a1a6d26db11f8654bf25307819686beae722bf869dddee2865db31f64c7d0a480f10c56961684513
+  data.tar.gz: 3657fde6ea4c9a9232041ffd94f2f6c13af3d56de15fb9fd99b2d6aa91de9e4a639b6ec7ead22e738c9a9b3bc76729f71b92b696f559179318cc4947d51c83cc

data/.travis.yml

@@ -0,0 +1,4 @@
+language: ruby
+rvm:
+  - 2.0.0
+  - 1.9.3

data/README.markdown

@@ -1,5 +1,7 @@
 # Swedish bank tools
 
+[![Build Status](https://secure.travis-ci.org/barsoom/banktools-se.png)](http://travis-ci.org/barsoom/banktools-se)
+
 Ruby gem to validate, normalize/prettify and to some extent interpret
 
   * Swedish bank account numbers
@@ -90,7 +92,6 @@ to install it.
 
 Possible improvements to make:
 
-  * Handle [Sparbanken zerofill](http://www.danskebank.se/sv-se/eBanking-content/text-pages/Pages/Bankliste2.aspx).
   * Luhn validation based on [BGC docs](http://www.bgc.se/upload/Gemensamt/Trycksaker/Manualer/BG910.pdf).
 
 

data/banktools-se.gemspec

@@ -17,6 +17,7 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
+  s.add_development_dependency "rake"
   s.add_development_dependency "rspec"
   s.add_development_dependency "guard"
   s.add_development_dependency "guard-rspec"

data/lib/banktools-se/account.rb

@@ -25,7 +25,7 @@ module BankTools
         6000..6999 => { :name => "Handelsbanken", :serial_number_length => 9 },
         7000..7999 => { :name => "Swedbank" },
         # Can be fewer chars but must be zero-filled, so let's call it 10.
-        8000..8999 => { :name => "Swedbank", :serial_number_length => 10, :checksum_for_clearing => true },
+        8000..8999 => { :name => "Swedbank", :serial_number_length => 10, :checksum_for_clearing => true, :zerofill => true },
         9020..9029 => { :name => "Länsförsäkringar Bank" },
         9040..9049 => { :name => "Citibank" },
         9060..9069 => { :name => "Länsförsäkringar Bank" },
@@ -42,13 +42,13 @@ module BankTools
         9260..9269 => { :name => "Den Norske Bank" },
         9270..9279 => { :name => "ICA Banken" },
         9280..9289 => { :name => "Resurs Bank" },
-        9300..9349 => { :name => "Sparbanken Öresund", :serial_number_length => 10 },
+        9300..9349 => { :name => "Sparbanken Öresund", :serial_number_length => 10, :zerofill => true },
         9400..9449 => { :name => "Forex Bank" },
         9460..9469 => { :name => "GE Money Bank" },
         9470..9479 => { :name => "Fortis Bank" },
         9500..9549 => { :name => "Nordea/Plusgirot", :serial_number_length => 1..10 },
         9550..9569 => { :name => "Avanza Bank" },
-        9570..9579 => { :name => "Sparbanken Syd", :serial_number_length => 10 },
+        9570..9579 => { :name => "Sparbanken Syd", :serial_number_length => 10, :zerofill => true},
         9960..9969 => { :name => "Nordea/Plusgirot", :serial_number_length => 1..10 },
       }
 
@@ -98,7 +98,8 @@ module BankTools
       end
 
       def serial_number
-        digits.slice(clearing_number_length..-1) || ""
+        number = digits.slice(clearing_number_length..-1) || ""
+        zerofill? ? "%.#{bank_data[:serial_number_length]}d" % number : number
       end
 
       private
@@ -144,6 +145,10 @@ module BankTools
         number.to_s.gsub(/\D/, '')
       end
 
+      def zerofill?
+        !!bank_data[:zerofill]
+      end
+
     end
   end
 end

data/lib/banktools-se/version.rb

@@ -1,5 +1,5 @@
 module BankTools
   module SE
-    VERSION = "0.2.0"
+    VERSION = "0.3.0"
   end
 end

data/spec/account_spec.rb

@@ -13,13 +13,13 @@ describe BankTools::SE::Account do
 
     it "should be true with no errors" do
       account = BankTools::SE::Account.new("foo")
-      account.stub!(:errors).and_return([])
+      account.stub(:errors).and_return([])
       account.should be_valid
     end
 
     it "should be false with errors" do
       account = BankTools::SE::Account.new("foo")
-      account.stub!(:errors).and_return([:error])
+      account.stub(:errors).and_return([:error])
       account.should_not be_valid
     end
 
@@ -78,6 +78,12 @@ describe BankTools::SE::Account do
       BankTools::SE::Account.new("11007").errors.should include(BankTools::SE::Errors::TOO_SHORT)
     end
 
+    it "should not include :too_short for Swedbank/Sparbanker numbers that can be zerofilled" do
+      BankTools::SE::Account.new("8000-2-00000000").errors.should_not include(BankTools::SE::Errors::TOO_SHORT)
+      BankTools::SE::Account.new("9300-2-00000000").errors.should_not include(BankTools::SE::Errors::TOO_SHORT)
+      BankTools::SE::Account.new("9570-2-00000000").errors.should_not include(BankTools::SE::Errors::TOO_SHORT)
+    end
+
     it "should include :too_long for numbers longer than the bank allows" do
       BankTools::SE::Account.new("1100000000007").errors.should include(BankTools::SE::Errors::TOO_LONG)
     end
@@ -161,6 +167,11 @@ describe BankTools::SE::Account do
       account = BankTools::SE::Account.new(" 1-2-3 ").normalize.should == " 1-2-3 "
     end
 
+    it "should prepend zeroes to the serial number if necessary" do
+      BankTools::SE::Account.new("8000-2-80000003").normalize.should   == "8000-2-0080000003"
+      BankTools::SE::Account.new("8000-2-8000000003").normalize.should == "8000-2-8000000003"
+    end
+
   end
 
 end

data/spec/bankgiro_spec.rb

@@ -11,13 +11,13 @@ describe BankTools::SE::Bankgiro do
 
     it "should be true with no errors" do
       account = BankTools::SE::Bankgiro.new("foo")
-      account.stub!(:errors).and_return([])
+      account.stub(:errors).and_return([])
       account.should be_valid
     end
 
     it "should be false with errors" do
       account = BankTools::SE::Bankgiro.new("foo")
-      account.stub!(:errors).and_return([:error])
+      account.stub(:errors).and_return([:error])
       account.should_not be_valid
     end
 

data/spec/plusgiro_spec.rb

@@ -11,13 +11,13 @@ describe BankTools::SE::Plusgiro do
 
     it "should be true with no errors" do
       account = BankTools::SE::Plusgiro.new("foo")
-      account.stub!(:errors).and_return([])
+      account.stub(:errors).and_return([])
       account.should be_valid
     end
 
     it "should be false with errors" do
       account = BankTools::SE::Plusgiro.new("foo")
-      account.stub!(:errors).and_return([:error])
+      account.stub(:errors).and_return([:error])
       account.should_not be_valid
     end
 

metadata

@@ -1,49 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: banktools-se
 version: !ruby/object:Gem::Version
-  version: 0.2.0
-  prerelease: 
+  version: 0.3.0
 platform: ruby
 authors:
 - Henrik Nyh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-10 00:00:00.000000000 Z
+date: 2013-12-13 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70242598104220 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70242598104220
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: guard
-  requirement: &70242598103800 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70242598103800
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &70242598103380 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70242598103380
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - henrik@barsoom.se
@@ -52,6 +74,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - Guardfile
 - README.markdown
@@ -71,27 +94,26 @@ files:
 - spec/utils_spec.rb
 homepage: ''
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: banktools-se
-rubygems_version: 1.8.5
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Validate and normalize Swedish bank account numbers, plusgiro and bankgiro.
 test_files:
 - spec/account_spec.rb
@@ -99,3 +121,4 @@ test_files:
 - spec/plusgiro_spec.rb
 - spec/spec_helper.rb
 - spec/utils_spec.rb
+has_rdoc: