banktools-gb 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e62708dc1891a4ffa3ff2cd58a02e3fb4f5eaa9d
-  data.tar.gz: 408c21b0d050f697b137090a1b291b948a6f0648
+  metadata.gz: c0f3e7f61bc8d6f56034536be0c064e6cf1f7d18
+  data.tar.gz: bb3a03b154524de3daed3de0d75513236b4541c8
 SHA512:
-  metadata.gz: d5910eeb5b48f599ecd3e2a964a7cc9741cad0bcaefcee22c85d7e6b5e49f733239a2923f9d04118c0dd1c8d4a84e23b7399f89ff5ca70ce5cedcfd8ceadd933
-  data.tar.gz: 040d89b34757aa5c4f8c86a9a3f71c487a697dd6233d46085f975e4d8b8d0ed5b50576b0762eb359a885250b0f53e27426057e573666bb8940ff5ebe4f4c0557
+  metadata.gz: 9a57461e8877d93410799c501e87d06cd995d9c92519f29731d3fdcef79c3450d43a0b23f2f4a0d8a149d5d7f9248ee711b15f7731de935855d51372abbf470a
+  data.tar.gz: f7e80fe6f3758b54ab86cd6f452172537fa0f684517313cce0b619a8b84b40e68824b1a201a6295695c8f7a46487dc14e5a320e5d5ac4ace2f909f4759b9e160

data/README.md

@@ -14,15 +14,16 @@ If we got anything wrong, please file an issue or contribute a fix yourself.
 
     bad_account = BankTools::GB::AccountNumberWithSortCode.new(account_number: "1", sort_code: "")
     bad_account.valid?  # => false
-    bad_account.errors  # => [:account_numberaccount_number_too_short]
+    bad_account.errors  # => [:account_number_is_too_short]
 
     # Error codes
 
-    BankTools::GB::Errors::ACCOUNT_NUMBER_TOO_SHORT                # => :account_number_too_short
-    BankTools::GB::Errors::ACCOUNT_NUMBER_TOO_LONG                 # => :account_number_too_long
-    BankTools::GB::Errors::SORT_CODE_WITH_WRONG_LENGTH             # => :sort_code_with_wrong_length
-    BankTools::GB::Errors::ACCOUNT_NUMBER_INVALID_CHARACTERS       # => :account_number_invalid_characters
-    BankTools::GB::Errors::SORT_CODE_INVALID_CHARACTERS            # => :sort_code_invalid_characters
+    BankTools::GB::Errors::ACCOUNT_NUMBER_IS_TOO_SHORT              # => :account_number_is_too_short
+    BankTools::GB::Errors::ACCOUNT_NUMBER_IS_TOO_LONG               # => :account_number_is_too_long
+    BankTools::GB::Errors::SORT_CODE_WITH_WRONG_LENGTH              # => :sort_code_with_wrong_length
+    BankTools::GB::Errors::ACCOUNT_NUMBER_WITH_INVALID_CHARACTERS   # => :account_number_with_invalid_characters
+    BankTools::GB::Errors::SORT_CODE_WITH_INVALID_CHARACTERS        # => :sort_code_with_invalid_characters
+    BankTools::GB::Errors::ACCOUNT_NUMBER_DOES_NOT_MATCH_SORT_CODE  # => :account_number_does_not_match_sort_code
 
 ## Installation
 

data/lib/banktools-gb/account_number_with_sort_code.rb

@@ -18,11 +18,11 @@ module BankTools
 
       def errors
         errors = []
-        errors << :account_number_too_short if account_number_too_short?
-        errors << :account_number_too_long if account_number_too_long?
+        errors << :account_number_is_too_short if account_number_is_too_short?
+        errors << :account_number_is_too_long if account_number_is_too_long?
         errors << :sort_code_with_wrong_length if sort_code_with_wrong_length?
-        errors << :sort_code_invalid_characters if any_non_digits?(compact_sort_code)
-        errors << :account_number_invalid_characters if any_non_digits?(compact_account_number)
+        errors << :sort_code_with_invalid_characters if any_non_digits?(compact_sort_code)
+        errors << :account_number_with_invalid_characters if any_non_digits?(compact_account_number)
         errors << :account_number_does_not_match_sort_code unless valid_account_number_with_sort_code?
         errors
       end
@@ -37,11 +37,11 @@ module BankTools
         compact_sort_code.length != SORT_CODE_LENGTH
       end
 
-      def account_number_too_short?
+      def account_number_is_too_short?
         compact_account_number.length < ACCOUNT_NUMBER_MIN_LENGTH
       end
 
-      def account_number_too_long?
+      def account_number_is_too_long?
         compact_account_number.length > ACCOUNT_NUMBER_MAX_LENGTH
       end
 

data/lib/banktools-gb/errors.rb

@@ -1,11 +1,11 @@
 module Banktools
   module GB
     module Errors
-      ACCOUNT_NUMBER_TOO_SHORT                = :account_number_too_short
-      ACCOUNT_NUMBER_TOO_LONG                 = :account_number_too_long
+      ACCOUNT_NUMBER_IS_TOO_SHORT             = :account_number_is_too_short
+      ACCOUNT_NUMBER_IS_TOO_LONG              = :account_number_is_too_long
       SORT_CODE_WITH_WRONG_LENGTH             = :sort_code_with_wrong_length
-      SORT_CODE_INVALID_CHARACTERS            = :sort_code_invalid_characters
-      ACCOUNT_NUMBER_INVALID_CHARACTERS       = :account_number_invalid_characters
+      SORT_CODE_WITH_INVALID_CHARACTERS       = :sort_code_with_invalid_characters
+      ACCOUNT_NUMBER_WITH_INVALID_CHARACTERS  = :account_number_with_invalid_characters
       ACCOUNT_NUMBER_DOES_NOT_MATCH_SORT_CODE = :account_number_does_not_match_sort_code
     end
   end

data/lib/banktools-gb/version.rb

@@ -1,5 +1,5 @@
 module Banktools
   module Gb
-    VERSION = "0.4.0"
+    VERSION = "0.5.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: banktools-gb
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Tomas Skogberg