banktools-gb 0.11.0 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ffdb9dce789b6c5c38ef0e3178ee9a3e80172267
-  data.tar.gz: 2753c4af90e0ebb2b7bdd4ac45dc67648139729b
+  metadata.gz: 102538128b1b587219b24bc7c1513972722502aa
+  data.tar.gz: b034463d437666eaee598d8b4464fddee40eee81
 SHA512:
-  metadata.gz: e493caa282cadc173b55f63ca09eda5ac1ffb248b9ff882e355adb347e1978561321eaa25ec4c20895baa869816b9962bce1cf84ec6371cb23cb776b3c171987
-  data.tar.gz: 3f77553a66f5234082d2b2b150ebb3e4876939b4778ec1c699d26f2256d70151c8a833220342296f004df5d1398085aab77cf7ba1747b7162183b3d33a68b57e
+  metadata.gz: 2e8778fd23af453510ef52e325ddb70cd39c7956b78469c7b4e8aaa1a02185830ea254e54103099c44c545fe60164dcc1abe58fd54c0c94b6d1165a78b0e5dde
+  data.tar.gz: bd9a364de035f617bf7f152460b04f00de89ef56d42c2a37a1ed6a9d4b48e0353413a3c9b012f88163652d4b6c8fe8615a54d7342bb98a6543333e876e5cc98c

data/README.md

@@ -30,18 +30,6 @@ If we got anything wrong, please file an issue or contribute a fix yourself.
     bad_account.valid?  # => false
     bad_account.errors  # => [ :too_short ]
 
-
-    # Account and sort code (checksum check and others)
-    # This relies on [our fork of the uk_account_validator gem](https://github.com/barsoom/uk_account_validator). If that gem is out of date, the checksum check may be also.
-
-    account_and_sort_code = BankTools::GB::AccountNumberAndSortCode.new(account_number_original_value: 14248387, sort_code_original_value: 405161).valid?
-    account_and_sort_code.valid?  # => true
-    account_and_sort_code.errors  # => []
-
-    account_and_sort_code = BankTools::GB::AccountNumberAndSortCode.new(account_number_original_value: 14248387, sort_code_original_value: "xx")
-    account_and_sort_code.valid?  # => false
-    account_and_sort_code.errors  # => [:sort_code_too_short, :sort_code_invalid_characters, :bad_checksum]
-
 ## Installation
 
 Add this line to your application's Gemfile:

data/banktools-gb.gemspec

@@ -18,7 +18,6 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "uk_account_validator_auctionet", "~> 0"
   spec.add_dependency "attr_extras", "~> 5"
 
   spec.add_development_dependency "bundler", "~> 1"

data/lib/banktools-gb.rb

@@ -1,6 +1,3 @@
-require "uk_account_validator"
-
 require "banktools-gb/version"
 require "banktools-gb/sort_code"
 require "banktools-gb/account"
-require "banktools-gb/account_number_and_sort_code"

data/lib/banktools-gb/errors.rb

@@ -7,7 +7,6 @@ module BankTools
       SORT_CODE_TOO_LONG           = :sort_code_too_long
       ACCOUNT_INVALID_CHARACTERS   = :account_invalid_characters
       SORT_CODE_INVALID_CHARACTERS = :sort_code_invalid_characters
-      BAD_CHECKSUM                 = :bad_checksum
     end
   end
 end

data/lib/banktools-gb/version.rb

@@ -1,5 +1,5 @@
 module BankTools
   module GB
-    VERSION = "0.11.0"
+    VERSION = "0.12.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: banktools-gb
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.12.0
 platform: ruby
 authors:
 - Tomas Skogberg
@@ -10,20 +10,6 @@ bindir: exe
 cert_chain: []
 date: 2018-10-18 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: uk_account_validator_auctionet
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: attr_extras
   requirement: !ruby/object:Gem::Requirement
@@ -99,7 +85,6 @@ files:
 - bin/setup
 - lib/banktools-gb.rb
 - lib/banktools-gb/account.rb
-- lib/banktools-gb/account_number_and_sort_code.rb
 - lib/banktools-gb/errors.rb
 - lib/banktools-gb/sort_code.rb
 - lib/banktools-gb/version.rb

data/lib/banktools-gb/account_number_and_sort_code.rb

@@ -1,40 +0,0 @@
-require "attr_extras/explicit"
-require "banktools-gb/errors"
-
-module BankTools
-  module GB
-    class AccountNumberAndSortCode
-      extend AttrExtras.mixin
-
-      pattr_initialize [ :account_number_original_value, :sort_code_original_value ]
-
-      def valid?
-        errors.none?
-      end
-
-      def errors
-        errors = []
-
-        errors << account_number.errors
-        errors << sort_code.errors
-        errors << Errors::BAD_CHECKSUM unless valid_account_number_and_sort_code?
-
-        errors.flatten
-      end
-
-      private
-
-      def account_number
-        Account.new(account_number_original_value)
-      end
-
-      def sort_code
-        SortCode.new(sort_code_original_value)
-      end
-
-      def valid_account_number_and_sort_code?
-        UkAccountValidator::Validator.new(account_number.compacted_value, sort_code.compacted_value).valid?
-      end
-    end
-  end
-end