banktools-de 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 010b6ad5764da47d0eee569b99a8494b4ea73d52
-  data.tar.gz: e02e69d013380a473866a788a04013831d8d775a
+  metadata.gz: 89114d9d963ca0aaba7ed20b2347965289b4c46e
+  data.tar.gz: bb9412ad2010aa834351d0ec94f4663c950ae1a3
 SHA512:
-  metadata.gz: 76cac880128d73863d1d75a8d3eecb4db6f1121f06268b34a298504b3b8974312214334b9e4ef8b67be3cf0404f92c85927fabe8bf9b847fa133d10c0f3367dd
-  data.tar.gz: 9d9fc8c51b69eac2fcadf788caf721eaf39f65cc37156366c084d33bf5101518a44cd0c442c48420af0696002d24f909f5db6cbdd4fb41cc462b6e0316f320c5
+  metadata.gz: e686988439bb9ef324ded10e87c8d9639db2d97828320ea36a6deb5fac4453c0300e2ddbf9214c814eab261ae0c9dad5e286c0785364aa9e73406d83ec6a3704
+  data.tar.gz: d2a368d77d104022ab247d5cb21b50cbd62ce0b7b2b85e7cb61b1964be62e43e717ed0e43b082e8937b19366ec23ee4f20987c89434033c81367733e377812cf

data/README.md

@@ -19,9 +19,21 @@ If we got anything wrong, please file an issue or contribute a fix yourself.
     blz.errors  # => []
 
     bad_blz = BankTools::DE::BLZ.new("1X")
+    bad_blz.normalize  # => "1X"
     bad_blz.valid?  # => false
     bad_blz.errors  # => [ :too_short, :invalid_characters ]
-    bad_account.normalize  # => "1X"
+
+    # Account
+
+    account = BankTools::DE::Account.new("123456789")
+    account.normalize  # => "123 456 789"
+    account.valid?  # => true
+    account.errors  # => []
+
+    bad_account = BankTools::DE::Account.new("1")
+    bad_account.normalize  # => "1"
+    bad_account.valid?  # => false
+    bad_account.errors  # => [ :too_short ]
 
 
 ## Tests

data/lib/bank_tools/de/account.rb

@@ -0,0 +1,47 @@
+# http://de.wikipedia.org/wiki/Bankleitzahl
+# http://translate.google.com/translate?hl=en&sl=de&tl=en&u=http%3A%2F%2Fde.wikipedia.org%2Fwiki%2FBankleitzahl
+
+require "attr_extras"
+require "bank_tools/de/errors"
+
+module BankTools
+  module DE
+    class Account
+      # Picked some reasonable values, erring on the side of allowing too much.
+      # Seems to claim max 10: http://docs.oracle.com/cd/E18727_01/doc.121/e13483/T359831T498954.htm
+      # Seems to claim 2 - 13: http://www.credit-card.be/BankAccount/ValidationRules.htm#DE_Validation
+      MIN_LENGTH = 2
+      MAX_LENGTH = 15
+
+      GROUPS_OF = 3
+
+      pattr_initialize :original_value
+
+      def normalize
+        if valid?
+          compacted_value.scan(/\d{#{GROUPS_OF}}|\d+/).join(" ")
+        else
+          original_value
+        end
+      end
+
+      def valid?
+        errors.empty?
+      end
+
+      def errors
+        errors = []
+        errors << Errors::TOO_SHORT if compacted_value.length < MIN_LENGTH
+        errors << Errors::TOO_LONG if compacted_value.length > MAX_LENGTH
+        errors << Errors::INVALID_CHARACTERS if compacted_value.match(/\D/)
+        errors
+      end
+
+      private
+
+      def compacted_value
+        original_value.to_s.gsub(/[\s-]/, "")
+      end
+    end
+  end
+end

data/lib/bank_tools/de/blz.rb

@@ -1,3 +1,6 @@
+# http://de.wikipedia.org/wiki/Bankleitzahl
+# http://translate.google.com/translate?hl=en&sl=de&tl=en&u=http%3A%2F%2Fde.wikipedia.org%2Fwiki%2FBankleitzahl
+
 require "attr_extras"
 require "bank_tools/de/errors"
 

data/lib/bank_tools/de/version.rb

@@ -1,5 +1,5 @@
 module BankTools
   module DE
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

data/spec/account_spec.rb

@@ -0,0 +1,57 @@
+require "spec_helper"
+require "bank_tools/de/account"
+
+describe BankTools::DE::Account, "#normalize" do
+  it "groups the number in threes" do
+    expect_normalization "12", "12"
+    expect_normalization "123", "123"
+    expect_normalization "1234", "123 4"
+    expect_normalization "1234567890", "123 456 789 0"
+  end
+
+  it "ignores previous whitespace" do
+    expect_normalization " 1 23 4 ", "123 4"
+  end
+
+  it "ignores previous dashes" do
+    expect_normalization " 1-2-3-4 ", "123 4"
+  end
+
+  it "leaves a bad format as-is" do
+    expect_normalization "hej", "hej"
+  end
+
+  def expect_normalization(from, unto)
+    expect(BankTools::DE::Account.new(from).normalize).to eq unto
+  end
+end
+
+describe BankTools::DE::Account, "#valid?" do
+  it "is true with no errors" do
+    expect(BankTools::DE::Account.new("12").valid?).to be_true
+  end
+
+  it "is false with errors" do
+    expect(BankTools::DE::Account.new("1").valid?).to be_false
+  end
+end
+
+describe BankTools::DE::Account, "#errors" do
+  Errors = BankTools::DE::Errors
+
+  it "is empty when valid" do
+    expect(BankTools::DE::Account.new(" 1-2 ").errors).to be_empty
+  end
+
+  it "includes TOO_SHORT if below 2 characters" do
+    expect(BankTools::DE::Account.new("1").errors).to include(Errors::TOO_SHORT)
+  end
+
+  it "includes TOO_LONG if above 15 characters" do
+    expect(BankTools::DE::Account.new("1234567890123456").errors).to include(Errors::TOO_LONG)
+  end
+
+  it "includes INVALID_CHARACTERS if there's other things than digits, whitespace and dashes" do
+    expect(BankTools::DE::Account.new("1X").errors).to include(Errors::INVALID_CHARACTERS)
+  end
+end

data/spec/blz_spec.rb

@@ -30,8 +30,8 @@ end
 describe BankTools::DE::BLZ, "#errors" do
   Errors = BankTools::DE::Errors
 
-  it "is empty with no errors" do
-    expect(BankTools::DE::BLZ.new("123 456 78").errors).to eq []
+  it "is empty if there's 8 digits and possibly whitespace" do
+    expect(BankTools::DE::BLZ.new(" 123 456 78 ").errors).to be_empty
   end
 
   it "includes TOO_SHORT if below 8 characters" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: banktools-de
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Henrik Nyh
@@ -79,9 +79,11 @@ files:
 - Rakefile
 - banktools-de.gemspec
 - lib/bank_tools/de.rb
+- lib/bank_tools/de/account.rb
 - lib/bank_tools/de/blz.rb
 - lib/bank_tools/de/errors.rb
 - lib/bank_tools/de/version.rb
+- spec/account_spec.rb
 - spec/blz_spec.rb
 - spec/spec_helper.rb
 homepage: ''
@@ -109,5 +111,6 @@ signing_key:
 specification_version: 4
 summary: Validate and normalize German Bankleitzahl (BLZ) and bank account numbers.
 test_files:
+- spec/account_spec.rb
 - spec/blz_spec.rb
 - spec/spec_helper.rb