bankster-transaction 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 13233f67cf124e55da18ba4f729de47db24fe375
-  data.tar.gz: 3969267143d63497d34c88077db153c5c101339b
+  metadata.gz: 860a2733dc4a0ee55294c9654cc38deacc22fb53
+  data.tar.gz: 7ea23ca5d57b7ad1856c88725cbbca5df3a2cf69
 SHA512:
-  metadata.gz: 8cf75dcceee8ca6b8fee59b9d685ee0c333733bc63ca94d68b3f4775a9186edc4c51a198ffb2cba326079a535a22012ee5920e18d18c28625b5d251d47909348
-  data.tar.gz: c7ff5f40bf5368064778f07ac7eb9c77eaec58b776d7fecffff0468994b64f52e8800b11229fc3e9c54df1ad2d7e98e09ac3ef67bd9016ab1f0c6d4e52e79340
+  metadata.gz: d41c7634a3a7167d90697e15518d4aa9b3e19a309ae40a21340094c1a25d4887d9579f8963a207e980c4edf2f9ec69056b5f5639ecf6fe87e070577c22e0c198
+  data.tar.gz: d0a79ee09f26cfdc3587dbb10abc2bb3517c21ada73efd0d6c3cf44ddbdcaac7ebe4b0c2f7293d174209717bd3a4df957ae2a7ab3e60b631918cae4dae314b6b

data/bankster-transaction.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'bankster-transaction'
-  spec.version       = '0.1.1'
+  spec.version       = '0.1.2'
   spec.authors       = ['Roman Lehnert']
   spec.email         = ['roman.lehnert@googlemail.com']
 
@@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
     raise 'RubyGems 2.0 or newer is required to protect against public gem pushes.'
   end
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.files         = `git ls-files -z`.split("\x0")
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']

data/spec/factories/transactions_factory.rb

@@ -0,0 +1,29 @@
+FactoryGirl.define do
+  factory :transaction, class: Bankster::Transaction do
+    skip_create
+
+    name            'Max Mustermann'
+    iban            'DE123'
+    bic             'ASD'
+    type            :credit_tansfer
+    purpose         'my purpose'
+    amount          Money.new(123, "EUR")
+    booking_date    Date.today
+    valutation_date Date.today
+  end
+
+  factory :transaction_api_response, class: Hash do
+    skip_create
+
+    name            'Max Mustermann'
+    type            'credit_transfer'
+    purpose         'my purpose'
+    iban            'DE123'
+    bic             'ASD'
+    amount          {{ 'cents' => "123", 'currency' => "EUR" }}
+    booking_date    Date.today.iso8601
+    valutation_date Date.today.iso8601
+
+    initialize_with { attributes.stringify_keys }
+  end
+end

data/spec/factories/transactions_factory_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+
+describe 'transaction_api_response factory' do
+  subject { FactoryGirl.create(:transaction_api_response) }
+
+  it 'validates against the json schema' do
+    expect(subject.to_json).to match_json_schema(:transaction_schema, strict: true)
+  end
+end

data/spec/representers/transaction_representer_spec.rb

@@ -0,0 +1,124 @@
+require 'spec_helper'
+
+describe Bankster::Representers::TransactionRepresenter do
+  describe 'creation of json from multiple transactions' do
+    let(:transaction_1) { FactoryGirl.build(:transaction, amount: Money.eur(123)) }
+    let(:transaction_2) { FactoryGirl.build(:transaction, amount: Money.eur(123)) }
+    let(:transactions) { [transaction_1, transaction_2] }
+    subject { described_class.for_collection.prepare(transactions) }
+
+    it 'creates json that matches the schema' do
+      expect(subject.to_json).to match_json_schema(:transactions_schema, strict: true)
+    end
+  end
+
+  describe 'creation of multiple bankster transactions from a collection api response' do
+    let(:transaction_1) { FactoryGirl.build(:transaction, amount: Money.eur(123)) }
+    let(:transaction_2) { FactoryGirl.build(:transaction, amount: Money.eur(345)) }
+    let(:transactions) { [transaction_1, transaction_2] }
+    let(:api_response) { described_class.for_collection.prepare(transactions).to_json }
+
+    it 'parses collections and returns transaction objects' do
+      parsed_transactions = [].extend(Bankster::Representers::TransactionRepresenter.for_collection).from_json(api_response)
+      expect(parsed_transactions.first).to be_a(Bankster::Transaction)
+      expect(parsed_transactions.last).to be_a(Bankster::Transaction)
+      expect(parsed_transactions.count).to eql(2)
+      expect(parsed_transactions.first.amount).to eql(transaction_1.amount)
+      expect(parsed_transactions.last.amount).to eql(transaction_2.amount)
+    end
+  end
+
+  describe 'creation of json from a Bankster::Transaction' do
+    let(:transaction) { FactoryGirl.build(:transaction, amount: Money.eur(123)) }
+    subject { transaction.extend(described_class) }
+
+    it 'creates json that matches the schema' do
+      expect(subject.to_json).to match_json_schema(:transaction_schema, strict: true)
+    end
+
+    describe 'attributes' do
+      let(:json) { JSON.parse(subject.to_json) }
+
+      it 'represents the amount as a hash with cents and currency' do
+        expect(json['amount']['cents']).to eql("123")
+        expect(json['amount']['currency']).to eql("EUR")
+      end
+
+      it 'represents the purpose' do
+        expect(json['purpose']).to eql(transaction.purpose)
+      end
+
+      it 'represents the iban' do
+        expect(json['iban']).to eql(transaction.iban)
+      end
+
+      it 'represents the bic' do
+        expect(json['bic']).to eql(transaction.bic)
+      end
+
+      it 'represents the name' do
+        expect(json['name']).to eql(transaction.name)
+      end
+
+      it 'represents the type' do
+        expect(json['type']).to eql(transaction.type.to_s)
+      end
+
+      it 'represents the booking date as a iso 8609 string' do
+        expect(json['booking_date']).to eql(Date.today.iso8601)
+      end
+
+      it 'represents the valutation date as a iso 8609 string' do
+        expect(json['valutation_date']).to eql(Date.today.iso8601)
+      end
+    end
+  end
+
+  describe 'creation of a Bankster::Transaction from json' do
+    let(:api_response) { FactoryGirl.build(:transaction_api_response) }
+    let(:subject) { Bankster::Transaction.new.extend(described_class) }
+
+    before do
+      subject.from_json(api_response.to_json)
+    end
+
+    describe 'attributes' do
+      it 'converts the money hash with cents and currency to a Money object' do
+        expect(subject.amount).to eql(
+          Money.new(
+            api_response['amount']['cents'],
+            api_response['amount']['currency']
+          )
+        )
+      end
+
+      it 'represents the purpose' do
+        expect(subject.purpose).to eql(api_response['purpose'])
+      end
+
+      it 'represents the name' do
+        expect(subject.name).to eql(api_response['name'])
+      end
+
+      it 'represents the iban' do
+        expect(subject.iban).to eql(api_response['iban'])
+      end
+
+      it 'represents the bic' do
+        expect(subject.bic).to eql(api_response['bic'])
+      end
+
+      it 'converts the type from a string to a symbol' do
+        expect(subject.type).to eql(api_response['type'].to_sym)
+      end
+
+      it 'converts the booking date from a iso 8609 string to a date object' do
+        expect(subject.booking_date).to eql(Date.parse(api_response['booking_date']))
+      end
+
+      it 'converts the valutation date from a iso 8609 string to a date object' do
+        expect(subject.valutation_date).to eql(Date.parse(api_response['valutation_date']))
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,16 @@
+$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+require 'bankster_shared'
+require 'byebug'
+require 'factory_girl'
+require 'json-schema-rspec'
+
+RSpec.configure do |config|
+
+  Dir[File.dirname(__FILE__) + '/../lib/schemas/*.json'].each do |file|
+    config.json_schemas[File.basename(file, ".json").to_sym] = file
+  end
+  config.include JSON::SchemaMatchers
+
+  config.include FactoryGirl::Syntax::Methods
+  FactoryGirl.find_definitions
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bankster-transaction
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Roman Lehnert
@@ -174,6 +174,10 @@ files:
 - lib/representers/transactions_representer.rb
 - lib/schemas/transaction_schema.json
 - lib/schemas/transactions_schema.json
+- spec/factories/transactions_factory.rb
+- spec/factories/transactions_factory_spec.rb
+- spec/representers/transaction_representer_spec.rb
+- spec/spec_helper.rb
 homepage: http://bankster.io/
 licenses:
 - MIT