banks_registry 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 164ba83a74e09032ba5c81b72084a62091462765
-  data.tar.gz: 10e1a4efdd129602b22606b906f81ecbb5e41c07
+  metadata.gz: b5b3596551da0c5be540d018d3f16816136a44c9
+  data.tar.gz: c0eca185134fdcd8641355b339ee3f69643e3016
 SHA512:
-  metadata.gz: 5936c95357eb11d3fcd9e56230a6e9cfc77cac0e78f1d5e329f2cb515bc19d11f64067b0be4ac69a510062e474a13695e271d6522cda0cfc8914c29cc98e0ebf
-  data.tar.gz: 3f5f971a4650ae6fa55cd35611f526b76db61d2622bc1c8f1149ea77a6b4d0a0933e691c97e7e5102b5569cd7b56b13437db0725c3de5c2004e508fa3f85cc51
+  metadata.gz: 91528f9245412be8730f3cd8f0a87b39a3ddadfe6c3d78ed799635d1432799a159756b55f0e6bd529eada130a8b60416eca9fdeb0d53257d42bad1ba051c5fd5
+  data.tar.gz: 5419e9bc78c900e29ea638ee934544810b0bce5764a5fc9997dce101b74ed1848c4bb89dc52123de5fb1cedecf4a774e4972109c665f3cabc8a2e20098f88f8a

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    banks_registry (0.1.2)
+    banks_registry (0.1.3)
 
 GEM
   remote: https://rubygems.org/

data/lib/banks_registry/loaders/banks_loader.rb

@@ -14,12 +14,23 @@ module BanksRegistry
 
       def call(code)
         return @cache[code] if @cache.key?(code)
+        return unless file_exists?(code)
 
         @cache[code] =
-          YAML.load_file("#{BANKS_FOLDER}/#{code}.yml")[code].map do |bank|
+          YAML.load_file(filename(code))[code].map do |bank|
             Models::Bank.new(bank)
           end
       end
+
+      private
+
+      def file_exists?(code)
+        File.file?(filename(code))
+      end
+
+      def filename(code)
+        "#{BANKS_FOLDER}/#{code}.yml"
+      end
     end
   end
 end

data/lib/banks_registry/loaders/rules_loader.rb

@@ -14,14 +14,23 @@ module BanksRegistry
 
       def call(code)
         return @cache[code] if @cache.key?(code)
+        return unless file_exists?(code)
 
         @cache[code] = Models::Rule.new(load_rule_yml(code))
       end
 
       private
 
+      def file_exists?(code)
+        File.file?(filename(code))
+      end
+
+      def filename(code)
+        "#{RULES_FOLDER}/#{code}.yml"
+      end
+
       def load_rule_yml(code)
-        YAML.load_file("#{RULES_FOLDER}/#{code}.yml")[code]
+        YAML.load_file(filename(code))[code]
       end
     end
   end

data/lib/banks_registry/matchers/bic_matcher.rb

@@ -6,7 +6,7 @@ module BanksRegistry
   module Matchers
     class BicMatcher
       def call(bic)
-        banks_loader.call(country_from_bic(bic)).find do |bank|
+        banks_loader.call(country_from_bic(bic))&.find do |bank|
           bank.bic == bic
         end
       end

data/lib/banks_registry/matchers/iban_matcher.rb

@@ -39,11 +39,12 @@ module BanksRegistry
       end
 
       def bank_code_regexp(iban)
-        rule_converter.call(iban_rule(country_from_iban(iban)))
+        rule = iban_rule(country_from_iban(iban))
+        rule_converter.call(rule) if rule
       end
 
       def iban_rule(code)
-        rules_loader.call(code).iban
+        rules_loader.call(code)&.iban
       end
 
       def rule_converter

data/lib/banks_registry/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BanksRegistry
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: banks_registry
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Advanon team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-20 00:00:00.000000000 Z
+date: 2018-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler